270799166b
REFACTOR: applies discourse core coding practices ( #82 )
2020-03-23 09:40:29 +01:00
cf27a7be64
DEV: Stop loading external scripts while running tests ( #81 )
...
* DEV: Stop loading external scripts while running tests
* Revert "Turn of CSP for tests"
This reverts commit db1bf99277
2020-01-06 10:01:40 -07:00
b59f841944
DEV: Respect radix rule in eslint-config-discourse 1.0.6
2019-11-18 10:07:55 -05:00
62888e734f
FIX: handle no ad size given for AdSense and DFP ad units
...
For AdSense, assume responsive size.
For DFP, don't attempt to render the ad unit.
2019-09-10 17:07:47 -04:00
1929ac405c
lint errors
2019-07-08 15:18:34 -04:00
333f6cef81
FEATURE: support multiple ad sizes in AdSense and Ad Manager
...
Each ad placement in the AdSense and Ad Manager settings takes a list
of ad sizes instead of only one size. If given multiple sizes, the sizes
will alternate in order for each ad that's rendered.
2019-07-08 15:10:25 -04:00
203e14b639
Fix eslint warnings
2019-06-14 12:10:11 -04:00
7af8f1d46b
FEATURE: new setting to disable ads based on category of current page
...
Use the "no ads for categories" setting to define which category pages
(topic list and topics) should not render any ads.
2019-06-05 16:00:24 -04:00
1bd80e1afe
FEATURE: House Ads
...
Allows creating ads within Discourse admin at Plugins > House Ads.
Write the ads in html and style them with CSS in themes.
2019-05-03 11:39:34 -04:00
5272995e74
FEATURE: use groups to control who sees ads
2019-05-03 11:39:34 -04:00
369d5dfc9e
oops revert again "FEATURE: use groups to control who sees ads" and all later"
2019-04-17 16:02:19 -04:00
e6bcd96d8e
FEATURE: use groups to control who sees ads" and all later
2019-04-17 15:40:50 -04:00
50d258dc37
Revert "FEATURE: use groups to control who sees ads" and all later
...
Revert "Updates to codefund-ad"
Revert "Updates to carbonads-ad"
Revert "Updates to amazon-product-links"
2019-04-17 15:37:09 -04:00
4fd7caffd6
FEATURE: use groups to control who sees ads
...
A new setting has been added in Admin > Settings > Ad Plugin called
"no ads for groups". Add group names to this list. If a user belongs
to any of the groups, they will not see any ads. This is an alternative
to using trust level settings like "adsense through trust level".
2019-04-17 11:36:50 -04:00
943acbfeb1
Add some js tests, and update adsense js
2019-04-17 11:36:47 -04:00
2e36e2c656
DEV: Apply prettier
2018-10-22 19:49:32 +01:00
9df93c03a7
AdSense: allow choosing ad size for mobile, including responsive
2017-05-30 18:13:49 -04:00
62377e6111
Support for AdSense responsive ad size
2017-05-30 15:54:59 -04:00
620404ab9e
FIX: AdSense ads not loading on initial page load. Only load adsbygoogle.js once because it's the async library.
2016-12-05 13:31:11 -05:00
de4a8366fc
FIX: don't load adsbygoogle.js when adsense publisher id isn't set
2016-11-21 15:58:29 -05:00
da1d4e0063
FIX: when dfp/adsense publisher id is missing, don't render blank ad units
2016-11-21 15:55:03 -05:00
883d5ecd85
FIX: Catch exception if ads can't be rendered
2016-11-09 16:46:09 -05:00
a70491c720
FIX: HTMLBars doesn't allow `<SCRIPT>` tags
2016-11-08 16:46:09 -05:00
ef45e3290e
Don't hard-code center justify of AdSense ads. Let position be customized with CSS.
2016-04-04 16:51:34 -04:00
4ab0f0fab8
Upgrade to new Plugin API
2016-02-22 12:16:09 -05:00
ebed90fab7
Support linting, clean up some unused variables and weird spacing
2016-02-19 15:29:00 -05:00
1f0d85740e
put mobile ad sizes back to original
...
testing on my forked version instead
2015-12-24 21:10:37 +11:00
a8c0910f5b
changed ad mobile height for adsense
...
temp test for mobile ad height space for testing on mobile.
2015-12-24 20:50:22 +11:00
ffbd69688e
Fixed: mobile viewport was too large when presenting ads, making for a sloppy mobile experience. Restricted length of "Advertisement" label to fix it.
2015-10-28 16:51:53 -07:00
fe9c53ce58
removed all disable boxes and changed trust levels for amazon
2015-09-21 10:44:37 +10:00
0adc5bfca7
Refactored to only have amazon link/banner ads and refactored for check trust levels
2015-09-16 12:11:50 +10:00
647eecd95b
master - more consistent naming for dfp settings and removed test folder
2015-09-10 12:07:36 +10:00
c868d4892a
Removed unused css and irrelevant comments and cleaned up formatting
2015-09-07 20:51:59 +10:00
bdc8a2dff5
Added comment to adsense
2015-09-07 20:38:53 +10:00
7062254c13
Reload fixed added googletag in - Thank you Myles!
2015-09-07 15:15:12 +10:00
8607cefcec
Added mobile slot code for adsense plugin and revisited the reloading issue
2015-09-07 14:26:53 +10:00
9e9d056d75
edited sizes for post bottom and fixed dfp googletag reload
2015-09-04 14:52:08 +10:00
b9945a6e4b
Added comments to pre and post google vars
2015-09-04 10:51:44 +10:00
916e53884c
working custom targeting for all locations
2015-09-02 15:23:17 +10:00
b0a97df0da
Fixed merge conflicts
2015-09-02 14:28:33 +10:00
5eecf0d731
Fixed up properties in ad mobile sizes for dfp and adsense
2015-09-01 13:44:56 +10:00
67141dd884
Added mobile code to topic list top position to test
2015-09-01 13:20:52 +10:00
2f1ac77380
Added trust levels to site setting and bug found in adsense reload comment out in line 30 to 57
2015-09-01 11:16:07 +10:00
7f13e0a1fb
Merge pull request #8 from team-melbourne-rgsoc2015/mobile-works
...
Successful mobile slots - default to 320*50
2015-09-01 10:10:09 +10:00
a7258f4848
For loop replaces while loop but line 50 doesn't work
2015-08-31 15:25:42 +10:00
6d93faf871
Successful mobile slots - default to 320*50
2015-08-28 15:34:14 +10:00
f94bf79192
Added custom targeting to all slots and Sebastian fixed the variable issue in adsense - thanks Seb!
2015-08-28 12:21:40 +10:00
50ee40cdfe
Myles fixed it - fixed cmd undefined and fixed up adsense code that was undefining all vars beginning with google
2015-08-26 10:42:43 +10:00
d179ed4fe9
Successfully merge with bug in cmd push
2015-08-25 14:30:23 +10:00
Joffrey JAFFEUX
David Taylor
Penar Musaraj
Neil Lalonde
Robin Ward
Vi Nguyen
Ken Cooper
Sarah Ni
vi
ladydanger