FEATURE: UI to update ai personas on admin page (#290)
Introduces a UI to manage customizable personas (admin only feature)
Part of the change was some extensive internal refactoring:
- AIBot now has a persona set in the constructor, once set it never changes
- Command now takes in bot as a constructor param, so it has the correct persona and is not generating AIBot objects on the fly
- Added a .prettierignore file, due to the way ALE is configured in nvim it is a pre-req for prettier to work
- Adds a bunch of validations on the AIPersona model, system personas (artist/creative etc...) are all seeded. We now ensure
- name uniqueness, and only allow certain properties to be touched for system personas.
- (JS note) the client side design takes advantage of nested routes, the parent route for personas gets all the personas via this.store.findAll("ai-persona") then child routes simply reach into this model to find a particular persona.
- (JS note) data is sideloaded into the ai-persona model the meta property supplied from the controller, resultSetMeta
- This removes ai_bot_enabled_personas and ai_bot_enabled_chat_commands, both should be controlled from the UI on a per persona basis
- Fixes a long standing bug in token accounting ... we were doing to_json.length instead of to_json.to_s.length
- Amended it so {commands} are always inserted at the end unconditionally, no need to add it to the template of the system message as it just confuses things
- Adds a concept of required_commands to stock personas, these are commands that must be configured for this stock persona to show up.
- Refactored tests so we stop requiring inference_stubs, it was very confusing to need it, added to plugin.rb for now which at least is clearer
- Migrates the persona selector to gjs
---------
Co-authored-by: Joffrey JAFFEUX <j.jaffeux@gmail.com>
Co-authored-by: Martin Brennan <martin@discourse.org>
2023-11-21 00:56:43 -05:00
|
|
|
# frozen_string_literal: true
|
|
|
|
|
|
|
|
module DiscourseAi
|
|
|
|
module Admin
|
|
|
|
class AiPersonasController < ::Admin::AdminController
|
|
|
|
before_action :find_ai_persona, only: %i[show update destroy]
|
|
|
|
|
|
|
|
def index
|
|
|
|
ai_personas =
|
|
|
|
AiPersona.ordered.map do |persona|
|
|
|
|
# we use a special serializer here cause names and descriptions are
|
|
|
|
# localized for system personas
|
|
|
|
LocalizedAiPersonaSerializer.new(persona, root: false)
|
|
|
|
end
|
|
|
|
commands =
|
|
|
|
DiscourseAi::AiBot::Personas::Persona.all_available_commands.map do |command|
|
2023-12-07 16:42:56 -05:00
|
|
|
AiCommandSerializer.new(command, root: false)
|
FEATURE: UI to update ai personas on admin page (#290)
Introduces a UI to manage customizable personas (admin only feature)
Part of the change was some extensive internal refactoring:
- AIBot now has a persona set in the constructor, once set it never changes
- Command now takes in bot as a constructor param, so it has the correct persona and is not generating AIBot objects on the fly
- Added a .prettierignore file, due to the way ALE is configured in nvim it is a pre-req for prettier to work
- Adds a bunch of validations on the AIPersona model, system personas (artist/creative etc...) are all seeded. We now ensure
- name uniqueness, and only allow certain properties to be touched for system personas.
- (JS note) the client side design takes advantage of nested routes, the parent route for personas gets all the personas via this.store.findAll("ai-persona") then child routes simply reach into this model to find a particular persona.
- (JS note) data is sideloaded into the ai-persona model the meta property supplied from the controller, resultSetMeta
- This removes ai_bot_enabled_personas and ai_bot_enabled_chat_commands, both should be controlled from the UI on a per persona basis
- Fixes a long standing bug in token accounting ... we were doing to_json.length instead of to_json.to_s.length
- Amended it so {commands} are always inserted at the end unconditionally, no need to add it to the template of the system message as it just confuses things
- Adds a concept of required_commands to stock personas, these are commands that must be configured for this stock persona to show up.
- Refactored tests so we stop requiring inference_stubs, it was very confusing to need it, added to plugin.rb for now which at least is clearer
- Migrates the persona selector to gjs
---------
Co-authored-by: Joffrey JAFFEUX <j.jaffeux@gmail.com>
Co-authored-by: Martin Brennan <martin@discourse.org>
2023-11-21 00:56:43 -05:00
|
|
|
end
|
|
|
|
render json: { ai_personas: ai_personas, meta: { commands: commands } }
|
|
|
|
end
|
|
|
|
|
|
|
|
def show
|
|
|
|
render json: LocalizedAiPersonaSerializer.new(@ai_persona)
|
|
|
|
end
|
|
|
|
|
|
|
|
def create
|
|
|
|
ai_persona = AiPersona.new(ai_persona_params)
|
|
|
|
if ai_persona.save
|
|
|
|
render json: { ai_persona: ai_persona }, status: :created
|
|
|
|
else
|
|
|
|
render_json_error ai_persona
|
|
|
|
end
|
|
|
|
end
|
|
|
|
|
|
|
|
def update
|
|
|
|
if @ai_persona.update(ai_persona_params)
|
|
|
|
render json: @ai_persona
|
|
|
|
else
|
|
|
|
render_json_error @ai_persona
|
|
|
|
end
|
|
|
|
end
|
|
|
|
|
|
|
|
def destroy
|
|
|
|
if @ai_persona.destroy
|
|
|
|
head :no_content
|
|
|
|
else
|
|
|
|
render_json_error @ai_persona
|
|
|
|
end
|
|
|
|
end
|
|
|
|
|
|
|
|
private
|
|
|
|
|
|
|
|
def find_ai_persona
|
|
|
|
@ai_persona = AiPersona.find(params[:id])
|
|
|
|
end
|
|
|
|
|
|
|
|
def ai_persona_params
|
2023-12-07 16:42:56 -05:00
|
|
|
permitted =
|
|
|
|
params.require(:ai_persona).permit(
|
|
|
|
:name,
|
|
|
|
:description,
|
|
|
|
:enabled,
|
|
|
|
:system_prompt,
|
|
|
|
:priority,
|
|
|
|
allowed_group_ids: [],
|
|
|
|
)
|
|
|
|
|
|
|
|
if commands = params.dig(:ai_persona, :commands)
|
|
|
|
permitted[:commands] = permit_commands(commands)
|
|
|
|
end
|
|
|
|
|
|
|
|
permitted
|
|
|
|
end
|
|
|
|
|
|
|
|
def permit_commands(commands)
|
|
|
|
return [] if !commands.is_a?(Array)
|
|
|
|
|
|
|
|
commands.filter_map do |command, options|
|
|
|
|
break nil if !command.is_a?(String)
|
|
|
|
options&.permit! if options && options.is_a?(ActionController::Parameters)
|
|
|
|
|
|
|
|
if options
|
|
|
|
[command, options]
|
|
|
|
else
|
|
|
|
command
|
|
|
|
end
|
|
|
|
end
|
FEATURE: UI to update ai personas on admin page (#290)
Introduces a UI to manage customizable personas (admin only feature)
Part of the change was some extensive internal refactoring:
- AIBot now has a persona set in the constructor, once set it never changes
- Command now takes in bot as a constructor param, so it has the correct persona and is not generating AIBot objects on the fly
- Added a .prettierignore file, due to the way ALE is configured in nvim it is a pre-req for prettier to work
- Adds a bunch of validations on the AIPersona model, system personas (artist/creative etc...) are all seeded. We now ensure
- name uniqueness, and only allow certain properties to be touched for system personas.
- (JS note) the client side design takes advantage of nested routes, the parent route for personas gets all the personas via this.store.findAll("ai-persona") then child routes simply reach into this model to find a particular persona.
- (JS note) data is sideloaded into the ai-persona model the meta property supplied from the controller, resultSetMeta
- This removes ai_bot_enabled_personas and ai_bot_enabled_chat_commands, both should be controlled from the UI on a per persona basis
- Fixes a long standing bug in token accounting ... we were doing to_json.length instead of to_json.to_s.length
- Amended it so {commands} are always inserted at the end unconditionally, no need to add it to the template of the system message as it just confuses things
- Adds a concept of required_commands to stock personas, these are commands that must be configured for this stock persona to show up.
- Refactored tests so we stop requiring inference_stubs, it was very confusing to need it, added to plugin.rb for now which at least is clearer
- Migrates the persona selector to gjs
---------
Co-authored-by: Joffrey JAFFEUX <j.jaffeux@gmail.com>
Co-authored-by: Martin Brennan <martin@discourse.org>
2023-11-21 00:56:43 -05:00
|
|
|
end
|
|
|
|
end
|
|
|
|
end
|
|
|
|
end
|