2023-11-09 19:39:49 -05:00
|
|
|
# frozen_string_literal: true
|
|
|
|
|
|
|
|
RSpec.describe AiPersona do
|
2024-02-15 00:37:59 -05:00
|
|
|
it "validates context settings" do
|
|
|
|
persona =
|
|
|
|
AiPersona.new(
|
|
|
|
name: "test",
|
|
|
|
description: "test",
|
|
|
|
system_prompt: "test",
|
2024-06-11 04:14:14 -04:00
|
|
|
tools: [],
|
2024-02-15 00:37:59 -05:00
|
|
|
allowed_group_ids: [],
|
|
|
|
)
|
|
|
|
|
|
|
|
expect(persona.valid?).to eq(true)
|
|
|
|
|
|
|
|
persona.max_context_posts = 0
|
|
|
|
expect(persona.valid?).to eq(false)
|
|
|
|
expect(persona.errors[:max_context_posts]).to eq(["must be greater than 0"])
|
|
|
|
|
|
|
|
persona.max_context_posts = 1
|
|
|
|
expect(persona.valid?).to eq(true)
|
|
|
|
|
|
|
|
persona.max_context_posts = nil
|
|
|
|
expect(persona.valid?).to eq(true)
|
|
|
|
end
|
|
|
|
|
|
|
|
it "allows creation of user" do
|
|
|
|
persona =
|
|
|
|
AiPersona.create!(
|
|
|
|
name: "test",
|
|
|
|
description: "test",
|
|
|
|
system_prompt: "test",
|
2024-06-11 04:14:14 -04:00
|
|
|
tools: [],
|
2024-02-15 00:37:59 -05:00
|
|
|
allowed_group_ids: [],
|
|
|
|
)
|
|
|
|
|
|
|
|
user = persona.create_user!
|
|
|
|
expect(user.username).to eq("test_bot")
|
|
|
|
expect(user.name).to eq("Test")
|
|
|
|
expect(user.bot?).to be(true)
|
|
|
|
expect(user.id).to be <= AiPersona::FIRST_PERSONA_USER_ID
|
|
|
|
end
|
|
|
|
|
2024-04-12 09:32:46 -04:00
|
|
|
it "removes all rag embeddings when rag params change" do
|
|
|
|
persona =
|
|
|
|
AiPersona.create!(
|
|
|
|
name: "test",
|
|
|
|
description: "test",
|
|
|
|
system_prompt: "test",
|
2024-06-11 04:14:14 -04:00
|
|
|
tools: [],
|
2024-04-12 09:32:46 -04:00
|
|
|
allowed_group_ids: [],
|
|
|
|
rag_chunk_tokens: 10,
|
|
|
|
rag_chunk_overlap_tokens: 5,
|
|
|
|
)
|
|
|
|
|
|
|
|
id =
|
|
|
|
RagDocumentFragment.create!(
|
2024-09-15 18:17:17 -04:00
|
|
|
target: persona,
|
2024-04-12 09:32:46 -04:00
|
|
|
fragment: "test",
|
|
|
|
fragment_number: 1,
|
|
|
|
upload: Fabricate(:upload),
|
|
|
|
).id
|
|
|
|
|
|
|
|
persona.rag_chunk_tokens = 20
|
|
|
|
persona.save!
|
|
|
|
|
|
|
|
expect(RagDocumentFragment.exists?(id)).to eq(false)
|
|
|
|
end
|
|
|
|
|
2024-02-15 00:37:59 -05:00
|
|
|
it "defines singleton methods on system persona classes" do
|
|
|
|
forum_helper = AiPersona.find_by(name: "Forum Helper")
|
|
|
|
forum_helper.update!(
|
|
|
|
user_id: 1,
|
|
|
|
default_llm: "anthropic:claude-2",
|
|
|
|
max_context_posts: 3,
|
2024-10-15 16:20:31 -04:00
|
|
|
allow_topic_mentions: true,
|
|
|
|
allow_personal_messages: true,
|
|
|
|
allow_chat_channel_mentions: true,
|
|
|
|
allow_chat_direct_messages: true,
|
2024-02-15 00:37:59 -05:00
|
|
|
)
|
|
|
|
|
|
|
|
klass = forum_helper.class_instance
|
|
|
|
|
|
|
|
expect(klass.id).to eq(forum_helper.id)
|
|
|
|
expect(klass.system).to eq(true)
|
|
|
|
# tl 0 by default
|
|
|
|
expect(klass.allowed_group_ids).to eq([10])
|
|
|
|
expect(klass.user_id).to eq(1)
|
|
|
|
expect(klass.default_llm).to eq("anthropic:claude-2")
|
|
|
|
expect(klass.max_context_posts).to eq(3)
|
2024-10-15 16:20:31 -04:00
|
|
|
expect(klass.allow_topic_mentions).to eq(true)
|
|
|
|
expect(klass.allow_personal_messages).to eq(true)
|
|
|
|
expect(klass.allow_chat_channel_mentions).to eq(true)
|
|
|
|
expect(klass.allow_chat_direct_messages).to eq(true)
|
2024-02-15 00:37:59 -05:00
|
|
|
end
|
|
|
|
|
|
|
|
it "defines singleton methods non persona classes" do
|
|
|
|
persona =
|
|
|
|
AiPersona.create!(
|
|
|
|
name: "test",
|
|
|
|
description: "test",
|
|
|
|
system_prompt: "test",
|
2024-06-11 04:14:14 -04:00
|
|
|
tools: [],
|
2024-02-15 00:37:59 -05:00
|
|
|
allowed_group_ids: [],
|
|
|
|
default_llm: "anthropic:claude-2",
|
|
|
|
max_context_posts: 3,
|
2024-10-15 16:20:31 -04:00
|
|
|
allow_topic_mentions: true,
|
|
|
|
allow_personal_messages: true,
|
|
|
|
allow_chat_channel_mentions: true,
|
|
|
|
allow_chat_direct_messages: true,
|
2024-02-15 00:37:59 -05:00
|
|
|
user_id: 1,
|
|
|
|
)
|
|
|
|
|
|
|
|
klass = persona.class_instance
|
|
|
|
|
|
|
|
expect(klass.id).to eq(persona.id)
|
|
|
|
expect(klass.system).to eq(false)
|
|
|
|
expect(klass.allowed_group_ids).to eq([])
|
|
|
|
expect(klass.user_id).to eq(1)
|
|
|
|
expect(klass.default_llm).to eq("anthropic:claude-2")
|
|
|
|
expect(klass.max_context_posts).to eq(3)
|
2024-10-15 16:20:31 -04:00
|
|
|
expect(klass.allow_topic_mentions).to eq(true)
|
|
|
|
expect(klass.allow_personal_messages).to eq(true)
|
|
|
|
expect(klass.allow_chat_channel_mentions).to eq(true)
|
|
|
|
expect(klass.allow_chat_direct_messages).to eq(true)
|
2024-02-15 00:37:59 -05:00
|
|
|
end
|
|
|
|
|
2024-10-15 16:20:31 -04:00
|
|
|
it "does not allow setting allowing chat without a default_llm" do
|
2024-05-05 19:49:02 -04:00
|
|
|
persona =
|
|
|
|
AiPersona.create(
|
|
|
|
name: "test",
|
|
|
|
description: "test",
|
|
|
|
system_prompt: "test",
|
|
|
|
allowed_group_ids: [],
|
|
|
|
default_llm: nil,
|
2024-10-15 16:20:31 -04:00
|
|
|
allow_chat_channel_mentions: true,
|
|
|
|
)
|
|
|
|
|
|
|
|
expect(persona.valid?).to eq(false)
|
|
|
|
expect(persona.errors[:default_llm].first).to eq(
|
|
|
|
I18n.t("discourse_ai.ai_bot.personas.default_llm_required"),
|
|
|
|
)
|
|
|
|
|
|
|
|
persona =
|
|
|
|
AiPersona.create(
|
|
|
|
name: "test",
|
|
|
|
description: "test",
|
|
|
|
system_prompt: "test",
|
|
|
|
allowed_group_ids: [],
|
|
|
|
default_llm: nil,
|
|
|
|
allow_chat_direct_messages: true,
|
|
|
|
)
|
|
|
|
|
|
|
|
expect(persona.valid?).to eq(false)
|
|
|
|
expect(persona.errors[:default_llm].first).to eq(
|
|
|
|
I18n.t("discourse_ai.ai_bot.personas.default_llm_required"),
|
|
|
|
)
|
|
|
|
|
|
|
|
persona =
|
|
|
|
AiPersona.create(
|
|
|
|
name: "test",
|
|
|
|
description: "test",
|
|
|
|
system_prompt: "test",
|
|
|
|
allowed_group_ids: [],
|
|
|
|
default_llm: nil,
|
|
|
|
allow_topic_mentions: true,
|
2024-05-05 19:49:02 -04:00
|
|
|
)
|
|
|
|
|
|
|
|
expect(persona.valid?).to eq(false)
|
|
|
|
expect(persona.errors[:default_llm].first).to eq(
|
|
|
|
I18n.t("discourse_ai.ai_bot.personas.default_llm_required"),
|
|
|
|
)
|
|
|
|
end
|
|
|
|
|
2023-11-09 19:39:49 -05:00
|
|
|
it "does not leak caches between sites" do
|
|
|
|
AiPersona.create!(
|
|
|
|
name: "pun_bot",
|
|
|
|
description: "you write puns",
|
|
|
|
system_prompt: "you are pun bot",
|
2024-06-11 04:14:14 -04:00
|
|
|
tools: ["ImageCommand"],
|
2023-11-09 19:39:49 -05:00
|
|
|
allowed_group_ids: [Group::AUTO_GROUPS[:trust_level_0]],
|
|
|
|
)
|
|
|
|
|
|
|
|
AiPersona.all_personas
|
|
|
|
|
FEATURE: UI to update ai personas on admin page (#290)
Introduces a UI to manage customizable personas (admin only feature)
Part of the change was some extensive internal refactoring:
- AIBot now has a persona set in the constructor, once set it never changes
- Command now takes in bot as a constructor param, so it has the correct persona and is not generating AIBot objects on the fly
- Added a .prettierignore file, due to the way ALE is configured in nvim it is a pre-req for prettier to work
- Adds a bunch of validations on the AIPersona model, system personas (artist/creative etc...) are all seeded. We now ensure
- name uniqueness, and only allow certain properties to be touched for system personas.
- (JS note) the client side design takes advantage of nested routes, the parent route for personas gets all the personas via this.store.findAll("ai-persona") then child routes simply reach into this model to find a particular persona.
- (JS note) data is sideloaded into the ai-persona model the meta property supplied from the controller, resultSetMeta
- This removes ai_bot_enabled_personas and ai_bot_enabled_chat_commands, both should be controlled from the UI on a per persona basis
- Fixes a long standing bug in token accounting ... we were doing to_json.length instead of to_json.to_s.length
- Amended it so {commands} are always inserted at the end unconditionally, no need to add it to the template of the system message as it just confuses things
- Adds a concept of required_commands to stock personas, these are commands that must be configured for this stock persona to show up.
- Refactored tests so we stop requiring inference_stubs, it was very confusing to need it, added to plugin.rb for now which at least is clearer
- Migrates the persona selector to gjs
---------
Co-authored-by: Joffrey JAFFEUX <j.jaffeux@gmail.com>
Co-authored-by: Martin Brennan <martin@discourse.org>
2023-11-21 00:56:43 -05:00
|
|
|
expect(AiPersona.persona_cache[:value].length).to be > (0)
|
2023-11-09 19:39:49 -05:00
|
|
|
RailsMultisite::ConnectionManagement.stubs(:current_db) { "abc" }
|
|
|
|
expect(AiPersona.persona_cache[:value]).to eq(nil)
|
|
|
|
end
|
|
|
|
end
|