2023-05-20 03:45:54 -04:00
|
|
|
#frozen_string_literal: true
|
|
|
|
|
|
|
|
RSpec.describe DiscourseAi::AiBot::Commands::GoogleCommand do
|
2023-10-23 02:00:58 -04:00
|
|
|
let(:bot_user) { User.find(DiscourseAi::AiBot::EntryPoint::GPT3_5_TURBO_ID) }
|
FEATURE: UI to update ai personas on admin page (#290)
Introduces a UI to manage customizable personas (admin only feature)
Part of the change was some extensive internal refactoring:
- AIBot now has a persona set in the constructor, once set it never changes
- Command now takes in bot as a constructor param, so it has the correct persona and is not generating AIBot objects on the fly
- Added a .prettierignore file, due to the way ALE is configured in nvim it is a pre-req for prettier to work
- Adds a bunch of validations on the AIPersona model, system personas (artist/creative etc...) are all seeded. We now ensure
- name uniqueness, and only allow certain properties to be touched for system personas.
- (JS note) the client side design takes advantage of nested routes, the parent route for personas gets all the personas via this.store.findAll("ai-persona") then child routes simply reach into this model to find a particular persona.
- (JS note) data is sideloaded into the ai-persona model the meta property supplied from the controller, resultSetMeta
- This removes ai_bot_enabled_personas and ai_bot_enabled_chat_commands, both should be controlled from the UI on a per persona basis
- Fixes a long standing bug in token accounting ... we were doing to_json.length instead of to_json.to_s.length
- Amended it so {commands} are always inserted at the end unconditionally, no need to add it to the template of the system message as it just confuses things
- Adds a concept of required_commands to stock personas, these are commands that must be configured for this stock persona to show up.
- Refactored tests so we stop requiring inference_stubs, it was very confusing to need it, added to plugin.rb for now which at least is clearer
- Migrates the persona selector to gjs
---------
Co-authored-by: Joffrey JAFFEUX <j.jaffeux@gmail.com>
Co-authored-by: Martin Brennan <martin@discourse.org>
2023-11-21 00:56:43 -05:00
|
|
|
let(:bot) { DiscourseAi::AiBot::OpenAiBot.new(bot_user) }
|
2023-10-23 02:00:58 -04:00
|
|
|
|
|
|
|
before { SiteSetting.ai_bot_enabled = true }
|
2023-05-20 03:45:54 -04:00
|
|
|
|
|
|
|
describe "#process" do
|
2023-08-14 02:30:12 -04:00
|
|
|
it "will not explode if there are no results" do
|
|
|
|
post = Fabricate(:post)
|
|
|
|
|
|
|
|
SiteSetting.ai_google_custom_search_api_key = "abc"
|
|
|
|
SiteSetting.ai_google_custom_search_cx = "cx"
|
|
|
|
|
|
|
|
json_text = { searchInformation: { totalResults: "0" } }.to_json
|
|
|
|
|
|
|
|
stub_request(
|
|
|
|
:get,
|
|
|
|
"https://www.googleapis.com/customsearch/v1?cx=cx&key=abc&num=10&q=some%20search%20term",
|
|
|
|
).to_return(status: 200, body: json_text, headers: {})
|
|
|
|
|
FEATURE: UI to update ai personas on admin page (#290)
Introduces a UI to manage customizable personas (admin only feature)
Part of the change was some extensive internal refactoring:
- AIBot now has a persona set in the constructor, once set it never changes
- Command now takes in bot as a constructor param, so it has the correct persona and is not generating AIBot objects on the fly
- Added a .prettierignore file, due to the way ALE is configured in nvim it is a pre-req for prettier to work
- Adds a bunch of validations on the AIPersona model, system personas (artist/creative etc...) are all seeded. We now ensure
- name uniqueness, and only allow certain properties to be touched for system personas.
- (JS note) the client side design takes advantage of nested routes, the parent route for personas gets all the personas via this.store.findAll("ai-persona") then child routes simply reach into this model to find a particular persona.
- (JS note) data is sideloaded into the ai-persona model the meta property supplied from the controller, resultSetMeta
- This removes ai_bot_enabled_personas and ai_bot_enabled_chat_commands, both should be controlled from the UI on a per persona basis
- Fixes a long standing bug in token accounting ... we were doing to_json.length instead of to_json.to_s.length
- Amended it so {commands} are always inserted at the end unconditionally, no need to add it to the template of the system message as it just confuses things
- Adds a concept of required_commands to stock personas, these are commands that must be configured for this stock persona to show up.
- Refactored tests so we stop requiring inference_stubs, it was very confusing to need it, added to plugin.rb for now which at least is clearer
- Migrates the persona selector to gjs
---------
Co-authored-by: Joffrey JAFFEUX <j.jaffeux@gmail.com>
Co-authored-by: Martin Brennan <martin@discourse.org>
2023-11-21 00:56:43 -05:00
|
|
|
google = described_class.new(bot: nil, post: post, args: {}.to_json)
|
2023-08-14 02:30:12 -04:00
|
|
|
info = google.process(query: "some search term").to_json
|
|
|
|
|
|
|
|
expect(google.description_args[:count]).to eq(0)
|
|
|
|
expect(info).to_not include("oops")
|
|
|
|
end
|
|
|
|
|
2023-05-20 03:45:54 -04:00
|
|
|
it "can generate correct info" do
|
|
|
|
post = Fabricate(:post)
|
|
|
|
|
|
|
|
SiteSetting.ai_google_custom_search_api_key = "abc"
|
|
|
|
SiteSetting.ai_google_custom_search_cx = "cx"
|
|
|
|
|
|
|
|
json_text = {
|
|
|
|
searchInformation: {
|
2023-10-18 23:44:59 -04:00
|
|
|
totalResults: "2",
|
2023-05-20 03:45:54 -04:00
|
|
|
},
|
|
|
|
items: [
|
|
|
|
{
|
|
|
|
title: "title1",
|
|
|
|
link: "link1",
|
|
|
|
snippet: "snippet1",
|
|
|
|
displayLink: "displayLink1",
|
|
|
|
formattedUrl: "formattedUrl1",
|
2023-08-08 01:41:57 -04:00
|
|
|
oops: "do no include me ... oops",
|
2023-05-20 03:45:54 -04:00
|
|
|
},
|
2023-10-18 23:44:59 -04:00
|
|
|
{
|
|
|
|
title: "title2",
|
|
|
|
link: "link2",
|
|
|
|
displayLink: "displayLink1",
|
|
|
|
formattedUrl: "formattedUrl1",
|
|
|
|
oops: "do no include me ... oops",
|
|
|
|
},
|
2023-05-20 03:45:54 -04:00
|
|
|
],
|
|
|
|
}.to_json
|
|
|
|
|
|
|
|
stub_request(
|
|
|
|
:get,
|
|
|
|
"https://www.googleapis.com/customsearch/v1?cx=cx&key=abc&num=10&q=some%20search%20term",
|
|
|
|
).to_return(status: 200, body: json_text, headers: {})
|
|
|
|
|
2023-08-14 02:30:12 -04:00
|
|
|
google =
|
FEATURE: UI to update ai personas on admin page (#290)
Introduces a UI to manage customizable personas (admin only feature)
Part of the change was some extensive internal refactoring:
- AIBot now has a persona set in the constructor, once set it never changes
- Command now takes in bot as a constructor param, so it has the correct persona and is not generating AIBot objects on the fly
- Added a .prettierignore file, due to the way ALE is configured in nvim it is a pre-req for prettier to work
- Adds a bunch of validations on the AIPersona model, system personas (artist/creative etc...) are all seeded. We now ensure
- name uniqueness, and only allow certain properties to be touched for system personas.
- (JS note) the client side design takes advantage of nested routes, the parent route for personas gets all the personas via this.store.findAll("ai-persona") then child routes simply reach into this model to find a particular persona.
- (JS note) data is sideloaded into the ai-persona model the meta property supplied from the controller, resultSetMeta
- This removes ai_bot_enabled_personas and ai_bot_enabled_chat_commands, both should be controlled from the UI on a per persona basis
- Fixes a long standing bug in token accounting ... we were doing to_json.length instead of to_json.to_s.length
- Amended it so {commands} are always inserted at the end unconditionally, no need to add it to the template of the system message as it just confuses things
- Adds a concept of required_commands to stock personas, these are commands that must be configured for this stock persona to show up.
- Refactored tests so we stop requiring inference_stubs, it was very confusing to need it, added to plugin.rb for now which at least is clearer
- Migrates the persona selector to gjs
---------
Co-authored-by: Joffrey JAFFEUX <j.jaffeux@gmail.com>
Co-authored-by: Martin Brennan <martin@discourse.org>
2023-11-21 00:56:43 -05:00
|
|
|
described_class.new(bot: bot, post: post, args: { query: "some search term" }.to_json)
|
2023-08-14 02:30:12 -04:00
|
|
|
|
2023-08-03 19:37:58 -04:00
|
|
|
info = google.process(query: "some search term").to_json
|
2023-05-20 03:45:54 -04:00
|
|
|
|
2023-10-18 23:44:59 -04:00
|
|
|
expect(google.description_args[:count]).to eq(2)
|
2023-05-20 03:45:54 -04:00
|
|
|
expect(info).to include("title1")
|
|
|
|
expect(info).to include("snippet1")
|
2023-08-08 01:41:57 -04:00
|
|
|
expect(info).to include("some+search+term")
|
2023-10-18 23:44:59 -04:00
|
|
|
expect(info).to include("title2")
|
2023-08-08 01:41:57 -04:00
|
|
|
expect(info).to_not include("oops")
|
2023-08-14 02:30:12 -04:00
|
|
|
|
|
|
|
google.invoke!
|
|
|
|
|
|
|
|
expect(post.reload.raw).to include("some search term")
|
|
|
|
|
|
|
|
expect { google.invoke! }.to raise_error(StandardError)
|
2023-05-20 03:45:54 -04:00
|
|
|
end
|
|
|
|
end
|
|
|
|
end
|