2023-08-08 17:19:56 -04:00
|
|
|
#frozen_string_literal: true
|
|
|
|
|
|
|
|
RSpec.describe DiscourseAi::AiBot::Commands::ReadCommand do
|
2023-10-23 02:00:58 -04:00
|
|
|
let(:bot_user) { User.find(DiscourseAi::AiBot::EntryPoint::GPT3_5_TURBO_ID) }
|
FEATURE: UI to update ai personas on admin page (#290)
Introduces a UI to manage customizable personas (admin only feature)
Part of the change was some extensive internal refactoring:
- AIBot now has a persona set in the constructor, once set it never changes
- Command now takes in bot as a constructor param, so it has the correct persona and is not generating AIBot objects on the fly
- Added a .prettierignore file, due to the way ALE is configured in nvim it is a pre-req for prettier to work
- Adds a bunch of validations on the AIPersona model, system personas (artist/creative etc...) are all seeded. We now ensure
- name uniqueness, and only allow certain properties to be touched for system personas.
- (JS note) the client side design takes advantage of nested routes, the parent route for personas gets all the personas via this.store.findAll("ai-persona") then child routes simply reach into this model to find a particular persona.
- (JS note) data is sideloaded into the ai-persona model the meta property supplied from the controller, resultSetMeta
- This removes ai_bot_enabled_personas and ai_bot_enabled_chat_commands, both should be controlled from the UI on a per persona basis
- Fixes a long standing bug in token accounting ... we were doing to_json.length instead of to_json.to_s.length
- Amended it so {commands} are always inserted at the end unconditionally, no need to add it to the template of the system message as it just confuses things
- Adds a concept of required_commands to stock personas, these are commands that must be configured for this stock persona to show up.
- Refactored tests so we stop requiring inference_stubs, it was very confusing to need it, added to plugin.rb for now which at least is clearer
- Migrates the persona selector to gjs
---------
Co-authored-by: Joffrey JAFFEUX <j.jaffeux@gmail.com>
Co-authored-by: Martin Brennan <martin@discourse.org>
2023-11-21 00:56:43 -05:00
|
|
|
let(:bot) { DiscourseAi::AiBot::Bot.as(bot_user) }
|
2023-08-08 17:19:56 -04:00
|
|
|
|
2023-09-11 21:06:55 -04:00
|
|
|
fab!(:parent_category) { Fabricate(:category, name: "animals") }
|
|
|
|
fab!(:category) { Fabricate(:category, parent_category: parent_category, name: "amazing-cat") }
|
|
|
|
|
|
|
|
fab!(:tag_funny) { Fabricate(:tag, name: "funny") }
|
|
|
|
fab!(:tag_sad) { Fabricate(:tag, name: "sad") }
|
|
|
|
fab!(:tag_hidden) { Fabricate(:tag, name: "hidden") }
|
2023-09-12 02:09:28 -04:00
|
|
|
fab!(:staff_tag_group) do
|
|
|
|
tag_group = Fabricate.build(:tag_group, name: "Staff only", tag_names: ["hidden"])
|
|
|
|
|
|
|
|
tag_group.permissions = [
|
|
|
|
[Group::AUTO_GROUPS[:staff], TagGroupPermission.permission_types[:full]],
|
|
|
|
]
|
|
|
|
tag_group.save!
|
|
|
|
tag_group
|
|
|
|
end
|
2023-09-11 21:06:55 -04:00
|
|
|
fab!(:topic_with_tags) do
|
|
|
|
Fabricate(:topic, category: category, tags: [tag_funny, tag_sad, tag_hidden])
|
|
|
|
end
|
|
|
|
|
2023-10-23 02:00:58 -04:00
|
|
|
before { SiteSetting.ai_bot_enabled = true }
|
|
|
|
|
2023-08-08 17:19:56 -04:00
|
|
|
describe "#process" do
|
|
|
|
it "can read a topic" do
|
2023-09-11 21:06:55 -04:00
|
|
|
topic_id = topic_with_tags.id
|
|
|
|
|
|
|
|
Fabricate(:post, topic: topic_with_tags, raw: "hello there")
|
|
|
|
Fabricate(:post, topic: topic_with_tags, raw: "mister sam")
|
2023-08-08 17:19:56 -04:00
|
|
|
|
FEATURE: UI to update ai personas on admin page (#290)
Introduces a UI to manage customizable personas (admin only feature)
Part of the change was some extensive internal refactoring:
- AIBot now has a persona set in the constructor, once set it never changes
- Command now takes in bot as a constructor param, so it has the correct persona and is not generating AIBot objects on the fly
- Added a .prettierignore file, due to the way ALE is configured in nvim it is a pre-req for prettier to work
- Adds a bunch of validations on the AIPersona model, system personas (artist/creative etc...) are all seeded. We now ensure
- name uniqueness, and only allow certain properties to be touched for system personas.
- (JS note) the client side design takes advantage of nested routes, the parent route for personas gets all the personas via this.store.findAll("ai-persona") then child routes simply reach into this model to find a particular persona.
- (JS note) data is sideloaded into the ai-persona model the meta property supplied from the controller, resultSetMeta
- This removes ai_bot_enabled_personas and ai_bot_enabled_chat_commands, both should be controlled from the UI on a per persona basis
- Fixes a long standing bug in token accounting ... we were doing to_json.length instead of to_json.to_s.length
- Amended it so {commands} are always inserted at the end unconditionally, no need to add it to the template of the system message as it just confuses things
- Adds a concept of required_commands to stock personas, these are commands that must be configured for this stock persona to show up.
- Refactored tests so we stop requiring inference_stubs, it was very confusing to need it, added to plugin.rb for now which at least is clearer
- Migrates the persona selector to gjs
---------
Co-authored-by: Joffrey JAFFEUX <j.jaffeux@gmail.com>
Co-authored-by: Martin Brennan <martin@discourse.org>
2023-11-21 00:56:43 -05:00
|
|
|
read = described_class.new(bot: bot, args: nil)
|
2023-08-08 17:19:56 -04:00
|
|
|
|
2023-09-11 21:06:55 -04:00
|
|
|
results = read.process(topic_id: topic_id)
|
2023-08-08 17:19:56 -04:00
|
|
|
|
2023-09-11 21:06:55 -04:00
|
|
|
expect(results[:topic_id]).to eq(topic_id)
|
2023-08-08 17:19:56 -04:00
|
|
|
expect(results[:content]).to include("hello")
|
|
|
|
expect(results[:content]).to include("sam")
|
2023-09-11 21:06:55 -04:00
|
|
|
expect(results[:content]).to include("amazing-cat")
|
|
|
|
expect(results[:content]).to include("funny")
|
|
|
|
expect(results[:content]).to include("sad")
|
|
|
|
expect(results[:content]).to include("animals")
|
|
|
|
expect(results[:content]).not_to include("hidden")
|
|
|
|
expect(read.description_args).to eq(
|
|
|
|
title: topic_with_tags.title,
|
|
|
|
url: topic_with_tags.relative_url,
|
|
|
|
)
|
2023-08-08 17:19:56 -04:00
|
|
|
end
|
|
|
|
end
|
|
|
|
end
|