From 491111e5c83111798c31b97917cd4b368459df7c Mon Sep 17 00:00:00 2001
From: Keegan George <kgeorge13@gmail.com>
Date: Mon, 20 Nov 2023 11:37:00 -0800
Subject: [PATCH] FIX: Un-clickable AI Results (#298)

---
 .../semantic-search.gjs                       | 22 ++++++++++++++-----
 .../embeddings/common/semantic-search.scss    |  1 -
 2 files changed, 17 insertions(+), 6 deletions(-)

diff --git a/assets/javascripts/discourse/connectors/full-page-search-below-search-header/semantic-search.gjs b/assets/javascripts/discourse/connectors/full-page-search-below-search-header/semantic-search.gjs
index 80deea56..06c04632 100644
--- a/assets/javascripts/discourse/connectors/full-page-search-below-search-header/semantic-search.gjs
+++ b/assets/javascripts/discourse/connectors/full-page-search-below-search-header/semantic-search.gjs
@@ -29,7 +29,7 @@ export default class SemanticSearch extends Component {
               {{if this.searching 'in-progress'}}"
           >
             <DToggleSwitch
-              disabled={{this.searching}}
+              disabled={{this.disableToggleSwitch}}
               @state={{this.showingAIResults}}
               title="AI search results hidden"
               class="semantic-search__results-toggle"
@@ -65,6 +65,12 @@ export default class SemanticSearch extends Component {
   @tracked AIResults = [];
   @tracked showingAIResults = false;
 
+  get disableToggleSwitch() {
+    if (this.searching || this.AIResults.length === 0) {
+      return true;
+    }
+  }
+
   get searchStateText() {
     if (this.searching) {
       return I18n.t("discourse_ai.embeddings.semantic_search_loading");
@@ -133,12 +139,18 @@ export default class SemanticSearch extends Component {
         })
           .then(async (results) => {
             const model = (await translateResults(results)) || {};
-            const AIResults = model.posts.map(function (post) {
-              return Object.assign({}, post, { generatedByAI: true });
+
+            if (model.posts?.length === 0) {
+              this.searching = false;
+              return;
+            }
+
+            model.posts.forEach((post) => {
+              post.generatedByAI = true;
             });
 
-            this.args.outletArgs.addSearchResults(AIResults, "topic_id");
-            this.AIResults = AIResults;
+            this.args.outletArgs.addSearchResults(model.posts, "topic_id");
+            this.AIResults = model.posts;
           })
           .catch(popupAjaxError)
           .finally(() => (this.searching = false));
diff --git a/assets/stylesheets/modules/embeddings/common/semantic-search.scss b/assets/stylesheets/modules/embeddings/common/semantic-search.scss
index e5940c46..dcb04a1b 100644
--- a/assets/stylesheets/modules/embeddings/common/semantic-search.scss
+++ b/assets/stylesheets/modules/embeddings/common/semantic-search.scss
@@ -62,7 +62,6 @@
 
   .ai-result {
     display: none;
-    background: var(--tertiary-very-low);
     border-radius: var(--d-border-radius);
 
     .ai-result__icon {