From 4a405311432f633e60e686cfa2884d64297fe351 Mon Sep 17 00:00:00 2001
From: Keegan George <kgeorge13@gmail.com>
Date: Tue, 20 Aug 2024 06:57:23 -0700
Subject: [PATCH] FIX: Clicking on summary links breaks summary (#759)

---
 .../ai-summary-box.gjs                        |  6 ++--
 .../summarization/desktop/ai-summary.scss     |  2 +-
 .../acceptance/topic-summary-test.js          | 31 +++++++++++++++++++
 3 files changed, 36 insertions(+), 3 deletions(-)

diff --git a/assets/javascripts/discourse/connectors/topic-map-expanded-after/ai-summary-box.gjs b/assets/javascripts/discourse/connectors/topic-map-expanded-after/ai-summary-box.gjs
index 6cfe231b..177890e7 100644
--- a/assets/javascripts/discourse/connectors/topic-map-expanded-after/ai-summary-box.gjs
+++ b/assets/javascripts/discourse/connectors/topic-map-expanded-after/ai-summary-box.gjs
@@ -69,8 +69,10 @@ export default class AiSummaryBox extends Component {
   }
 
   @bind
-  subscribe(unsubscribe) {
-    if (unsubscribe && this._channel) {
+  subscribe(unsubscribe, [topicId]) {
+    const sameTopicId = this.args.outletArgs.topic.id === topicId;
+
+    if (unsubscribe && this._channel && !sameTopicId) {
       this.unsubscribe();
     }
     const channel = `/discourse-ai/summaries/topic/${this.args.outletArgs.topic.id}`;
diff --git a/assets/stylesheets/modules/summarization/desktop/ai-summary.scss b/assets/stylesheets/modules/summarization/desktop/ai-summary.scss
index 245abc91..f6054af9 100644
--- a/assets/stylesheets/modules/summarization/desktop/ai-summary.scss
+++ b/assets/stylesheets/modules/summarization/desktop/ai-summary.scss
@@ -37,7 +37,7 @@
           }
         }
         &-box {
-          padding-bottom: 1rem;
+          padding-block: 1rem;
         }
       }
     }
diff --git a/test/javascripts/acceptance/topic-summary-test.js b/test/javascripts/acceptance/topic-summary-test.js
index 03ee27b7..b051471a 100644
--- a/test/javascripts/acceptance/topic-summary-test.js
+++ b/test/javascripts/acceptance/topic-summary-test.js
@@ -66,6 +66,37 @@ acceptance("Topic - Summary", function (needs) {
       .dom(".ai-summary-box .summarized-on")
       .exists("summary metadata exists");
   });
+
+  test("clicking summary links", async function (assert) {
+    await visit("/t/-/1");
+
+    const partialSummary = "In this post,";
+    await publishToMessageBus("/discourse-ai/summaries/topic/1", {
+      done: false,
+      ai_topic_summary: { summarized_text: partialSummary },
+    });
+
+    await click(".ai-topic-summarization");
+    const finalSummaryCooked =
+      "In this post,  <a href='/t/-/1/1'>bianca</a> said some stuff.";
+    const finalSummaryResult = "In this post, bianca said some stuff.";
+    await publishToMessageBus("/discourse-ai/summaries/topic/1", {
+      done: true,
+      ai_topic_summary: {
+        summarized_text: finalSummaryCooked,
+        summarized_on: "2023-01-01T04:00:00.000Z",
+        algorithm: "OpenAI GPT-4",
+        outdated: false,
+        new_posts_since_summary: false,
+        can_regenerate: true,
+      },
+    });
+
+    await click(".generated-summary a");
+    assert
+      .dom(".ai-summary-box .generated-summary p")
+      .hasText(finalSummaryResult, "Retains final summary after clicking link");
+  });
 });
 
 acceptance("Topic - Summary - Anon", function (needs) {