From 71affe75bf6154b837f96233d3eb88be7121ec76 Mon Sep 17 00:00:00 2001
From: Keegan George <kgeorge13@gmail.com>
Date: Mon, 27 May 2024 13:27:45 -0700
Subject: [PATCH] UX: Hide AI preferences page completely if no settings for
 user (#644)

---
 .../user-preferences-nav/ai-preferences.gjs   | 18 +++++++++-
 .../discourse/controllers/preferences-ai.js   |  9 -----
 .../discourse/templates/preferences/ai.hbs    | 35 ++++++++-----------
 config/locales/client.en.yml                  |  5 ---
 4 files changed, 31 insertions(+), 36 deletions(-)

diff --git a/assets/javascripts/discourse/connectors/user-preferences-nav/ai-preferences.gjs b/assets/javascripts/discourse/connectors/user-preferences-nav/ai-preferences.gjs
index 298c7119..2fc2a2b4 100644
--- a/assets/javascripts/discourse/connectors/user-preferences-nav/ai-preferences.gjs
+++ b/assets/javascripts/discourse/connectors/user-preferences-nav/ai-preferences.gjs
@@ -3,9 +3,25 @@ import { LinkTo } from "@ember/routing";
 import dIcon from "discourse-common/helpers/d-icon";
 import i18n from "discourse-common/helpers/i18n";
 
+function showAiPreferences(user, siteSettings) {
+  // Since we only have one AI related user setting we don't show
+  // AI preferences if these conditions aren't met.
+  // If we add more user settings in the future we can move this
+  // logic to the the specific settings and conditionally show it in the template.
+  const userGroups = user.groups.map((g) => g.id);
+  const captionGroups = siteSettings.ai_auto_image_caption_allowed_groups
+    .split("|")
+    .map((id) => parseInt(id, 10));
+
+  return userGroups.some((groupId) => captionGroups.includes(groupId));
+}
+
 export default class AutoImageCaptionSetting extends Component {
   static shouldRender(outletArgs, helper) {
-    return helper.siteSettings.discourse_ai_enabled;
+    return (
+      helper.siteSettings.discourse_ai_enabled &&
+      showAiPreferences(outletArgs.model, helper.siteSettings)
+    );
   }
 
   <template>
diff --git a/assets/javascripts/discourse/controllers/preferences-ai.js b/assets/javascripts/discourse/controllers/preferences-ai.js
index 64db7dda..58856a68 100644
--- a/assets/javascripts/discourse/controllers/preferences-ai.js
+++ b/assets/javascripts/discourse/controllers/preferences-ai.js
@@ -11,15 +11,6 @@ export default class PreferencesAiController extends Controller {
   @service siteSettings;
   @tracked saved = false;
 
-  get canToggleAutoImageCaption() {
-    const userGroups = this.model.groups.map((g) => g.id);
-    const captionGroups = this.siteSettings.ai_auto_image_caption_allowed_groups
-      .split("|")
-      .map((id) => parseInt(id, 10));
-
-    return userGroups.some((groupId) => captionGroups.includes(groupId));
-  }
-
   @action
   save() {
     this.saved = false;
diff --git a/assets/javascripts/discourse/templates/preferences/ai.hbs b/assets/javascripts/discourse/templates/preferences/ai.hbs
index 760dcc6c..dceec402 100644
--- a/assets/javascripts/discourse/templates/preferences/ai.hbs
+++ b/assets/javascripts/discourse/templates/preferences/ai.hbs
@@ -1,24 +1,17 @@
 <label class="control-label">{{i18n "discourse_ai.title"}}</label>
 
-{{#if this.canToggleAutoImageCaption}}
-  <div class="control-group ai-setting">
-    <PreferenceCheckbox
-      @labelKey="discourse_ai.ai_helper.image_caption.automatic_caption_setting"
-      @checked={{this.model.user_option.auto_image_caption}}
-      data-setting-name="auto-image-caption"
-      class="pref-auto-image-caption"
-    />
-  </div>
+<div class="control-group ai-setting">
+  <PreferenceCheckbox
+    @labelKey="discourse_ai.ai_helper.image_caption.automatic_caption_setting"
+    @checked={{this.model.user_option.auto_image_caption}}
+    data-setting-name="auto-image-caption"
+    class="pref-auto-image-caption"
+  />
+</div>
 
-  <SaveControls
-    @id="user_ai_preference_save"
-    @model={{this.model}}
-    @action={{this.save}}
-    @saved={{this.saved}}
-  />
-{{else}}
-  <EmptyState
-    @title={{i18n "discourse_ai.user_preferences.empty_state.title"}}
-    @body={{i18n "discourse_ai.user_preferences.empty_state.body"}}
-  />
-{{/if}}
\ No newline at end of file
+<SaveControls
+  @id="user_ai_preference_save"
+  @model={{this.model}}
+  @action={{this.save}}
+  @saved={{this.saved}}
+/>
\ No newline at end of file
diff --git a/config/locales/client.en.yml b/config/locales/client.en.yml
index 3c334a19..4c1a57be 100644
--- a/config/locales/client.en.yml
+++ b/config/locales/client.en.yml
@@ -119,11 +119,6 @@ en:
     discourse_ai:
       title: "AI"
 
-      user_preferences:
-        empty_state:
-          title: "No AI specific user preferences available."
-          body: "There are currently no user preferences related to AI that are available for you to toggle."
-
       modals:
         select_option: "Select an option..."