FEATURE: Allow specific groups access to summary feature on PMs (#760)

New `ai_pm_summarization_allowed_groups` can be used to allow
visibility of the summarization feature on PMs.

This can be useful on forums where a lot of communication happens
inside PMs.
This commit is contained in:
Sam 2024-08-21 07:58:24 +10:00 committed by GitHub
parent c0328267be
commit 97fc822cb6
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
4 changed files with 18 additions and 2 deletions

View File

@ -80,6 +80,7 @@ en:
ai_summarization_enabled: "Enable the topic summarization module." ai_summarization_enabled: "Enable the topic summarization module."
ai_summarization_model: "Model to use for summarization." ai_summarization_model: "Model to use for summarization."
ai_custom_summarization_allowed_groups: "Groups allowed to use create new summaries." ai_custom_summarization_allowed_groups: "Groups allowed to use create new summaries."
ai_pm_summarization_allowed_groups: "Groups allowed to create and view summaries in PMs."
ai_bot_enabled: "Enable the AI Bot module." ai_bot_enabled: "Enable the AI Bot module."
ai_bot_enable_chat_warning: "Display a warning when PM chat is initiated. Can be overriden by editing the translation string: discourse_ai.ai_bot.pm_warning" ai_bot_enable_chat_warning: "Display a warning when PM chat is initiated. Can be overriden by editing the translation string: discourse_ai.ai_bot.pm_warning"

View File

@ -353,6 +353,10 @@ discourse_ai:
type: enum type: enum
enum: "DiscourseAi::Configuration::LlmEnumerator" enum: "DiscourseAi::Configuration::LlmEnumerator"
validator: "DiscourseAi::Configuration::LlmValidator" validator: "DiscourseAi::Configuration::LlmValidator"
ai_pm_summarization_allowed_groups:
type: group_list
list_type: compact
default: ""
ai_custom_summarization_allowed_groups: ai_custom_summarization_allowed_groups:
type: group_list type: group_list
list_type: compact list_type: compact

View File

@ -5,8 +5,14 @@ module DiscourseAi
def can_see_summary?(target) def can_see_summary?(target)
return false if !SiteSetting.ai_summarization_enabled return false if !SiteSetting.ai_summarization_enabled
# TODO we want a switch to allow summaries for all topics if target.class == Topic && target.private_message?
return false if target.class == Topic && target.private_message? allowed =
SiteSetting.ai_pm_summarization_allowed_groups_map.any? do |group_id|
user.group_ids.include?(group_id)
end
return false if !allowed
end
has_cached_summary = AiSummary.exists?(target: target) has_cached_summary = AiSummary.exists?(target: target)
return has_cached_summary if user.nil? return has_cached_summary if user.nil?

View File

@ -50,6 +50,11 @@ describe DiscourseAi::GuardianExtensions do
it "returns false" do it "returns false" do
expect(guardian.can_see_summary?(pm)).to eq(false) expect(guardian.can_see_summary?(pm)).to eq(false)
end end
it "returns true if user is in a group that is allowed summaries" do
SiteSetting.ai_pm_summarization_allowed_groups = group.id
expect(guardian.can_see_summary?(pm)).to eq(true)
end
end end
context "when there is no user" do context "when there is no user" do