FIX: Display related topics when scrolling to the bottom of a topic. (#150)
Besides updating the connector using the new tracking preference service interface, this PR fixes a bug where due to `ai_embeddings_semantic_related_topics_enabled` not having `client: true` the initializer never ran, and we didn't show the related topics list when scrolling to the bottom of a long topic.
This commit is contained in:
parent
78f61914c8
commit
f111bcb35b
|
@ -3,8 +3,8 @@
|
||||||
class="more-topics__list {{if this.hidden 'hidden'}}"
|
class="more-topics__list {{if this.hidden 'hidden'}}"
|
||||||
role="complementary"
|
role="complementary"
|
||||||
aria-labelledby="related-topics-title"
|
aria-labelledby="related-topics-title"
|
||||||
data-mobile-title={{i18n "discourse_ai.related_topics.pill"}}
|
{{did-insert this.registerList}}
|
||||||
data-list-id={{this.listId}}
|
{{will-destroy this.removeList}}
|
||||||
>
|
>
|
||||||
<h3 id="related-topics-title" class="more-topics__list-title">
|
<h3 id="related-topics-title" class="more-topics__list-title">
|
||||||
{{i18n "discourse_ai.related_topics.title"}}
|
{{i18n "discourse_ai.related_topics.title"}}
|
||||||
|
|
|
@ -1,6 +1,7 @@
|
||||||
import Component from "@glimmer/component";
|
import Component from "@glimmer/component";
|
||||||
import { inject as service } from "@ember/service";
|
import { inject as service } from "@ember/service";
|
||||||
import { computed } from "@ember/object";
|
import { action, computed } from "@ember/object";
|
||||||
|
import I18n from "I18n";
|
||||||
|
|
||||||
export default class extends Component {
|
export default class extends Component {
|
||||||
static shouldRender(args) {
|
static shouldRender(args) {
|
||||||
|
@ -13,9 +14,9 @@ export default class extends Component {
|
||||||
|
|
||||||
listId = "related-topics";
|
listId = "related-topics";
|
||||||
|
|
||||||
@computed("moreTopicsPreferenceTracking.preference")
|
@computed("moreTopicsPreferenceTracking.selectedTab")
|
||||||
get hidden() {
|
get hidden() {
|
||||||
return this.moreTopicsPreferenceTracking.preference !== this.listId;
|
return this.moreTopicsPreferenceTracking.selectedTab !== this.listId;
|
||||||
}
|
}
|
||||||
|
|
||||||
get relatedTopics() {
|
get relatedTopics() {
|
||||||
|
@ -23,4 +24,18 @@ export default class extends Component {
|
||||||
this.store.createRecord("topic", topic)
|
this.store.createRecord("topic", topic)
|
||||||
);
|
);
|
||||||
}
|
}
|
||||||
|
|
||||||
|
@action
|
||||||
|
registerList() {
|
||||||
|
this.moreTopicsPreferenceTracking.registerTopicList({
|
||||||
|
name: I18n.t("discourse_ai.related_topics.pill"),
|
||||||
|
id: this.listId,
|
||||||
|
icon: "magic",
|
||||||
|
});
|
||||||
|
}
|
||||||
|
|
||||||
|
@action
|
||||||
|
removeList() {
|
||||||
|
this.moreTopicsPreferenceTracking.removeTopicList(this.listId);
|
||||||
|
}
|
||||||
}
|
}
|
||||||
|
|
|
@ -165,7 +165,9 @@ discourse_ai:
|
||||||
- text-embedding-ada-002
|
- text-embedding-ada-002
|
||||||
- multilingual-e5-large
|
- multilingual-e5-large
|
||||||
ai_embeddings_generate_for_pms: false
|
ai_embeddings_generate_for_pms: false
|
||||||
ai_embeddings_semantic_related_topics_enabled: false
|
ai_embeddings_semantic_related_topics_enabled:
|
||||||
|
default: false
|
||||||
|
client: true
|
||||||
ai_embeddings_semantic_related_topics: 5
|
ai_embeddings_semantic_related_topics: 5
|
||||||
ai_embeddings_semantic_related_include_closed_topics: true
|
ai_embeddings_semantic_related_include_closed_topics: true
|
||||||
ai_embeddings_pg_connection_string: ""
|
ai_embeddings_pg_connection_string: ""
|
||||||
|
|
Loading…
Reference in New Issue