mirror of
https://github.com/discourse/discourse-ai.git
synced 2025-02-08 20:44:42 +00:00
e817b7dc11
This re-implements tool support in DiscourseAi::Completions::Llm #generate
Previously tool support was always returned via XML and it would be the responsibility of the caller to parse XML
New implementation has the endpoints return ToolCall objects.
Additionally this simplifies the Llm endpoint interface and gives it more clarity. Llms must implement
decode, decode_chunk (for streaming)
It is the implementers responsibility to figure out how to decode chunks, base no longer implements. To make this easy we ship a flexible json decoder which is easy to wire up.
Also (new)
Better debugging for PMs, we now have a next / previous button to see all the Llm messages associated with a PM
Token accounting is fixed for vllm (we were not correctly counting tokens)
126 lines
4.1 KiB
Ruby
126 lines
4.1 KiB
Ruby
# frozen_string_literal: true
|
|
|
|
RSpec.describe DiscourseAi::AiBot::BotController do
|
|
fab!(:user)
|
|
fab!(:pm_topic) { Fabricate(:private_message_topic) }
|
|
fab!(:pm_post) { Fabricate(:post, topic: pm_topic) }
|
|
fab!(:pm_post2) { Fabricate(:post, topic: pm_topic) }
|
|
fab!(:pm_post3) { Fabricate(:post, topic: pm_topic) }
|
|
|
|
before { sign_in(user) }
|
|
|
|
describe "#show_debug_info" do
|
|
before do
|
|
SiteSetting.ai_bot_enabled = true
|
|
SiteSetting.discourse_ai_enabled = true
|
|
end
|
|
|
|
it "returns a 403 when the user cannot debug the AI bot conversation" do
|
|
get "/discourse-ai/ai-bot/post/#{pm_post.id}/show-debug-info"
|
|
expect(response.status).to eq(403)
|
|
end
|
|
|
|
it "returns debug info if the user can debug the AI bot conversation" do
|
|
user = pm_topic.topic_allowed_users.first.user
|
|
sign_in(user)
|
|
|
|
log1 =
|
|
AiApiAuditLog.create!(
|
|
provider_id: 1,
|
|
topic_id: pm_topic.id,
|
|
raw_request_payload: "request",
|
|
raw_response_payload: "response",
|
|
request_tokens: 1,
|
|
response_tokens: 2,
|
|
)
|
|
|
|
log2 =
|
|
AiApiAuditLog.create!(
|
|
post_id: pm_post.id,
|
|
provider_id: 1,
|
|
topic_id: pm_topic.id,
|
|
raw_request_payload: "request",
|
|
raw_response_payload: "response",
|
|
request_tokens: 1,
|
|
response_tokens: 2,
|
|
)
|
|
|
|
log3 =
|
|
AiApiAuditLog.create!(
|
|
post_id: pm_post2.id,
|
|
provider_id: 1,
|
|
topic_id: pm_topic.id,
|
|
raw_request_payload: "request",
|
|
raw_response_payload: "response",
|
|
request_tokens: 1,
|
|
response_tokens: 2,
|
|
)
|
|
|
|
Group.refresh_automatic_groups!
|
|
SiteSetting.ai_bot_debugging_allowed_groups = user.groups.first.id.to_s
|
|
|
|
get "/discourse-ai/ai-bot/post/#{pm_post.id}/show-debug-info"
|
|
expect(response.status).to eq(200)
|
|
|
|
expect(response.parsed_body["id"]).to eq(log2.id)
|
|
expect(response.parsed_body["next_log_id"]).to eq(log3.id)
|
|
expect(response.parsed_body["prev_log_id"]).to eq(log1.id)
|
|
expect(response.parsed_body["topic_id"]).to eq(pm_topic.id)
|
|
|
|
expect(response.parsed_body["request_tokens"]).to eq(1)
|
|
expect(response.parsed_body["response_tokens"]).to eq(2)
|
|
expect(response.parsed_body["raw_request_payload"]).to eq("request")
|
|
expect(response.parsed_body["raw_response_payload"]).to eq("response")
|
|
|
|
# return previous post if current has no debug info
|
|
get "/discourse-ai/ai-bot/post/#{pm_post3.id}/show-debug-info"
|
|
expect(response.status).to eq(200)
|
|
expect(response.parsed_body["request_tokens"]).to eq(1)
|
|
expect(response.parsed_body["response_tokens"]).to eq(2)
|
|
|
|
# can return debug info by id as well
|
|
get "/discourse-ai/ai-bot/show-debug-info/#{log1.id}"
|
|
expect(response.status).to eq(200)
|
|
expect(response.parsed_body["id"]).to eq(log1.id)
|
|
end
|
|
end
|
|
|
|
describe "#stop_streaming_response" do
|
|
let(:redis_stream_key) { "gpt_cancel:#{pm_post.id}" }
|
|
|
|
before { Discourse.redis.setex(redis_stream_key, 60, 1) }
|
|
|
|
it "returns a 403 when the user cannot see the PM" do
|
|
post "/discourse-ai/ai-bot/post/#{pm_post.id}/stop-streaming"
|
|
|
|
expect(response.status).to eq(403)
|
|
end
|
|
|
|
it "deletes the key using to track the streaming" do
|
|
sign_in(pm_topic.topic_allowed_users.first.user)
|
|
|
|
post "/discourse-ai/ai-bot/post/#{pm_post.id}/stop-streaming"
|
|
|
|
expect(response.status).to eq(200)
|
|
expect(Discourse.redis.get(redis_stream_key)).to be_nil
|
|
end
|
|
end
|
|
|
|
describe "#show_bot_username" do
|
|
it "returns the username_lower of the selected bot" do
|
|
gpt_35_bot = Fabricate(:llm_model, name: "gpt-3.5-turbo")
|
|
|
|
SiteSetting.ai_bot_enabled = true
|
|
toggle_enabled_bots(bots: [gpt_35_bot])
|
|
|
|
expected_username =
|
|
DiscourseAi::AiBot::EntryPoint.find_user_from_model("gpt-3.5-turbo").username_lower
|
|
|
|
get "/discourse-ai/ai-bot/bot-username", params: { username: gpt_35_bot.name }
|
|
|
|
expect(response.status).to eq(200)
|
|
expect(response.parsed_body["bot_username"]).to eq(expected_username)
|
|
end
|
|
end
|
|
end
|