Discource-C
/
discourse-chat-integration
mirror of https://github.com/discourse/discourse-chat-integration.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Only load dummy providers in specs where they are required

This commit is contained in:
David Taylor 2017-07-31 13:12:09 +01:00
parent 142687f4d4
commit 04c711e438
2 changed files with 9 additions and 17 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
spec/controllers/chat_controller_spec.rb
View File

@ -11,6 +11,7 @@ describe 'Chat Controller', type: :request do
let(:channel) { DiscourseChat::Channel.create(provider:'dummy') } let(:channel) { DiscourseChat::Channel.create(provider:'dummy') }
include_context "dummy provider" include_context "dummy provider"
include_context "validated dummy provider"
before do before do
SiteSetting.chat_integration_enabled = true SiteSetting.chat_integration_enabled = true
@ -48,7 +49,7 @@ describe 'Chat Controller', type: :request do
expect(json['providers'].size).to eq(2) expect(json['providers'].size).to eq(2)
expect(json['providers'][0]).to eq('name'=> 'dummy', expect(json['providers'].find{|h| h['name']=='dummy'}).to eq('name'=> 'dummy',
'id'=> 'dummy', 'id'=> 'dummy',
'channel_parameters'=> [] 'channel_parameters'=> []
) )

21
spec/dummy_provider.rb
View File

@ -1,10 +1,6 @@
RSpec.shared_context "dummy provider" do RSpec.shared_context "dummy provider" do
before(:each) do before(:each) do
if defined? ::DiscourseChat::Provider::DummyProvider
::DiscourseChat::Provider.send(:remove_const, :DummyProvider)
end
module ::DiscourseChat::Provider::DummyProvider module ::DiscourseChat::Provider::DummyProvider
PROVIDER_NAME = "dummy".freeze PROVIDER_NAME = "dummy".freeze
PROVIDER_ENABLED_SETTING = :chat_integration_enabled # Tie to main plugin enabled setting PROVIDER_ENABLED_SETTING = :chat_integration_enabled # Tie to main plugin enabled setting
@ -32,7 +28,10 @@ RSpec.shared_context "dummy provider" do
@@raise_exception = bool @@raise_exception = bool
end end
end end
end
after(:each) do
::DiscourseChat::Provider.send(:remove_const, :DummyProvider)
end end
let(:provider){::DiscourseChat::Provider::DummyProvider} let(:provider){::DiscourseChat::Provider::DummyProvider}
@ -40,10 +39,6 @@ end
RSpec.shared_context "validated dummy provider" do RSpec.shared_context "validated dummy provider" do
before(:each) do before(:each) do
if defined? ::DiscourseChat::Provider::Dummy2Provider
::DiscourseChat::Provider.send(:remove_const, :Dummy2Provider)
end
module ::DiscourseChat::Provider::Dummy2Provider module ::DiscourseChat::Provider::Dummy2Provider
PROVIDER_NAME = "dummy2".freeze PROVIDER_NAME = "dummy2".freeze
PROVIDER_ENABLED_SETTING = :chat_integration_enabled # Tie to main plugin enabled setting PROVIDER_ENABLED_SETTING = :chat_integration_enabled # Tie to main plugin enabled setting
@ -64,11 +59,7 @@ RSpec.shared_context "validated dummy provider" do
end end
let(:provider){::DiscourseChat::Provider::DummyProvider} after(:each) do
end ::DiscourseChat::Provider.send(:remove_const, :Dummy2Provider)
end
RSpec.configure do |rspec|
rspec.include_context "dummy provider"
rspec.include_context "validated dummy provider"
end end