Merge pull request #2 from discourse/separate-channel-model

Separate channel model

app/controllers/chat_controller.rb

@@ -9,29 +9,25 @@ class DiscourseChat::ChatController < ApplicationController
     providers = ::DiscourseChat::Provider.enabled_providers.map {|x| {
                                       name: x::PROVIDER_NAME, 
                                       id: x::PROVIDER_NAME, 
-                                      channel_regex: (defined? x::PROVIDER_CHANNEL_REGEX) ? x::PROVIDER_CHANNEL_REGEX : nil
+                                      channel_parameters: (defined? x::CHANNEL_PARAMETERS) ? x::CHANNEL_PARAMETERS : []
                                       }}
     
     render json:providers, root: 'providers'
   end
 
-  def test_provider
+  def test
     begin
-      requested_provider = params[:provider]
-      channel = params[:channel]
-      topic_id = params[:topic_id]
+      channel_id = params[:channel_id].to_i
+      topic_id = params[:topic_id].to_i
 
-      provider = ::DiscourseChat::Provider.get_by_name(requested_provider)
+      channel = DiscourseChat::Channel.find(channel_id)
 
-      if provider.nil? or not ::DiscourseChat::Provider.is_enabled(provider)
+      provider = ::DiscourseChat::Provider.get_by_name(channel.provider)
+
+      if not ::DiscourseChat::Provider.is_enabled(provider)
         raise Discourse::NotFound
       end
 
-      if defined? provider::PROVIDER_CHANNEL_REGEX
-        channel_regex = Regexp.new provider::PROVIDER_CHANNEL_REGEX
-        raise Discourse::InvalidParameters, 'Channel is not valid' if not channel_regex.match?(channel)
-      end
-
       post = Topic.find(topic_id.to_i).posts.first
 
       provider.trigger_notification(post, channel)
@@ -48,23 +44,80 @@ class DiscourseChat::ChatController < ApplicationController
     end
   end
 
-  def list_rules
+  def list_channels
     providers = ::DiscourseChat::Provider.enabled_providers.map {|x| x::PROVIDER_NAME}
 
     requested_provider = params[:provider]
 
-    if providers.include? requested_provider
-      rules = DiscourseChat::Rule.with_provider(requested_provider)
-    else
+    if not providers.include? requested_provider
       raise Discourse::NotFound
     end
 
-    render_serialized rules, DiscourseChat::RuleSerializer, root: 'rules'
+    channels = DiscourseChat::Channel.with_provider(requested_provider)
+
+    render_serialized channels, DiscourseChat::ChannelSerializer, root: 'channels'
+  end
+
+  def create_channel
+    begin
+      providers = ::DiscourseChat::Provider.enabled_providers.map {|x| x::PROVIDER_NAME}
+
+      if not defined? params[:channel] and defined? params[:channel][:provider]
+        raise Discourse::InvalidParameters, 'Provider is not valid'
+      end
+
+      requested_provider = params[:channel][:provider]
+
+      if not providers.include? requested_provider
+        raise Discourse::InvalidParameters, 'Provider is not valid'
+      end
+
+      allowed_keys = DiscourseChat::Provider.get_by_name(requested_provider)::CHANNEL_PARAMETERS.map{|p| p[:key].to_sym}
+
+      hash = params.require(:channel).permit(:provider, data:allowed_keys)
+
+      channel = DiscourseChat::Channel.new(hash)
+      
+      if not channel.save(hash)
+        raise Discourse::InvalidParameters, 'Channel is not valid'
+      end
+
+      render_serialized channel, DiscourseChat::ChannelSerializer, root: 'channel'
+    rescue Discourse::InvalidParameters => e
+      render json: {errors: [e.message]}, status: 422
+    end
+  end
+
+  def update_channel
+    begin
+      channel = DiscourseChat::Channel.find(params[:id].to_i)
+      channel.error_key = nil # Reset any error on the rule
+
+      allowed_keys = DiscourseChat::Provider.get_by_name(channel.provider)::CHANNEL_PARAMETERS.map{|p| p[:key].to_sym}
+
+      hash = params.require(:channel).permit(data:allowed_keys)
+      
+      if not channel.update(hash)
+        raise Discourse::InvalidParameters, 'Channel is not valid'
+      end
+
+      render_serialized channel, DiscourseChat::ChannelSerializer, root: 'channel'
+    rescue Discourse::InvalidParameters => e
+      render json: {errors: [e.message]}, status: 422
+    end
+  end
+
+  def destroy_channel
+    rule = DiscourseChat::Channel.find(params[:id].to_i)
+
+    rule.destroy
+
+    render json: success_json
   end
 
   def create_rule
     begin
-      hash = params.require(:rule).permit(:provider, :channel, :filter, :category_id, tags:[])
+      hash = params.require(:rule).permit(:channel_id, :filter, :category_id, tags:[])
 
       rule = DiscourseChat::Rule.new(hash)
       
@@ -81,8 +134,7 @@ class DiscourseChat::ChatController < ApplicationController
   def update_rule
     begin
       rule = DiscourseChat::Rule.find(params[:id].to_i)
-      rule.error_key = nil # Reset any error on the rule
-      hash = params.require(:rule).permit(:provider, :channel, :filter, :category_id, tags:[])
+      hash = params.require(:rule).permit(:filter, :category_id, tags:[])
       
       if not rule.update(hash)
         raise Discourse::InvalidParameters, 'Rule is not valid'

app/helpers/helper.rb

@@ -2,8 +2,9 @@ module DiscourseChat
   module Helper
 	
     # Produce a string with a list of all rules associated with a channel
-  	def self.status_for_channel(provider, channel)
-  		rules = DiscourseChat::Rule.with_channel(provider, channel)
+  	def self.status_for_channel(channel)
+  		rules = channel.rules.order_by_precedence
+      provider = channel.provider
 
   		text = I18n.t("chat_integration.provider.#{provider}.status.header") + "\n"
 
@@ -43,8 +44,8 @@ module DiscourseChat
 
     # Delete a rule based on its (1 based) index as seen in the 
     # status_for_channel function
-    def self.delete_by_index(provider, channel, index)
-      rules = DiscourseChat::Rule.with_channel(provider, channel)
+    def self.delete_by_index(channel, index)
+      rules = channel.rules.order_by_precedence
 
       return false if index < 1 or index > rules.size
 
@@ -58,8 +59,8 @@ module DiscourseChat
     #     :updated if an existing rule has been updated
     #     :created if a new rule has been created
     #     false if there was an error
-    def self.smart_create_rule(provider:, channel:, filter:, category_id:, tags:)
-      existing_rules = DiscourseChat::Rule.with_channel(provider, channel)
+    def self.smart_create_rule(channel:, filter:, category_id:nil, tags:nil)
+      existing_rules = DiscourseChat::Rule.with_channel(channel)
 
       # Select the ones that have the same category
       same_category = existing_rules.select { |rule| rule.category_id == category_id }
@@ -100,7 +101,7 @@ module DiscourseChat
       end
 
       # This rule is unique! Create a new one:
-      return :created if Rule.new({provider: provider, channel: channel, filter: filter, category_id: category_id, tags: tags}).save
+      return :created if Rule.new(channel: channel, filter: filter, category_id: category_id, tags: tags).save
 
       return false # Error
 

app/models/channel.rb

@@ -2,6 +2,54 @@ class DiscourseChat::Channel < DiscourseChat::PluginModel
   KEY_PREFIX = 'channel:'
 
   # Setup ActiveRecord::Store to use the JSON field to read/write these values
-  store :value, accessors: [ :name ], coder: JSON
+  store :value, accessors: [ :provider, :error_key, :data ], coder: JSON
+
+  after_initialize :init_data
+
+  def init_data
+    self.data = {} if self.data.nil?
+  end
+
+  after_destroy :destroy_rules
+  def destroy_rules
+    rules.destroy_all()
+  end
+
+  validate :provider_valid?, :data_valid?
+
+  def provider_valid?
+    # Validate provider
+    if not ::DiscourseChat::Provider.provider_names.include? provider
+      errors.add(:provider, "#{provider} is not a valid provider")
+      return
+    end
+  end
+
+  def data_valid?
+    # If provider is invalid, don't try and check data
+    return unless ::DiscourseChat::Provider.provider_names.include? provider
+
+    params = ::DiscourseChat::Provider.get_by_name(provider)::CHANNEL_PARAMETERS
+
+    unless params.map {|p| p[:key]}.sort == data.keys.sort
+      errors.add(:data, "data does not match the required structure for provider #{provider}")
+      return
+    end
+
+    data.each do |key, value|
+      regex_string = params.find{|p| p[:key] == key}[:regex]
+      if !Regexp.new(regex_string).match?(value)
+        errors.add(:data, "data.#{key} is invalid")
+      end
+    end
+  end
+
+  def rules
+    DiscourseChat::Rule.with_channel_id(id)
+  end
+
+  scope :with_provider, ->(provider) { where("value::json->>'provider'=?", provider)} 
+
+  scope :with_data_value, ->(key, value) { where("(value::json->>'data')::json->>?=?", key, value)} 
 
 end

app/models/rule.rb

@@ -2,7 +2,7 @@ class DiscourseChat::Rule < DiscourseChat::PluginModel
   KEY_PREFIX = 'rule:'
 
   # Setup ActiveRecord::Store to use the JSON field to read/write these values
-  store :value, accessors: [ :provider, :channel, :category_id, :tags, :filter, :error_key ], coder: JSON
+  store :value, accessors: [ :channel_id, :category_id, :tags, :filter ], coder: JSON
 
   after_initialize :init_filter
 
@@ -13,27 +13,12 @@ class DiscourseChat::Rule < DiscourseChat::PluginModel
   validates :filter, :inclusion => { :in => %w(watch follow mute),
     :message => "%{value} is not a valid filter" }
 
-  validate :provider_and_channel_valid?, :category_valid?, :tags_valid?
+  validate :channel_valid?, :category_valid?, :tags_valid?
 
-  def provider_and_channel_valid?
-    # Validate provider
-    if not ::DiscourseChat::Provider.provider_names.include? provider
-      errors.add(:provider, "#{provider} is not a valid provider")
-      return
-    end
-    
-    # Validate channel
-    if channel.blank? 
-      errors.add(:channel, "channel cannot be blank")
-      return
-    end
-
-    provider_class = ::DiscourseChat::Provider.get_by_name(provider)
-    if defined? provider_class::PROVIDER_CHANNEL_REGEX
-      channel_regex = Regexp.new provider_class::PROVIDER_CHANNEL_REGEX
-      if not channel_regex.match?(channel)
-        errors.add(:channel, "#{channel} is not a valid channel for provider #{provider}")
-      end
+  def channel_valid?
+    # Validate category
+    if not (DiscourseChat::Channel.where(id: channel_id).exists?)
+      errors.add(:channel_id, "#{channel_id} is not a valid channel id")
     end
   end
 
@@ -72,12 +57,33 @@ class DiscourseChat::Rule < DiscourseChat::PluginModel
     end
   end
 
-  scope :with_provider, ->(provider) { where("value::json->>'provider'=?", provider)} 
+  # Don't want this to end up as anything other than an integer
+  def channel_id=(val)
+    if val.nil? or val.blank?
+      super(nil)
+    else
+      super(val.to_i)
+    end
+  end
 
-  scope :with_channel, ->(provider, channel) { with_provider(provider).where("value::json->>'channel'=?", channel)} 
+  # Mock foreign key
+  # Could return nil
+  def channel
+    DiscourseChat::Channel.find_by(id:channel_id)
+  end
+  def channel=(val)
+    self.channel_id = val.id
+  end
 
-  scope :with_category, ->(category_id) { category_id.nil? ? where("(value::json->'category_id') IS NULL OR json_typeof(value::json->'category_id')='null'") : where("value::json->>'category_id'=?", category_id.to_s)}
+  scope :with_channel, ->(channel) { with_channel_id(channel.id) } 
+  scope :with_channel_id, ->(channel_id) { where("value::json->>'channel_id'=?", channel_id.to_s)} 
 
+  scope :with_category_id, ->(category_id) { category_id.nil? ? where("(value::json->'category_id') IS NULL OR json_typeof(value::json->'category_id')='null'") : where("value::json->>'category_id'=?", category_id.to_s)}
 
+  scope :order_by_precedence, ->{ order("CASE
+                                          WHEN value::json->>'filter' = 'mute' THEN 1
+                                          WHEN value::json->>'filter' = 'watch' THEN 2
+                                          WHEN value::json->>'filter' = 'follow' THEN 3
+                                         END") }
 
 end

app/routes/discourse_chat.rb

@@ -4,10 +4,14 @@ module DiscourseChat
   AdminEngine.routes.draw do
     get "" => "chat#respond"
     get '/providers' => "chat#list_providers"
-    post '/test' => "chat#test_provider"
+    post '/test' => "chat#test"
     
-    get '/rules' => "chat#list_rules"
-    put '/rules' => "chat#create_rule"
+    get '/channels' => "chat#list_channels"
+    post '/channels' => "chat#create_channel"
+    put '/channels/:id' => "chat#update_channel"
+    delete '/channels/:id' => "chat#destroy_channel"
+
+    post '/rules' => "chat#create_rule"
     put '/rules/:id' => "chat#update_rule"
     delete '/rules/:id' => "chat#destroy_rule"
 

app/serializers/channel_serializer.rb

@@ -0,0 +1,11 @@
+require_relative './rule_serializer'
+
+class DiscourseChat::ChannelSerializer < ApplicationSerializer
+  attributes :id, :provider, :error_key, :data, :rules
+
+  def rules
+    object.rules.order_by_precedence.map do |rule|
+      DiscourseChat::RuleSerializer.new(rule, root:false)
+    end
+  end
+end

app/serializers/rule_serializer.rb

@@ -1,3 +1,3 @@
-class DiscourseChat::RuleSerializer < ActiveModel::Serializer
-  attributes :id, :provider, :channel, :category_id, :tags, :filter, :error_key
+class DiscourseChat::RuleSerializer < ApplicationSerializer
+  attributes :id, :channel_id, :category_id, :tags, :filter
 end

app/services/manager.rb

@@ -22,10 +22,10 @@ module DiscourseChat
       return if topic.blank? || topic.archetype == Archetype.private_message
 
       # Load all the rules that apply to this topic's category
-      matching_rules = DiscourseChat::Rule.with_category(topic.category_id)
+      matching_rules = DiscourseChat::Rule.with_category_id(topic.category_id)
 
       if topic.category # Also load the rules for the wildcard category
-        matching_rules += DiscourseChat::Rule.with_category(nil)
+        matching_rules += DiscourseChat::Rule.with_category_id(nil)
       end
 
       # If tagging is enabled, thow away rules that don't apply to this topic
@@ -44,7 +44,7 @@ module DiscourseChat
       matching_rules = matching_rules.sort(&sort_func)
 
       # Take the first rule for each channel
-      uniq_func = proc { |rule| [rule.provider, rule.channel] }
+      uniq_func = proc { |rule| [rule.channel_id] }
       matching_rules = matching_rules.uniq(&uniq_func)
 
       # If a matching rule is set to mute, we can discard it now
@@ -61,18 +61,19 @@ module DiscourseChat
 
       # Loop through each rule, and trigger appropriate notifications
       matching_rules.each do |rule|
-        provider = ::DiscourseChat::Provider.get_by_name(rule.provider)
-        is_enabled = ::DiscourseChat::Provider.is_enabled(provider)
+        # If there are any issues, skip to the next rule
+        next unless channel = rule.channel
+        next unless provider = ::DiscourseChat::Provider.get_by_name(channel.provider)
+        next unless is_enabled = ::DiscourseChat::Provider.is_enabled(provider)
 
-        if provider and is_enabled
         begin
-            provider.trigger_notification(post, rule.channel)
-            rule.update_attribute('error_key', nil) if rule.error_key
+          provider.trigger_notification(post, channel)
+          channel.update_attribute('error_key', nil) if channel.error_key
         rescue => e
           if e.class == DiscourseChat::ProviderError and e.info.key?(:error_key) and !e.info[:error_key].nil?
-              rule.update_attribute('error_key', e.info[:error_key])
+            channel.update_attribute('error_key', e.info[:error_key])
           else
-              rule.update_attribute('error_key','chat_integration.rule_exception')
+            channel.update_attribute('error_key','chat_integration.channel_exception')
           end
 
           # Log the error
@@ -84,11 +85,7 @@ module DiscourseChat
                      error_info: e.class == DiscourseChat::ProviderError ? e.info : nil }
           )
         end
-        elsif provider
-          # Provider is disabled, don't do anything
-        else
-          # TODO: Handle when the provider does not exist
-        end
+        
       end
 
     end

assets/javascripts/admin/adapters/channel.js.es6

@@ -0,0 +1,7 @@
+import buildPluginAdapter from 'admin/adapters/build-plugin';
+import Rule from 'discourse/plugins/discourse-chat-integration/admin/models/rule'
+
+export default buildPluginAdapter('chat').extend({
+
+
+});

assets/javascripts/admin/components/channel-details.js.es6

@@ -0,0 +1,38 @@
+import { popupAjaxError } from 'discourse/lib/ajax-error';
+
+export default Ember.Component.extend({
+  classNames: ['channel-details'],
+  actions: {
+    refresh: function(){
+      this.sendAction('refresh');
+    },
+
+    delete(channel){
+      bootbox.confirm(I18n.t("chat_integration.channel_delete_confirm"), I18n.t("no_value"), I18n.t("yes_value"), result => {
+        if (result) {
+          channel.destroyRecord().then(() => {
+            this.send('refresh');
+          }).catch(popupAjaxError)
+        }
+      });
+    },
+
+    edit(channel){
+      this.sendAction('edit', channel)
+    },
+
+    test(channel){
+      this.sendAction('test', channel)
+    },
+
+    createRule(channel){
+      var newRule = this.get('store').createRecord('rule',{channel_id: channel.id});
+      channel.rules.pushObject(newRule)
+    },
+
+    showError(error_key){
+      bootbox.alert(I18n.t(error_key));
+    },
+
+  }
+});

assets/javascripts/admin/components/rule-row.js.es6

@@ -0,0 +1,38 @@
+import { popupAjaxError } from 'discourse/lib/ajax-error';
+
+export default Ember.Component.extend({
+  tagName: 'tr',
+  editing: false,
+
+  autoEdit: function(){
+    if(!this.get('rule').id){
+      this.set('editing', true);
+    }
+  }.on('init'),
+
+  actions: {
+    edit: function(){
+      this.set('editing', true);
+    },
+
+    cancel: function(){
+      this.send('refresh');
+    },
+
+    save: function(){
+      this.get('rule').save().then(result => {
+        this.send('refresh');
+      }).catch(popupAjaxError);
+    },
+
+    delete(rule){
+      rule.destroyRecord().then(() => {
+        this.send('refresh');
+      }).catch(popupAjaxError)
+    },
+
+    refresh: function(){
+      this.sendAction('refresh');
+    }
+  }
+});

assets/javascripts/admin/controllers/admin-plugins-chat-provider.js.es6

@@ -10,39 +10,30 @@ export default Ember.Controller.extend({
 
   anyErrors: function(){
     var anyErrors = false;
-    this.get('model.rules').forEach(function(rule){
-      if(rule.error_key){
+    this.get('model.channels').forEach(function(channel){
+      if(channel.error_key){
         anyErrors = true;
       }
     });
     return anyErrors;
-  }.property('model.rules'),
+  }.property('model.channels'),
 
   actions:{
-  	create(){
+  	createChannel(){
   		this.set('modalShowing', true);
-      var model = {rule: this.store.createRecord('rule',{provider: this.get('model.provider').id}), provider:this.get('model.provider')};
-  		showModal('admin-plugins-chat-edit-rule', { model: model, admin: true });
+      var model = {channel: this.store.createRecord('channel',{provider: this.get('model.provider').id, data:{}},), provider:this.get('model.provider')};
+  		showModal('admin-plugins-chat-edit-channel', { model: model, admin: true });
   	},
-  	edit(rule){
+  	editChannel(channel){
   		this.set('modalShowing', true);
-      var model = {rule: rule, provider:this.get('model.provider')};
-  		showModal('admin-plugins-chat-edit-rule', { model: model, admin: true });
+      var model = {channel: channel, provider: this.get('model.provider')};
+  		showModal('admin-plugins-chat-edit-channel', { model: model, admin: true });
   	},
-  	delete(rule){
-  		const self = this;
-  		rule.destroyRecord().then(function() {
-        self.send('refresh');
-      }).catch(popupAjaxError)
-  	},
-    showError(error_key){
-      bootbox.alert(I18n.t(error_key));
-    },
-    test(){
+    testChannel(channel){
       this.set('modalShowing', true);
-      var model = {provider:this.get('model.provider'), channel:''}
+      var model = {channel:channel}
       showModal('admin-plugins-chat-test', { model: model, admin: true });
-    }
+    },
 
   }
 

assets/javascripts/admin/controllers/modals/admin-plugins-chat-edit-channel.js.es6

@@ -0,0 +1,93 @@
+import Rule from 'discourse/plugins/discourse-chat-integration/admin/models/rule'
+import ModalFunctionality from 'discourse/mixins/modal-functionality';
+import { ajax } from 'discourse/lib/ajax';
+import { extractError } from 'discourse/lib/ajax-error';
+import InputValidation from 'discourse/models/input-validation';
+
+export default Ember.Controller.extend(ModalFunctionality, {
+
+  // The validation property must be defined at runtime since the possible parameters vary by provider
+  setupValidations: function(){
+    if(this.get('model.provider')){
+      var theKeys = this.get('model.provider.channel_parameters').map( ( param ) => param['key'] );
+      Ember.defineProperty(this,'paramValidation',Ember.computed('model.channel.data.{' + theKeys.join(',') + '}',this._paramValidation));
+    }
+  }.observes('model'),
+
+  validate(parameter){
+    var regString = parameter.regex;
+    var regex = new RegExp(regString);
+    var val = this.get('model.channel.data.'+parameter.key);
+
+    if(val==undefined){
+      val = "";
+    }
+
+    if(val == ""){ // Fail silently if field blank
+      return InputValidation.create({
+        failed: true,
+      });
+    }else if(!regString){ // Pass silently if no regex available for provider
+      return InputValidation.create({
+        ok: true,
+      });
+    }else if(regex.test(val)){ // Test against regex
+      return InputValidation.create({
+        ok: true,
+        reason: I18n.t('chat_integration.edit_channel_modal.channel_validation.ok')
+      });
+    }else{ // Failed regex
+      return InputValidation.create({
+        failed: true,
+        reason: I18n.t('chat_integration.edit_channel_modal.channel_validation.fail')
+      });
+    }
+
+  },
+
+  _paramValidation: function(){
+    var response = {}
+    var parameters = this.get('model.provider.channel_parameters');
+    parameters.forEach(parameter => {
+      response[parameter.key] = this.validate(parameter);
+    });
+    return response;
+  },
+
+  saveDisabled: function(){
+    var validations = this.get('paramValidation');
+    
+    if(!validations){ return true }
+
+    var invalid = false;
+
+    Object.keys(validations).forEach(key =>{
+      if(!validations[key]){
+        invalid = true;
+      }
+      if(!validations[key]['ok']){
+       invalid = true;
+      }
+    });
+      
+    return invalid;
+  }.property('paramValidation'),
+
+  actions: {
+    cancel: function(){
+      this.send('closeModal');
+    },
+
+    save: function(){
+
+    	const self = this;
+
+    	this.get('model.channel').save().then(function(result) {
+        self.send('closeModal');
+      }).catch(function(error) {
+        self.flash(extractError(error), 'error');
+      });
+
+    }
+  }
+});

assets/javascripts/admin/controllers/modals/admin-plugins-chat-edit-rule.js.es6

@@ -1,61 +0,0 @@
-import Rule from 'discourse/plugins/discourse-chat-integration/admin/models/rule'
-import ModalFunctionality from 'discourse/mixins/modal-functionality';
-import { ajax } from 'discourse/lib/ajax';
-import { extractError } from 'discourse/lib/ajax-error';
-import InputValidation from 'discourse/models/input-validation';
-
-export default Ember.Controller.extend(ModalFunctionality, {
-
-  model: Rule.create({}),
-
-  channelValidation: function(){
-
-    var regString = this.get('model.provider.channel_regex');
-    var regex = new RegExp(regString);
-    var val = this.get('model.rule.channel');
-
-    if(val == ""){ // Fail silently if field blank
-      return InputValidation.create({
-        failed: true,
-      });
-    }else if(!regString){ // Pass silently if no regex available for provider
-      return InputValidation.create({
-        ok: true,
-      });
-    }else if(regex.test(val)){ // Test against regex
-      return InputValidation.create({
-        ok: true,
-        reason: I18n.t('chat_integration.edit_rule_modal.channel_validation.ok')
-      });
-    }else{ // Failed regex
-      return InputValidation.create({
-        failed: true,
-        reason: I18n.t('chat_integration.edit_rule_modal.channel_validation.fail')
-      });
-    }
-  }.property('model.rule.channel'),
-
-  saveDisabled: function(){
-    if(this.get('channelValidation.failed')){ return true }
-      
-    return false;
-  }.property('channelValidation.failed'),
-
-  actions: {
-    cancel: function(){
-      this.send('closeModal');
-    },
-
-    save: function(){
-
-    	const self = this;
-
-    	this.get('model.rule').update().then(function(result) {
-        self.send('closeModal');
-      }).catch(function(error) {
-        self.flash(extractError(error), 'error');
-      });
-
-    }
-  }
-});

assets/javascripts/admin/controllers/modals/admin-plugins-chat-test.js.es6

@@ -3,11 +3,11 @@ import { ajax } from 'discourse/lib/ajax';
 
 export default Ember.Controller.extend(ModalFunctionality, {
 	sendDisabled: function(){
-		if(this.get('model').topic_id && this.get('model').channel){
+		if(this.get('model').topic_id){
 			return false
 		}
 		return true
-	}.property('model.topic_id', 'model.channel'),
+	}.property('model.topic_id'),
 
 	actions: {
 
@@ -15,8 +15,7 @@ export default Ember.Controller.extend(ModalFunctionality, {
 			self = this;
 			this.set('loading', true);
 			ajax("/admin/plugins/chat/test", {
-        data: { provider: this.get('model.provider.name'), 
-        				channel: this.get('model.channel'), 
+        data: { channel_id: this.get('model.channel.id'), 
         				topic_id: this.get('model.topic_id') 
         			},
         type: 'POST'

assets/javascripts/admin/models/channel.js.es6

@@ -0,0 +1,14 @@
+import RestModel from 'discourse/models/rest';
+
+export default RestModel.extend({
+
+  updateProperties() {
+    var prop_names = ['data'];
+    return this.getProperties(prop_names);
+  },
+
+  createProperties() {
+    var prop_names = ['provider','data'];
+    return this.getProperties(prop_names);
+  }
+});

assets/javascripts/admin/models/rule.js.es6

@@ -11,9 +11,8 @@ export default RestModel.extend({
 
   category_id: null,
   tags: null,
-  provider: '',
-  channel: '',
-  filter: null,
+  channel_id: null,
+  filter: 'watch',
   error_key: null,
 
   @computed('category_id')
@@ -31,12 +30,13 @@ export default RestModel.extend({
   },
 
   updateProperties() {
-    var prop_names = ['category_id','provider','channel', 'tags','filter'];
+    var prop_names = ['category_id','tags','filter'];
     return this.getProperties(prop_names);
   },
 
   createProperties() {
-    return this.updateProperties();
+    var prop_names = ['channel_id', 'category_id','tags','filter'];
+    return this.getProperties(prop_names);
   }
 
 });

assets/javascripts/admin/routes/admin-plugins-chat-provider.js.es6

@@ -1,12 +1,20 @@
-import Rule from 'discourse/plugins/discourse-chat-integration/admin/models/rule'
 import { ajax } from 'discourse/lib/ajax';
 
 export default Discourse.Route.extend({
 
   model(params, transition) {
     return Ember.RSVP.hash({
-      rules: this.store.find('rule', {provider: params.provider}),
+      channels: this.store.findAll('channel', {provider: params.provider}),
       provider: this.modelFor("admin-plugins-chat").findBy('id',params.provider)
+    }).then(value => {
+      value.channels.forEach(channel => {
+        channel.set('rules', channel.rules.map(rule => {
+          rule = this.store.createRecord('rule', rule);
+          rule.channel = channel;
+          return rule;
+        }));
+      });
+      return value;
     });
   },
 

assets/javascripts/admin/templates/modal/admin-plugins-chat-edit-channel.hbs

@@ -0,0 +1,49 @@
+{{#d-modal-body id="chat_integration_edit_channel_modal" title="chat_integration.edit_channel_modal.title"}}
+  <div>
+    <form>
+      <table>
+
+      	<tr class="input">
+          <td class="label"><label for='provider'>{{i18n "chat_integration.edit_channel_modal.provider"}}</label></td>
+          <td>
+          	{{i18n (concat 'chat_integration.provider.' model.channel.provider '.title')}}
+          </td>
+        </tr>
+        <tr class="instructions">
+          <td></td>
+          <td></td>
+        </tr>
+
+        {{# each model.provider.channel_parameters as |param|}}
+          <tr class="input">
+            <td class="label"><label for='param-{{param.key}}'>{{i18n (concat 'chat_integration.provider.' model.channel.provider '.param.' param.key '.title')}}</label></td>
+            <td>
+            	{{text-field 
+  							name=(concat 'param-' param.key)
+  							value=(mut (get model.channel.data param.key))
+                }}
+
+              &nbsp;
+              {{#if (get model.channel.data param.key)}}
+                {{input-tip validation=(get paramValidation param.key)}}
+              {{/if}}
+            </td>
+          </tr>
+          <tr class="instructions">
+            <td></td>
+            <td><label>{{i18n (concat 'chat_integration.provider.' model.channel.provider '.param.' param.key '.help')}}</label></td>
+          </tr>
+        {{/each}}
+      </table>
+
+    </form>
+  </div>	
+{{/d-modal-body}}
+
+<div class="modal-footer">
+
+	{{d-button id="save_channel" class='btn-primary btn-large' action="save" title="chat_integration.edit_channel_modal.save" label="chat_integration.edit_channel_modal.save" disabled=saveDisabled}}
+
+	{{d-button class="btn-large" action="cancel" title="chat_integration.edit_channel_modal.cancel" label="chat_integration.edit_channel_modal.cancel"}}
+
+</div>

assets/javascripts/admin/templates/modal/admin-plugins-chat-edit-rule.hbs

@@ -1,87 +0,0 @@
-{{#d-modal-body id="chat_integration_edit_rule_modal" title="chat_integration.edit_rule_modal.title"}}
-  <div>
-    <form>
-      <table>
-
-      	<tr class="input">
-          <td class="label"><label for='provider'>{{i18n "chat_integration.edit_rule_modal.provider"}}</label></td>
-          <td>
-          	{{i18n (concat 'chat_integration.provider.' model.rule.provider '.title')}}
-          </td>
-        </tr>
-        <tr class="instructions">
-          <td></td>
-          <td></td>
-        </tr>
-
-        <tr class="input">
-          <td class="label"><label for='channel'>{{i18n "chat_integration.edit_rule_modal.channel"}}</label></td>
-          <td>
-          	{{text-field 
-							name="channel"
-							value=model.rule.channel 
-							autofocus="autofocus"
-              id="channel-field"}}
-
-            &nbsp;{{input-tip validation=channelValidation}}
-          </td>
-        </tr>
-        <tr class="instructions">
-          <td></td>
-          <td><label>{{i18n (concat 'chat_integration.provider.' model.rule.provider '.channel_instructions')}}</label></td>
-        </tr>
-
-        <tr class="input">
-          <td class="label"><label for='filter'>{{i18n "chat_integration.edit_rule_modal.filter"}}</label></td>
-          <td>
-            {{combo-box name="filter" content=model.rule.available_filters value=model.rule.filter}}
-          </td>
-        </tr>
-        <tr class="instructions">
-          <td></td>
-          <td><label>{{i18n 'chat_integration.edit_rule_modal.instructions.filter'}}</label></td>
-        </tr>
-
-        <tr class="input">
-          <td class="label"><label for='category'>{{i18n "chat_integration.edit_rule_modal.category"}}</label></td>
-          <td>
-          	{{category-chooser
-	      			name="category"
-	            value=model.rule.category_id
-	            rootNoneLabel="chat_integration.all_categories"
-	            rootNone=true
-              overrideWidths=false
-	            }} 
-          </td>
-        </tr>
-        <tr class="instructions">
-          <td></td>
-          <td><label>{{i18n 'chat_integration.edit_rule_modal.instructions.category'}}</label></td>
-        </tr>
-
-        {{#if siteSettings.tagging_enabled}}
-          <tr class="input">
-            <td class="label"><label for='tags'>{{i18n "chat_integration.edit_rule_modal.tags"}}</label></td>
-            <td>
-              {{tag-chooser placeholderKey="chat_integration.all_tags" name="tags" tags=model.rule.tags}}
-            </td>
-          </tr>
-          <tr class="instructions">
-            <td></td>
-            <td><label>{{i18n 'chat_integration.edit_rule_modal.instructions.tags'}}</label></td>
-          </tr>
-		    {{/if}}
-
-      </table>
-
-    </form>
-  </div>	
-{{/d-modal-body}}
-
-<div class="modal-footer">
-
-	{{d-button id="save_rule" class='btn-primary btn-large' action="save" title="chat_integration.edit_rule_modal.save" label="chat_integration.edit_rule_modal.save" disabled=saveDisabled}}
-
-	{{d-button class="btn-large" action="cancel" title="chat_integration.edit_rule_modal.cancel" label="chat_integration.edit_rule_modal.cancel"}}
-
-</div>

assets/javascripts/admin/templates/modal/admin-plugins-chat-test.hbs

@@ -3,33 +3,6 @@
     <form>
       <table>
 
-      	<tr class="input">
-          <td class="label"><label for='provider'>{{i18n "chat_integration.test_modal.provider"}}</label></td>
-          <td>
-          	{{i18n (concat 'chat_integration.provider.' model.provider.id '.title')}}
-          </td>
-        </tr>
-        <tr class="instructions">
-          <td></td>
-          <td></td>
-        </tr>
-
-        <tr class="input">
-          <td class="label"><label for='channel'>{{i18n "chat_integration.test_modal.channel"}}</label></td>
-          <td>
-          	{{text-field 
-							name="channel"
-							value=model.channel
-							autofocus="autofocus"
-              id="channel-field"}}
-
-            {{!-- &nbsp;{{input-tip validation=channelValidation}} --}}
-          </td>
-        </tr>
-        <tr class="instructions">
-          <td></td>
-          <td><label>{{i18n (concat 'chat_integration.provider.' model.provider.id '.channel_instructions')}}</label></td>
-        </tr>
  
         <tr class="input">
           <td class="label"><label for='channel'>{{i18n "chat_integration.test_modal.topic"}}</label></td>

assets/javascripts/discourse/templates/admin/plugins-chat-provider.hbs

@@ -2,74 +2,24 @@
   {{#if anyErrors}}
     <div class="error">
       <i class="fa fa-exclamation-triangle"></i>
-      <span class="error-message">{{i18n "chat_integration.rules_with_errors"}}</span>
+      <span class="error-message">{{i18n "chat_integration.channels_with_errors"}}</span>
     </div>
   {{/if}}
 
-  <table>
-    <tr>
-      <th>{{i18n "chat_integration.rule_table.channel"}}</th>
-      <th>{{i18n "chat_integration.rule_table.filter"}}</th>
+  {{# each model.channels as |channel|}}
+    {{channel-details 
+        channel=channel 
+        provider=model.provider 
+        store=store 
+        refresh='refresh' 
+        edit='editChannel' 
+        test='testChannel' 
+        }}
     
-      <th>{{i18n "chat_integration.rule_table.category"}}</th>
-
-      {{#if siteSettings.tagging_enabled}}
-        <th>{{i18n "chat_integration.rule_table.tags"}}</th>
-      {{/if}}
-
-      
-      
-      <th></th>
-    </tr>
-
-
-    {{#each model.rules as |rule|}}
-
-      <tr>
-				<td>
-          {{#if rule.error_key}}
-
-            {{d-button action="showError" actionParam=rule.error_key class="delete btn-danger" icon="exclamation-triangle"}}
-            
-          {{/if}}
-
-          {{rule.channel}}
-        </td>
-        <td>{{rule.filterName}}</td>
-
-        <td>
-        	{{#if rule.category}}
-        		{{category-link rule.category allowUncategorized="true" link="false"}}
-        	{{else}}
-        		{{i18n "chat_integration.all_categories"}}
-        	{{/if}}
-        </td>
-
-
-        {{#if siteSettings.tagging_enabled}}
-          <td>
-            {{#if rule.tags}}
-              {{rule.tags}}
-            {{else}}
-              {{i18n "chat_integration.all_tags"}}
-            {{/if}}
-          </td>
-        {{/if}}
-
-        
-        <td>
-          {{d-button action="edit" actionParam=rule icon="pencil" class="edit" title="chat_integration.rule_table.edit_rule"}}
-          {{d-button action="delete" actionParam=rule icon="trash-o" class="delete" title="chat_integration.rule_table.delete_rule"}}
-        </td>
-      </tr>
   {{/each}}
   
-  </table>
-  
   <div class="table-footer">
-    {{d-button id="test_provider" action="test" actionParam=model.provider icon="rocket" title="chat_integration.test_provider" label="chat_integration.test_provider"}}
-
     <div class="pull-right">
-       {{d-button id="create_rule" action="create" actionParam=model.provider icon="plus" title="chat_integration.create_rule" label="chat_integration.create_rule"}}
+       {{d-button id="create_channel" action="createChannel" actionParam=model.provider icon="plus" title="chat_integration.create_channel" label="chat_integration.create_channel"}}
     </div>
   </div>

assets/javascripts/discourse/templates/components/channel-details.hbs

@@ -0,0 +1,53 @@
+<div class='channel-header'>
+  <div class='pull-right'>
+    {{d-button action="edit" actionParam=channel icon="pencil" title="chat_integration.edit_channel" label="chat_integration.edit_channel"}}
+
+    {{d-button action="test" actionParam=channel icon="rocket" title="chat_integration.test_channel" label="chat_integration.test_channel"}}
+
+    {{d-button class='cancel' action="delete" actionParam=channel icon="trash" title="chat_integration.delete_channel" label="chat_integration.delete_channel"}}
+  </div>
+  <span class='channel-title'>
+    {{#if channel.error_key}}
+      {{d-button action="showError" actionParam=channel.error_key class="delete btn-danger" icon="exclamation-triangle"}}
+    {{/if}}
+
+
+    {{# each provider.channel_parameters as |param|}}
+        <b>{{i18n (concat 'chat_integration.provider.' channel.provider '.param.' param.key '.title')}}:</b>
+        {{get channel.data param.key}} <br/>
+      
+    {{/each}}
+
+  </span>
+  
+</div>
+<div class='channel-body'>
+<table>
+  <tr>
+    {{!-- <th></th> --}}
+    <th>{{i18n "chat_integration.rule_table.filter"}}</th>
+
+    <th>{{i18n "chat_integration.rule_table.category"}}</th>
+
+    {{#if siteSettings.tagging_enabled}}
+      <th>{{i18n "chat_integration.rule_table.tags"}}</th>
+    {{/if}}
+
+    
+    
+    <th></th>
+  </tr>
+
+  
+  {{#each channel.rules as |rule|}}
+    {{rule-row rule=rule refresh=refresh}}
+    
+  {{/each}}
+
+</table>
+</div>
+<div class='channel-footer'>
+  <div class='pull-right'>
+   {{d-button action="createRule" actionParam=channel icon="plus" title="chat_integration.create_rule" label="chat_integration.create_rule"}}
+  </div>
+</div>

assets/javascripts/discourse/templates/components/rule-row.hbs

@@ -0,0 +1,53 @@
+
+<td>
+  {{#if editing}}
+    {{combo-box name="filter" content=rule.available_filters value=rule.filter}}
+  {{else}}
+    {{rule.filterName}}
+  {{/if}}
+</td>
+  
+
+<td>
+  {{#if editing}}
+    {{category-chooser
+      name="category"
+      value=rule.category_id
+      rootNoneLabel="chat_integration.all_categories"
+      rootNone=true
+      overrideWidths=false
+      }} 
+  {{else}}
+    {{#if rule.category}}
+      {{category-link rule.category allowUncategorized="true" link="false"}}
+    {{else}}
+      {{i18n "chat_integration.all_categories"}}
+    {{/if}}
+  {{/if}}
+</td>
+
+
+{{#if siteSettings.tagging_enabled}}
+  <td>
+    {{#if editing}}
+      {{tag-chooser placeholderKey="chat_integration.all_tags" name="tags" tags=rule.tags}}
+    {{else}}
+      {{#if rule.tags}}
+        {{rule.tags}}
+      {{else}}
+        {{i18n "chat_integration.all_tags"}}
+      {{/if}}
+    {{/if}}
+  </td>
+{{/if}}
+
+
+<td>
+  {{#if editing}}
+    {{d-button action="save" actionParam=rule icon="check" class="ok" title="chat_integration.rule_table.save_rule"}}
+    {{d-button action="cancel" actionParam=rule icon="times" class="cancel" title="chat_integration.rule_table.cancel_edit"}}
+  {{else}}
+    {{d-button action="edit" actionParam=rule icon="pencil" class="edit" title="chat_integration.rule_table.edit_rule"}}
+    {{d-button action="delete" actionParam=rule icon="trash-o" class="delete" title="chat_integration.rule_table.delete_rule"}}
+  {{/if}}
+</td>

assets/stylesheets/chat-integration-admin.scss

@@ -1,16 +1,17 @@
 #admin-plugin-chat{
 
 	table{
+		margin-top:0;
 		td:last-child{
 			white-space:nowrap;
 		}
 		td:not(:last-child){
-			width: 25%;
+			width: 30%;
 		}
 	}
 
 	div.table-footer{
-		margin-top: 10px;
+		margin: 10px;
 	}
 
 	div.error {
@@ -21,14 +22,35 @@
     margin-bottom: 10px;
     background-color: dark-light-diff($quaternary, $secondary, 70%, -70%);
     padding: 15px;
+  }
 
+  div.channel-details{
+  	margin: 20px 10px;
   	
+  	border: 1px solid dark-light-diff($primary, $secondary, 90%, -75%);
+
+  	div.channel-header{
+			background: dark-light-diff($primary, $secondary, 90%, -75%);  		
+			padding: 10px;
+			overflow:auto;
+
+			.channel-title{
+				font-weight: bold;
+				font-size: 1.3em;
 			}
 
 
   	}
 
-#chat_integration_edit_rule_modal, #chat_integration_test_modal{
+  	div.channel-footer{
+  		overflow:auto;
+  	}
+  }
+
+
+}
+
+#chat_integration_edit_channel_modal, #chat_integration_test_modal{
 		table{
 			width:100%;
 

config/locales/client.en.yml

@@ -4,12 +4,16 @@ en:
       menu_title: "Chat Integrations"
       settings: "Settings"
       no_providers: "You need to enable some providers in the plugin settings"
-      rules_with_errors: "Some rules for this provider failed last time they were triggered. Click the error icon(s) to learn more."
-      rule_exception: "An unknown error occured when this rule was last triggered. Check the site logs for more information."
+      channels_with_errors: "Some channels for this provider failed last time messages were sent. Click the error icon(s) to learn more."
+      channel_exception: "An unknown error occured when a message was last sent to this channel. Check the site logs for more information."
       all_categories: "(all categories)"
       all_tags: "(all tags)"
       create_rule: "Create Rule"
-      test_provider: "Test Provider"
+      create_channel: "Create Channel"
+      delete_channel: "Delete"
+      test_channel: "Test"
+      edit_channel: "Edit"
+      channel_delete_confirm: "Are you sure you want to delete this channel? All associated rules will be deleted."
       test_modal:
         title: "Send a test message"
         provider: "Provider"
@@ -30,22 +34,14 @@ en:
         tags: "Tags"
         edit_rule: "Edit"
         delete_rule: "Delete"
-      edit_rule_modal:
-        title: "Edit Rule"
-        save: "Save Rule"
+      edit_channel_modal:
+        title: "Edit Channel"
+        save: "Save Channel"
         cancel: "Cancel"
         provider: "Provider"
-        category: "Category"
-        tags: "Tags"
-        channel: "Channel"
-        filter: "Filter"
         channel_validation:
           ok: "Valid"
-          fail: "Invalid channel format"
-        instructions:
-          filter: "Notification level. Mute overrides other matching rules."
-          category: "This rule will only apply to topics in the specified category."
-          tags: "If specified, this rule will only apply to topics which have at least one of these tags."
+          fail: "Invalid format"
 
       provider:
 
@@ -54,7 +50,10 @@ en:
         #######################################
         slack:
           title: "Slack"
-          channel_instructions: "e.g. #channel, @username."
+          param:
+            identifier:
+              title: Channel
+              help: "e.g. #channel, @username."
           errors:
             action_prohibited: "The bot does not have permission to post to that channel"
             channel_not_found: "The specified channel does not exist on slack"

lib/discourse_chat/provider/slack/slack_command_controller.rb

@@ -22,7 +22,7 @@ module DiscourseChat::Provider::SlackProvider
       tokens = params[:text].split(" ")
 
       # channel name fix
-      channel =
+      channel_id =
         case params[:channel_name]
         when 'directmessage'
           "@#{params[:user_name]}"
@@ -34,6 +34,11 @@ module DiscourseChat::Provider::SlackProvider
 
       provider = DiscourseChat::Provider::SlackProvider::PROVIDER_NAME
 
+      channel = DiscourseChat::Channel.with_provider(provider).with_data_value('identifier',channel_id).first
+
+      # Create channel if doesn't exist
+      channel ||= DiscourseChat::Channel.create!(provider:provider, data:{identifier: channel_id})
+
       cmd = tokens.shift if tokens.size >= 1
 
       error_text = I18n.t("chat_integration.provider.slack.parse_error")
@@ -72,7 +77,7 @@ module DiscourseChat::Provider::SlackProvider
         end
 
         category_id = category.nil? ? nil : category.id
-        case DiscourseChat::Helper.smart_create_rule(provider: provider, channel:channel, filter:cmd, category_id: category_id, tags:tags)
+        case DiscourseChat::Helper.smart_create_rule(channel:channel, filter:cmd, category_id: category_id, tags:tags)
         when :created
           return I18n.t("chat_integration.provider.slack.create.created")
         when :updated
@@ -86,13 +91,13 @@ module DiscourseChat::Provider::SlackProvider
         rule_number = tokens[0].to_i
         return error_text unless rule_number.to_s == tokens[0] # Check we were given a number
 
-        if DiscourseChat::Helper.delete_by_index(provider, channel, rule_number)
+        if DiscourseChat::Helper.delete_by_index(channel, rule_number)
           return I18n.t("chat_integration.provider.slack.delete.success")
         else
           return I18n.t("chat_integration.provider.slack.delete.error")
         end
       when "status"
-        return DiscourseChat::Helper.status_for_channel(provider, channel)
+        return DiscourseChat::Helper.status_for_channel(channel)
       when "help"
         return I18n.t("chat_integration.provider.slack.help")
       else

lib/discourse_chat/provider/slack/slack_provider.rb

@@ -3,7 +3,9 @@ module DiscourseChat::Provider::SlackProvider
 
   PROVIDER_ENABLED_SETTING = :chat_integration_slack_enabled
 
-  PROVIDER_CHANNEL_REGEX = '^[@#]\S*$'
+  CHANNEL_PARAMETERS = [
+                        {key: "identifier", regex: '^[@#]\S*$'}
+                       ]
 
   def self.excerpt(post, max_length = SiteSetting.chat_integration_slack_excerpt_length)
     doc = Nokogiri::HTML.fragment(post.excerpt(max_length,
@@ -137,12 +139,13 @@ module DiscourseChat::Provider::SlackProvider
   end
 
   def self.trigger_notification(post, channel)
-  	message = slack_message(post, channel)
+    channel_id = channel.data['identifier']
+  	message = slack_message(post, channel_id)
 
 		if SiteSetting.chat_integration_slack_access_token.empty?
 			self.send_via_webhook(message)
 		else
-			self.send_via_api(post, channel, message)
+			self.send_via_api(post, channel_id, message)
 		end
 
   end

lib/discourse_chat/provider/telegram/telegram_provider.rb

@@ -1,10 +1,10 @@
 module DiscourseChat
   module Provider
     module TelegramProvider
-    	include Provider
-
       PROVIDER_NAME = "telegram".freeze
       PROVIDER_ENABLED_SETTING = :chat_integration_telegram_enabled
+      CHANNEL_PARAMETERS = []
+
     end
   end
 end

plugin.rb

@@ -19,6 +19,7 @@ after_initialize do
   require_relative "app/models/rule"
   require_relative "app/models/channel"
 
+  require_relative "app/serializers/channel_serializer"
   require_relative "app/serializers/rule_serializer"
   
   require_relative "app/controllers/chat_controller"

spec/controllers/chat_controller_spec.rb

@@ -6,7 +6,9 @@ describe 'Chat Controller', type: :request do
   let(:topic) { Fabricate(:topic, posts: [first_post]) }
   let(:admin) { Fabricate(:admin) }
   let(:category) { Fabricate(:category) }
+  let(:category2) { Fabricate(:category) }
   let(:tag) { Fabricate(:tag) }
+  let(:channel) { DiscourseChat::Channel.create(provider:'dummy') }
 
   include_context "dummy provider"
 
@@ -44,17 +46,17 @@ describe 'Chat Controller', type: :request do
 
         json = JSON.parse(response.body)
 
-        expect(json['providers'].size).to eq(1)
+        expect(json['providers'].size).to eq(2)
 
         expect(json['providers'][0]).to eq('name'=> 'dummy',
                               'id'=> 'dummy',
-                              'channel_regex'=> nil
+                              'channel_parameters'=> []
                               )
       end
     end
   end
 
-  describe 'testing providers' do
+  describe 'testing channels' do
     include_examples 'admin constraints', 'get', '/admin/plugins/chat/test.json'
 
     context 'when signed in as an admin' do
@@ -63,23 +65,23 @@ describe 'Chat Controller', type: :request do
       end
 
       it 'should return the right response' do
-        post '/admin/plugins/chat/test.json', provider: 'dummy', channel: '#general', topic_id: topic.id
+        post '/admin/plugins/chat/test.json', channel_id: channel.id, topic_id: topic.id
 
         expect(response).to be_success
 
         json = JSON.parse(response.body)
       end
 
-      it 'should fail for invalid provider' do
-        post '/admin/plugins/chat/test.json', provider: 'someprovider', channel: '#general', topic_id: topic.id
+      it 'should fail for invalid channel' do
+        post '/admin/plugins/chat/test.json', channel_id: 999, topic_id: topic.id
 
         expect(response).not_to be_success
       end
     end
   end
 
-  describe 'viewing rules' do
-    include_examples 'admin constraints', 'get', '/admin/plugins/chat/rules.json'
+  describe 'viewing channels' do
+    include_examples 'admin constraints', 'get', '/admin/plugins/chat/channels.json'
 
     context 'when signed in as an admin' do
       before do
@@ -87,29 +89,27 @@ describe 'Chat Controller', type: :request do
       end
 
       it 'should return the right response' do
-        rule = DiscourseChat::Rule.create({provider: 'dummy', channel: '#general', filter:'follow', category_id:category.id, tags:[tag.name]})
+        rule = DiscourseChat::Rule.create(channel: channel, filter:'follow', category_id:category.id, tags:[tag.name])
 
-        get '/admin/plugins/chat/rules.json', provider:'dummy'
+        get '/admin/plugins/chat/channels.json', provider:'dummy'
 
         expect(response).to be_success
 
-        rules = JSON.parse(response.body)['rules']
+        channels = JSON.parse(response.body)['channels']
 
-        expect(rules.count).to eq(1)
+        expect(channels.count).to eq(1)
 
-        expect(rules.first).to eq(
-          "channel" => "#general",
-          "category_id" => category.id,
-          "tags" => [tag.name],
-          "filter" => "follow",
+        expect(channels.first).to eq(
+          "id" => channel.id,
+          "provider" => 'dummy',
+          "data" => {},
           "error_key" => nil,
-          "id" => rule.id,
-          "provider" => 'dummy'
+          "rules" => [{"id" => rule.id, "filter" => "follow", "channel_id" => channel.id, "category_id" => category.id, "tags" => [tag.name]}]
         )
       end
 
       it 'should fail for invalid provider' do
-        get '/admin/plugins/chat/rules.json', provider:'someprovider'
+        get '/admin/plugins/chat/channels.json', provider:'someprovider'
 
         expect(response).not_to be_success
       end
@@ -117,6 +117,98 @@ describe 'Chat Controller', type: :request do
     end
   end
 
+  describe 'adding a channel' do
+    include_examples 'admin constraints', 'post', '/admin/plugins/chat/channels.json'
+
+    context 'as an admin' do
+
+      before do
+        sign_in(admin)
+      end
+
+      it 'should be able to add a new channel' do
+        post '/admin/plugins/chat/channels.json',
+          channel:{
+            provider: 'dummy',
+            data: {}
+          }
+
+        expect(response).to be_success
+
+        channel = DiscourseChat::Channel.all.first
+
+        expect(channel.provider).to eq('dummy')
+      end
+
+      it 'should fail for invalid params' do
+        post '/admin/plugins/chat/channels.json',
+          channel:{
+            provider: 'dummy2',
+            data: {val: 'something with whitespace'}
+          }
+
+        expect(response).not_to be_success
+
+      end
+    end
+  end
+
+  describe 'updating a channel' do
+    let(:channel){DiscourseChat::Channel.create(provider:'dummy2', data:{val:"something"})}
+    
+    include_examples 'admin constraints', 'put', "/admin/plugins/chat/channels/1.json"
+
+    context 'as an admin' do
+
+      before do
+        sign_in(admin)
+      end
+
+      it 'should be able update a channel' do
+        put "/admin/plugins/chat/channels/#{channel.id}.json",
+          channel:{
+            data: {val: "something-else"}
+          }
+
+        expect(response).to be_success
+
+        channel = DiscourseChat::Channel.all.first
+        expect(channel.data).to eq({"val" => "something-else"})
+      end
+
+      it 'should fail for invalid params' do
+        put "/admin/plugins/chat/channels/#{channel.id}.json",
+          channel:{
+            data: {val: "something with whitespace"}
+          }
+
+        expect(response).not_to be_success
+
+      end
+    end
+  end
+
+  describe 'deleting a channel' do
+    let(:channel){DiscourseChat::Channel.create(provider:'dummy', data:{})}
+    
+    include_examples 'admin constraints', 'delete', "/admin/plugins/chat/channels/1.json"
+
+    context 'as an admin' do
+
+      before do
+        sign_in(admin)
+      end
+
+      it 'should be able delete a channel' do
+        delete "/admin/plugins/chat/channels/#{channel.id}.json"
+
+        expect(response).to be_success
+
+        expect(DiscourseChat::Channel.all.size).to eq(0)
+      end
+    end
+  end
+
   describe 'adding a rule' do
     include_examples 'admin constraints', 'put', '/admin/plugins/chat/rules.json'
 
@@ -127,10 +219,9 @@ describe 'Chat Controller', type: :request do
       end
 
       it 'should be able to add a new rule' do
-        put '/admin/plugins/chat/rules.json',
+        post '/admin/plugins/chat/rules.json',
           rule:{
-            provider: 'dummy',
-            channel: '#general',
+            channel_id: channel.id,
             category_id: category.id,
             filter: 'watch',
             tags: [tag.name]
@@ -140,8 +231,7 @@ describe 'Chat Controller', type: :request do
 
         rule = DiscourseChat::Rule.all.first
 
-        expect(rule.provider).to eq('dummy')
-        expect(rule.channel).to eq('#general')
+        expect(rule.channel_id).to eq(channel.id)
         expect(rule.category_id).to eq(category.id)
         expect(rule.filter).to eq('watch')
         expect(rule.tags).to eq([tag.name])
@@ -149,10 +239,9 @@ describe 'Chat Controller', type: :request do
       end
 
       it 'should fail for invalid params' do
-        put '/admin/plugins/chat/rules.json',
+        post '/admin/plugins/chat/rules.json',
           rule:{
-            provider: 'dummy',
-            channel: '#general',
+            channel_id: channel.id,
             category_id: category.id,
             filter: 'watch',
             tags: ['somenonexistanttag']
@@ -165,7 +254,7 @@ describe 'Chat Controller', type: :request do
   end
 
   describe 'updating a rule' do
-    let(:rule){DiscourseChat::Rule.create({provider: 'dummy', channel: '#general', filter:'follow', category_id:category.id, tags:[tag.name]})}
+    let(:rule){DiscourseChat::Rule.create(channel: channel, filter:'follow', category_id:category.id, tags:[tag.name])}
     
     include_examples 'admin constraints', 'put', "/admin/plugins/chat/rules/1.json"
 
@@ -178,9 +267,8 @@ describe 'Chat Controller', type: :request do
       it 'should be able update a rule' do
         put "/admin/plugins/chat/rules/#{rule.id}.json",
           rule:{
-            provider: rule.provider,
-            channel: '#random',
-            category_id: rule.category_id,
+            channel_id: channel.id,
+            category_id: category2.id,
             filter: rule.filter,
             tags: rule.tags
           }
@@ -188,20 +276,13 @@ describe 'Chat Controller', type: :request do
         expect(response).to be_success
 
         rule = DiscourseChat::Rule.all.first
-
-        expect(rule.provider).to eq('dummy')
-        expect(rule.channel).to eq('#random')
-        expect(rule.category_id).to eq(category.id)
-        expect(rule.filter).to eq('follow')
-        expect(rule.tags).to eq([tag.name])
-
+        expect(rule.category_id).to eq(category2.id)
       end
 
       it 'should fail for invalid params' do
         put "/admin/plugins/chat/rules/#{rule.id}.json",
           rule:{
-            provider: 'dummy',
-            channel: '#general',
+            channel_id: channel.id,
             category_id: category.id,
             filter: 'watch',
             tags: ['somenonexistanttag']
@@ -214,7 +295,7 @@ describe 'Chat Controller', type: :request do
   end
 
   describe 'deleting a rule' do
-    let(:rule){DiscourseChat::Rule.create({provider: 'dummy', channel: '#general', filter:'follow', category_id:category.id, tags:[tag.name]})}
+    let(:rule){DiscourseChat::Rule.create(channel_id: channel.id, filter:'follow', category_id:category.id, tags:[tag.name])}
     
     include_examples 'admin constraints', 'delete', "/admin/plugins/chat/rules/1.json"
 

spec/dummy_provider.rb

@@ -8,6 +8,8 @@ RSpec.shared_context "dummy provider" do
     module ::DiscourseChat::Provider::DummyProvider
       PROVIDER_NAME = "dummy".freeze
       PROVIDER_ENABLED_SETTING = :chat_integration_enabled # Tie to main plugin enabled setting
+      CHANNEL_PARAMETERS = []
+
       @@sent_messages = []
       @@raise_exception = nil
 
@@ -22,6 +24,10 @@ RSpec.shared_context "dummy provider" do
         @@sent_messages
       end
 
+      def self.sent_to_channel_ids
+        @@sent_messages.map{|x| x[:channel].id}
+      end
+
       def self.set_raise_exception(bool)
         @@raise_exception = bool
       end
@@ -30,9 +36,39 @@ RSpec.shared_context "dummy provider" do
   end
 
   let(:provider){::DiscourseChat::Provider::DummyProvider}
+end
 
+RSpec.shared_context "validated dummy provider" do
+  before(:each) do
+    if defined? ::DiscourseChat::Provider::Dummy2Provider
+      ::DiscourseChat::Provider.send(:remove_const, :Dummy2Provider)
+    end
+    
+    module ::DiscourseChat::Provider::Dummy2Provider
+      PROVIDER_NAME = "dummy2".freeze
+      PROVIDER_ENABLED_SETTING = :chat_integration_enabled # Tie to main plugin enabled setting
+      CHANNEL_PARAMETERS = [
+                            {key: "val", regex: '^\S+$'}
+                           ]
+
+      @@sent_messages = []
+
+      def self.trigger_notification(post, channel)
+        @@sent_messages.push(post: post.id, channel: channel)
+      end
+
+      def self.sent_messages
+        @@sent_messages
+      end
+    end
+    
+  end
+
+  let(:provider){::DiscourseChat::Provider::DummyProvider}
 end
 
 RSpec.configure do |rspec|
   rspec.include_context "dummy provider"
+  rspec.include_context "validated dummy provider"
+
 end

spec/helpers/helper_spec.rb

@@ -1,6 +1,13 @@
 require 'rails_helper'
+require_relative '../dummy_provider'
 
 RSpec.describe DiscourseChat::Manager do
+  include_context "dummy provider"
+
+  let(:chan1){DiscourseChat::Channel.create!(provider:'dummy')}
+  let(:chan2){DiscourseChat::Channel.create!(provider:'dummy')}
+
+  let(:category) {Fabricate(:category)}
 
   let(:category) {Fabricate(:category)}
   let(:tag1){Fabricate(:tag)}
@@ -11,45 +18,36 @@ RSpec.describe DiscourseChat::Manager do
     
     context 'with no rules' do
       it 'includes the heading' do
-        string = DiscourseChat::Helper.status_for_channel('slack','#general')
-        expect(string).to include('Rules for this channel')
+        string = DiscourseChat::Helper.status_for_channel(chan1)
+        expect(string).to include('dummy.status.header')
       end
 
       it 'includes the no_rules string' do
-        string = DiscourseChat::Helper.status_for_channel('slack','#general')
-        expect(string).to include('no rules')
+        string = DiscourseChat::Helper.status_for_channel(chan1)
+        expect(string).to include('dummy.status.no_rules')
       end
     end
 
     context 'with some rules' do
       before do
-        DiscourseChat::Rule.new({provider: 'slack', channel: '#general', filter:'watch', category_id:category.id, tags:nil}).save!
-        DiscourseChat::Rule.new({provider: 'slack', channel: '#general', filter:'mute', category_id:nil, tags:nil}).save!
-        DiscourseChat::Rule.new({provider: 'slack', channel: '#general', filter:'follow', category_id:nil, tags:[tag1.name]}).save!
-        DiscourseChat::Rule.new({provider: 'slack', channel: '#otherchannel', filter:'watch', category_id:1, tags:nil}).save!
+        DiscourseChat::Rule.create!(channel: chan1, filter:'watch', category_id:category.id, tags:nil)
+        DiscourseChat::Rule.create!(channel: chan1, filter:'mute', category_id:nil, tags:nil)
+        DiscourseChat::Rule.create!(channel: chan1, filter:'follow', category_id:nil, tags:[tag1.name])
+        DiscourseChat::Rule.create!(channel: chan2, filter:'watch', category_id:1, tags:nil)
       end
 
       it 'displays the correct rules' do
-        string = DiscourseChat::Helper.status_for_channel('slack','#general')
-        expect(string.scan('watch').size).to eq(1)
-        expect(string.scan('mute').size).to eq(1)
-        expect(string.scan('follow').size).to eq(1)
-      end
-
-      it 'enumerates the rules correctly' do
-        string = DiscourseChat::Helper.status_for_channel('slack','#general')
-        expect(string.scan('1)').size).to eq(1)
-        expect(string.scan('2)').size).to eq(1)
-        expect(string.scan('3)').size).to eq(1)
+        string = DiscourseChat::Helper.status_for_channel(chan1)
+        expect(string.scan('status.rule_string').size).to eq(3)
       end
 
       it 'only displays tags for rules with tags' do
-        string = DiscourseChat::Helper.status_for_channel('slack','#general')
-        expect(string.scan('with tags').size).to eq(0)
+        string = DiscourseChat::Helper.status_for_channel(chan1)
+        expect(string.scan('rule_string_tags_suffix').size).to eq(0)
 
         SiteSetting.tagging_enabled = true
-        string = DiscourseChat::Helper.status_for_channel('slack','#general')
-        expect(string.scan('with tags').size).to eq(1)
+        string = DiscourseChat::Helper.status_for_channel(chan1)
+        expect(string.scan('rule_string_tags_suffix').size).to eq(1)
       end
 
     end
@@ -64,46 +62,42 @@ RSpec.describe DiscourseChat::Manager do
       # Three identical rules, with different categories 
       # Status will be sorted by category id, so they should
       # be in this order
-      rule1 = DiscourseChat::Rule.new({provider: 'slack',
-                                          channel: '#general',
+      rule1 = DiscourseChat::Rule.create(channel: chan1,
                                       filter: 'watch',
                                       category_id: category.id,
                                       tags: [tag1.name, tag2.name]
-                                        }).save!
-      rule2 = DiscourseChat::Rule.new({provider: 'slack',
-                                          channel: '#general',
+                                      )
+      rule2 = DiscourseChat::Rule.create(channel: chan1,
                                       filter: 'watch',
                                       category_id: category2.id,
                                       tags: [tag1.name, tag2.name]
-                                        }).save!
-      rule3 = DiscourseChat::Rule.new({provider: 'slack',
-                                          channel: '#general',
+                                      )
+      rule3 = DiscourseChat::Rule.create(channel: chan1,
                                       filter: 'watch',
                                       category_id: category3.id,
                                       tags: [tag1.name, tag2.name]
-                                        }).save!
+                                      )
 
       expect(DiscourseChat::Rule.all.size).to eq(3)
 
-      expect(DiscourseChat::Helper.delete_by_index('slack','#general',2)).to eq(:deleted)
+      expect(DiscourseChat::Helper.delete_by_index(chan1,2)).to eq(:deleted)
 
       expect(DiscourseChat::Rule.all.size).to eq(2)
       expect(DiscourseChat::Rule.all.map(&:category_id)).to contain_exactly(category.id, category3.id)
     end
 
     it 'fails gracefully for out of range indexes' do
-      rule1 = DiscourseChat::Rule.new({provider: 'slack',
-                                          channel: '#general',
+      rule1 = DiscourseChat::Rule.create(channel: chan1,
                                         filter: 'watch',
                                         category_id: category.id,
                                         tags: [tag1.name, tag2.name]
-                                        }).save!
+                                        )
 
-      expect(DiscourseChat::Helper.delete_by_index('slack','#general',-1)).to eq(false)
-      expect(DiscourseChat::Helper.delete_by_index('slack','#general',0)).to eq(false)
-      expect(DiscourseChat::Helper.delete_by_index('slack','#general',2)).to eq(false)
+      expect(DiscourseChat::Helper.delete_by_index(chan1,-1)).to eq(false)
+      expect(DiscourseChat::Helper.delete_by_index(chan1,0)).to eq(false)
+      expect(DiscourseChat::Helper.delete_by_index(chan1,2)).to eq(false)
 
-      expect(DiscourseChat::Helper.delete_by_index('slack','#general',1)).to eq(:deleted)
+      expect(DiscourseChat::Helper.delete_by_index(chan1,1)).to eq(:deleted)
     end
 
 
@@ -112,8 +106,7 @@ RSpec.describe DiscourseChat::Manager do
   describe '.smart_create_rule' do
 
     it 'creates a rule when there are none' do
-      val = DiscourseChat::Helper.smart_create_rule(provider: 'slack',
-                                                    channel: '#general',
+      val = DiscourseChat::Helper.smart_create_rule(channel: chan1,
                                                     filter: 'watch',
                                                     category_id: category.id,
                                                     tags: [tag1.name]
@@ -121,23 +114,20 @@ RSpec.describe DiscourseChat::Manager do
       expect(val).to eq(:created)
 
       record = DiscourseChat::Rule.all.first
-      expect(record.provider).to eq('slack')
-      expect(record.channel).to eq('#general')
+      expect(record.channel).to eq(chan1)
       expect(record.filter).to eq('watch')
       expect(record.category_id).to eq(category.id)
       expect(record.tags).to eq([tag1.name])
     end
 
     it 'updates a rule when it has the same category and tags' do
-      existing = DiscourseChat::Rule.new({provider: 'slack',
-                                          channel: '#general',
+      existing = DiscourseChat::Rule.create!(channel:chan1,
                                           filter: 'watch',
                                           category_id: category.id,
                                           tags: [tag2.name, tag1.name]
-                                        }).save!
+                                        )
 
-      val = DiscourseChat::Helper.smart_create_rule(provider: 'slack',
-                                                    channel: '#general',
+      val = DiscourseChat::Helper.smart_create_rule(channel: chan1,
                                                     filter: 'mute',
                                                     category_id: category.id,
                                                     tags: [tag1.name, tag2.name]
@@ -150,15 +140,13 @@ RSpec.describe DiscourseChat::Manager do
     end
 
     it 'updates a rule when it has the same category and filter' do
-      existing = DiscourseChat::Rule.new({provider: 'slack',
-                                          channel: '#general',
+      existing = DiscourseChat::Rule.create(channel: chan1,
                                             filter: 'watch',
                                             category_id: category.id,
                                             tags: [tag1.name, tag2.name]
-                                        }).save!
+                                            )
 
-      val = DiscourseChat::Helper.smart_create_rule(provider: 'slack',
-                                                    channel: '#general',
+      val = DiscourseChat::Helper.smart_create_rule(channel: chan1,
                                                     filter: 'watch',
                                                     category_id: category.id,
                                                     tags: [tag1.name, tag3.name]
@@ -171,11 +159,10 @@ RSpec.describe DiscourseChat::Manager do
     end
 
     it 'destroys duplicate rules on save' do
-      DiscourseChat::Rule.new({provider: 'slack', channel: '#general', filter: 'watch'}).save!
-      DiscourseChat::Rule.new({provider: 'slack', channel: '#general', filter: 'watch'}).save!
+      DiscourseChat::Rule.create!(channel: chan1, filter: 'watch')
+      DiscourseChat::Rule.create!(channel: chan1, filter: 'watch')
       expect(DiscourseChat::Rule.all.size).to eq(2)
-      val = DiscourseChat::Helper.smart_create_rule(provider: 'slack',
-                                                    channel: '#general',
+      val = DiscourseChat::Helper.smart_create_rule(channel: chan1,
                                                     filter: 'watch',
                                                     category_id: nil,
                                                     tags: nil
@@ -185,12 +172,7 @@ RSpec.describe DiscourseChat::Manager do
     end
 
     it 'returns false on error' do
-      val = DiscourseChat::Helper.smart_create_rule(provider: 'nonexistantprovider',
-                                                    channel: '#general',
-                                                    filter: 'watch',
-                                                    category_id: nil,
-                                                    tags: nil
-                                                    )
+      val = DiscourseChat::Helper.smart_create_rule(channel: chan1, filter: 'blah')
 
       expect(val).to eq(false)
     end

spec/lib/discourse_chat/provider/slack/slack_command_controller_spec.rb

@@ -4,6 +4,7 @@ describe 'Slack Command Controller', type: :request do
   let(:category) { Fabricate(:category) }
   let(:tag) { Fabricate(:tag) }
   let(:tag2) { Fabricate(:tag) }
+  let!(:chan1){DiscourseChat::Channel.create!(provider:'slack', data:{identifier: '#welcome'})}
 
   describe 'with plugin disabled' do
     it 'should return a 404' do
@@ -24,8 +25,6 @@ describe 'Slack Command Controller', type: :request do
     end
   end
   
-
-
   describe 'slash commands endpoint' do
     before do
       SiteSetting.chat_integration_enabled = true
@@ -82,8 +81,7 @@ describe 'Slack Command Controller', type: :request do
           expect(json["text"]).to eq(I18n.t("chat_integration.provider.slack.create.created"))
 
           rule = DiscourseChat::Rule.all.first
-          expect(rule.provider).to eq('slack')
-          expect(rule.channel).to eq('#welcome')
+          expect(rule.channel).to eq(chan1)
           expect(rule.filter).to eq('watch')
           expect(rule.category_id).to eq(category.id)
           expect(rule.tags).to eq(nil)
@@ -144,8 +142,7 @@ describe 'Slack Command Controller', type: :request do
             expect(json["text"]).to eq(I18n.t("chat_integration.provider.slack.create.created"))
 
             rule = DiscourseChat::Rule.all.first
-            expect(rule.provider).to eq('slack')
-            expect(rule.channel).to eq('#welcome')
+            expect(rule.channel).to eq(chan1)
             expect(rule.filter).to eq('watch')
             expect(rule.category_id).to eq(nil)
             expect(rule.tags).to eq([tag.name])
@@ -164,8 +161,7 @@ describe 'Slack Command Controller', type: :request do
             expect(json["text"]).to eq(I18n.t("chat_integration.provider.slack.create.created"))
 
             rule = DiscourseChat::Rule.all.first
-            expect(rule.provider).to eq('slack')
-            expect(rule.channel).to eq('#welcome')
+            expect(rule.channel).to eq(chan1)
             expect(rule.filter).to eq('watch')
             expect(rule.category_id).to eq(category.id)
             expect(rule.tags).to contain_exactly(tag.name, tag2.name)
@@ -184,16 +180,36 @@ describe 'Slack Command Controller', type: :request do
             expect(json["text"]).to eq(I18n.t("chat_integration.provider.slack.not_found.tag", name:"blah"))
           end
         end
+
+        context 'from an unknown channel' do
+          it 'creates the channel' do
+            post "/chat-integration/slack/command.json",
+            text: "watch #{category.slug}",
+            channel_name: 'general',
+            token: token
+
+            json = JSON.parse(response.body)
+
+            expect(json["text"]).to eq(I18n.t("chat_integration.provider.slack.create.created"))
+
+            chan = DiscourseChat::Channel.with_provider('slack').with_data_value('identifier','#general').first
+            expect(chan.provider).to eq('slack')
+
+            rule = chan.rules.first
+            expect(rule.filter).to eq('watch')
+            expect(rule.category_id).to eq(category.id)
+            expect(rule.tags).to eq(nil)
+          end
+        end
       end
 
       describe 'remove rule' do
         it 'removes the rule' do
-          rule1 = DiscourseChat::Rule.new({provider: 'slack',
-                                          channel: '#welcome',
+          rule1 = DiscourseChat::Rule.create(channel: chan1,
                                             filter: 'watch',
                                             category_id: category.id,
                                             tags: [tag.name, tag2.name]
-                                        }).save!
+                                            )
 
           expect(DiscourseChat::Rule.all.size).to eq(1)
           post "/chat-integration/slack/command.json",
@@ -250,7 +266,7 @@ describe 'Slack Command Controller', type: :request do
 
           json = JSON.parse(response.body)
 
-          expect(json["text"]).to eq(DiscourseChat::Helper.status_for_channel('slack','#welcome'))
+          expect(json["text"]).to eq(DiscourseChat::Helper.status_for_channel(chan1))
         end
       end
 

spec/lib/discourse_chat/provider/slack/slack_provider_spec.rb

@@ -57,16 +57,18 @@ RSpec.describe DiscourseChat::Provider::SlackProvider do
       SiteSetting.chat_integration_slack_enabled = true
     end
 
+    let(:chan1){DiscourseChat::Channel.create!(provider:'slack', data:{identifier: '#general'})}
+
     it 'sends a webhook request' do
       stub1 = stub_request(:post, SiteSetting.chat_integration_slack_outbound_webhook_url).to_return(body: "success")
-      described_class.trigger_notification(post, '#general')
+      described_class.trigger_notification(post, chan1)
       expect(stub1).to have_been_requested.once
     end
 
     it 'handles errors correctly' do 
       stub1 = stub_request(:post, SiteSetting.chat_integration_slack_outbound_webhook_url).to_return(status: 400, body: "error")
       expect(stub1).to have_been_requested.times(0)
-      expect{described_class.trigger_notification(post, '#general')}.to raise_exception(::DiscourseChat::ProviderError)
+      expect{described_class.trigger_notification(post, chan1)}.to raise_exception(::DiscourseChat::ProviderError)
       expect(stub1).to have_been_requested.once
     end
 
@@ -81,14 +83,14 @@ RSpec.describe DiscourseChat::Provider::SlackProvider do
       it 'sends an api request' do
         expect(@stub2).to have_been_requested.times(0)
         
-        described_class.trigger_notification(post, '#general')
+        described_class.trigger_notification(post, chan1)
         expect(@stub1).to have_been_requested.times(0)
         expect(@stub2).to have_been_requested.once
       end
 
       it 'handles errors correctly' do
         @stub2 = stub_request(:post, %r{https://slack.com/api/chat.postMessage}).to_return(body: "{\"ok\":false }", headers: {'Content-Type' => 'application/json'})
-        expect{described_class.trigger_notification(post, '#general')}.to raise_exception(::DiscourseChat::ProviderError)
+        expect{described_class.trigger_notification(post, chan1)}.to raise_exception(::DiscourseChat::ProviderError)
         expect(@stub2).to have_been_requested.once
       end
 
@@ -97,8 +99,8 @@ RSpec.describe DiscourseChat::Provider::SlackProvider do
         expect(@stub2).to have_been_requested.times(0)
         expect(@stub3).to have_been_requested.times(0)
         
-        described_class.trigger_notification(post, '#general')
-        described_class.trigger_notification(second_post, '#general')
+        described_class.trigger_notification(post, chan1)
+        described_class.trigger_notification(second_post, chan1)
         expect(@stub1).to have_been_requested.times(0)
         expect(@stub2).to have_been_requested.once # Initial creation of message
         expect(@stub3).to have_been_requested.once # Requests to update the existing message

spec/models/channel_spec.rb

@@ -0,0 +1,97 @@
+require 'rails_helper'
+require_relative '../dummy_provider'
+
+RSpec.describe DiscourseChat::Channel do
+  include_context "dummy provider"
+  include_context "validated dummy provider"
+
+
+  it 'should save and load successfully' do
+    expect(DiscourseChat::Channel.all.length).to eq(0)
+
+    chan = DiscourseChat::Channel.create({
+          provider:"dummy",
+        })
+
+    expect(DiscourseChat::Channel.all.length).to eq(1)
+
+    loadedChan = DiscourseChat::Channel.find(chan.id)
+
+    expect(loadedChan.provider).to eq('dummy')
+    
+  end
+
+  it 'can be filtered by provider' do
+    channel1 = DiscourseChat::Channel.create!(provider:'dummy')
+    channel2 = DiscourseChat::Channel.create!(provider:'dummy2', data:{val:"blah"})
+    channel3 = DiscourseChat::Channel.create!(provider:'dummy2', data:{val:"blah"})
+
+    expect(DiscourseChat::Channel.all.length).to eq(3)
+
+    expect(DiscourseChat::Channel.with_provider('dummy2').length).to eq(2)
+    expect(DiscourseChat::Channel.with_provider('dummy').length).to eq(1)
+  end
+
+  it 'can be filtered by data value' do
+    channel2 = DiscourseChat::Channel.create!(provider:'dummy2', data:{val:"foo"})
+    channel3 = DiscourseChat::Channel.create!(provider:'dummy2', data:{val:"blah"})
+
+    expect(DiscourseChat::Channel.all.length).to eq(2)
+
+    for_provider = DiscourseChat::Channel.with_provider('dummy2')
+    expect(for_provider.length).to eq(2)
+
+    expect(DiscourseChat::Channel.with_provider('dummy2').with_data_value('val','blah').length).to eq(1)
+  end
+
+  it 'can find its own rules' do
+    channel = DiscourseChat::Channel.create({provider:'dummy'})
+    expect(channel.rules.size).to eq(0)
+    DiscourseChat::Rule.create(channel: channel)
+    DiscourseChat::Rule.create(channel: channel)
+    expect(channel.rules.size).to eq(2)
+  end
+
+  it 'destroys its rules on destroy' do
+    channel = DiscourseChat::Channel.create({provider:'dummy'})
+    expect(channel.rules.size).to eq(0)
+    rule1 = DiscourseChat::Rule.create(channel: channel)
+    rule2 = DiscourseChat::Rule.create(channel: channel)
+
+    expect(DiscourseChat::Rule.with_channel(channel).exists?).to eq(true)
+    channel.destroy()
+    expect(DiscourseChat::Rule.with_channel(channel).exists?).to eq(false)
+  end
+
+  describe 'validations' do
+    let(:channel) {  }
+
+    it 'validates provider correctly' do
+      channel = DiscourseChat::Channel.create!(provider:"dummy")
+      expect(channel.valid?).to eq(true)
+      channel.provider = 'somerandomprovider'
+      expect(channel.valid?).to eq(false)
+    end
+
+    it 'succeeds with valid data' do
+      channel2 = DiscourseChat::Channel.new(provider:"dummy2", data:{val:"hello"})
+      expect(channel2.valid?).to eq(true)
+    end
+
+    it 'disallows invalid data' do
+      channel2 = DiscourseChat::Channel.new(provider:"dummy2", data:{val:''})
+      expect(channel2.valid?).to eq(false)
+    end
+
+    it 'disallows unknown keys' do
+      channel2 = DiscourseChat::Channel.new(provider:"dummy2", data:{val:"hello", unknown:"world"})
+      expect(channel2.valid?).to eq(false)
+    end
+
+    it 'requires all keys' do
+      channel2 = DiscourseChat::Channel.new(provider:"dummy2", data:{})
+      expect(channel2.valid?).to eq(false)
+    end
+
+  end
+end

spec/models/rule_spec.rb

@@ -1,24 +1,33 @@
 require 'rails_helper'
+require_relative '../dummy_provider'
 
 RSpec.describe DiscourseChat::Rule do
+  include_context "dummy provider"
 
   let(:tag1){Fabricate(:tag)}
   let(:tag2){Fabricate(:tag)}
 
+  let(:channel){DiscourseChat::Channel.create(provider:'dummy')}
+
   describe '.alloc_key' do
     it 'should return sequential numbers' do 
-      expect( DiscourseChat::Rule.create(provider:'slack',channel:'#general').key ).to eq("rule:1")
-      expect( DiscourseChat::Rule.create(provider:'slack',channel:'#general').key ).to eq("rule:2")
-      expect( DiscourseChat::Rule.create(provider:'slack',channel:'#general').key ).to eq("rule:3")
+      expect( DiscourseChat::Rule.create(channel: channel).key ).to eq("rule:1")
+      expect( DiscourseChat::Rule.create(channel: channel).key ).to eq("rule:2")
+      expect( DiscourseChat::Rule.create(channel: channel).key ).to eq("rule:3")
     end
   end
 
+  it 'should convert between channel and channel_id successfully' do
+    rule = DiscourseChat::Rule.create(channel: channel)
+    expect( rule.channel_id ).to eq(channel.id)
+    expect( rule.channel.id ).to eq(channel.id)
+  end
+
   it 'should save and load successfully' do
     expect(DiscourseChat::Rule.all.length).to eq(0)
 
     rule = DiscourseChat::Rule.create({
-          provider:"slack",
-          channel: "#general",
+          channel: channel,
           category_id: 1,
           tags: [tag1.name, tag2.name],
           filter: 'watch'
@@ -28,8 +37,7 @@ RSpec.describe DiscourseChat::Rule do
 
     loadedRule = DiscourseChat::Rule.find(rule.id)
 
-    expect(loadedRule.provider).to eq('slack')
-    expect(loadedRule.channel).to eq('#general')
+    expect(loadedRule.channel.id).to eq(channel.id)
     expect(loadedRule.category_id).to eq(1)
     expect(loadedRule.tags).to contain_exactly(tag1.name,tag2.name)
     expect(loadedRule.filter).to eq('watch')
@@ -39,8 +47,7 @@ RSpec.describe DiscourseChat::Rule do
   describe 'general operations' do
     before do
       rule = DiscourseChat::Rule.create({
-          provider:"slack",
-          channel: "#general",
+          channel: channel,
           category_id: 1,
           tags: [tag1.name, tag2.name]
         })
@@ -48,16 +55,16 @@ RSpec.describe DiscourseChat::Rule do
 
     it 'can be modified' do
       rule = DiscourseChat::Rule.all.first
-      rule.channel = "#random"
+      rule.tags = [tag1.name]
 
       rule.save!
 
       rule = DiscourseChat::Rule.all.first
-      expect(rule.channel).to eq('#random')
+      expect(rule.tags).to contain_exactly(tag1.name)
     end
 
     it 'can be deleted' do
-      DiscourseChat::Rule.new({provider:'telegram', channel:'blah'}).save!
+      DiscourseChat::Rule.new(channel:channel).save!
       expect(DiscourseChat::Rule.all.length).to eq(2)
 
       rule = DiscourseChat::Rule.all.first
@@ -67,10 +74,10 @@ RSpec.describe DiscourseChat::Rule do
     end
 
     it 'can delete all' do
-      DiscourseChat::Rule.new({provider:'telegram', channel:'blah'}).save!
-      DiscourseChat::Rule.new({provider:'telegram', channel:'blah'}).save!
-      DiscourseChat::Rule.new({provider:'telegram', channel:'blah'}).save!
-      DiscourseChat::Rule.new({provider:'telegram', channel:'blah'}).save!
+      DiscourseChat::Rule.create({channel:channel})
+      DiscourseChat::Rule.create({channel:channel})
+      DiscourseChat::Rule.create({channel:channel})
+      DiscourseChat::Rule.create({channel:channel})
       
       expect(DiscourseChat::Rule.all.length).to eq(5)
 
@@ -79,36 +86,39 @@ RSpec.describe DiscourseChat::Rule do
       expect(DiscourseChat::Rule.all.length).to eq(0)
     end
 
-    it 'can be filtered by provider' do
-      rule2 = DiscourseChat::Rule.new({provider:'telegram', channel:'blah'}).save!
-      rule3 = DiscourseChat::Rule.new({provider:'slack', channel:'#blah'}).save!
-
-      expect(DiscourseChat::Rule.all.length).to eq(3)
-
-      expect(DiscourseChat::Rule.with_provider('slack').length).to eq(2)
-      expect(DiscourseChat::Rule.with_provider('telegram').length).to eq(1)
-    end
-
     it 'can be filtered by channel' do
-      rule2 = DiscourseChat::Rule.new({provider:'telegram', channel:'blah'}).save!
-      rule3 = DiscourseChat::Rule.new({provider:'slack', channel:'#blah'}).save!
-      rule4 = DiscourseChat::Rule.new({provider:'slack', channel:'#general'}).save!
-      rule5 = DiscourseChat::Rule.new({provider:'slack', channel:'#general'}).save!
+      channel2 = DiscourseChat::Channel.create(provider:'dummy')
+      channel3 = DiscourseChat::Channel.create(provider:'dummy')
+
+      rule2 = DiscourseChat::Rule.create(channel:channel)
+      rule3 = DiscourseChat::Rule.create(channel:channel)
+      rule4 = DiscourseChat::Rule.create(channel:channel2)
+      rule5 = DiscourseChat::Rule.create(channel:channel3)
       
       expect(DiscourseChat::Rule.all.length).to eq(5)
 
-      expect(DiscourseChat::Rule.with_channel('slack','#general').length).to eq(3)
-      expect(DiscourseChat::Rule.with_channel('slack', '#blah').length).to eq(1)
+      expect(DiscourseChat::Rule.with_channel(channel).length).to eq(3)
+      expect(DiscourseChat::Rule.with_channel(channel2).length).to eq(1)
     end
 
     it 'can be filtered by category' do
-      rule2 = DiscourseChat::Rule.new({provider:'slack', channel:'#blah', category_id: 1}).save!      
-      rule3 = DiscourseChat::Rule.new({provider:'slack', channel:'#blah', category_id: nil}).save!
+      rule2 = DiscourseChat::Rule.create(channel:channel, category_id: 1)
+      rule3 = DiscourseChat::Rule.create(channel:channel, category_id: nil)
 
       expect(DiscourseChat::Rule.all.length).to eq(3)
 
-      expect(DiscourseChat::Rule.with_category(1).length).to eq(2)
-      expect(DiscourseChat::Rule.with_category(nil).length).to eq(1)
+      expect(DiscourseChat::Rule.with_category_id(1).length).to eq(2)
+      expect(DiscourseChat::Rule.with_category_id(nil).length).to eq(1)
+    end
+
+    it 'can be sorted by precedence' do
+      rule2 = DiscourseChat::Rule.create(channel:channel, filter:'mute')
+      rule3 = DiscourseChat::Rule.create(channel:channel, filter:'follow')
+      rule4 = DiscourseChat::Rule.create(channel:channel, filter:'mute')
+
+      expect(DiscourseChat::Rule.all.length).to eq(4)
+
+      expect(DiscourseChat::Rule.all.order_by_precedence.map(&:filter)).to eq(["mute", "mute", "watch", "follow"])
     end
   end
 
@@ -117,23 +127,16 @@ RSpec.describe DiscourseChat::Rule do
     let(:rule) do
       DiscourseChat::Rule.create({
           filter: 'watch',
-          provider:"slack",
-          channel: "#general",
+          channel: channel,
           category_id: 1,
         })
     end
 
-    it 'validates provider correctly' do
-      expect(rule.valid?).to eq(true)
-      rule.provider = 'somerandomprovider'
-      expect(rule.valid?).to eq(false)
-    end
-
     it 'validates channel correctly' do
       expect(rule.valid?).to eq(true)
-      rule.channel = ''
+      rule.channel_id = 'blahblahblah'
       expect(rule.valid?).to eq(false)
-      rule.channel = 'blah'
+      rule.channel_id = -1
       expect(rule.valid?).to eq(false)
     end
 
@@ -167,7 +170,7 @@ RSpec.describe DiscourseChat::Rule do
 
     it "doesn't allow save when invalid" do
       expect(rule.valid?).to eq(true)
-      rule.provider = 'somerandomprovider'
+      rule.filter = 'somerandomfilter'
       expect(rule.valid?).to eq(false)
       expect(rule.save).to eq(false)
     end

spec/services/manager_spec.rb

@@ -13,111 +13,102 @@ RSpec.describe DiscourseChat::Manager do
   describe '.trigger_notifications' do
     include_context "dummy provider"
 
+    let(:chan1){DiscourseChat::Channel.create!(provider:'dummy')}
+    let(:chan2){DiscourseChat::Channel.create!(provider:'dummy')}
+    let(:chan3){DiscourseChat::Channel.create!(provider:'dummy')}
+
     before do
       SiteSetting.chat_integration_enabled = true
     end
 
-    def create_rule(provider, channel, filter, category_id, tags) # Just shorthand for testing purposes
-      DiscourseChat::Rule.create({provider: provider, channel: channel, filter:filter, category_id:category_id, tags:tags})
-    end
-
     it "should fail gracefully when a provider throws an exception" do
-      create_rule('dummy', 'chan1', 'watch', category.id, nil)
+      DiscourseChat::Rule.create!(channel: chan1, filter: 'watch', category_id:category.id )
 
       # Triggering a ProviderError should set the error_key to the error message
-      ::DiscourseChat::Provider::DummyProvider.set_raise_exception(DiscourseChat::ProviderError.new info: {error_key:"hello"})
+      provider.set_raise_exception(DiscourseChat::ProviderError.new info: {error_key:"hello"})
       manager.trigger_notifications(first_post.id)
-      expect(provider.sent_messages.map{|x| x[:channel]}).to contain_exactly()
-      expect(DiscourseChat::Rule.all.first.error_key).to eq('hello')
+      expect(provider.sent_to_channel_ids).to contain_exactly()
+      expect(DiscourseChat::Channel.all.first.error_key).to eq('hello')
 
       # Triggering a different error should set the error_key to a generic message
-      ::DiscourseChat::Provider::DummyProvider.set_raise_exception(StandardError.new "hello")
+      provider.set_raise_exception(StandardError.new "hello")
       manager.trigger_notifications(first_post.id)
-      expect(provider.sent_messages.map{|x| x[:channel]}).to contain_exactly()
-      expect(DiscourseChat::Rule.all.first.error_key).to eq('chat_integration.rule_exception')
+      expect(provider.sent_to_channel_ids).to contain_exactly()
+      expect(DiscourseChat::Channel.all.first.error_key).to eq('chat_integration.channel_exception')
 
-      ::DiscourseChat::Provider::DummyProvider.set_raise_exception(nil)
+      provider.set_raise_exception(nil)
 
       manager.trigger_notifications(first_post.id)
-      expect(DiscourseChat::Rule.all.first.error_key.nil?).to be true      
+      expect(DiscourseChat::Channel.all.first.error_key.nil?).to be true      
     end
 
     it "should not send notifications when provider is disabled" do
       SiteSetting.chat_integration_enabled = false
-      create_rule('dummy', 'chan1', 'watch', category.id, nil)
+      DiscourseChat::Rule.create!(channel: chan1, filter: 'watch', category_id:category.id )
 
       manager.trigger_notifications(first_post.id)
 
-      expect(provider.sent_messages.map{|x| x[:channel]}).to contain_exactly()
+      expect(provider.sent_to_channel_ids).to contain_exactly()
     end
 
     it "should send a notification to watched and following channels for new topic" do
-
-      create_rule('dummy', 'chan1', 'watch', category.id, nil)
-      create_rule('dummy', 'chan2', 'follow', category.id, nil)
-      create_rule('dummy', 'chan3', 'mute', category.id, nil)
+      DiscourseChat::Rule.create!(channel: chan1, filter: 'watch', category_id:category.id )
+      DiscourseChat::Rule.create!(channel: chan2, filter: 'follow', category_id:category.id )
+      DiscourseChat::Rule.create!(channel: chan3, filter: 'mute', category_id:category.id )
 
       manager.trigger_notifications(first_post.id)
 
-      expect(provider.sent_messages.map{|x| x[:channel]}).to contain_exactly('chan1', 'chan2')
+      expect(provider.sent_to_channel_ids).to contain_exactly(chan1.id, chan2.id)
     end
 
     it "should send a notification only to watched for reply" do
-      create_rule('dummy', 'chan1', 'watch', category.id, nil)
-      create_rule('dummy', 'chan2', 'follow', category.id, nil)
-      create_rule('dummy', 'chan3', 'mute', category.id, nil)
+      DiscourseChat::Rule.create!(channel: chan1, filter: 'watch', category_id:category.id )
+      DiscourseChat::Rule.create!(channel: chan2, filter: 'follow', category_id:category.id )
+      DiscourseChat::Rule.create!(channel: chan3, filter: 'mute', category_id:category.id )
 
       manager.trigger_notifications(second_post.id)
 
-      expect(provider.sent_messages.map{|x| x[:channel]}).to contain_exactly('chan1')
+      expect(provider.sent_to_channel_ids).to contain_exactly(chan1.id)
     end
 
     it "should respect wildcard category settings" do
-      create_rule('dummy', 'chan1', 'watch', nil, nil)
+      DiscourseChat::Rule.create!(channel: chan1, filter: 'watch', category_id: nil )
 
       manager.trigger_notifications(first_post.id)
 
-      expect(provider.sent_messages.map{|x| x[:channel]}).to contain_exactly('chan1')
+      expect(provider.sent_to_channel_ids).to contain_exactly(chan1.id)
     end
 
     it "should respect mute over watch" do
-      create_rule('dummy', 'chan1', 'watch', nil, nil) # Wildcard watch
-      create_rule('dummy', 'chan1', 'mute', category.id, nil) # Specific mute
+      DiscourseChat::Rule.create!(channel: chan1, filter: 'watch', category_id: nil ) # Wildcard watch
+      DiscourseChat::Rule.create!(channel: chan1, filter: 'mute', category_id: category.id  ) # Specific mute
 
       manager.trigger_notifications(first_post.id)
 
-      expect(provider.sent_messages.map{|x| x[:channel]}).to contain_exactly()
+      expect(provider.sent_to_channel_ids).to contain_exactly()
     end
 
     it "should respect watch over follow" do
-      create_rule('dummy', 'chan1', 'follow', nil, nil)
-      create_rule('dummy', 'chan1', 'watch', category.id, nil)
+      DiscourseChat::Rule.create!(channel: chan1, filter: 'follow', category_id: nil ) # Wildcard watch
+      DiscourseChat::Rule.create!(channel: chan1, filter: 'watch', category_id: category.id  ) # Specific watch
 
       manager.trigger_notifications(second_post.id)
 
-      expect(provider.sent_messages.map{|x| x[:channel]}).to contain_exactly('chan1')
+      expect(provider.sent_to_channel_ids).to contain_exactly(chan1.id)
     end
 
     it "should not notify about private messages" do
-      create_rule('dummy', 'chan1', 'watch', nil, nil)
+      DiscourseChat::Rule.create!(channel: chan1, filter: 'follow', category_id: nil ) # Wildcard watch
+      
       private_post = Fabricate(:private_message_post)
 
       manager.trigger_notifications(private_post.id)
 
-      expect(provider.sent_messages.map{|x| x[:channel]}).to contain_exactly()
-    end
-
-    it "should not notify about private messages" do
-      create_rule('dummy', 'chan1', 'watch', nil, nil)
-      private_post = Fabricate(:private_message_post)
-
-      manager.trigger_notifications(private_post.id)
-
-      expect(provider.sent_messages.map{|x| x[:channel]}).to contain_exactly()
+      expect(provider.sent_to_channel_ids).to contain_exactly()
     end
 
     it "should not notify about posts the chat_user cannot see" do
-      create_rule('dummy', 'chan1', 'watch', nil, nil)
+      DiscourseChat::Rule.create!(channel: chan1, filter: 'follow', category_id: nil ) # Wildcard watch
 
       # Create a group & user
       group = Fabricate(:group, name: "friends")
@@ -138,7 +129,7 @@ RSpec.describe DiscourseChat::Manager do
 
       # Check no notification sent
       manager.trigger_notifications(first_post.id)
-      expect(provider.sent_messages.map{|x| x[:channel]}).to contain_exactly()
+      expect(provider.sent_to_channel_ids).to contain_exactly()
 
       # Now expose category to new user
       category.set_permissions(Group[:friends] => :full)
@@ -146,7 +137,7 @@ RSpec.describe DiscourseChat::Manager do
 
       # Check notification sent
       manager.trigger_notifications(first_post.id)
-      expect(provider.sent_messages.map{|x| x[:channel]}).to contain_exactly('chan1')
+      expect(provider.sent_to_channel_ids).to contain_exactly(chan1.id)
 
     end
 
@@ -160,21 +151,21 @@ RSpec.describe DiscourseChat::Manager do
       end
 
       it 'should still work for rules without any tags specified' do
-        create_rule('dummy', 'chan1', 'watch', category.id, nil)
+        DiscourseChat::Rule.create!(channel: chan1, filter: 'follow', category_id: nil ) # Wildcard watch
 
         manager.trigger_notifications(first_post.id)
         manager.trigger_notifications(tagged_first_post.id)
 
-        expect(provider.sent_messages.map{|x| x[:channel]}).to contain_exactly('chan1','chan1')
+        expect(provider.sent_to_channel_ids).to contain_exactly(chan1.id, chan1.id)
       end
 
       it 'should only match tagged topics when rule has tags' do
-        create_rule('dummy', 'chan1', 'watch', category.id, [tag.name])
+        DiscourseChat::Rule.create!(channel: chan1, filter: 'follow', category_id: category.id, tags:[tag.name] )
 
         manager.trigger_notifications(first_post.id)
         manager.trigger_notifications(tagged_first_post.id)
 
-        expect(provider.sent_messages.map{|x| x[:channel]}).to contain_exactly('chan1')
+        expect(provider.sent_to_channel_ids).to contain_exactly(chan1.id)
       end
 
     end

test/javascripts/acceptance/chat-integration-test.js.es6

@@ -11,12 +11,21 @@ acceptance("Chat Integration", {
       ];
     };
     server.get('/admin/plugins/chat/providers', () => {
-      return response({ providers: [{name: 'dummy', id:'dummy',channel_regex:null}] });
+      return response({ providers: [{name: 'dummy', id:'dummy',channel_parameters:[{key:'somekey', regex:"^\\S+$"}]}] });
     });
-    server.get('/admin/plugins/chat/rules', () => {
-      return response({ rules: [{"id":11,"provider":"dummy","channel":"#general","category_id":2,"tags":null,"filter":"follow","error_key":null}] });
+    server.get('/admin/plugins/chat/channels', () => {
+      return response({"channels":[{"id":97,"provider":"dummy","data":{val:"#general"},"rules":[{"id":98,"channel_id":97,"category_id":null,"tags":[],"filter":"watch","error_key":null}]}]});
     });
-    server.put('/admin/plugins/chat/rules', () => {
+    server.post('/admin/plugins/chat/channels', () => {
+      return response({ });
+    });
+    server.put('/admin/plugins/chat/channels/:id', () => {
+      return response({ });
+    });
+    server.delete('/admin/plugins/chat/channels/:id', () => {
+      return response({ });
+    });
+    server.post('/admin/plugins/chat/rules', () => {
       return response({ });
     });
     server.put('/admin/plugins/chat/rules/:id', () => {
@@ -38,78 +47,108 @@ test("Rules load successfully", assert => {
 
   andThen(() => {
     assert.ok(exists('#admin-plugin-chat table'), "it shows the table of rules");
-    assert.equal(find('#admin-plugin-chat table tr td').eq(0).text().trim(), '#general', 'rule displayed');
+    assert.equal(find('#admin-plugin-chat table tr td').eq(0).text().trim(), 'All posts and replies', 'rule displayed');
   });
 });
 
-test("Create rule works", assert => {
+test("Create channel works", assert => {
   visit("/admin/plugins/chat");
 
   andThen(() => {
-    click('#create_rule');
+    click('#create_channel');
   });
 
   andThen(() => {
-    assert.ok(exists('#chat_integration_edit_rule_modal'), 'it displays the modal');
-    assert.ok(find('#save_rule').prop('disabled'), 'it disables the save button');
-    fillIn('#channel-field', '#general');
-    assert.ok(find('#save_rule').prop('disabled'), 'it enables the save button');
+    assert.ok(exists('#chat_integration_edit_channel_modal'), 'it displays the modal');
+    assert.ok(find('#save_channel').prop('disabled'), 'it disables the save button');
+    fillIn('#chat_integration_edit_channel_modal input', '#general');
   });
 
-  click('#save_rule');
+  andThen(() => {
+    assert.ok(!find('#save_channel').prop('disabled'), 'it enables the save button');
+  })
 
   andThen(() => {
-    assert.ok(!exists('#chat_integration_edit_rule_modal'), 'modal closes on save');
+    click('#save_channel');
+  });
+
+  andThen(() => {
+    assert.ok(!exists('#chat_integration_edit_channel_modal'), 'modal closes on save');
   })
 
 });
 
-test("Edit rule works", assert => {
-  visit("/admin/plugins/chat");
+// test("Edit channel works", assert => {
+//   visit("/admin/plugins/chat");
 
-  andThen(() => {
-    assert.ok(exists('.edit:first'), 'edit button is displayed');
-  });
+//   andThen(() => {
+//     click('#create_channel');
+//   });
 
-  click('.edit:first');
+//   andThen(() => {
+//     assert.ok(exists('#chat_integration_edit_channel_modal'), 'it displays the modal');
+//     assert.ok(find('#save_channel').prop('disabled'), 'it disables the save button');
+//     fillIn('#chat_integration_edit_channel_modal input', '#general');
+//   });
 
-  andThen(() => {
-    assert.ok(exists('#chat_integration_edit_rule_modal'), 'modal opens on edit');
-    assert.ok(!find('#save_rule').prop('disabled'), 'it enables the save button');
-  });
+//   andThen(() => {
+//     assert.ok(!find('#save_channel').prop('disabled'), 'it enables the save button');
+//   })
 
-  click('#save_rule');
+//   andThen(() => {
+//     click('#save_channel');
+//   });
 
-  andThen(() => {
-    assert.ok(!exists('#chat_integration_edit_rule_modal'), 'modal closes on save');
-  });
-});
+//   andThen(() => {
+//     assert.ok(!exists('#chat_integration_edit_channel_modal'), 'modal closes on save');
+//   })
 
-test("Delete rule works", function(assert) {
-  visit("/admin/plugins/chat");
+// });
 
-  andThen(() => {
-    assert.ok(exists('.delete:first'));
-    click('.delete:first');
-  });
-});
+// test("Edit rule works", assert => {
+//   visit("/admin/plugins/chat");
+
+//   andThen(() => {
+//     assert.ok(exists('.edit:first'), 'edit button is displayed');
+//   });
+
+//   click('.edit:first');
+
+//   andThen(() => {
+//     assert.ok(exists('#chat_integration_edit_rule_modal'), 'modal opens on edit');
+//     assert.ok(!find('#save_rule').prop('disabled'), 'it enables the save button');
+//   });
+
+//   click('#save_rule');
+
+//   andThen(() => {
+//     assert.ok(!exists('#chat_integration_edit_rule_modal'), 'modal closes on save');
+//   });
+// });
+
+// test("Delete rule works", function(assert) {
+//   visit("/admin/plugins/chat");
+
+//   andThen(() => {
+//     assert.ok(exists('.delete:first'));
+//     click('.delete:first');
+//   });
+// });
 
 test("Test provider works", assert => {
   visit("/admin/plugins/chat");
 
   andThen(() => {
-    click('#test_provider');
+    click('.fa-rocket');
   });
 
   andThen(() => {
     assert.ok(exists('#chat_integration_test_modal'), 'it displays the modal');
     assert.ok(find('#send_test').prop('disabled'), 'it disables the send button');
-    fillIn('#channel-field', '#general');
     fillIn('#choose-topic-title', '9318');
   });
 
   andThen(() => {
-    debugger;
     click('#chat_integration_test_modal .radio:first');
   });