Discource-C
/
discourse-chat-integration
mirror of https://github.com/discourse/discourse-chat-integration.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Move slash command specs into helper_spec

This commit is contained in:
David Taylor 2017-07-19 18:22:50 +01:00
parent bf0b645f31
commit 4422f14c6d
2 changed files with 127 additions and 183 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

123
spec/helpers/helper_spec.rb
View File

@ -14,6 +14,129 @@ RSpec.describe DiscourseChat::Manager do
let(:tag2){Fabricate(:tag)}
let(:tag3){Fabricate(:tag)}
describe '.process_command' do
describe 'add new rule' do
# Not testing how filters are merged here, that's done in .smart_create_rule
# We just want to make sure the commands are being interpretted correctly
it 'should add a new rule correctly' do
response = DiscourseChat::Helper.process_command(chan1, ['watch',category.slug])
expect(response).to eq(I18n.t("chat_integration.provider.dummy.create.created"))
rule = DiscourseChat::Rule.all.first
expect(rule.channel).to eq(chan1)
expect(rule.filter).to eq('watch')
expect(rule.category_id).to eq(category.id)
expect(rule.tags).to eq(nil)
end
it 'should work with all three filter types' do
response = DiscourseChat::Helper.process_command(chan1, ['watch',category.slug])
rule = DiscourseChat::Rule.all.first
expect(rule.filter).to eq('watch')
response = DiscourseChat::Helper.process_command(chan1, ['follow',category.slug])
rule = DiscourseChat::Rule.all.first
expect(rule.filter).to eq('follow')
response = DiscourseChat::Helper.process_command(chan1, ['mute',category.slug])
rule = DiscourseChat::Rule.all.first
expect(rule.filter).to eq('mute')
end
it 'errors on incorrect categories' do
response = DiscourseChat::Helper.process_command(chan1, ['watch','blah'])
expect(response).to eq(I18n.t("chat_integration.provider.dummy.not_found.category", name:'blah', list:'uncategorized'))
end
context 'with tags enabled' do
before do
SiteSetting.tagging_enabled = true
end
it 'should add a new tag rule correctly' do
response = DiscourseChat::Helper.process_command(chan1, ['watch',"tag:#{tag1.name}"])
expect(response).to eq(I18n.t("chat_integration.provider.dummy.create.created"))
rule = DiscourseChat::Rule.all.first
expect(rule.channel).to eq(chan1)
expect(rule.filter).to eq('watch')
expect(rule.category_id).to eq(nil)
expect(rule.tags).to eq([tag1.name])
end
it 'should work with a category and multiple tags' do
response = DiscourseChat::Helper.process_command(chan1, ['watch',category.slug, "tag:#{tag1.name}", "tag:#{tag2.name}"])
expect(response).to eq(I18n.t("chat_integration.provider.dummy.create.created"))
rule = DiscourseChat::Rule.all.first
expect(rule.channel).to eq(chan1)
expect(rule.filter).to eq('watch')
expect(rule.category_id).to eq(category.id)
expect(rule.tags).to contain_exactly(tag1.name, tag2.name)
end
it 'errors on incorrect tags' do
response = DiscourseChat::Helper.process_command(chan1, ['watch',category.slug, "tag:blah"])
expect(response).to eq(I18n.t("chat_integration.provider.dummy.not_found.tag", name:"blah"))
end
end
end
describe 'remove rule' do
it 'removes the rule' do
rule1 = DiscourseChat::Rule.create(channel: chan1,
filter: 'watch',
category_id: category.id,
tags: [tag1.name, tag2.name]
)
expect(DiscourseChat::Rule.all.size).to eq(1)
response = DiscourseChat::Helper.process_command(chan1, ['remove','1'])
expect(response).to eq(I18n.t("chat_integration.provider.dummy.delete.success"))
expect(DiscourseChat::Rule.all.size).to eq(0)
end
it 'errors correctly' do
response = DiscourseChat::Helper.process_command(chan1, ['remove','1'])
expect(response).to eq(I18n.t("chat_integration.provider.dummy.delete.error"))
end
end
describe 'help command' do
it 'should return the right response' do
response = DiscourseChat::Helper.process_command(chan1, ["help"])
expect(response).to eq(I18n.t("chat_integration.provider.dummy.help"))
end
end
describe 'status command' do
it 'should return the right response' do
response = DiscourseChat::Helper.process_command(chan1, ['status'])
expect(response).to eq(DiscourseChat::Helper.status_for_channel(chan1))
end
end
describe 'unknown command' do
it 'should return the right response' do
response = DiscourseChat::Helper.process_command(chan1, ['somerandomtext'])
expect(response).to eq(I18n.t("chat_integration.provider.dummy.parse_error"))
end
end
end
describe '.status_for_channel' do
context 'with no rules' do

187
spec/lib/discourse_chat/provider/slack/slack_command_controller_spec.rb
View File

@ -62,14 +62,15 @@ describe 'Slack Command Controller', type: :request do
describe 'when token is valid' do
let(:token) { "Secret Sauce" }
# No need to test every single command here, that's tested
# by helper_spec upstream
before do
SiteSetting.chat_integration_slack_incoming_webhook_token = token
end
describe 'add new rule' do
# Not testing how filters are merged here, that's done upstream in helper_spec
# We just want to make sure the slash commands are being interpretted correctly
it 'should add a new rule correctly' do
post "/chat-integration/slack/command.json",
text: "watch #{category.slug}",
@ -87,100 +88,6 @@ describe 'Slack Command Controller', type: :request do
expect(rule.tags).to eq(nil)
end
it 'should work with all three filter types' do
post "/chat-integration/slack/command.json",
text: "watch #{category.slug}",
channel_name: 'welcome',
token: token
rule = DiscourseChat::Rule.all.first
expect(rule.filter).to eq('watch')
post "/chat-integration/slack/command.json",
text: "follow #{category.slug}",
channel_name: 'welcome',
token: token
rule = DiscourseChat::Rule.all.first
expect(rule.filter).to eq('follow')
post "/chat-integration/slack/command.json",
text: "mute #{category.slug}",
channel_name: 'welcome',
token: token
rule = DiscourseChat::Rule.all.first
expect(rule.filter).to eq('mute')
end
it 'errors on incorrect categories' do
post "/chat-integration/slack/command.json",
text: "watch blah",
channel_name: 'welcome',
token: token
expect(response).to be_success
json = JSON.parse(response.body)
expect(json["text"]).to eq(I18n.t("chat_integration.provider.slack.not_found.category", name:'blah', list:'uncategorized'))
end
context 'with tags enabled' do
before do
SiteSetting.tagging_enabled = true
end
it 'should add a new tag rule correctly' do
post "/chat-integration/slack/command.json",
text: "watch tag:#{tag.name}",
channel_name: 'welcome',
token: token
expect(response).to be_success
json = JSON.parse(response.body)
expect(json["text"]).to eq(I18n.t("chat_integration.provider.slack.create.created"))
rule = DiscourseChat::Rule.all.first
expect(rule.channel).to eq(chan1)
expect(rule.filter).to eq('watch')
expect(rule.category_id).to eq(nil)
expect(rule.tags).to eq([tag.name])
end
it 'should work with a category and multiple tags' do
post "/chat-integration/slack/command.json",
text: "watch #{category.slug} tag:#{tag.name} tag:#{tag2.name}",
channel_name: 'welcome',
token: token
expect(response).to be_success
json = JSON.parse(response.body)
expect(json["text"]).to eq(I18n.t("chat_integration.provider.slack.create.created"))
rule = DiscourseChat::Rule.all.first
expect(rule.channel).to eq(chan1)
expect(rule.filter).to eq('watch')
expect(rule.category_id).to eq(category.id)
expect(rule.tags).to contain_exactly(tag.name, tag2.name)
end
it 'errors on incorrect tags' do
post "/chat-integration/slack/command.json",
text: "watch tag:blah",
channel_name: 'welcome',
token: token
expect(response).to be_success
json = JSON.parse(response.body)
expect(json["text"]).to eq(I18n.t("chat_integration.provider.slack.not_found.tag", name:"blah"))
end
end
context 'from an unknown channel' do
it 'creates the channel' do
post "/chat-integration/slack/command.json",
@ -202,92 +109,6 @@ describe 'Slack Command Controller', type: :request do
end
end
end
describe 'remove rule' do
it 'removes the rule' do
rule1 = DiscourseChat::Rule.create(channel: chan1,
filter: 'watch',
category_id: category.id,
tags: [tag.name, tag2.name]
)
expect(DiscourseChat::Rule.all.size).to eq(1)
post "/chat-integration/slack/command.json",
text: "remove 1",
channel_name: 'welcome',
token: token
expect(response).to be_success
json = JSON.parse(response.body)
expect(json["text"]).to eq(I18n.t("chat_integration.provider.slack.delete.success"))
expect(DiscourseChat::Rule.all.size).to eq(0)
end
it 'errors correctly' do
post "/chat-integration/slack/command.json",
text: "remove 1",
channel_name: 'welcome',
token: token
expect(response).to be_success
json = JSON.parse(response.body)
expect(json["text"]).to eq(I18n.t("chat_integration.provider.slack.delete.error"))
end
end
describe 'help command' do
it 'should return the right response' do
post '/chat-integration/slack/command.json', text: "help", channel_name: "welcome", token: token
expect(response).to be_success
json = JSON.parse(response.body)
expect(json["text"]).to eq(I18n.t("chat_integration.provider.slack.help"))
end
end
describe 'status command' do
# No need to test this with different combinations of rules
# That's done upstream in helper_spec
it 'should return the right response' do
post '/chat-integration/slack/command.json',
text: "status",
channel_name: "welcome",
token: token
expect(response).to be_success
json = JSON.parse(response.body)
expect(json["text"]).to eq(DiscourseChat::Helper.status_for_channel(chan1))
end
end
describe 'unknown command' do
# No need to test this with different combinations of rules
# That's done upstream in helper_spec
it 'should return the right response' do
post '/chat-integration/slack/command.json',
text: "somerandomtext",
channel_name: "welcome",
token: token
expect(response).to be_success
json = JSON.parse(response.body)
expect(json["text"]).to eq(I18n.t("chat_integration.provider.slack.parse_error"))
end
end
end
end
end