FIX: Add missing dummy translations for tests (#195)

This change copies the translations from the Slack provider to the dummy provider in the test so we're testing real values.
This commit is contained in:
Ted Johansson 2024-05-24 20:14:03 +08:00 committed by GitHub
parent 8b6e02af9c
commit cbdac03a84
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
1 changed files with 12 additions and 5 deletions

View File

@ -14,6 +14,13 @@ RSpec.describe DiscourseChatIntegration::Manager do
let(:tag2) { Fabricate(:tag) } let(:tag2) { Fabricate(:tag) }
let(:tag3) { Fabricate(:tag) } let(:tag3) { Fabricate(:tag) }
before do
I18n.backend.store_translations(
:en,
{ chat_integration: { provider: { dummy: I18n.t("chat_integration.provider.slack") } } },
)
end
describe ".process_command" do describe ".process_command" do
describe "add new rule" do describe "add new rule" do
# Not testing how filters are merged here, that's done in .smart_create_rule # Not testing how filters are merged here, that's done in .smart_create_rule
@ -163,12 +170,12 @@ RSpec.describe DiscourseChatIntegration::Manager do
context "with no rules" do context "with no rules" do
it "includes the heading" do it "includes the heading" do
string = DiscourseChatIntegration::Helper.status_for_channel(chan1) string = DiscourseChatIntegration::Helper.status_for_channel(chan1)
expect(string).to include("dummy.status.header") expect(string).to include(I18n.t("chat_integration.provider.dummy.status.header"))
end end
it "includes the no_rules string" do it "includes the no_rules string" do
string = DiscourseChatIntegration::Helper.status_for_channel(chan1) string = DiscourseChatIntegration::Helper.status_for_channel(chan1)
expect(string).to include("dummy.status.no_rules") expect(string).to include(I18n.t("chat_integration.provider.dummy.status.no_rules"))
end end
end end
@ -211,16 +218,16 @@ RSpec.describe DiscourseChatIntegration::Manager do
it "displays the correct rules" do it "displays the correct rules" do
string = DiscourseChatIntegration::Helper.status_for_channel(chan1) string = DiscourseChatIntegration::Helper.status_for_channel(chan1)
expect(string.scan("status.rule_string").size).to eq(4) expect(string.scan("posts in").size).to eq(4)
end end
it "only displays tags for rules with tags" do it "only displays tags for rules with tags" do
string = DiscourseChatIntegration::Helper.status_for_channel(chan1) string = DiscourseChatIntegration::Helper.status_for_channel(chan1)
expect(string.scan("rule_string_tags_suffix").size).to eq(0) expect(string.scan("with tags").size).to eq(0)
SiteSetting.tagging_enabled = true SiteSetting.tagging_enabled = true
string = DiscourseChatIntegration::Helper.status_for_channel(chan1) string = DiscourseChatIntegration::Helper.status_for_channel(chan1)
expect(string.scan("rule_string_tags_suffix").size).to eq(1) expect(string.scan("with tags").size).to eq(1)
end end
end end
end end