Discource-C
/
discourse-chat-integration
mirror of https://github.com/discourse/discourse-chat-integration.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Improve QUnit tests for admin interface

This commit is contained in:
David Taylor 2017-08-14 16:02:43 +03:00
parent 9604edaf88
commit d13bf5409d
2 changed files with 92 additions and 47 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
assets/javascripts/admin/templates/modal/admin-plugins-chat-edit-rule.hbs
View File

@ -100,7 +100,7 @@
<div class="modal-footer"> <div class="modal-footer">
{{d-button id="save_channel" class='btn-primary btn-large' action="save" title="chat_integration.edit_rule_modal.save" label="chat_integration.edit_rule_modal.save" disabled=saveDisabled}} {{d-button id="save_rule" class='btn-primary btn-large' action="save" title="chat_integration.edit_rule_modal.save" label="chat_integration.edit_rule_modal.save" disabled=saveDisabled}}
{{d-button class="btn-large" action="cancel" title="chat_integration.edit_rule_modal.cancel" label="chat_integration.edit_rule_modal.cancel"}} {{d-button class="btn-large" action="cancel" title="chat_integration.edit_rule_modal.cancel" label="chat_integration.edit_rule_modal.cancel"}}

137
test/javascripts/acceptance/chat-integration-test.js.es6
View File

@ -14,7 +14,9 @@ acceptance("Chat Integration", {
return response({ providers: [{name: 'dummy', id:'dummy',channel_parameters:[{key:'somekey', regex:"^\\S+$"}]}] }); return response({ providers: [{name: 'dummy', id:'dummy',channel_parameters:[{key:'somekey', regex:"^\\S+$"}]}] });
}); });
server.get('/admin/plugins/chat/channels', () => { // eslint-disable-line no-undef server.get('/admin/plugins/chat/channels', () => { // eslint-disable-line no-undef
return response({"channels":[{"id":97,"provider":"dummy","data":{val:"#general"},"rules":[{"id":98,"channel_id":97,"category_id":null,"tags":[],"filter":"watch","error_key":null}]}]}); return response({"channels":[{"id":97,"provider":"dummy","data":{somekey:"#general"},"rules":[
{"id":98,"channel_id":97,"category_id":null,"team_id":null,"type":"normal","tags":[],"filter":"watch","error_key":null}
]}]});
}); });
server.post('/admin/plugins/chat/channels', () => { // eslint-disable-line no-undef server.post('/admin/plugins/chat/channels', () => { // eslint-disable-line no-undef
return response({ }); return response({ });
@ -68,7 +70,7 @@ test("Create channel works", assert => {
}); });
andThen(() => { andThen(() => {
assert.ok(!find('#save_channel').prop('disabled'), 'it enables the save button'); assert.ok(find('#save_channel').prop('disabled') === false, 'it enables the save button');
}); });
andThen(() => { andThen(() => {
@ -81,64 +83,107 @@ test("Create channel works", assert => {
}); });
// test("Edit channel works", assert => { test("Edit channel works", assert => {
// visit("/admin/plugins/chat"); visit("/admin/plugins/chat");
// andThen(() => { andThen(() => {
// click('#create_channel'); click('.channel-header button:first');
// }); });
// andThen(() => { andThen(() => {
// assert.ok(exists('#chat_integration_edit_channel_modal'), 'it displays the modal'); assert.ok(exists('#chat_integration_edit_channel_modal'), 'it displays the modal');
// assert.ok(find('#save_channel').prop('disabled'), 'it disables the save button'); assert.ok(!find('#save_channel').prop('disabled'), 'save is enabled');
// fillIn('#chat_integration_edit_channel_modal input', '#general'); fillIn('#chat_integration_edit_channel_modal input', ' general');
// }); });
// andThen(() => { andThen(() => {
// assert.ok(!find('#save_channel').prop('disabled'), 'it enables the save button'); assert.ok(find('#save_channel').prop('disabled'), 'it disables the save button');
// }) });
// andThen(() => { andThen(() => {
// click('#save_channel'); fillIn('#chat_integration_edit_channel_modal input', '#random');
// }); });
// andThen(() => { andThen(() => {
// assert.ok(!exists('#chat_integration_edit_channel_modal'), 'modal closes on save'); $("#chat_integration_edit_channel_modal input").trigger( $.Event( "keydown", { keyCode: 13 } ) ); // Press enter
// }) });
// }); andThen(() => {
assert.ok(!exists('#chat_integration_edit_channel_modal'), 'modal saves on enter');
});
// test("Edit rule works", assert => { });
// visit("/admin/plugins/chat");
// andThen(() => { test("Create rule works", assert => {
// assert.ok(exists('.edit:first'), 'edit button is displayed'); visit("/admin/plugins/chat");
// });
// click('.edit:first'); andThen(() => {
assert.ok(exists('.channel-footer button:first'), 'create button is displayed');
});
// andThen(() => { click('.channel-footer button:first');
// assert.ok(exists('#chat_integration_edit_rule_modal'), 'modal opens on edit');
// assert.ok(!find('#save_rule').prop('disabled'), 'it enables the save button');
// });
// click('#save_rule'); andThen(() => {
assert.ok(exists('#chat_integration_edit_rule_modal'), 'modal opens on edit');
assert.ok(find('#save_rule').prop('disabled') === false, 'save is enabled');
});
// andThen(() => { click('#save_rule');
// assert.ok(!exists('#chat_integration_edit_rule_modal'), 'modal closes on save');
// });
// });
// test("Delete rule works", function(assert) { andThen(() => {
// visit("/admin/plugins/chat"); assert.ok(!exists('#chat_integration_edit_rule_modal'), 'modal closes on save');
});
});
// andThen(() => { test("Edit rule works", assert => {
// assert.ok(exists('.delete:first')); visit("/admin/plugins/chat");
// click('.delete:first');
// });
// });
test("Test provider works", assert => { andThen(() => {
assert.ok(exists('.edit:first'), 'edit button is displayed');
});
click('.edit:first');
andThen(() => {
assert.ok(exists('#chat_integration_edit_rule_modal'), 'modal opens on edit');
assert.ok(find('#save_rule').prop('disabled') === false, 'it enables the save button');
});
click('#save_rule');
andThen(() => {
assert.ok(!exists('#chat_integration_edit_rule_modal'), 'modal closes on save');
});
});
test("Delete channel works", function(assert) {
visit("/admin/plugins/chat");
andThen(() => {
assert.ok(exists('.channel-header button:last'), "delete button exists");
click('.channel-header button:last');
});
andThen(() => {
assert.ok(exists('div.bootbox'), "modal is displayed");
click('div.bootbox .btn-primary');
});
andThen(() => {
assert.ok(exists('div.bootbox')===false, "modal has closed");
});
});
test("Delete rule works", function(assert) {
visit("/admin/plugins/chat");
andThen(() => {
assert.ok(exists('.delete:first'));
click('.delete:first');
});
});
test("Test channel works", assert => {
visit("/admin/plugins/chat"); visit("/admin/plugins/chat");
andThen(() => { andThen(() => {
@ -156,7 +201,7 @@ test("Test provider works", assert => {
}); });
andThen(() => { andThen(() => {
assert.ok(!find('#send_test').prop('disabled'), 'it enables the send button'); assert.ok(find('#send_test').prop('disabled') === false, 'it enables the send button');
}); });
andThen(() => { andThen(() => {