From d63477fec0f894a7dfd47a0e83fc29f677796be3 Mon Sep 17 00:00:00 2001
From: David Taylor <david@taylorhq.com>
Date: Mon, 21 Mar 2022 16:03:23 +0000
Subject: [PATCH] FIX: Use correct identifier in transcript thread hint (#115)

We were using the internal UID of the channel in the hint, which would then fail to match any 'channel' configs in Discourse (which use the human-friendly `#channel` format). This was causing automatic threading for transcripts to fail.
---
 .../provider/slack/slack_transcript.rb                          | 2 +-
 .../provider/slack/slack_transcript_spec.rb                     | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/lib/discourse_chat_integration/provider/slack/slack_transcript.rb b/lib/discourse_chat_integration/provider/slack/slack_transcript.rb
index 0e168a2..efa7a15 100644
--- a/lib/discourse_chat_integration/provider/slack/slack_transcript.rb
+++ b/lib/discourse_chat_integration/provider/slack/slack_transcript.rb
@@ -121,7 +121,7 @@ module DiscourseChatIntegration::Provider::SlackProvider
       end
 
       if not @requested_thread_ts.nil?
-        post_content << "<!--SLACK_CHANNEL_ID=#{@channel_id};SLACK_TS=#{@requested_thread_ts}-->"
+        post_content << "<!--SLACK_CHANNEL_ID=#{@channel_name};SLACK_TS=#{@requested_thread_ts}-->"
       end
 
       post_content
diff --git a/spec/lib/discourse_chat_integration/provider/slack/slack_transcript_spec.rb b/spec/lib/discourse_chat_integration/provider/slack/slack_transcript_spec.rb
index fe20f87..a3c9a46 100644
--- a/spec/lib/discourse_chat_integration/provider/slack/slack_transcript_spec.rb
+++ b/spec/lib/discourse_chat_integration/provider/slack/slack_transcript_spec.rb
@@ -198,7 +198,7 @@ RSpec.describe DiscourseChatIntegration::Provider::SlackProvider::SlackTranscrip
 
       it 'includes slack thread identifiers in body' do
         text = thread_transcript.build_transcript
-        expect(text).to include("<!--SLACK_CHANNEL_ID=G1234;SLACK_TS=1501801629.052212-->")
+        expect(text).to include("<!--SLACK_CHANNEL_ID=#general;SLACK_TS=1501801629.052212-->")
       end
 
     end