Commit Graph

3 Commits

Author SHA1 Message Date
Gabriel Grubba ac91fe053b
FIX: Update flaky test in showing error modal (#228)
the error:

```
Randomized with seed 43756
.F

Failures:

  1) Create channel shows error in chanel modal
     Failure/Error: super

     Capybara::ElementNotFound:
       Unable to find css ".error-message"

     [Screenshot Image]: /var/www/discourse/tmp/capybara/failures_r_spec_example_groups_create_channel_shows_error_in_chanel_modal_523.png

     ~~~~~~~ JS LOGS ~~~~~~~
     (no logs)
```

To try solving this, I've changed the ordering, before visiting the page I already set up the channel error.
2024-10-29 09:56:24 -03:00
Gabriel Grubba 19766fbc09
FIX: Error modal not showing data (#225)
* FIX: Error modal not showing data

Before, there was an issue where the error modal was not showing the data. This was because the error modal was not being shown when there were errors.

* DEV: add tests to ensure that error modal is showing data
2024-10-17 12:53:29 -03:00
Jarek Radosz 30ac835e1d
FIX: Form validation bugs, new modal api, glimmer (#182) 2023-12-11 20:00:34 +01:00