Discource-C
/
discourse-custom-header-links
mirror of https://github.com/discourse/discourse-custom-header-links.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

DEV: Rename `Custom_header_links` settings to `custom_header_links` (#45) 

Why this change?

Using uppercase in settings name is not part of our convention so
renaming it here.
This commit is contained in:
Alan Guo Xiang Tan 2024-01-26 10:15:41 +08:00 committed by GitHub
parent 916b1ffeff
commit 5006125483
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
4 changed files with 36 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
javascripts/discourse/components/custom-header-links.js
View File

@ -3,11 +3,11 @@ import { dasherize } from "@ember/string";
export default class CustomHeaderLinks extends Component {
get shouldShow() {
return settings.Custom_header_links?.length > 0;
return settings.custom_header_links?.length > 0;
}
get links() {
return settings.Custom_header_links.split("|").reduce((result, item) => {
return settings.custom_header_links.split("|").reduce((result, item) => {
let [
linkText,
linkTitle,

8
migrations/settings/0001-rename-settings.js Normal file
View File

@ -0,0 +1,8 @@
export default function migrate(settings) {
if (settings.has("Custom_header_links")) {
settings.set("custom_header_links", settings.get("Custom_header_links"));
settings.delete("Custom_header_links");
}
return settings;
}

2
settings.yml
View File

@ -1,4 +1,4 @@
Custom_header_links:
custom_header_links:
type: list
list_type: simple
default: "External link, this link will open in a new tab, https://meta.discourse.org, vdo, blank, remove|Most Liked, Posts with the most amount of likes, /latest/?order=op_likes, vdo, self, keep|Privacy, Our Privacy Policy, /privacy, vdm, self, keep"

25
test/unit/migrations/settings/0001-rename-settings-test.js Normal file
View File

@ -0,0 +1,25 @@
import { module, test } from "qunit";
import migrate from "../../../../migrations/settings/0001-rename-settings";
module("Unit | Migrations | Settings | 0001-rename-settings", function () {
test("migrate", function (assert) {
const settings = new Map(
Object.entries({
Custom_header_links: "some,links",
})
);
const result = migrate(settings);
assert.deepEqual(
Array.from(result),
Array.from(
new Map(
Object.entries({
custom_header_links: "some,links",
})
)
)
);
});
});