discourse-custom-header-links

Author SHA1 Message Date

Author	SHA1	Message	Date
Alan Guo Xiang Tan	4cc2a57c21	FIX: Allow title to be blank when migrating `custom_header_links` (#56 ) This commit allows setting value of `Link Name, ,/some/path` to be migrated. This format of the setting was allowed and the current migration will not migrate the link if the title is empty which isn't what we want. Follows-up to `167bc8cee9`	2024-04-26 15:46:20 +08:00
Alan Guo Xiang Tan	167bc8cee9	FIX: Ensure that custom header links migration do not fail validation (#55 ) This commit is a follow up to `73747938bd` where the migration will fail because the objects created by the migration will end up failing to save because the objects will fail the validation given the new schema. This commit updates the migration to ensure that we do not end up with invalid objects.	2024-04-26 12:57:46 +08:00
Alan Guo Xiang Tan	73747938bd	DEV: Migrate custom header links to new objects setting type (#53 ) Why this change? Since discourse/discourse@a440e15, we have started to support objects typed theme setting so we are switching this theme component to use it instead as it provides a much better UX for configuring the settings required for the theme component.	2024-04-23 11:50:20 +08:00

Alan Guo Xiang Tan

4cc2a57c21

FIX: Allow title to be blank when migrating `custom_header_links` (#56 )

This commit allows setting value of `Link Name, ,/some/path` to be
migrated. This format of the setting was allowed and the current
migration will not migrate the link if the title is empty which isn't
what we want.

Follows-up to 167bc8cee9

2024-04-26 15:46:20 +08:00

Alan Guo Xiang Tan

167bc8cee9

FIX: Ensure that custom header links migration do not fail validation (#55 )

This commit is a follow up to 73747938bd
where the migration will fail because the objects created by the
migration will end up failing to save because the objects will fail the
validation given the new schema. This commit updates the migration to
ensure that we do not end up with invalid objects.

2024-04-26 12:57:46 +08:00

Alan Guo Xiang Tan

73747938bd

DEV: Migrate custom header links to new objects setting type (#53 )

Why this change?

Since discourse/discourse@a440e15, we have started to support objects typed theme setting so we are switching this theme component to use it instead as it provides a much better UX for configuring the settings required for the theme component.

2024-04-23 11:50:20 +08:00

3 Commits