discourse-data-explorer/spec/lib/tasks/data_explorer_spec.rb

184 lines
7.8 KiB
Ruby
Raw Normal View History

FEATURE: Add ability to soft delete (hide) queries and revert deletion with rake tasks (#54) * FEATURE: Add hide button (toggleable) for all queries (frontend only) * Switches between hide/unhide on click * Works almost like the delete button, but toggles between the query's hidden attribute instead * So far this is only a frontend feature, the backend implementation still needs work * Revert "FEATURE: Add hide button (toggleable) for all queries (frontend only)" This reverts commit a8771d2ad57083a91b7130df807fa54c26205d11. REVERT: Remove button that hides queries (frontend) * Prepare for migration of old frontend logic to backend * We are going to reuse the existing delete button, but change its backend logic to enable soft deletion. From the user's perspective nothing will change, but any deletion mistakes can be reverted. * DEV: Hide user queries upon deletion, but keep them in store * Creating a new query will set its hidden attribute to false by default * Deleting a user-made query will not delete it from the store, but set its hidden attribute to true * User queries will not be indexed if they are hidden * Undeleting a query will unhide it, and will be indexed * Updating a hidden query will unhide it, and will be indexed * SPEC: Add spec for hidden/deleted queries * Hidden queries should not be shown * FEATURE: Add ability to delete/hide system queries * System queries are now able to be deleted from view, but will remain in the backend for retrieval, if necessary * FEATURE/DEV: Add rake commands for query soft deletion * query:list_hidden - Shows a list of hidden queries * query:hide_all[only_default] - Hides all queries, w/ boolean arg to hide only default ones * query:unhide[id] - Unhides a query by id * query:unhide_all[exclude_default] - Unhides all hidden queries, w/ boolean arg to exclude default ones * Remove rails loggers * UX/DEV: Update query rake tasks to be more user friendly * Split query:hide_all[only_default] into two tasks: * query:hide_all - Hides all queries * query:hide_all:only_default - Hide only default queries * Split query:unhide_all[exclude_default] into two tasks: * query:unhide_all - Unhides all hidden queries * query:unhide_all:exclude_default - Unhides all non-default queries * Rename file to match task name * UX: query:unhide can accept multiple arguments * Example: rake query:unhide[-5,-6,-7,3,5,6,-13,-14,-10] * UX: Update query rake tasks to output cleaner messages * Remove unneeded comment * DEV: Keep only necessary rake tasks, use more specific naming * UX/DEV: Add rake task for hard deletion, better console logs * User is able to hard delete a query only if it is hidden, otherwise output a message stating so * Add commented examples above each task * Add rainbow support for more readable console logs * Successful messages will display green, failures display red, additional info displays yellow * Separate multiple queries with spaces instead of lines * DEV: Remove rainbow colorizing in console logs * Rainbow is a dependency of rubocop and it may go away in the future * Rainbow is only used for dev and test environments * DEV: Add Rails engine to enable rake tasks to be loaded at runtime * DEV: Favor require - load files only if they are not already loaded * SPEC: Add tests for data_explorer[id] rake command * Test if a single query is hidden correctly * Expect length of query list to not be modified * Expect array of hidden queries to have exactly 1 element * Expect that one element to have the same ID as the one invoked to be hidden * Test if multiple queries are hidden correctly * Expect length of query list to not be modified * Expect array of hidden queries to have the number of elements equal to the number invoked to be hidden * Expect the elements to have the same ID as the ones invoked to be hidden * Test if a query exists in PluginStore * Expect query list to be empty * DEV: Clear pre-existing tasks before redefining * This prevents double invocation when user invokes the task once * SPEC: Add tests for unhide_query rake task * Test if a single query unhides correctly * Expect length of query list to not be modified * Expect array of hidden queries to have exactly 1 element after unhiding 1 of 2 queries * Expect remaining element to be hidden * Test if multiple queries unhide correctly * Expect length of query list to not be modified * Expect array of hidden queries to have exactly 1 element after unhiding 3 of 4 queries * Expect remaining element to be hidden * Test if a query exists in PluginStore * Expect query list to not be modified * SPEC: Add tests for hard_delete rake task * Test if a single query hard deletes correctly * Expect length of query list to be shorter by 1 * Expect array of hidden queries to have exactly 1 element after hard deleting 1 of 2 queries * Expect 1 remaining hidden element * Test if multiple queries hard delete correctly * Expect length of query list to be shorter by 3 after hard deleting 3 of 4 queries * Expect array of hidden queries to have exactly 1 element after hard deleting 3 of 4 queries * Expect 1 remaining hidden element * Test if a query exists in PluginStore * Expect hidden query list to not be modified * Test if a query is not hidden * Expect query list to not be modified * UX: Favor newline char in place of puts for logs * Condensed console logs to output newline char instead of another puts statement (reduces number of lines used significantly)
2020-07-29 02:50:24 -04:00
# frozen_string_literal: true
require 'rails_helper'
describe 'Data Explorer rake tasks' do
before do
Rake::Task.clear
Discourse::Application.load_tasks
end
def make_query(sql, opts = {}, group_ids = [])
query = DataExplorer::Query.create!(id: opts[:id], name: opts[:name] || "Query number", description: "A description for query number", sql: sql, hidden: opts[:hidden] || false)
group_ids.each do |group_id|
query.query_groups.create!(group_id: group_id)
end
query
FEATURE: Add ability to soft delete (hide) queries and revert deletion with rake tasks (#54) * FEATURE: Add hide button (toggleable) for all queries (frontend only) * Switches between hide/unhide on click * Works almost like the delete button, but toggles between the query's hidden attribute instead * So far this is only a frontend feature, the backend implementation still needs work * Revert "FEATURE: Add hide button (toggleable) for all queries (frontend only)" This reverts commit a8771d2ad57083a91b7130df807fa54c26205d11. REVERT: Remove button that hides queries (frontend) * Prepare for migration of old frontend logic to backend * We are going to reuse the existing delete button, but change its backend logic to enable soft deletion. From the user's perspective nothing will change, but any deletion mistakes can be reverted. * DEV: Hide user queries upon deletion, but keep them in store * Creating a new query will set its hidden attribute to false by default * Deleting a user-made query will not delete it from the store, but set its hidden attribute to true * User queries will not be indexed if they are hidden * Undeleting a query will unhide it, and will be indexed * Updating a hidden query will unhide it, and will be indexed * SPEC: Add spec for hidden/deleted queries * Hidden queries should not be shown * FEATURE: Add ability to delete/hide system queries * System queries are now able to be deleted from view, but will remain in the backend for retrieval, if necessary * FEATURE/DEV: Add rake commands for query soft deletion * query:list_hidden - Shows a list of hidden queries * query:hide_all[only_default] - Hides all queries, w/ boolean arg to hide only default ones * query:unhide[id] - Unhides a query by id * query:unhide_all[exclude_default] - Unhides all hidden queries, w/ boolean arg to exclude default ones * Remove rails loggers * UX/DEV: Update query rake tasks to be more user friendly * Split query:hide_all[only_default] into two tasks: * query:hide_all - Hides all queries * query:hide_all:only_default - Hide only default queries * Split query:unhide_all[exclude_default] into two tasks: * query:unhide_all - Unhides all hidden queries * query:unhide_all:exclude_default - Unhides all non-default queries * Rename file to match task name * UX: query:unhide can accept multiple arguments * Example: rake query:unhide[-5,-6,-7,3,5,6,-13,-14,-10] * UX: Update query rake tasks to output cleaner messages * Remove unneeded comment * DEV: Keep only necessary rake tasks, use more specific naming * UX/DEV: Add rake task for hard deletion, better console logs * User is able to hard delete a query only if it is hidden, otherwise output a message stating so * Add commented examples above each task * Add rainbow support for more readable console logs * Successful messages will display green, failures display red, additional info displays yellow * Separate multiple queries with spaces instead of lines * DEV: Remove rainbow colorizing in console logs * Rainbow is a dependency of rubocop and it may go away in the future * Rainbow is only used for dev and test environments * DEV: Add Rails engine to enable rake tasks to be loaded at runtime * DEV: Favor require - load files only if they are not already loaded * SPEC: Add tests for data_explorer[id] rake command * Test if a single query is hidden correctly * Expect length of query list to not be modified * Expect array of hidden queries to have exactly 1 element * Expect that one element to have the same ID as the one invoked to be hidden * Test if multiple queries are hidden correctly * Expect length of query list to not be modified * Expect array of hidden queries to have the number of elements equal to the number invoked to be hidden * Expect the elements to have the same ID as the ones invoked to be hidden * Test if a query exists in PluginStore * Expect query list to be empty * DEV: Clear pre-existing tasks before redefining * This prevents double invocation when user invokes the task once * SPEC: Add tests for unhide_query rake task * Test if a single query unhides correctly * Expect length of query list to not be modified * Expect array of hidden queries to have exactly 1 element after unhiding 1 of 2 queries * Expect remaining element to be hidden * Test if multiple queries unhide correctly * Expect length of query list to not be modified * Expect array of hidden queries to have exactly 1 element after unhiding 3 of 4 queries * Expect remaining element to be hidden * Test if a query exists in PluginStore * Expect query list to not be modified * SPEC: Add tests for hard_delete rake task * Test if a single query hard deletes correctly * Expect length of query list to be shorter by 1 * Expect array of hidden queries to have exactly 1 element after hard deleting 1 of 2 queries * Expect 1 remaining hidden element * Test if multiple queries hard delete correctly * Expect length of query list to be shorter by 3 after hard deleting 3 of 4 queries * Expect array of hidden queries to have exactly 1 element after hard deleting 3 of 4 queries * Expect 1 remaining hidden element * Test if a query exists in PluginStore * Expect hidden query list to not be modified * Test if a query is not hidden * Expect query list to not be modified * UX: Favor newline char in place of puts for logs * Condensed console logs to output newline char instead of another puts statement (reduces number of lines used significantly)
2020-07-29 02:50:24 -04:00
end
def hidden_queries
DataExplorer::Query.where(hidden: true)
FEATURE: Add ability to soft delete (hide) queries and revert deletion with rake tasks (#54) * FEATURE: Add hide button (toggleable) for all queries (frontend only) * Switches between hide/unhide on click * Works almost like the delete button, but toggles between the query's hidden attribute instead * So far this is only a frontend feature, the backend implementation still needs work * Revert "FEATURE: Add hide button (toggleable) for all queries (frontend only)" This reverts commit a8771d2ad57083a91b7130df807fa54c26205d11. REVERT: Remove button that hides queries (frontend) * Prepare for migration of old frontend logic to backend * We are going to reuse the existing delete button, but change its backend logic to enable soft deletion. From the user's perspective nothing will change, but any deletion mistakes can be reverted. * DEV: Hide user queries upon deletion, but keep them in store * Creating a new query will set its hidden attribute to false by default * Deleting a user-made query will not delete it from the store, but set its hidden attribute to true * User queries will not be indexed if they are hidden * Undeleting a query will unhide it, and will be indexed * Updating a hidden query will unhide it, and will be indexed * SPEC: Add spec for hidden/deleted queries * Hidden queries should not be shown * FEATURE: Add ability to delete/hide system queries * System queries are now able to be deleted from view, but will remain in the backend for retrieval, if necessary * FEATURE/DEV: Add rake commands for query soft deletion * query:list_hidden - Shows a list of hidden queries * query:hide_all[only_default] - Hides all queries, w/ boolean arg to hide only default ones * query:unhide[id] - Unhides a query by id * query:unhide_all[exclude_default] - Unhides all hidden queries, w/ boolean arg to exclude default ones * Remove rails loggers * UX/DEV: Update query rake tasks to be more user friendly * Split query:hide_all[only_default] into two tasks: * query:hide_all - Hides all queries * query:hide_all:only_default - Hide only default queries * Split query:unhide_all[exclude_default] into two tasks: * query:unhide_all - Unhides all hidden queries * query:unhide_all:exclude_default - Unhides all non-default queries * Rename file to match task name * UX: query:unhide can accept multiple arguments * Example: rake query:unhide[-5,-6,-7,3,5,6,-13,-14,-10] * UX: Update query rake tasks to output cleaner messages * Remove unneeded comment * DEV: Keep only necessary rake tasks, use more specific naming * UX/DEV: Add rake task for hard deletion, better console logs * User is able to hard delete a query only if it is hidden, otherwise output a message stating so * Add commented examples above each task * Add rainbow support for more readable console logs * Successful messages will display green, failures display red, additional info displays yellow * Separate multiple queries with spaces instead of lines * DEV: Remove rainbow colorizing in console logs * Rainbow is a dependency of rubocop and it may go away in the future * Rainbow is only used for dev and test environments * DEV: Add Rails engine to enable rake tasks to be loaded at runtime * DEV: Favor require - load files only if they are not already loaded * SPEC: Add tests for data_explorer[id] rake command * Test if a single query is hidden correctly * Expect length of query list to not be modified * Expect array of hidden queries to have exactly 1 element * Expect that one element to have the same ID as the one invoked to be hidden * Test if multiple queries are hidden correctly * Expect length of query list to not be modified * Expect array of hidden queries to have the number of elements equal to the number invoked to be hidden * Expect the elements to have the same ID as the ones invoked to be hidden * Test if a query exists in PluginStore * Expect query list to be empty * DEV: Clear pre-existing tasks before redefining * This prevents double invocation when user invokes the task once * SPEC: Add tests for unhide_query rake task * Test if a single query unhides correctly * Expect length of query list to not be modified * Expect array of hidden queries to have exactly 1 element after unhiding 1 of 2 queries * Expect remaining element to be hidden * Test if multiple queries unhide correctly * Expect length of query list to not be modified * Expect array of hidden queries to have exactly 1 element after unhiding 3 of 4 queries * Expect remaining element to be hidden * Test if a query exists in PluginStore * Expect query list to not be modified * SPEC: Add tests for hard_delete rake task * Test if a single query hard deletes correctly * Expect length of query list to be shorter by 1 * Expect array of hidden queries to have exactly 1 element after hard deleting 1 of 2 queries * Expect 1 remaining hidden element * Test if multiple queries hard delete correctly * Expect length of query list to be shorter by 3 after hard deleting 3 of 4 queries * Expect array of hidden queries to have exactly 1 element after hard deleting 3 of 4 queries * Expect 1 remaining hidden element * Test if a query exists in PluginStore * Expect hidden query list to not be modified * Test if a query is not hidden * Expect query list to not be modified * UX: Favor newline char in place of puts for logs * Condensed console logs to output newline char instead of another puts statement (reduces number of lines used significantly)
2020-07-29 02:50:24 -04:00
end
describe 'data_explorer' do
it 'hides a single query' do
DataExplorer::Query.destroy_all
make_query('SELECT 1 as value', id: 1, name: 'A')
make_query('SELECT 1 as value', id: 2, name: 'B')
# rake data_explorer[1] => hide query with ID 1
2022-02-01 15:38:24 -05:00
silence_stdout { Rake::Task['data_explorer'].invoke(1) }
FEATURE: Add ability to soft delete (hide) queries and revert deletion with rake tasks (#54) * FEATURE: Add hide button (toggleable) for all queries (frontend only) * Switches between hide/unhide on click * Works almost like the delete button, but toggles between the query's hidden attribute instead * So far this is only a frontend feature, the backend implementation still needs work * Revert "FEATURE: Add hide button (toggleable) for all queries (frontend only)" This reverts commit a8771d2ad57083a91b7130df807fa54c26205d11. REVERT: Remove button that hides queries (frontend) * Prepare for migration of old frontend logic to backend * We are going to reuse the existing delete button, but change its backend logic to enable soft deletion. From the user's perspective nothing will change, but any deletion mistakes can be reverted. * DEV: Hide user queries upon deletion, but keep them in store * Creating a new query will set its hidden attribute to false by default * Deleting a user-made query will not delete it from the store, but set its hidden attribute to true * User queries will not be indexed if they are hidden * Undeleting a query will unhide it, and will be indexed * Updating a hidden query will unhide it, and will be indexed * SPEC: Add spec for hidden/deleted queries * Hidden queries should not be shown * FEATURE: Add ability to delete/hide system queries * System queries are now able to be deleted from view, but will remain in the backend for retrieval, if necessary * FEATURE/DEV: Add rake commands for query soft deletion * query:list_hidden - Shows a list of hidden queries * query:hide_all[only_default] - Hides all queries, w/ boolean arg to hide only default ones * query:unhide[id] - Unhides a query by id * query:unhide_all[exclude_default] - Unhides all hidden queries, w/ boolean arg to exclude default ones * Remove rails loggers * UX/DEV: Update query rake tasks to be more user friendly * Split query:hide_all[only_default] into two tasks: * query:hide_all - Hides all queries * query:hide_all:only_default - Hide only default queries * Split query:unhide_all[exclude_default] into two tasks: * query:unhide_all - Unhides all hidden queries * query:unhide_all:exclude_default - Unhides all non-default queries * Rename file to match task name * UX: query:unhide can accept multiple arguments * Example: rake query:unhide[-5,-6,-7,3,5,6,-13,-14,-10] * UX: Update query rake tasks to output cleaner messages * Remove unneeded comment * DEV: Keep only necessary rake tasks, use more specific naming * UX/DEV: Add rake task for hard deletion, better console logs * User is able to hard delete a query only if it is hidden, otherwise output a message stating so * Add commented examples above each task * Add rainbow support for more readable console logs * Successful messages will display green, failures display red, additional info displays yellow * Separate multiple queries with spaces instead of lines * DEV: Remove rainbow colorizing in console logs * Rainbow is a dependency of rubocop and it may go away in the future * Rainbow is only used for dev and test environments * DEV: Add Rails engine to enable rake tasks to be loaded at runtime * DEV: Favor require - load files only if they are not already loaded * SPEC: Add tests for data_explorer[id] rake command * Test if a single query is hidden correctly * Expect length of query list to not be modified * Expect array of hidden queries to have exactly 1 element * Expect that one element to have the same ID as the one invoked to be hidden * Test if multiple queries are hidden correctly * Expect length of query list to not be modified * Expect array of hidden queries to have the number of elements equal to the number invoked to be hidden * Expect the elements to have the same ID as the ones invoked to be hidden * Test if a query exists in PluginStore * Expect query list to be empty * DEV: Clear pre-existing tasks before redefining * This prevents double invocation when user invokes the task once * SPEC: Add tests for unhide_query rake task * Test if a single query unhides correctly * Expect length of query list to not be modified * Expect array of hidden queries to have exactly 1 element after unhiding 1 of 2 queries * Expect remaining element to be hidden * Test if multiple queries unhide correctly * Expect length of query list to not be modified * Expect array of hidden queries to have exactly 1 element after unhiding 3 of 4 queries * Expect remaining element to be hidden * Test if a query exists in PluginStore * Expect query list to not be modified * SPEC: Add tests for hard_delete rake task * Test if a single query hard deletes correctly * Expect length of query list to be shorter by 1 * Expect array of hidden queries to have exactly 1 element after hard deleting 1 of 2 queries * Expect 1 remaining hidden element * Test if multiple queries hard delete correctly * Expect length of query list to be shorter by 3 after hard deleting 3 of 4 queries * Expect array of hidden queries to have exactly 1 element after hard deleting 3 of 4 queries * Expect 1 remaining hidden element * Test if a query exists in PluginStore * Expect hidden query list to not be modified * Test if a query is not hidden * Expect query list to not be modified * UX: Favor newline char in place of puts for logs * Condensed console logs to output newline char instead of another puts statement (reduces number of lines used significantly)
2020-07-29 02:50:24 -04:00
# Soft deletion: PluginStoreRow should not be modified
expect(DataExplorer::Query.all.length).to eq(2)
# Array of hidden queries should have exactly 1 element
expect(hidden_queries.length).to eq(1)
# That one element should have the same ID as the one invoked to be hidden
expect(hidden_queries[0].id).to eq(1)
end
it 'hides multiple queries' do
DataExplorer::Query.destroy_all
make_query('SELECT 1 as value', id: 1, name: 'A')
make_query('SELECT 1 as value', id: 2, name: 'B')
make_query('SELECT 1 as value', id: 3, name: 'C')
make_query('SELECT 1 as value', id: 4, name: 'D')
# rake data_explorer[1,2,4] => hide queries with IDs 1, 2 and 4
2022-02-01 15:38:24 -05:00
silence_stdout { Rake::Task['data_explorer'].invoke(1, 2, 4) }
FEATURE: Add ability to soft delete (hide) queries and revert deletion with rake tasks (#54) * FEATURE: Add hide button (toggleable) for all queries (frontend only) * Switches between hide/unhide on click * Works almost like the delete button, but toggles between the query's hidden attribute instead * So far this is only a frontend feature, the backend implementation still needs work * Revert "FEATURE: Add hide button (toggleable) for all queries (frontend only)" This reverts commit a8771d2ad57083a91b7130df807fa54c26205d11. REVERT: Remove button that hides queries (frontend) * Prepare for migration of old frontend logic to backend * We are going to reuse the existing delete button, but change its backend logic to enable soft deletion. From the user's perspective nothing will change, but any deletion mistakes can be reverted. * DEV: Hide user queries upon deletion, but keep them in store * Creating a new query will set its hidden attribute to false by default * Deleting a user-made query will not delete it from the store, but set its hidden attribute to true * User queries will not be indexed if they are hidden * Undeleting a query will unhide it, and will be indexed * Updating a hidden query will unhide it, and will be indexed * SPEC: Add spec for hidden/deleted queries * Hidden queries should not be shown * FEATURE: Add ability to delete/hide system queries * System queries are now able to be deleted from view, but will remain in the backend for retrieval, if necessary * FEATURE/DEV: Add rake commands for query soft deletion * query:list_hidden - Shows a list of hidden queries * query:hide_all[only_default] - Hides all queries, w/ boolean arg to hide only default ones * query:unhide[id] - Unhides a query by id * query:unhide_all[exclude_default] - Unhides all hidden queries, w/ boolean arg to exclude default ones * Remove rails loggers * UX/DEV: Update query rake tasks to be more user friendly * Split query:hide_all[only_default] into two tasks: * query:hide_all - Hides all queries * query:hide_all:only_default - Hide only default queries * Split query:unhide_all[exclude_default] into two tasks: * query:unhide_all - Unhides all hidden queries * query:unhide_all:exclude_default - Unhides all non-default queries * Rename file to match task name * UX: query:unhide can accept multiple arguments * Example: rake query:unhide[-5,-6,-7,3,5,6,-13,-14,-10] * UX: Update query rake tasks to output cleaner messages * Remove unneeded comment * DEV: Keep only necessary rake tasks, use more specific naming * UX/DEV: Add rake task for hard deletion, better console logs * User is able to hard delete a query only if it is hidden, otherwise output a message stating so * Add commented examples above each task * Add rainbow support for more readable console logs * Successful messages will display green, failures display red, additional info displays yellow * Separate multiple queries with spaces instead of lines * DEV: Remove rainbow colorizing in console logs * Rainbow is a dependency of rubocop and it may go away in the future * Rainbow is only used for dev and test environments * DEV: Add Rails engine to enable rake tasks to be loaded at runtime * DEV: Favor require - load files only if they are not already loaded * SPEC: Add tests for data_explorer[id] rake command * Test if a single query is hidden correctly * Expect length of query list to not be modified * Expect array of hidden queries to have exactly 1 element * Expect that one element to have the same ID as the one invoked to be hidden * Test if multiple queries are hidden correctly * Expect length of query list to not be modified * Expect array of hidden queries to have the number of elements equal to the number invoked to be hidden * Expect the elements to have the same ID as the ones invoked to be hidden * Test if a query exists in PluginStore * Expect query list to be empty * DEV: Clear pre-existing tasks before redefining * This prevents double invocation when user invokes the task once * SPEC: Add tests for unhide_query rake task * Test if a single query unhides correctly * Expect length of query list to not be modified * Expect array of hidden queries to have exactly 1 element after unhiding 1 of 2 queries * Expect remaining element to be hidden * Test if multiple queries unhide correctly * Expect length of query list to not be modified * Expect array of hidden queries to have exactly 1 element after unhiding 3 of 4 queries * Expect remaining element to be hidden * Test if a query exists in PluginStore * Expect query list to not be modified * SPEC: Add tests for hard_delete rake task * Test if a single query hard deletes correctly * Expect length of query list to be shorter by 1 * Expect array of hidden queries to have exactly 1 element after hard deleting 1 of 2 queries * Expect 1 remaining hidden element * Test if multiple queries hard delete correctly * Expect length of query list to be shorter by 3 after hard deleting 3 of 4 queries * Expect array of hidden queries to have exactly 1 element after hard deleting 3 of 4 queries * Expect 1 remaining hidden element * Test if a query exists in PluginStore * Expect hidden query list to not be modified * Test if a query is not hidden * Expect query list to not be modified * UX: Favor newline char in place of puts for logs * Condensed console logs to output newline char instead of another puts statement (reduces number of lines used significantly)
2020-07-29 02:50:24 -04:00
# Soft deletion: PluginStoreRow should not be modified
expect(DataExplorer::Query.all.length).to eq(4)
# Array of hidden queries should have the same number of elements invoked to be hidden
expect(hidden_queries.length).to eq(3)
# The elements should have the same ID as the ones invoked to be hidden
expect(hidden_queries[0].id).to eq(1)
expect(hidden_queries[1].id).to eq(2)
expect(hidden_queries[2].id).to eq(4)
end
context 'query does not exist in PluginStore' do
it 'should not hide the query' do
DataExplorer::Query.destroy_all
make_query('SELECT 1 as value', id: 1, name: 'A')
make_query('SELECT 1 as value', id: 2, name: 'B')
# rake data_explorer[3] => try to hide query with ID 3
2022-02-01 15:38:24 -05:00
silence_stdout { Rake::Task['data_explorer'].invoke(3) }
FEATURE: Add ability to soft delete (hide) queries and revert deletion with rake tasks (#54) * FEATURE: Add hide button (toggleable) for all queries (frontend only) * Switches between hide/unhide on click * Works almost like the delete button, but toggles between the query's hidden attribute instead * So far this is only a frontend feature, the backend implementation still needs work * Revert "FEATURE: Add hide button (toggleable) for all queries (frontend only)" This reverts commit a8771d2ad57083a91b7130df807fa54c26205d11. REVERT: Remove button that hides queries (frontend) * Prepare for migration of old frontend logic to backend * We are going to reuse the existing delete button, but change its backend logic to enable soft deletion. From the user's perspective nothing will change, but any deletion mistakes can be reverted. * DEV: Hide user queries upon deletion, but keep them in store * Creating a new query will set its hidden attribute to false by default * Deleting a user-made query will not delete it from the store, but set its hidden attribute to true * User queries will not be indexed if they are hidden * Undeleting a query will unhide it, and will be indexed * Updating a hidden query will unhide it, and will be indexed * SPEC: Add spec for hidden/deleted queries * Hidden queries should not be shown * FEATURE: Add ability to delete/hide system queries * System queries are now able to be deleted from view, but will remain in the backend for retrieval, if necessary * FEATURE/DEV: Add rake commands for query soft deletion * query:list_hidden - Shows a list of hidden queries * query:hide_all[only_default] - Hides all queries, w/ boolean arg to hide only default ones * query:unhide[id] - Unhides a query by id * query:unhide_all[exclude_default] - Unhides all hidden queries, w/ boolean arg to exclude default ones * Remove rails loggers * UX/DEV: Update query rake tasks to be more user friendly * Split query:hide_all[only_default] into two tasks: * query:hide_all - Hides all queries * query:hide_all:only_default - Hide only default queries * Split query:unhide_all[exclude_default] into two tasks: * query:unhide_all - Unhides all hidden queries * query:unhide_all:exclude_default - Unhides all non-default queries * Rename file to match task name * UX: query:unhide can accept multiple arguments * Example: rake query:unhide[-5,-6,-7,3,5,6,-13,-14,-10] * UX: Update query rake tasks to output cleaner messages * Remove unneeded comment * DEV: Keep only necessary rake tasks, use more specific naming * UX/DEV: Add rake task for hard deletion, better console logs * User is able to hard delete a query only if it is hidden, otherwise output a message stating so * Add commented examples above each task * Add rainbow support for more readable console logs * Successful messages will display green, failures display red, additional info displays yellow * Separate multiple queries with spaces instead of lines * DEV: Remove rainbow colorizing in console logs * Rainbow is a dependency of rubocop and it may go away in the future * Rainbow is only used for dev and test environments * DEV: Add Rails engine to enable rake tasks to be loaded at runtime * DEV: Favor require - load files only if they are not already loaded * SPEC: Add tests for data_explorer[id] rake command * Test if a single query is hidden correctly * Expect length of query list to not be modified * Expect array of hidden queries to have exactly 1 element * Expect that one element to have the same ID as the one invoked to be hidden * Test if multiple queries are hidden correctly * Expect length of query list to not be modified * Expect array of hidden queries to have the number of elements equal to the number invoked to be hidden * Expect the elements to have the same ID as the ones invoked to be hidden * Test if a query exists in PluginStore * Expect query list to be empty * DEV: Clear pre-existing tasks before redefining * This prevents double invocation when user invokes the task once * SPEC: Add tests for unhide_query rake task * Test if a single query unhides correctly * Expect length of query list to not be modified * Expect array of hidden queries to have exactly 1 element after unhiding 1 of 2 queries * Expect remaining element to be hidden * Test if multiple queries unhide correctly * Expect length of query list to not be modified * Expect array of hidden queries to have exactly 1 element after unhiding 3 of 4 queries * Expect remaining element to be hidden * Test if a query exists in PluginStore * Expect query list to not be modified * SPEC: Add tests for hard_delete rake task * Test if a single query hard deletes correctly * Expect length of query list to be shorter by 1 * Expect array of hidden queries to have exactly 1 element after hard deleting 1 of 2 queries * Expect 1 remaining hidden element * Test if multiple queries hard delete correctly * Expect length of query list to be shorter by 3 after hard deleting 3 of 4 queries * Expect array of hidden queries to have exactly 1 element after hard deleting 3 of 4 queries * Expect 1 remaining hidden element * Test if a query exists in PluginStore * Expect hidden query list to not be modified * Test if a query is not hidden * Expect query list to not be modified * UX: Favor newline char in place of puts for logs * Condensed console logs to output newline char instead of another puts statement (reduces number of lines used significantly)
2020-07-29 02:50:24 -04:00
# rake data_explorer[3,4,5] => try to hide queries with IDs 3, 4 and 5
2022-02-01 15:38:24 -05:00
silence_stdout { Rake::Task['data_explorer'].invoke(3, 4, 5) }
FEATURE: Add ability to soft delete (hide) queries and revert deletion with rake tasks (#54) * FEATURE: Add hide button (toggleable) for all queries (frontend only) * Switches between hide/unhide on click * Works almost like the delete button, but toggles between the query's hidden attribute instead * So far this is only a frontend feature, the backend implementation still needs work * Revert "FEATURE: Add hide button (toggleable) for all queries (frontend only)" This reverts commit a8771d2ad57083a91b7130df807fa54c26205d11. REVERT: Remove button that hides queries (frontend) * Prepare for migration of old frontend logic to backend * We are going to reuse the existing delete button, but change its backend logic to enable soft deletion. From the user's perspective nothing will change, but any deletion mistakes can be reverted. * DEV: Hide user queries upon deletion, but keep them in store * Creating a new query will set its hidden attribute to false by default * Deleting a user-made query will not delete it from the store, but set its hidden attribute to true * User queries will not be indexed if they are hidden * Undeleting a query will unhide it, and will be indexed * Updating a hidden query will unhide it, and will be indexed * SPEC: Add spec for hidden/deleted queries * Hidden queries should not be shown * FEATURE: Add ability to delete/hide system queries * System queries are now able to be deleted from view, but will remain in the backend for retrieval, if necessary * FEATURE/DEV: Add rake commands for query soft deletion * query:list_hidden - Shows a list of hidden queries * query:hide_all[only_default] - Hides all queries, w/ boolean arg to hide only default ones * query:unhide[id] - Unhides a query by id * query:unhide_all[exclude_default] - Unhides all hidden queries, w/ boolean arg to exclude default ones * Remove rails loggers * UX/DEV: Update query rake tasks to be more user friendly * Split query:hide_all[only_default] into two tasks: * query:hide_all - Hides all queries * query:hide_all:only_default - Hide only default queries * Split query:unhide_all[exclude_default] into two tasks: * query:unhide_all - Unhides all hidden queries * query:unhide_all:exclude_default - Unhides all non-default queries * Rename file to match task name * UX: query:unhide can accept multiple arguments * Example: rake query:unhide[-5,-6,-7,3,5,6,-13,-14,-10] * UX: Update query rake tasks to output cleaner messages * Remove unneeded comment * DEV: Keep only necessary rake tasks, use more specific naming * UX/DEV: Add rake task for hard deletion, better console logs * User is able to hard delete a query only if it is hidden, otherwise output a message stating so * Add commented examples above each task * Add rainbow support for more readable console logs * Successful messages will display green, failures display red, additional info displays yellow * Separate multiple queries with spaces instead of lines * DEV: Remove rainbow colorizing in console logs * Rainbow is a dependency of rubocop and it may go away in the future * Rainbow is only used for dev and test environments * DEV: Add Rails engine to enable rake tasks to be loaded at runtime * DEV: Favor require - load files only if they are not already loaded * SPEC: Add tests for data_explorer[id] rake command * Test if a single query is hidden correctly * Expect length of query list to not be modified * Expect array of hidden queries to have exactly 1 element * Expect that one element to have the same ID as the one invoked to be hidden * Test if multiple queries are hidden correctly * Expect length of query list to not be modified * Expect array of hidden queries to have the number of elements equal to the number invoked to be hidden * Expect the elements to have the same ID as the ones invoked to be hidden * Test if a query exists in PluginStore * Expect query list to be empty * DEV: Clear pre-existing tasks before redefining * This prevents double invocation when user invokes the task once * SPEC: Add tests for unhide_query rake task * Test if a single query unhides correctly * Expect length of query list to not be modified * Expect array of hidden queries to have exactly 1 element after unhiding 1 of 2 queries * Expect remaining element to be hidden * Test if multiple queries unhide correctly * Expect length of query list to not be modified * Expect array of hidden queries to have exactly 1 element after unhiding 3 of 4 queries * Expect remaining element to be hidden * Test if a query exists in PluginStore * Expect query list to not be modified * SPEC: Add tests for hard_delete rake task * Test if a single query hard deletes correctly * Expect length of query list to be shorter by 1 * Expect array of hidden queries to have exactly 1 element after hard deleting 1 of 2 queries * Expect 1 remaining hidden element * Test if multiple queries hard delete correctly * Expect length of query list to be shorter by 3 after hard deleting 3 of 4 queries * Expect array of hidden queries to have exactly 1 element after hard deleting 3 of 4 queries * Expect 1 remaining hidden element * Test if a query exists in PluginStore * Expect hidden query list to not be modified * Test if a query is not hidden * Expect query list to not be modified * UX: Favor newline char in place of puts for logs * Condensed console logs to output newline char instead of another puts statement (reduces number of lines used significantly)
2020-07-29 02:50:24 -04:00
# Array of hidden queries should be empty
expect(hidden_queries.length).to eq(0)
end
end
end
describe '#unhide_query' do
it 'unhides a single query' do
DataExplorer::Query.destroy_all
make_query('SELECT 1 as value', id: 1, name: 'A', hidden: true)
make_query('SELECT 1 as value', id: 2, name: 'B', hidden: true)
# rake data_explorer:unhide_query[1] => unhide query with ID 1
2022-02-01 15:38:24 -05:00
silence_stdout { Rake::Task['data_explorer:unhide_query'].invoke(1) }
FEATURE: Add ability to soft delete (hide) queries and revert deletion with rake tasks (#54) * FEATURE: Add hide button (toggleable) for all queries (frontend only) * Switches between hide/unhide on click * Works almost like the delete button, but toggles between the query's hidden attribute instead * So far this is only a frontend feature, the backend implementation still needs work * Revert "FEATURE: Add hide button (toggleable) for all queries (frontend only)" This reverts commit a8771d2ad57083a91b7130df807fa54c26205d11. REVERT: Remove button that hides queries (frontend) * Prepare for migration of old frontend logic to backend * We are going to reuse the existing delete button, but change its backend logic to enable soft deletion. From the user's perspective nothing will change, but any deletion mistakes can be reverted. * DEV: Hide user queries upon deletion, but keep them in store * Creating a new query will set its hidden attribute to false by default * Deleting a user-made query will not delete it from the store, but set its hidden attribute to true * User queries will not be indexed if they are hidden * Undeleting a query will unhide it, and will be indexed * Updating a hidden query will unhide it, and will be indexed * SPEC: Add spec for hidden/deleted queries * Hidden queries should not be shown * FEATURE: Add ability to delete/hide system queries * System queries are now able to be deleted from view, but will remain in the backend for retrieval, if necessary * FEATURE/DEV: Add rake commands for query soft deletion * query:list_hidden - Shows a list of hidden queries * query:hide_all[only_default] - Hides all queries, w/ boolean arg to hide only default ones * query:unhide[id] - Unhides a query by id * query:unhide_all[exclude_default] - Unhides all hidden queries, w/ boolean arg to exclude default ones * Remove rails loggers * UX/DEV: Update query rake tasks to be more user friendly * Split query:hide_all[only_default] into two tasks: * query:hide_all - Hides all queries * query:hide_all:only_default - Hide only default queries * Split query:unhide_all[exclude_default] into two tasks: * query:unhide_all - Unhides all hidden queries * query:unhide_all:exclude_default - Unhides all non-default queries * Rename file to match task name * UX: query:unhide can accept multiple arguments * Example: rake query:unhide[-5,-6,-7,3,5,6,-13,-14,-10] * UX: Update query rake tasks to output cleaner messages * Remove unneeded comment * DEV: Keep only necessary rake tasks, use more specific naming * UX/DEV: Add rake task for hard deletion, better console logs * User is able to hard delete a query only if it is hidden, otherwise output a message stating so * Add commented examples above each task * Add rainbow support for more readable console logs * Successful messages will display green, failures display red, additional info displays yellow * Separate multiple queries with spaces instead of lines * DEV: Remove rainbow colorizing in console logs * Rainbow is a dependency of rubocop and it may go away in the future * Rainbow is only used for dev and test environments * DEV: Add Rails engine to enable rake tasks to be loaded at runtime * DEV: Favor require - load files only if they are not already loaded * SPEC: Add tests for data_explorer[id] rake command * Test if a single query is hidden correctly * Expect length of query list to not be modified * Expect array of hidden queries to have exactly 1 element * Expect that one element to have the same ID as the one invoked to be hidden * Test if multiple queries are hidden correctly * Expect length of query list to not be modified * Expect array of hidden queries to have the number of elements equal to the number invoked to be hidden * Expect the elements to have the same ID as the ones invoked to be hidden * Test if a query exists in PluginStore * Expect query list to be empty * DEV: Clear pre-existing tasks before redefining * This prevents double invocation when user invokes the task once * SPEC: Add tests for unhide_query rake task * Test if a single query unhides correctly * Expect length of query list to not be modified * Expect array of hidden queries to have exactly 1 element after unhiding 1 of 2 queries * Expect remaining element to be hidden * Test if multiple queries unhide correctly * Expect length of query list to not be modified * Expect array of hidden queries to have exactly 1 element after unhiding 3 of 4 queries * Expect remaining element to be hidden * Test if a query exists in PluginStore * Expect query list to not be modified * SPEC: Add tests for hard_delete rake task * Test if a single query hard deletes correctly * Expect length of query list to be shorter by 1 * Expect array of hidden queries to have exactly 1 element after hard deleting 1 of 2 queries * Expect 1 remaining hidden element * Test if multiple queries hard delete correctly * Expect length of query list to be shorter by 3 after hard deleting 3 of 4 queries * Expect array of hidden queries to have exactly 1 element after hard deleting 3 of 4 queries * Expect 1 remaining hidden element * Test if a query exists in PluginStore * Expect hidden query list to not be modified * Test if a query is not hidden * Expect query list to not be modified * UX: Favor newline char in place of puts for logs * Condensed console logs to output newline char instead of another puts statement (reduces number of lines used significantly)
2020-07-29 02:50:24 -04:00
# Soft deletion: PluginStoreRow should not be modified
expect(DataExplorer::Query.all.length).to eq(2)
# Array of hidden queries should have exactly 1 element
expect(hidden_queries.length).to eq(1)
# There should be one remaining element that is still hidden
expect(hidden_queries[0].id).to eq(2)
end
it 'unhides multiple queries' do
DataExplorer::Query.destroy_all
make_query('SELECT 1 as value', id: 1, name: 'A', hidden: true)
make_query('SELECT 1 as value', id: 2, name: 'B', hidden: true)
make_query('SELECT 1 as value', id: 3, name: 'C', hidden: true)
make_query('SELECT 1 as value', id: 4, name: 'D', hidden: true)
# rake data_explorer:unhide_query[1,2,4] => unhide queries with IDs 1, 2 and 4
2022-02-01 15:38:24 -05:00
silence_stdout { Rake::Task['data_explorer:unhide_query'].invoke(1, 2, 4) }
FEATURE: Add ability to soft delete (hide) queries and revert deletion with rake tasks (#54) * FEATURE: Add hide button (toggleable) for all queries (frontend only) * Switches between hide/unhide on click * Works almost like the delete button, but toggles between the query's hidden attribute instead * So far this is only a frontend feature, the backend implementation still needs work * Revert "FEATURE: Add hide button (toggleable) for all queries (frontend only)" This reverts commit a8771d2ad57083a91b7130df807fa54c26205d11. REVERT: Remove button that hides queries (frontend) * Prepare for migration of old frontend logic to backend * We are going to reuse the existing delete button, but change its backend logic to enable soft deletion. From the user's perspective nothing will change, but any deletion mistakes can be reverted. * DEV: Hide user queries upon deletion, but keep them in store * Creating a new query will set its hidden attribute to false by default * Deleting a user-made query will not delete it from the store, but set its hidden attribute to true * User queries will not be indexed if they are hidden * Undeleting a query will unhide it, and will be indexed * Updating a hidden query will unhide it, and will be indexed * SPEC: Add spec for hidden/deleted queries * Hidden queries should not be shown * FEATURE: Add ability to delete/hide system queries * System queries are now able to be deleted from view, but will remain in the backend for retrieval, if necessary * FEATURE/DEV: Add rake commands for query soft deletion * query:list_hidden - Shows a list of hidden queries * query:hide_all[only_default] - Hides all queries, w/ boolean arg to hide only default ones * query:unhide[id] - Unhides a query by id * query:unhide_all[exclude_default] - Unhides all hidden queries, w/ boolean arg to exclude default ones * Remove rails loggers * UX/DEV: Update query rake tasks to be more user friendly * Split query:hide_all[only_default] into two tasks: * query:hide_all - Hides all queries * query:hide_all:only_default - Hide only default queries * Split query:unhide_all[exclude_default] into two tasks: * query:unhide_all - Unhides all hidden queries * query:unhide_all:exclude_default - Unhides all non-default queries * Rename file to match task name * UX: query:unhide can accept multiple arguments * Example: rake query:unhide[-5,-6,-7,3,5,6,-13,-14,-10] * UX: Update query rake tasks to output cleaner messages * Remove unneeded comment * DEV: Keep only necessary rake tasks, use more specific naming * UX/DEV: Add rake task for hard deletion, better console logs * User is able to hard delete a query only if it is hidden, otherwise output a message stating so * Add commented examples above each task * Add rainbow support for more readable console logs * Successful messages will display green, failures display red, additional info displays yellow * Separate multiple queries with spaces instead of lines * DEV: Remove rainbow colorizing in console logs * Rainbow is a dependency of rubocop and it may go away in the future * Rainbow is only used for dev and test environments * DEV: Add Rails engine to enable rake tasks to be loaded at runtime * DEV: Favor require - load files only if they are not already loaded * SPEC: Add tests for data_explorer[id] rake command * Test if a single query is hidden correctly * Expect length of query list to not be modified * Expect array of hidden queries to have exactly 1 element * Expect that one element to have the same ID as the one invoked to be hidden * Test if multiple queries are hidden correctly * Expect length of query list to not be modified * Expect array of hidden queries to have the number of elements equal to the number invoked to be hidden * Expect the elements to have the same ID as the ones invoked to be hidden * Test if a query exists in PluginStore * Expect query list to be empty * DEV: Clear pre-existing tasks before redefining * This prevents double invocation when user invokes the task once * SPEC: Add tests for unhide_query rake task * Test if a single query unhides correctly * Expect length of query list to not be modified * Expect array of hidden queries to have exactly 1 element after unhiding 1 of 2 queries * Expect remaining element to be hidden * Test if multiple queries unhide correctly * Expect length of query list to not be modified * Expect array of hidden queries to have exactly 1 element after unhiding 3 of 4 queries * Expect remaining element to be hidden * Test if a query exists in PluginStore * Expect query list to not be modified * SPEC: Add tests for hard_delete rake task * Test if a single query hard deletes correctly * Expect length of query list to be shorter by 1 * Expect array of hidden queries to have exactly 1 element after hard deleting 1 of 2 queries * Expect 1 remaining hidden element * Test if multiple queries hard delete correctly * Expect length of query list to be shorter by 3 after hard deleting 3 of 4 queries * Expect array of hidden queries to have exactly 1 element after hard deleting 3 of 4 queries * Expect 1 remaining hidden element * Test if a query exists in PluginStore * Expect hidden query list to not be modified * Test if a query is not hidden * Expect query list to not be modified * UX: Favor newline char in place of puts for logs * Condensed console logs to output newline char instead of another puts statement (reduces number of lines used significantly)
2020-07-29 02:50:24 -04:00
# Soft deletion: PluginStoreRow should not be modified
expect(DataExplorer::Query.all.length).to eq(4)
# Array of hidden queries should have exactly 1 element
expect(hidden_queries.length).to eq(1)
# There should be one remaining element that is still hidden
expect(hidden_queries[0].id).to eq(3)
end
context 'query does not exist in PluginStore' do
it 'should not unhide the query' do
DataExplorer::Query.destroy_all
make_query('SELECT 1 as value', id: 1, name: 'A', hidden: true)
make_query('SELECT 1 as value', id: 2, name: 'B', hidden: true)
# rake data_explorer:unhide_query[3] => try to unhide query with ID 3
2022-02-01 15:38:24 -05:00
silence_stdout { Rake::Task['data_explorer:unhide_query'].invoke(3) }
FEATURE: Add ability to soft delete (hide) queries and revert deletion with rake tasks (#54) * FEATURE: Add hide button (toggleable) for all queries (frontend only) * Switches between hide/unhide on click * Works almost like the delete button, but toggles between the query's hidden attribute instead * So far this is only a frontend feature, the backend implementation still needs work * Revert "FEATURE: Add hide button (toggleable) for all queries (frontend only)" This reverts commit a8771d2ad57083a91b7130df807fa54c26205d11. REVERT: Remove button that hides queries (frontend) * Prepare for migration of old frontend logic to backend * We are going to reuse the existing delete button, but change its backend logic to enable soft deletion. From the user's perspective nothing will change, but any deletion mistakes can be reverted. * DEV: Hide user queries upon deletion, but keep them in store * Creating a new query will set its hidden attribute to false by default * Deleting a user-made query will not delete it from the store, but set its hidden attribute to true * User queries will not be indexed if they are hidden * Undeleting a query will unhide it, and will be indexed * Updating a hidden query will unhide it, and will be indexed * SPEC: Add spec for hidden/deleted queries * Hidden queries should not be shown * FEATURE: Add ability to delete/hide system queries * System queries are now able to be deleted from view, but will remain in the backend for retrieval, if necessary * FEATURE/DEV: Add rake commands for query soft deletion * query:list_hidden - Shows a list of hidden queries * query:hide_all[only_default] - Hides all queries, w/ boolean arg to hide only default ones * query:unhide[id] - Unhides a query by id * query:unhide_all[exclude_default] - Unhides all hidden queries, w/ boolean arg to exclude default ones * Remove rails loggers * UX/DEV: Update query rake tasks to be more user friendly * Split query:hide_all[only_default] into two tasks: * query:hide_all - Hides all queries * query:hide_all:only_default - Hide only default queries * Split query:unhide_all[exclude_default] into two tasks: * query:unhide_all - Unhides all hidden queries * query:unhide_all:exclude_default - Unhides all non-default queries * Rename file to match task name * UX: query:unhide can accept multiple arguments * Example: rake query:unhide[-5,-6,-7,3,5,6,-13,-14,-10] * UX: Update query rake tasks to output cleaner messages * Remove unneeded comment * DEV: Keep only necessary rake tasks, use more specific naming * UX/DEV: Add rake task for hard deletion, better console logs * User is able to hard delete a query only if it is hidden, otherwise output a message stating so * Add commented examples above each task * Add rainbow support for more readable console logs * Successful messages will display green, failures display red, additional info displays yellow * Separate multiple queries with spaces instead of lines * DEV: Remove rainbow colorizing in console logs * Rainbow is a dependency of rubocop and it may go away in the future * Rainbow is only used for dev and test environments * DEV: Add Rails engine to enable rake tasks to be loaded at runtime * DEV: Favor require - load files only if they are not already loaded * SPEC: Add tests for data_explorer[id] rake command * Test if a single query is hidden correctly * Expect length of query list to not be modified * Expect array of hidden queries to have exactly 1 element * Expect that one element to have the same ID as the one invoked to be hidden * Test if multiple queries are hidden correctly * Expect length of query list to not be modified * Expect array of hidden queries to have the number of elements equal to the number invoked to be hidden * Expect the elements to have the same ID as the ones invoked to be hidden * Test if a query exists in PluginStore * Expect query list to be empty * DEV: Clear pre-existing tasks before redefining * This prevents double invocation when user invokes the task once * SPEC: Add tests for unhide_query rake task * Test if a single query unhides correctly * Expect length of query list to not be modified * Expect array of hidden queries to have exactly 1 element after unhiding 1 of 2 queries * Expect remaining element to be hidden * Test if multiple queries unhide correctly * Expect length of query list to not be modified * Expect array of hidden queries to have exactly 1 element after unhiding 3 of 4 queries * Expect remaining element to be hidden * Test if a query exists in PluginStore * Expect query list to not be modified * SPEC: Add tests for hard_delete rake task * Test if a single query hard deletes correctly * Expect length of query list to be shorter by 1 * Expect array of hidden queries to have exactly 1 element after hard deleting 1 of 2 queries * Expect 1 remaining hidden element * Test if multiple queries hard delete correctly * Expect length of query list to be shorter by 3 after hard deleting 3 of 4 queries * Expect array of hidden queries to have exactly 1 element after hard deleting 3 of 4 queries * Expect 1 remaining hidden element * Test if a query exists in PluginStore * Expect hidden query list to not be modified * Test if a query is not hidden * Expect query list to not be modified * UX: Favor newline char in place of puts for logs * Condensed console logs to output newline char instead of another puts statement (reduces number of lines used significantly)
2020-07-29 02:50:24 -04:00
# rake data_explorer:unhide_query[3,4,5] => try to unhide queries with IDs 3, 4 and 5
2022-02-01 15:38:24 -05:00
silence_stdout { Rake::Task['data_explorer:unhide_query'].invoke(3, 4, 5) }
FEATURE: Add ability to soft delete (hide) queries and revert deletion with rake tasks (#54) * FEATURE: Add hide button (toggleable) for all queries (frontend only) * Switches between hide/unhide on click * Works almost like the delete button, but toggles between the query's hidden attribute instead * So far this is only a frontend feature, the backend implementation still needs work * Revert "FEATURE: Add hide button (toggleable) for all queries (frontend only)" This reverts commit a8771d2ad57083a91b7130df807fa54c26205d11. REVERT: Remove button that hides queries (frontend) * Prepare for migration of old frontend logic to backend * We are going to reuse the existing delete button, but change its backend logic to enable soft deletion. From the user's perspective nothing will change, but any deletion mistakes can be reverted. * DEV: Hide user queries upon deletion, but keep them in store * Creating a new query will set its hidden attribute to false by default * Deleting a user-made query will not delete it from the store, but set its hidden attribute to true * User queries will not be indexed if they are hidden * Undeleting a query will unhide it, and will be indexed * Updating a hidden query will unhide it, and will be indexed * SPEC: Add spec for hidden/deleted queries * Hidden queries should not be shown * FEATURE: Add ability to delete/hide system queries * System queries are now able to be deleted from view, but will remain in the backend for retrieval, if necessary * FEATURE/DEV: Add rake commands for query soft deletion * query:list_hidden - Shows a list of hidden queries * query:hide_all[only_default] - Hides all queries, w/ boolean arg to hide only default ones * query:unhide[id] - Unhides a query by id * query:unhide_all[exclude_default] - Unhides all hidden queries, w/ boolean arg to exclude default ones * Remove rails loggers * UX/DEV: Update query rake tasks to be more user friendly * Split query:hide_all[only_default] into two tasks: * query:hide_all - Hides all queries * query:hide_all:only_default - Hide only default queries * Split query:unhide_all[exclude_default] into two tasks: * query:unhide_all - Unhides all hidden queries * query:unhide_all:exclude_default - Unhides all non-default queries * Rename file to match task name * UX: query:unhide can accept multiple arguments * Example: rake query:unhide[-5,-6,-7,3,5,6,-13,-14,-10] * UX: Update query rake tasks to output cleaner messages * Remove unneeded comment * DEV: Keep only necessary rake tasks, use more specific naming * UX/DEV: Add rake task for hard deletion, better console logs * User is able to hard delete a query only if it is hidden, otherwise output a message stating so * Add commented examples above each task * Add rainbow support for more readable console logs * Successful messages will display green, failures display red, additional info displays yellow * Separate multiple queries with spaces instead of lines * DEV: Remove rainbow colorizing in console logs * Rainbow is a dependency of rubocop and it may go away in the future * Rainbow is only used for dev and test environments * DEV: Add Rails engine to enable rake tasks to be loaded at runtime * DEV: Favor require - load files only if they are not already loaded * SPEC: Add tests for data_explorer[id] rake command * Test if a single query is hidden correctly * Expect length of query list to not be modified * Expect array of hidden queries to have exactly 1 element * Expect that one element to have the same ID as the one invoked to be hidden * Test if multiple queries are hidden correctly * Expect length of query list to not be modified * Expect array of hidden queries to have the number of elements equal to the number invoked to be hidden * Expect the elements to have the same ID as the ones invoked to be hidden * Test if a query exists in PluginStore * Expect query list to be empty * DEV: Clear pre-existing tasks before redefining * This prevents double invocation when user invokes the task once * SPEC: Add tests for unhide_query rake task * Test if a single query unhides correctly * Expect length of query list to not be modified * Expect array of hidden queries to have exactly 1 element after unhiding 1 of 2 queries * Expect remaining element to be hidden * Test if multiple queries unhide correctly * Expect length of query list to not be modified * Expect array of hidden queries to have exactly 1 element after unhiding 3 of 4 queries * Expect remaining element to be hidden * Test if a query exists in PluginStore * Expect query list to not be modified * SPEC: Add tests for hard_delete rake task * Test if a single query hard deletes correctly * Expect length of query list to be shorter by 1 * Expect array of hidden queries to have exactly 1 element after hard deleting 1 of 2 queries * Expect 1 remaining hidden element * Test if multiple queries hard delete correctly * Expect length of query list to be shorter by 3 after hard deleting 3 of 4 queries * Expect array of hidden queries to have exactly 1 element after hard deleting 3 of 4 queries * Expect 1 remaining hidden element * Test if a query exists in PluginStore * Expect hidden query list to not be modified * Test if a query is not hidden * Expect query list to not be modified * UX: Favor newline char in place of puts for logs * Condensed console logs to output newline char instead of another puts statement (reduces number of lines used significantly)
2020-07-29 02:50:24 -04:00
# Array of hidden queries shouldn't change
expect(hidden_queries.length).to eq(2)
end
end
end
describe '#hard_delete' do
it 'hard deletes a single query' do
DataExplorer::Query.destroy_all
make_query('SELECT 1 as value', id: 1, name: 'A', hidden: true)
make_query('SELECT 1 as value', id: 2, name: 'B', hidden: true)
# rake data_explorer:hard_delete[1] => hard delete query with ID 1
2022-02-01 15:38:24 -05:00
silence_stdout { Rake::Task['data_explorer:hard_delete'].invoke(1) }
FEATURE: Add ability to soft delete (hide) queries and revert deletion with rake tasks (#54) * FEATURE: Add hide button (toggleable) for all queries (frontend only) * Switches between hide/unhide on click * Works almost like the delete button, but toggles between the query's hidden attribute instead * So far this is only a frontend feature, the backend implementation still needs work * Revert "FEATURE: Add hide button (toggleable) for all queries (frontend only)" This reverts commit a8771d2ad57083a91b7130df807fa54c26205d11. REVERT: Remove button that hides queries (frontend) * Prepare for migration of old frontend logic to backend * We are going to reuse the existing delete button, but change its backend logic to enable soft deletion. From the user's perspective nothing will change, but any deletion mistakes can be reverted. * DEV: Hide user queries upon deletion, but keep them in store * Creating a new query will set its hidden attribute to false by default * Deleting a user-made query will not delete it from the store, but set its hidden attribute to true * User queries will not be indexed if they are hidden * Undeleting a query will unhide it, and will be indexed * Updating a hidden query will unhide it, and will be indexed * SPEC: Add spec for hidden/deleted queries * Hidden queries should not be shown * FEATURE: Add ability to delete/hide system queries * System queries are now able to be deleted from view, but will remain in the backend for retrieval, if necessary * FEATURE/DEV: Add rake commands for query soft deletion * query:list_hidden - Shows a list of hidden queries * query:hide_all[only_default] - Hides all queries, w/ boolean arg to hide only default ones * query:unhide[id] - Unhides a query by id * query:unhide_all[exclude_default] - Unhides all hidden queries, w/ boolean arg to exclude default ones * Remove rails loggers * UX/DEV: Update query rake tasks to be more user friendly * Split query:hide_all[only_default] into two tasks: * query:hide_all - Hides all queries * query:hide_all:only_default - Hide only default queries * Split query:unhide_all[exclude_default] into two tasks: * query:unhide_all - Unhides all hidden queries * query:unhide_all:exclude_default - Unhides all non-default queries * Rename file to match task name * UX: query:unhide can accept multiple arguments * Example: rake query:unhide[-5,-6,-7,3,5,6,-13,-14,-10] * UX: Update query rake tasks to output cleaner messages * Remove unneeded comment * DEV: Keep only necessary rake tasks, use more specific naming * UX/DEV: Add rake task for hard deletion, better console logs * User is able to hard delete a query only if it is hidden, otherwise output a message stating so * Add commented examples above each task * Add rainbow support for more readable console logs * Successful messages will display green, failures display red, additional info displays yellow * Separate multiple queries with spaces instead of lines * DEV: Remove rainbow colorizing in console logs * Rainbow is a dependency of rubocop and it may go away in the future * Rainbow is only used for dev and test environments * DEV: Add Rails engine to enable rake tasks to be loaded at runtime * DEV: Favor require - load files only if they are not already loaded * SPEC: Add tests for data_explorer[id] rake command * Test if a single query is hidden correctly * Expect length of query list to not be modified * Expect array of hidden queries to have exactly 1 element * Expect that one element to have the same ID as the one invoked to be hidden * Test if multiple queries are hidden correctly * Expect length of query list to not be modified * Expect array of hidden queries to have the number of elements equal to the number invoked to be hidden * Expect the elements to have the same ID as the ones invoked to be hidden * Test if a query exists in PluginStore * Expect query list to be empty * DEV: Clear pre-existing tasks before redefining * This prevents double invocation when user invokes the task once * SPEC: Add tests for unhide_query rake task * Test if a single query unhides correctly * Expect length of query list to not be modified * Expect array of hidden queries to have exactly 1 element after unhiding 1 of 2 queries * Expect remaining element to be hidden * Test if multiple queries unhide correctly * Expect length of query list to not be modified * Expect array of hidden queries to have exactly 1 element after unhiding 3 of 4 queries * Expect remaining element to be hidden * Test if a query exists in PluginStore * Expect query list to not be modified * SPEC: Add tests for hard_delete rake task * Test if a single query hard deletes correctly * Expect length of query list to be shorter by 1 * Expect array of hidden queries to have exactly 1 element after hard deleting 1 of 2 queries * Expect 1 remaining hidden element * Test if multiple queries hard delete correctly * Expect length of query list to be shorter by 3 after hard deleting 3 of 4 queries * Expect array of hidden queries to have exactly 1 element after hard deleting 3 of 4 queries * Expect 1 remaining hidden element * Test if a query exists in PluginStore * Expect hidden query list to not be modified * Test if a query is not hidden * Expect query list to not be modified * UX: Favor newline char in place of puts for logs * Condensed console logs to output newline char instead of another puts statement (reduces number of lines used significantly)
2020-07-29 02:50:24 -04:00
# Hard deletion: query list should be shorter by 1
expect(DataExplorer::Query.all.length).to eq(1)
# Array of hidden queries should have exactly 1 element
expect(hidden_queries.length).to eq(1)
# There should be one remaining hidden element
expect(hidden_queries[0].id).to eq(2)
end
it 'hard deletes multiple queries' do
DataExplorer::Query.destroy_all
make_query('SELECT 1 as value', id: 1, name: 'A', hidden: true)
make_query('SELECT 1 as value', id: 2, name: 'B', hidden: true)
make_query('SELECT 1 as value', id: 3, name: 'C', hidden: true)
make_query('SELECT 1 as value', id: 4, name: 'D', hidden: true)
# rake data_explorer:hard_delete[1,2,4] => hard delete queries with IDs 1, 2 and 4
2022-02-01 15:38:24 -05:00
silence_stdout { Rake::Task['data_explorer:hard_delete'].invoke(1, 2, 4) }
FEATURE: Add ability to soft delete (hide) queries and revert deletion with rake tasks (#54) * FEATURE: Add hide button (toggleable) for all queries (frontend only) * Switches between hide/unhide on click * Works almost like the delete button, but toggles between the query's hidden attribute instead * So far this is only a frontend feature, the backend implementation still needs work * Revert "FEATURE: Add hide button (toggleable) for all queries (frontend only)" This reverts commit a8771d2ad57083a91b7130df807fa54c26205d11. REVERT: Remove button that hides queries (frontend) * Prepare for migration of old frontend logic to backend * We are going to reuse the existing delete button, but change its backend logic to enable soft deletion. From the user's perspective nothing will change, but any deletion mistakes can be reverted. * DEV: Hide user queries upon deletion, but keep them in store * Creating a new query will set its hidden attribute to false by default * Deleting a user-made query will not delete it from the store, but set its hidden attribute to true * User queries will not be indexed if they are hidden * Undeleting a query will unhide it, and will be indexed * Updating a hidden query will unhide it, and will be indexed * SPEC: Add spec for hidden/deleted queries * Hidden queries should not be shown * FEATURE: Add ability to delete/hide system queries * System queries are now able to be deleted from view, but will remain in the backend for retrieval, if necessary * FEATURE/DEV: Add rake commands for query soft deletion * query:list_hidden - Shows a list of hidden queries * query:hide_all[only_default] - Hides all queries, w/ boolean arg to hide only default ones * query:unhide[id] - Unhides a query by id * query:unhide_all[exclude_default] - Unhides all hidden queries, w/ boolean arg to exclude default ones * Remove rails loggers * UX/DEV: Update query rake tasks to be more user friendly * Split query:hide_all[only_default] into two tasks: * query:hide_all - Hides all queries * query:hide_all:only_default - Hide only default queries * Split query:unhide_all[exclude_default] into two tasks: * query:unhide_all - Unhides all hidden queries * query:unhide_all:exclude_default - Unhides all non-default queries * Rename file to match task name * UX: query:unhide can accept multiple arguments * Example: rake query:unhide[-5,-6,-7,3,5,6,-13,-14,-10] * UX: Update query rake tasks to output cleaner messages * Remove unneeded comment * DEV: Keep only necessary rake tasks, use more specific naming * UX/DEV: Add rake task for hard deletion, better console logs * User is able to hard delete a query only if it is hidden, otherwise output a message stating so * Add commented examples above each task * Add rainbow support for more readable console logs * Successful messages will display green, failures display red, additional info displays yellow * Separate multiple queries with spaces instead of lines * DEV: Remove rainbow colorizing in console logs * Rainbow is a dependency of rubocop and it may go away in the future * Rainbow is only used for dev and test environments * DEV: Add Rails engine to enable rake tasks to be loaded at runtime * DEV: Favor require - load files only if they are not already loaded * SPEC: Add tests for data_explorer[id] rake command * Test if a single query is hidden correctly * Expect length of query list to not be modified * Expect array of hidden queries to have exactly 1 element * Expect that one element to have the same ID as the one invoked to be hidden * Test if multiple queries are hidden correctly * Expect length of query list to not be modified * Expect array of hidden queries to have the number of elements equal to the number invoked to be hidden * Expect the elements to have the same ID as the ones invoked to be hidden * Test if a query exists in PluginStore * Expect query list to be empty * DEV: Clear pre-existing tasks before redefining * This prevents double invocation when user invokes the task once * SPEC: Add tests for unhide_query rake task * Test if a single query unhides correctly * Expect length of query list to not be modified * Expect array of hidden queries to have exactly 1 element after unhiding 1 of 2 queries * Expect remaining element to be hidden * Test if multiple queries unhide correctly * Expect length of query list to not be modified * Expect array of hidden queries to have exactly 1 element after unhiding 3 of 4 queries * Expect remaining element to be hidden * Test if a query exists in PluginStore * Expect query list to not be modified * SPEC: Add tests for hard_delete rake task * Test if a single query hard deletes correctly * Expect length of query list to be shorter by 1 * Expect array of hidden queries to have exactly 1 element after hard deleting 1 of 2 queries * Expect 1 remaining hidden element * Test if multiple queries hard delete correctly * Expect length of query list to be shorter by 3 after hard deleting 3 of 4 queries * Expect array of hidden queries to have exactly 1 element after hard deleting 3 of 4 queries * Expect 1 remaining hidden element * Test if a query exists in PluginStore * Expect hidden query list to not be modified * Test if a query is not hidden * Expect query list to not be modified * UX: Favor newline char in place of puts for logs * Condensed console logs to output newline char instead of another puts statement (reduces number of lines used significantly)
2020-07-29 02:50:24 -04:00
# Hard deletion: query list should be shorter by 3
expect(DataExplorer::Query.all.length).to eq(1)
# Array of hidden queries should have exactly 1 element
expect(hidden_queries.length).to eq(1)
# There should be one remaining hidden element
expect(hidden_queries[0].id).to eq(3)
end
context 'query does not exist in PluginStore' do
it 'should not hard delete the query' do
DataExplorer::Query.destroy_all
make_query('SELECT 1 as value', id: 1, name: 'A', hidden: true)
make_query('SELECT 1 as value', id: 2, name: 'B', hidden: true)
# rake data_explorer:hard_delete[3] => try to hard delete query with ID 3
2022-02-01 15:38:24 -05:00
silence_stdout { Rake::Task['data_explorer:hard_delete'].invoke(3) }
FEATURE: Add ability to soft delete (hide) queries and revert deletion with rake tasks (#54) * FEATURE: Add hide button (toggleable) for all queries (frontend only) * Switches between hide/unhide on click * Works almost like the delete button, but toggles between the query's hidden attribute instead * So far this is only a frontend feature, the backend implementation still needs work * Revert "FEATURE: Add hide button (toggleable) for all queries (frontend only)" This reverts commit a8771d2ad57083a91b7130df807fa54c26205d11. REVERT: Remove button that hides queries (frontend) * Prepare for migration of old frontend logic to backend * We are going to reuse the existing delete button, but change its backend logic to enable soft deletion. From the user's perspective nothing will change, but any deletion mistakes can be reverted. * DEV: Hide user queries upon deletion, but keep them in store * Creating a new query will set its hidden attribute to false by default * Deleting a user-made query will not delete it from the store, but set its hidden attribute to true * User queries will not be indexed if they are hidden * Undeleting a query will unhide it, and will be indexed * Updating a hidden query will unhide it, and will be indexed * SPEC: Add spec for hidden/deleted queries * Hidden queries should not be shown * FEATURE: Add ability to delete/hide system queries * System queries are now able to be deleted from view, but will remain in the backend for retrieval, if necessary * FEATURE/DEV: Add rake commands for query soft deletion * query:list_hidden - Shows a list of hidden queries * query:hide_all[only_default] - Hides all queries, w/ boolean arg to hide only default ones * query:unhide[id] - Unhides a query by id * query:unhide_all[exclude_default] - Unhides all hidden queries, w/ boolean arg to exclude default ones * Remove rails loggers * UX/DEV: Update query rake tasks to be more user friendly * Split query:hide_all[only_default] into two tasks: * query:hide_all - Hides all queries * query:hide_all:only_default - Hide only default queries * Split query:unhide_all[exclude_default] into two tasks: * query:unhide_all - Unhides all hidden queries * query:unhide_all:exclude_default - Unhides all non-default queries * Rename file to match task name * UX: query:unhide can accept multiple arguments * Example: rake query:unhide[-5,-6,-7,3,5,6,-13,-14,-10] * UX: Update query rake tasks to output cleaner messages * Remove unneeded comment * DEV: Keep only necessary rake tasks, use more specific naming * UX/DEV: Add rake task for hard deletion, better console logs * User is able to hard delete a query only if it is hidden, otherwise output a message stating so * Add commented examples above each task * Add rainbow support for more readable console logs * Successful messages will display green, failures display red, additional info displays yellow * Separate multiple queries with spaces instead of lines * DEV: Remove rainbow colorizing in console logs * Rainbow is a dependency of rubocop and it may go away in the future * Rainbow is only used for dev and test environments * DEV: Add Rails engine to enable rake tasks to be loaded at runtime * DEV: Favor require - load files only if they are not already loaded * SPEC: Add tests for data_explorer[id] rake command * Test if a single query is hidden correctly * Expect length of query list to not be modified * Expect array of hidden queries to have exactly 1 element * Expect that one element to have the same ID as the one invoked to be hidden * Test if multiple queries are hidden correctly * Expect length of query list to not be modified * Expect array of hidden queries to have the number of elements equal to the number invoked to be hidden * Expect the elements to have the same ID as the ones invoked to be hidden * Test if a query exists in PluginStore * Expect query list to be empty * DEV: Clear pre-existing tasks before redefining * This prevents double invocation when user invokes the task once * SPEC: Add tests for unhide_query rake task * Test if a single query unhides correctly * Expect length of query list to not be modified * Expect array of hidden queries to have exactly 1 element after unhiding 1 of 2 queries * Expect remaining element to be hidden * Test if multiple queries unhide correctly * Expect length of query list to not be modified * Expect array of hidden queries to have exactly 1 element after unhiding 3 of 4 queries * Expect remaining element to be hidden * Test if a query exists in PluginStore * Expect query list to not be modified * SPEC: Add tests for hard_delete rake task * Test if a single query hard deletes correctly * Expect length of query list to be shorter by 1 * Expect array of hidden queries to have exactly 1 element after hard deleting 1 of 2 queries * Expect 1 remaining hidden element * Test if multiple queries hard delete correctly * Expect length of query list to be shorter by 3 after hard deleting 3 of 4 queries * Expect array of hidden queries to have exactly 1 element after hard deleting 3 of 4 queries * Expect 1 remaining hidden element * Test if a query exists in PluginStore * Expect hidden query list to not be modified * Test if a query is not hidden * Expect query list to not be modified * UX: Favor newline char in place of puts for logs * Condensed console logs to output newline char instead of another puts statement (reduces number of lines used significantly)
2020-07-29 02:50:24 -04:00
# rake data_explorer:hard_delete[3,4,5] => try to hard delete queries with IDs 3, 4 and 5
2022-02-01 15:38:24 -05:00
silence_stdout { Rake::Task['data_explorer:hard_delete'].invoke(3, 4, 5) }
FEATURE: Add ability to soft delete (hide) queries and revert deletion with rake tasks (#54) * FEATURE: Add hide button (toggleable) for all queries (frontend only) * Switches between hide/unhide on click * Works almost like the delete button, but toggles between the query's hidden attribute instead * So far this is only a frontend feature, the backend implementation still needs work * Revert "FEATURE: Add hide button (toggleable) for all queries (frontend only)" This reverts commit a8771d2ad57083a91b7130df807fa54c26205d11. REVERT: Remove button that hides queries (frontend) * Prepare for migration of old frontend logic to backend * We are going to reuse the existing delete button, but change its backend logic to enable soft deletion. From the user's perspective nothing will change, but any deletion mistakes can be reverted. * DEV: Hide user queries upon deletion, but keep them in store * Creating a new query will set its hidden attribute to false by default * Deleting a user-made query will not delete it from the store, but set its hidden attribute to true * User queries will not be indexed if they are hidden * Undeleting a query will unhide it, and will be indexed * Updating a hidden query will unhide it, and will be indexed * SPEC: Add spec for hidden/deleted queries * Hidden queries should not be shown * FEATURE: Add ability to delete/hide system queries * System queries are now able to be deleted from view, but will remain in the backend for retrieval, if necessary * FEATURE/DEV: Add rake commands for query soft deletion * query:list_hidden - Shows a list of hidden queries * query:hide_all[only_default] - Hides all queries, w/ boolean arg to hide only default ones * query:unhide[id] - Unhides a query by id * query:unhide_all[exclude_default] - Unhides all hidden queries, w/ boolean arg to exclude default ones * Remove rails loggers * UX/DEV: Update query rake tasks to be more user friendly * Split query:hide_all[only_default] into two tasks: * query:hide_all - Hides all queries * query:hide_all:only_default - Hide only default queries * Split query:unhide_all[exclude_default] into two tasks: * query:unhide_all - Unhides all hidden queries * query:unhide_all:exclude_default - Unhides all non-default queries * Rename file to match task name * UX: query:unhide can accept multiple arguments * Example: rake query:unhide[-5,-6,-7,3,5,6,-13,-14,-10] * UX: Update query rake tasks to output cleaner messages * Remove unneeded comment * DEV: Keep only necessary rake tasks, use more specific naming * UX/DEV: Add rake task for hard deletion, better console logs * User is able to hard delete a query only if it is hidden, otherwise output a message stating so * Add commented examples above each task * Add rainbow support for more readable console logs * Successful messages will display green, failures display red, additional info displays yellow * Separate multiple queries with spaces instead of lines * DEV: Remove rainbow colorizing in console logs * Rainbow is a dependency of rubocop and it may go away in the future * Rainbow is only used for dev and test environments * DEV: Add Rails engine to enable rake tasks to be loaded at runtime * DEV: Favor require - load files only if they are not already loaded * SPEC: Add tests for data_explorer[id] rake command * Test if a single query is hidden correctly * Expect length of query list to not be modified * Expect array of hidden queries to have exactly 1 element * Expect that one element to have the same ID as the one invoked to be hidden * Test if multiple queries are hidden correctly * Expect length of query list to not be modified * Expect array of hidden queries to have the number of elements equal to the number invoked to be hidden * Expect the elements to have the same ID as the ones invoked to be hidden * Test if a query exists in PluginStore * Expect query list to be empty * DEV: Clear pre-existing tasks before redefining * This prevents double invocation when user invokes the task once * SPEC: Add tests for unhide_query rake task * Test if a single query unhides correctly * Expect length of query list to not be modified * Expect array of hidden queries to have exactly 1 element after unhiding 1 of 2 queries * Expect remaining element to be hidden * Test if multiple queries unhide correctly * Expect length of query list to not be modified * Expect array of hidden queries to have exactly 1 element after unhiding 3 of 4 queries * Expect remaining element to be hidden * Test if a query exists in PluginStore * Expect query list to not be modified * SPEC: Add tests for hard_delete rake task * Test if a single query hard deletes correctly * Expect length of query list to be shorter by 1 * Expect array of hidden queries to have exactly 1 element after hard deleting 1 of 2 queries * Expect 1 remaining hidden element * Test if multiple queries hard delete correctly * Expect length of query list to be shorter by 3 after hard deleting 3 of 4 queries * Expect array of hidden queries to have exactly 1 element after hard deleting 3 of 4 queries * Expect 1 remaining hidden element * Test if a query exists in PluginStore * Expect hidden query list to not be modified * Test if a query is not hidden * Expect query list to not be modified * UX: Favor newline char in place of puts for logs * Condensed console logs to output newline char instead of another puts statement (reduces number of lines used significantly)
2020-07-29 02:50:24 -04:00
# Array of hidden queries shouldn't change
expect(hidden_queries.length).to eq(2)
end
end
context 'query is not hidden' do
it 'should not hard delete the query' do
DataExplorer::Query.destroy_all
make_query('SELECT 1 as value', id: 1, name: 'A')
# rake data_explorer:hard_delete[1] => try to hard delete query with ID 1
2022-02-01 15:38:24 -05:00
silence_stdout { Rake::Task['data_explorer:hard_delete'].invoke(1) }
FEATURE: Add ability to soft delete (hide) queries and revert deletion with rake tasks (#54) * FEATURE: Add hide button (toggleable) for all queries (frontend only) * Switches between hide/unhide on click * Works almost like the delete button, but toggles between the query's hidden attribute instead * So far this is only a frontend feature, the backend implementation still needs work * Revert "FEATURE: Add hide button (toggleable) for all queries (frontend only)" This reverts commit a8771d2ad57083a91b7130df807fa54c26205d11. REVERT: Remove button that hides queries (frontend) * Prepare for migration of old frontend logic to backend * We are going to reuse the existing delete button, but change its backend logic to enable soft deletion. From the user's perspective nothing will change, but any deletion mistakes can be reverted. * DEV: Hide user queries upon deletion, but keep them in store * Creating a new query will set its hidden attribute to false by default * Deleting a user-made query will not delete it from the store, but set its hidden attribute to true * User queries will not be indexed if they are hidden * Undeleting a query will unhide it, and will be indexed * Updating a hidden query will unhide it, and will be indexed * SPEC: Add spec for hidden/deleted queries * Hidden queries should not be shown * FEATURE: Add ability to delete/hide system queries * System queries are now able to be deleted from view, but will remain in the backend for retrieval, if necessary * FEATURE/DEV: Add rake commands for query soft deletion * query:list_hidden - Shows a list of hidden queries * query:hide_all[only_default] - Hides all queries, w/ boolean arg to hide only default ones * query:unhide[id] - Unhides a query by id * query:unhide_all[exclude_default] - Unhides all hidden queries, w/ boolean arg to exclude default ones * Remove rails loggers * UX/DEV: Update query rake tasks to be more user friendly * Split query:hide_all[only_default] into two tasks: * query:hide_all - Hides all queries * query:hide_all:only_default - Hide only default queries * Split query:unhide_all[exclude_default] into two tasks: * query:unhide_all - Unhides all hidden queries * query:unhide_all:exclude_default - Unhides all non-default queries * Rename file to match task name * UX: query:unhide can accept multiple arguments * Example: rake query:unhide[-5,-6,-7,3,5,6,-13,-14,-10] * UX: Update query rake tasks to output cleaner messages * Remove unneeded comment * DEV: Keep only necessary rake tasks, use more specific naming * UX/DEV: Add rake task for hard deletion, better console logs * User is able to hard delete a query only if it is hidden, otherwise output a message stating so * Add commented examples above each task * Add rainbow support for more readable console logs * Successful messages will display green, failures display red, additional info displays yellow * Separate multiple queries with spaces instead of lines * DEV: Remove rainbow colorizing in console logs * Rainbow is a dependency of rubocop and it may go away in the future * Rainbow is only used for dev and test environments * DEV: Add Rails engine to enable rake tasks to be loaded at runtime * DEV: Favor require - load files only if they are not already loaded * SPEC: Add tests for data_explorer[id] rake command * Test if a single query is hidden correctly * Expect length of query list to not be modified * Expect array of hidden queries to have exactly 1 element * Expect that one element to have the same ID as the one invoked to be hidden * Test if multiple queries are hidden correctly * Expect length of query list to not be modified * Expect array of hidden queries to have the number of elements equal to the number invoked to be hidden * Expect the elements to have the same ID as the ones invoked to be hidden * Test if a query exists in PluginStore * Expect query list to be empty * DEV: Clear pre-existing tasks before redefining * This prevents double invocation when user invokes the task once * SPEC: Add tests for unhide_query rake task * Test if a single query unhides correctly * Expect length of query list to not be modified * Expect array of hidden queries to have exactly 1 element after unhiding 1 of 2 queries * Expect remaining element to be hidden * Test if multiple queries unhide correctly * Expect length of query list to not be modified * Expect array of hidden queries to have exactly 1 element after unhiding 3 of 4 queries * Expect remaining element to be hidden * Test if a query exists in PluginStore * Expect query list to not be modified * SPEC: Add tests for hard_delete rake task * Test if a single query hard deletes correctly * Expect length of query list to be shorter by 1 * Expect array of hidden queries to have exactly 1 element after hard deleting 1 of 2 queries * Expect 1 remaining hidden element * Test if multiple queries hard delete correctly * Expect length of query list to be shorter by 3 after hard deleting 3 of 4 queries * Expect array of hidden queries to have exactly 1 element after hard deleting 3 of 4 queries * Expect 1 remaining hidden element * Test if a query exists in PluginStore * Expect hidden query list to not be modified * Test if a query is not hidden * Expect query list to not be modified * UX: Favor newline char in place of puts for logs * Condensed console logs to output newline char instead of another puts statement (reduces number of lines used significantly)
2020-07-29 02:50:24 -04:00
# List of queries shouldn't change
expect(DataExplorer::Query.all.length).to eq(1)
end
end
end
end