DEV: Resolve some template linting issues (#123)

Some larger issues still remain, but this is a good first step

Gemfile.lock

@@ -31,4 +31,4 @@ DEPENDENCIES
   rubocop-discourse
 
 BUNDLED WITH
-   2.2.7
+   2.2.15

assets/javascripts/discourse/templates/admin/plugins-explorer.hbs

@@ -42,9 +42,10 @@
             {{else}}
               <div class="name">
                 {{d-button action=(action "goHome") icon="chevron-left" class="previous"}}
-                <h1>{{selectedItem.name}}
+                <h1>
+                  {{selectedItem.name}}
                   {{#unless editDisabled}}
-                    <a {{action "editName" class="edit-query-name"}}>{{d-icon "pencil-alt"}}</a>
+                    <a href {{action "editName" class="edit-query-name"}}>{{d-icon "pencil-alt"}}</a>
                   {{/unless}}
                 </h1>
               </div>

assets/javascripts/discourse/templates/components/explorer-schema-enuminfo.hbs

@@ -1,5 +1,5 @@
 {{#each enuminfo as |enum|}}
-  <li value="{{enum.value}}">
+  <li value={{enum.value}}>
     {{enum.name}}
   </li>
 {{/each}}

assets/javascripts/discourse/templates/components/explorer-schema-onetable.hbs

@@ -11,7 +11,7 @@
     <dl>
       {{#each table.columns as |col|}}
         <div>
-      <dt class="{{if col.sensitive "sensitive"}}" title="{{if col.sensitive (i18n "explorer.schema.sensitive")}}">
+          <dt class={{if col.sensitive "sensitive"}} title={{if col.sensitive (i18n "explorer.schema.sensitive")}}>
             {{#if col.sensitive}}
               {{d-icon "exclamation-triangle"}}
             {{/if}}

assets/javascripts/discourse/templates/components/explorer-schema.hbs

@@ -1,4 +1,4 @@
-<div class="{{if hideSchema "hidden"}}">
+<div class={{if hideSchema "hidden"}}>
   {{text-field value=filter placeholderKey="explorer.schema.filter"}}
   {{d-button action=(action "collapseSchema") icon="chevron-right" class="no-text"}}
   {{conditional-loading-spinner condition=loading}}

assets/javascripts/discourse/templates/components/json-file-uploader.hbs

@@ -1,7 +1,7 @@
 <div class="jsfu-shade-container">
   <div class="jsfu-file">
     <input id="js-file-input" type="file" style="display:none;" accept={{accept}}>
-    {{d-button class="fileSelect" action=(action "selectFile") class="" icon="upload" label="upload_selector.select_file"}}
+    {{d-button class="fileSelect" action=(action "selectFile") icon="upload" label="upload_selector.select_file"}}
     {{conditional-loading-spinner condition=loading size="small"}}
   </div>
   <div class="jsfu-separator">
@@ -12,5 +12,5 @@
   <div class="jsfu-paste">
     {{textarea value=value}}
   </div>
-  <div class="jsfu-shade {{if hover '' 'hidden'}}"><span class="text">{{d-icon "upload"}}</span></div>
+  <div class="jsfu-shade {{if hover "" "hidden"}}"><span class="text">{{d-icon "upload"}}</span></div>
 </div>

assets/javascripts/discourse/templates/components/share-report.hbs

@@ -3,9 +3,9 @@
   {{group}}
 </div>
 {{#if visible}}
-  <div class='popup'>
+  <div class="popup">
     <label>{{i18n "explorer.link"}} {{group}}</label>
-    <input type="text" value={{link}}/>
+    <input type="text" value={{link}}>
     {{d-button action="close" class="btn-flat close" icon="times" aria-label="share.close" title="share.close"}}
   </div>
 {{/if}}

assets/javascripts/discourse/templates/connectors/group-reports-nav-item/nav-item.hbs

@@ -1,3 +1,3 @@
-{{#link-to 'group.reports'}}
+{{#link-to "group.reports"}}
-  {{d-icon 'chart-bar'}}{{i18n 'group.reports'}}
+  {{d-icon "chart-bar"}}{{i18n "group.reports"}}
 {{/link-to}}

assets/javascripts/discourse/templates/explorer/badge.raw.hbs

@@ -1,6 +1,8 @@
 {{! source: badge-button component }}
 <a href="{{baseuri}}/badges/{{badge.id}}/{{badge.name}}"
   class="user-badge {{badge.badgeTypeClassName}}"
-   title="{{badge.display_name}}"
+  title={{badge.display_name}}
-   data-badge-name="{{badge.name}}">{{icon-or-image badge.icon}}
+  data-badge-name={{badge.name}}>
-<span class="badge-display-name">{{badge.display_name}}</span></a>
+  {{icon-or-image badge.icon}}
+  <span class="badge-display-name">{{badge.display_name}}</span>
+</a>

assets/javascripts/discourse/templates/explorer/html.raw.hbs

@@ -1 +1 @@
-{{{value}}}
+{{html-safe value}}

assets/javascripts/discourse/templates/explorer/post.raw.hbs

@@ -1,5 +1,5 @@
 {{#if post}}
-  <aside class="quote" data-post="{{post.post_number}}" data-topic="{{post.topic_id}}">
+  <aside class="quote" data-post={{post.post_number}} data-topic={{post.topic_id}}>
     <div class="title">
       <div class="quote-controls">
         <a href="/t/via-quote/{{post.topic_id}}/{{post.post_number}}"
@@ -13,7 +13,7 @@
     </div>
     <blockquote>
       <p>
-        {{{post.excerpt}}}
+        {{html-safe post.excerpt}}
       </p>
     </blockquote>
   </aside>

assets/javascripts/discourse/templates/explorer/topic.raw.hbs

@@ -1,6 +1,8 @@
 {{#if topic}}
-  <a href="{{baseuri}}/t/{{topic.slug}}/{{topic.id}}"
+  <a href="{{baseuri}}/t/{{topic.slug}}/{{topic.id}}">
-          >{{{topic.fancy_title}}}</a> ({{topic.posts_count}})
+    {{html-safe topic.fancy_title}}
+  </a>
+  ({{topic.posts_count}})
 {{else}}
   <a href="{{baseuri}}/t/{{id}}">{{id}}</a>
 {{/if}}

assets/javascripts/discourse/templates/explorer/url.raw.hbs

@@ -1 +1 @@
-<a href="{{href}}">{{target}}</a>
+<a href={{href}}>{{target}}</a>

assets/javascripts/discourse/templates/explorer/user.raw.hbs

@@ -1,6 +1,7 @@
 {{#if user}}
-  <a href="{{baseuri}}/u/{{user.username}}/activity"
+  <a href="{{baseuri}}/u/{{user.username}}/activity" data-user-card={{user.username}}>
-     data-user-card="{{user.username}}">{{avatar user imageSize="tiny"}} {{user.username}}</a>
+    {{avatar user imageSize="tiny"}} {{user.username}}
+  </a>
 {{else}}
   {{id}}
 {{/if}}

assets/javascripts/discourse/templates/group-reports-index.hbs

@@ -1,5 +1,5 @@
-<section class='user-content'>
+<section class="user-content">
-  <table class='group-reports'>
+  <table class="group-reports">
     <thead>
       <th>
         {{i18n "explorer.report_name"}}
@@ -11,12 +11,11 @@
         {{i18n "explorer.query_time"}}
       </th>
     </thead>
-    <tr></tr>
     <tbody>
       {{#each queries as |query|}}
         <tr>
           <td>
-            {{#link-to 'group.reports.show' group.name query.id}}{{query.name}}{{/link-to}}
+            {{#link-to "group.reports.show" group.name query.id}}{{query.name}}{{/link-to}}
           </td>
           <td>{{query.description}}</td>
           <td>

assets/javascripts/discourse/templates/group-reports-show.hbs

@@ -1,4 +1,4 @@
-<section class='user-content'>
+<section class="user-content">
   <h1>{{model.name}}</h1>
   <p>{{model.description}}</p>
   <form class="query-run" {{action "run" on="submit"}}>

assets/javascripts/discourse/templates/modal/import-query.hbs

@@ -1,10 +1,10 @@
 {{#d-modal-body title="explorer.import.modal"}}
   <form {{action "dummy" on="submit"}}>
-    <div class='modal-body'>
+    <div class="modal-body">
       {{json-file-uploader value=queryFile extension=".dcquery.json"}}
     </div>
     <div class="modal-footer">
-      {{d-button class='btn-primary' action='doImport' type='submit' disabled=notReady icon="plus" label='explorer.import.label'}}
+      {{d-button class="btn-primary" action="doImport" type="submit" disabled=notReady icon="plus" label="explorer.import.label"}}
     </div>
   </form>
 {{/d-modal-body}}