Discource-C
/
discourse-data-explorer
mirror of https://github.com/discourse/discourse-data-explorer.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

FIX: Fix ESLint issues and use d-icon instead of <i> tags

This commit is contained in:
Rishabh Nambiar 2018-08-30 21:08:12 +05:30
parent d5d933c2a8
commit 5a75b6c1e1
2 changed files with 8 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
assets/javascripts/discourse/controllers/admin-plugins-explorer.js.es6
View File

@ -120,11 +120,12 @@ export default Ember.Controller.extend({
}, },
sortByProperty(property) { sortByProperty(property) {
if (this.sortBy == `${property}:desc`){ if (this.sortBy[0] === `${property}:desc`) {
this.set('sortBy', [`${property}:asc`]);} this.set('sortBy', [`${property}:asc`]);
else { } else {
this.set('sortBy', [`${property}:desc`]); this.set('sortBy', [`${property}:desc`]);
}}, }
},
create() { create() {
const name = this.get("newQueryName").trim(); const name = this.get("newQueryName").trim();

6
assets/javascripts/discourse/templates/admin/plugins-explorer.hbs
View File

@ -148,15 +148,15 @@
<table class="recent-queries"> <table class="recent-queries">
<thead class="heading-container"> <thead class="heading-container">
<th {{action "sortByProperty" "name"}} class="col heading name"> <th {{action "sortByProperty" "name"}} class="col heading name">
<i class="fa fa-sort"></i> {{d-icon "sort"}}
{{i18n 'explorer.query_name'}} {{i18n 'explorer.query_name'}}
</th> </th>
<th {{action "sortByProperty" "username"}} class="col heading user"> <th {{action "sortByProperty" "username"}} class="col heading user">
<i class="fa fa-sort"></i> {{d-icon "sort"}}
{{i18n 'explorer.query_user'}} {{i18n 'explorer.query_user'}}
</th> </th>
<th {{action "sortByProperty" "last_run_at"}} class="col heading time"> <th {{action "sortByProperty" "last_run_at"}} class="col heading time">
<i class="fa fa-sort"></i> {{d-icon "sort"}}
{{i18n 'explorer.query_time'}} {{i18n 'explorer.query_time'}}
</th> </th>
</thead> </thead>