From 42b6dbbae2b4b3267670598d4ece756997d4d375 Mon Sep 17 00:00:00 2001 From: Rishabh Nambiar <5862206+rishabhnambiar@users.noreply.github.com> Date: Sun, 19 Aug 2018 10:24:53 +0530 Subject: [PATCH] FIX: Remove bad default query description and add placeholder instead --- .../javascripts/discourse/templates/admin/plugins-explorer.hbs | 2 +- config/locales/client.en.yml | 1 + plugin.rb | 2 +- 3 files changed, 3 insertions(+), 2 deletions(-) diff --git a/assets/javascripts/discourse/templates/admin/plugins-explorer.hbs b/assets/javascripts/discourse/templates/admin/plugins-explorer.hbs index 4a5149a..7231d3a 100644 --- a/assets/javascripts/discourse/templates/admin/plugins-explorer.hbs +++ b/assets/javascripts/discourse/templates/admin/plugins-explorer.hbs @@ -39,7 +39,7 @@ {{text-field value=selectedItem.name}}
- {{textarea value=selectedItem.description}} + {{textarea value=selectedItem.description placeholder=(i18n "explorer.description_placeholder")}}
{{else}}
diff --git a/config/locales/client.en.yml b/config/locales/client.en.yml index 1bf2ba0..baf1e50 100644 --- a/config/locales/client.en.yml +++ b/config/locales/client.en.yml @@ -26,6 +26,7 @@ en: title: "Data Explorer" create: "Create New" create_placeholder: "Query name..." + description_placeholder: "Enter a description here" import: label: "Import" modal: "Import A Query" diff --git a/plugin.rb b/plugin.rb index 7aa0f7a..4b03fe7 100644 --- a/plugin.rb +++ b/plugin.rb @@ -571,7 +571,7 @@ SQL def initialize @name = 'Unnamed Query' - @description = 'Enter a description here' + @description = '' @sql = 'SELECT 1' end