DEV: Update eslint-config-discourse, use prettier for hbs (#212)

.github/workflows/plugin-linting.yml

@@ -41,8 +41,8 @@ jobs:
         shell: bash
         run: |
           yarn prettier -v
-          if [ 0 -lt $(find assets admin/assets -type f \( -name "*.scss" -or -name "*.js" -or -name "*.es6" \) 2> /dev/null | wc -l) ]; then
+          if [ 0 -lt $(find assets admin/assets -type f \( -name "*.scss" -or -name "*.js" -or -name "*.es6" -or -name "*.hbs" \) 2> /dev/null | wc -l) ]; then
-            yarn prettier --list-different "assets/**/*.{scss,js,es6}"
+            yarn prettier --list-different "assets/**/*.{scss,js,es6,hbs}"
           fi
           if [ 0 -lt $(find test -type f \( -name "*.js" -or -name "*.es6" \) 2> /dev/null | wc -l) ]; then
             yarn prettier --list-different "test/**/*.{js,es6}"
@@ -50,7 +50,12 @@ jobs:
 
       - name: Ember template lint
         if: ${{ !cancelled() }}
-        run: yarn ember-template-lint --no-error-on-unmatched-pattern assets/javascripts admin/assets/javascripts
+        run: yarn ember-template-lint --no-error-on-unmatched-pattern assets/javascripts
+
+      # Separated due to https://github.com/ember-template-lint/ember-template-lint/issues/2758
+      - name: Ember template lint (admin)
+        if: ${{ !cancelled() }}
+        run: yarn ember-template-lint --no-error-on-unmatched-pattern admin/assets/javascripts
 
       - name: Rubocop
         if: ${{ !cancelled() }}

assets/javascripts/discourse/components/explorer-schema/one-table.hbs

@@ -1,4 +1,6 @@
+{{! template-lint-disable no-invalid-interactive }}
 <li class="schema-table {{this.styles}}" {{on "click" this.toggleOpen}}>
+  {{! template-lint-enable no-invalid-interactive }}
   <div class="schema-table-name">
     {{#if this.open}}
       {{d-icon "caret-down"}}

assets/javascripts/discourse/templates/admin/plugins-explorer.hbs

@@ -88,7 +88,7 @@
               </div>
             {{/if}}
 
-            {{#if (not selectedItem.destroyed)}}
+            {{#unless selectedItem.destroyed}}
               <div class="pull-left">
                 <div class="groups">
                   <span class="label">{{i18n "explorer.allow_groups"}}</span>
@@ -102,7 +102,7 @@
                   </span>
                 </div>
               </div>
-            {{/if}}
+            {{/unless}}
 
             <div class="clear"></div>