From c19fca406035cf85c7bac7c016c3583ecdec0a6e Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Lo=C3=AFc=20Guitaut?= Date: Tue, 28 May 2024 11:16:14 +0200 Subject: [PATCH] DEV: Update rubocop-discourse to version 3.8.0 (#292) --- Gemfile.lock | 46 +++++++++++--------- lib/discourse_data_explorer/data_explorer.rb | 2 +- lib/discourse_data_explorer/parameter.rb | 2 +- package.json | 9 ++-- plugin.rb | 2 +- 5 files changed, 33 insertions(+), 28 deletions(-) diff --git a/Gemfile.lock b/Gemfile.lock index a2f0dbf..27fcd63 100644 --- a/Gemfile.lock +++ b/Gemfile.lock @@ -1,7 +1,7 @@ GEM remote: https://rubygems.org/ specs: - activesupport (7.1.3.2) + activesupport (7.1.3.3) base64 bigdecimal concurrent-ruby (~> 1.0, >= 1.0.2) @@ -13,29 +13,28 @@ GEM tzinfo (~> 2.0) ast (2.4.2) base64 (0.2.0) - bigdecimal (3.1.6) + bigdecimal (3.1.8) concurrent-ruby (1.2.3) connection_pool (2.4.1) - drb (2.2.0) - ruby2_keywords - i18n (1.14.1) + drb (2.2.1) + i18n (1.14.5) concurrent-ruby (~> 1.0) - json (2.7.1) + json (2.7.2) language_server-protocol (3.17.0.3) - minitest (5.22.2) + minitest (5.23.1) mutex_m (0.2.0) parallel (1.24.0) - parser (3.3.0.5) + parser (3.3.1.0) ast (~> 2.4.1) racc prettier_print (1.2.1) - prism (0.24.0) - racc (1.7.3) + racc (1.8.0) + rack (3.0.11) rainbow (3.1.1) - regexp_parser (2.9.0) + regexp_parser (2.9.2) rexml (3.2.8) strscan (>= 3.0.9) - rubocop (1.61.0) + rubocop (1.64.0) json (~> 2.3) language_server-protocol (>= 3.17.0) parallel (~> 1.10) @@ -43,28 +42,35 @@ GEM rainbow (>= 2.2.2, < 4.0) regexp_parser (>= 1.8, < 3.0) rexml (>= 3.2.5, < 4.0) - rubocop-ast (>= 1.30.0, < 2.0) + rubocop-ast (>= 1.31.1, < 2.0) ruby-progressbar (~> 1.7) unicode-display_width (>= 2.4.0, < 3.0) - rubocop-ast (1.31.0) - parser (>= 3.3.0.4) - prism (>= 0.24.0) + rubocop-ast (1.31.3) + parser (>= 3.3.1.0) rubocop-capybara (2.20.0) rubocop (~> 1.41) - rubocop-discourse (3.7.1) + rubocop-discourse (3.8.0) activesupport (>= 6.1) rubocop (>= 1.59.0) rubocop-capybara (>= 2.0.0) rubocop-factory_bot (>= 2.0.0) + rubocop-rails (>= 2.25.0) rubocop-rspec (>= 2.25.0) rubocop-factory_bot (2.25.1) rubocop (~> 1.41) - rubocop-rspec (2.26.1) + rubocop-rails (2.25.0) + activesupport (>= 4.2.0) + rack (>= 1.1) + rubocop (>= 1.33.0, < 2.0) + rubocop-ast (>= 1.31.1, < 2.0) + rubocop-rspec (2.29.2) rubocop (~> 1.40) rubocop-capybara (~> 2.17) rubocop-factory_bot (~> 2.22) + rubocop-rspec_rails (~> 2.28) + rubocop-rspec_rails (2.28.3) + rubocop (~> 1.40) ruby-progressbar (1.13.0) - ruby2_keywords (0.0.5) strscan (3.1.0) syntax_tree (6.2.0) prettier_print (>= 1.2.0) @@ -80,4 +86,4 @@ DEPENDENCIES syntax_tree BUNDLED WITH - 2.5.4 + 2.5.10 diff --git a/lib/discourse_data_explorer/data_explorer.rb b/lib/discourse_data_explorer/data_explorer.rb index 1bd002d..fd94ea8 100644 --- a/lib/discourse_data_explorer/data_explorer.rb +++ b/lib/discourse_data_explorer/data_explorer.rb @@ -170,7 +170,7 @@ module ::DiscourseDataExplorer end needed_classes.each do |cls, column_nums| - next unless column_nums.present? + next if column_nums.blank? support_info = extra_data_pluck_fields[cls] next unless support_info diff --git a/lib/discourse_data_explorer/parameter.rb b/lib/discourse_data_explorer/parameter.rb index 8ea313e..c02d3a8 100644 --- a/lib/discourse_data_explorer/parameter.rb +++ b/lib/discourse_data_explorer/parameter.rb @@ -25,7 +25,7 @@ module ::DiscourseDataExplorer @default = default @nullable = nullable begin - cast_to_ruby default unless default.blank? + cast_to_ruby default if default.present? rescue ValidationError raise ValidationError.new( "Parameter declaration error - the default value is not a valid #{type}", diff --git a/package.json b/package.json index a028f0a..b032ece 100644 --- a/package.json +++ b/package.json @@ -1,10 +1,9 @@ { - "name": "discourse-data-explorer", "private": true, "devDependencies": { - "@discourse/lint-configs": "^1.3.5", - "ember-template-lint": "^5.13.0", - "eslint": "^8.56.0", - "prettier": "^2.8.8" + "@discourse/lint-configs": "1.3.9", + "ember-template-lint": "6.0.0", + "eslint": "8.57.0", + "prettier": "2.8.8" } } diff --git a/plugin.rb b/plugin.rb index 85dbc39..8b6a725 100644 --- a/plugin.rb +++ b/plugin.rb @@ -105,7 +105,7 @@ after_initialize do next end - unless recipients.present? + if recipients.blank? Rails.logger.warn "#{DiscourseDataExplorer::PLUGIN_NAME} - couldn't find any recipients for automation #{automation.id}" next end