mirror of
https://github.com/discourse/discourse-data-explorer.git
synced 2025-02-13 06:55:09 +00:00
216dff3ed9
Previously this was adding an extra AJAX request to check if the group had any queries available. Now a boolean is included in the group serializer, so there is no need for the extra request. Removing this ajax request will also stop other plugin JS integration tests from failing when the data-explorer plugin is installed. This commit also fixes the HTML markup of the tab, so that it doesn't have a <ul> nested inside the existing <ul>. Also adds an icon for good measure.
45 lines
1.4 KiB
Ruby
45 lines
1.4 KiB
Ruby
# frozen_string_literal: true
|
|
|
|
require 'rails_helper'
|
|
|
|
describe "Data explorer group serializer additions" do
|
|
let(:group_user) { Fabricate(:user) }
|
|
let(:other_user) { Fabricate(:user) }
|
|
let(:group) { Fabricate(:group) }
|
|
let!(:query) { DataExplorer::Query.create!(name: "My query", sql: "") }
|
|
|
|
before do
|
|
SiteSetting.data_explorer_enabled = true
|
|
group.add(group_user)
|
|
DataExplorer::QueryGroup.create!(group: group, query: query)
|
|
end
|
|
|
|
it "query boolean is true for group user" do
|
|
sign_in group_user
|
|
get "/g/#{group.name}.json"
|
|
expect(response.status).to eq(200)
|
|
expect(response.parsed_body["group"]["has_visible_data_explorer_queries"]).to eq(true)
|
|
end
|
|
|
|
it "query boolean is false for group user when there are no queries" do
|
|
query.destroy!
|
|
sign_in group_user
|
|
get "/g/#{group.name}.json"
|
|
expect(response.status).to eq(200)
|
|
expect(response.parsed_body["group"]["has_visible_data_explorer_queries"]).to eq(false)
|
|
end
|
|
|
|
it "does not include query boolean for anon" do
|
|
get "/g/#{group.name}.json"
|
|
expect(response.status).to eq(200)
|
|
expect(response.parsed_body["group"]["has_visible_data_explorer_queries"]).to eq(nil)
|
|
end
|
|
|
|
it "does not include query boolean for non-group user" do
|
|
sign_in other_user
|
|
get "/g/#{group.name}.json"
|
|
expect(response.status).to eq(200)
|
|
expect(response.parsed_body["group"]["has_visible_data_explorer_queries"]).to eq(nil)
|
|
end
|
|
end
|