948634fe31
SECURITY: Apply transformations to text nodes only
...
Previously, the replacement system would modify raw HTML, which is prone to issues and vulnerabilities. With this commit, we iterate over text nodes only, and do simple string replacements on their content. That means that the user input never gets passed into an HTML parser, and there is no chance of injection attacks.
The re-rendering system is also simplified to store the original value for re-use later, instead of mapping position/length of replacements.
This does mean the behavior is changed slightly. Replacements will no longer be applied to html attributes (e.g `a[href]`). If this affects your use-case, please let us know [on Meta](https://meta.discourse.org/t/113533 ).
This is a followup to the fix in a62f711d56
2024-08-29 10:15:53 +01:00
a62f711d56
SECURITY: properly escape user input ( #38 )
...
We were failing to correctly escape content which we would then inject in the HTML of the post causing an XSS.
Note this XSS is stopped by CSP.
2024-08-20 18:06:58 +02:00
a319c0baa1
DEV: Update linting ( #28 )
2024-03-27 18:55:28 +01:00
05a727efd5
DEV: Use the new modal api ( #26 )
2023-12-05 23:15:32 +01:00
344f4dd0ea
DEV: Switch to new addComposerToolbarPopupMenuOption plugin API ( #25 )
...
Why this change?
`api.addToolbarPopupMenuOptionsCallback` has been deprecated in 913fd3a7b3
2023-10-23 08:08:57 +08:00
8fe8b1d4d1
DEV: Update eslint-config-discourse, use prettier for hbs ( #17 )
2023-01-04 13:46:24 +01:00
3918061c50
DEV: Replace bootbox alert dialog ( #13 )
2022-10-31 08:04:38 -03:00
be75773375
FIX: fully rely on keyValueStore to prevent error ( #12 )
...
* FIX: fully rely on keyValueStore to prevent error
The component was generating errors for some users due to direct access to `localStorage`:
```
TypeError: Cannot convert undefined or null to object
at Function.keys (<anonymous>)
at Object.expireOldValues (https://d3bpeqsaub0i6y.cloudfront.net/theme-javascripts/33bf35dc19b970a42f8c1e7d57d8cc72d6205bbd.js?__ws=meta.discourse.org:157:14 )
at Object.initialize (https://d3bpeqsaub0i6y.cloudfront.net/theme-javascripts/33bf35dc19b970a42f8c1e7d57d8cc72d6205bbd.js?__ws=meta.discourse.org:193:12 )
at o.initialize (https://d11a6trkgmumsb.cloudfront.net/assets/discourse-2bd9a9aa6b5c9cbee990a03159f5bff41fe503fe74814c3b66b3770876913dd5.gz.js:68:38 )
```
This commits removes old unnecessary code using cookies and uses latest API from core `removeKeys`. Old discourse instances will just not evict old keys which is a minor annoyance.
* linting
2022-08-22 00:25:50 +02:00
faf88c2209
DEV: Fix `key-value-store:main` deprecation ( #11 )
2022-08-13 22:40:11 +02:00
ba7ca9e588
DEV: Fix typo ( #10 )
2022-08-13 22:39:58 +02:00
1c4f5b1a99
DEV: Add CI setup and fix linting issues ( #9 )
2022-06-18 21:27:31 +02:00
9a002eed80
FIX: Dropdowns following recent refactoring ( #7 )
2022-01-13 16:48:07 -08:00
9882e993c5
DEV: Remove JQuery
2022-01-13 13:02:06 +00:00
468cf81fd2
DEV: Migrate to local storage
...
Setting cookies means that they're sent in the request headers for every HTTP request. This will have a (tiny) impact on performance, plus it can raise privacy concerns. Using localStorage is more appropriate for this use case.
This commit includes migration logic for any previously-saved values.
Previously the cookies were set to last for the 'session'. localStorage doesn't have an expiration mechanism, so this commit implements a 7-day expiration on the values.
2022-01-13 13:02:06 +00:00
6c43321b28
DEV: Apply prettier, remove es6 extension
2022-01-13 13:02:06 +00:00
3adf5b8300
DEV: Use `cookie` imports ( #5 )
...
Fixes deprecation warnings.
2021-10-28 19:40:25 +02:00
bd544c3f38
FIX: `modifyClass` deprecation ( #3 )
2021-09-03 13:43:45 -04:00
222e50bacb
FIX: ensures we can rewrite links
...
This selector was too specific and would end up catching a directlyt wich would result in innerHTML being the text of the link and not the full link.
2020-04-24 11:19:36 +02:00
81bbc2080a
removes links and clear placeholders for now
...
It works well, but is too much noise for the value
2020-04-22 12:41:42 +02:00
e49d7411e5
FIX: better detection of default value
2020-04-20 20:39:54 +02:00
f947865904
FIX: ensures correct updates on input and clear
2020-04-20 17:07:04 +02:00
1fab87e976
FIX: do not placeholder the placeholder
2020-04-20 17:06:49 +02:00
3726aa75e3
REFACTOR: various code/UI/UX changes and refactorings
...
- ability to clear placeholders
- builder UI
- link to placeholder
- improve styles
2020-04-20 16:07:10 +02:00
David Taylor
Joffrey JAFFEUX
Jarek Radosz
Alan Guo Xiang Tan
Jan Cernik
Robin Ward