From 882dd61e11f9bab8e99510296938b0cdbc3269c4 Mon Sep 17 00:00:00 2001
From: Gerhard Schlager <gerhard.schlager@discourse.org>
Date: Tue, 22 Nov 2022 00:36:46 +0100
Subject: [PATCH] FEATURE: Add new badges and rename existing badges

---
 config/locales/server.en.yml | 18 +++++++---
 db/fixtures/001_badges.rb    | 70 +++++++++++++++++++-----------------
 2 files changed, 52 insertions(+), 36 deletions(-)

diff --git a/config/locales/server.en.yml b/config/locales/server.en.yml
index 2883409..8f5f281 100644
--- a/config/locales/server.en.yml
+++ b/config/locales/server.en.yml
@@ -27,11 +27,21 @@ en:
 
   badges:
     solved_1:
-      name: "Helpdesk"
-      description: "First Accepted Answer on a Topic"
+      name: "Solved!"
+      description: "Have a reply marked as a Solution"
+      long_description: "This badge is granted for having a reply marked as a Solution to a topic. :white_check_mark: Nice job. :+1:"
     solved_2:
-      name: "Tech Support"
-      description: "10 Accepted answers"
+      name: "Guidance Counsellor"
+      description: "Have 10 replies marked as Solutions"
+      long_description: "This badge is granted for having 10 of your replies marked as Solutions to topics. :white_check_mark: You are a true asset to your fellow community members."
+    solved_3:
+      name: "Know-it-All"
+      description: "Have 50 replies marked as Solutions"
+      long_description: "This badge is granted for having 50 of your replies marked as Solutions to topics. :white_check_mark: You really know your stuff. :clap:"
+    solved_4:
+      name: "Solution Institution"
+      description: "Have 150 replies marked as Solutions"
+      long_description: "This badge is granted for having 150 of your replies marked as Solutions to topics. :white_check_mark: Excellent work. :slightly_smiling_face: You are officially a Solution Institution. :brain:"
 
   discourse_automation:
     triggerables:
diff --git a/db/fixtures/001_badges.rb b/db/fixtures/001_badges.rb
index 2c6a885..7052acd 100644
--- a/db/fixtures/001_badges.rb
+++ b/db/fixtures/001_badges.rb
@@ -1,8 +1,6 @@
 # frozen_string_literal: true
 
-return unless badge_grouping = BadgeGrouping.find_by(name: "Community")
-
-first_solution_query = <<-SQL
+first_solution_query = <<~SQL
   SELECT post_id, user_id, created_at AS granted_at
   FROM (
            SELECT p.id AS post_id, p.user_id, pcf.created_at,
@@ -19,9 +17,9 @@ SQL
 
 Badge.seed(:name) do |badge|
   badge.name = "Solved 1"
-  badge.icon = "check-square"
-  badge.badge_type_id = 3
-  badge.badge_grouping = badge_grouping
+  badge.default_icon = "check-square"
+  badge.badge_type_id = BadgeType::Bronze
+  badge.default_badge_grouping_id = BadgeGrouping::Community
   badge.query = first_solution_query
   badge.listable = true
   badge.target_posts = true
@@ -32,30 +30,38 @@ Badge.seed(:name) do |badge|
   badge.system = true
 end
 
-solved_10_query = <<-SQL
-  SELECT p.user_id, MAX(pcf.created_at) AS granted_at
-  FROM post_custom_fields pcf
-       JOIN badge_posts p ON pcf.post_id = p.id
-       JOIN topics t ON p.topic_id = t.id
-  WHERE pcf.name = 'is_accepted_answer'
-    AND p.user_id <> t.user_id -- ignore topics solved by OP
-    AND (:backfill OR p.id IN (:post_ids))
-  GROUP BY p.user_id
-  HAVING COUNT(*) >= 10
-SQL
-
-Badge.seed(:name) do |badge|
-  badge.name = "Solved 2"
-  badge.icon = "check-square"
-  badge.badge_type_id = 2
-  badge.badge_grouping = badge_grouping
-  badge.query = solved_10_query
-  badge.listable = true
-  badge.allow_title = true
-  badge.target_posts = false
-  badge.enabled = false
-  badge.trigger = Badge::Trigger::PostRevision
-  badge.auto_revoke = true
-  badge.show_posts = false
-  badge.system = true
+def solved_query_with_count(min_count)
+  <<~SQL
+    SELECT p.user_id, MAX(pcf.created_at) AS granted_at
+    FROM post_custom_fields pcf
+         JOIN badge_posts p ON pcf.post_id = p.id
+         JOIN topics t ON p.topic_id = t.id
+    WHERE pcf.name = 'is_accepted_answer'
+      AND p.user_id <> t.user_id -- ignore topics solved by OP
+      AND (:backfill OR p.id IN (:post_ids))
+    GROUP BY p.user_id
+    HAVING COUNT(*) >= #{min_count}
+  SQL
+end
+
+[
+  ["Solved 2", BadgeType::Silver, 10],
+  ["Solved 3", BadgeType::Gold, 50],
+  ["Solved 4", BadgeType::Gold, 150],
+].each do |name, level, count|
+  Badge.seed(:name) do |badge|
+    badge.name = name
+    badge.default_icon = "check-square"
+    badge.badge_type_id = level
+    badge.default_badge_grouping_id = BadgeGrouping::Community
+    badge.query = solved_query_with_count(count)
+    badge.listable = true
+    badge.default_allow_title = true
+    badge.target_posts = false
+    badge.enabled = false
+    badge.trigger = Badge::Trigger::PostRevision
+    badge.auto_revoke = true
+    badge.show_posts = false
+    badge.system = true
+  end
 end