From bbb3212258453aa82dac1d9c60688e6702f54607 Mon Sep 17 00:00:00 2001
From: Gerhard Schlager <gerhard.schlager@discourse.org>
Date: Mon, 21 Nov 2022 17:56:22 +0100
Subject: [PATCH] PERF: Improve query for "Tech Support" badge

The old query could be extremely slow and resource intensive.
This also switches `granted_at` from `current_timestamp` to the date of the most recent accepted answer for each user.
---
 db/fixtures/001_badges.rb | 30 +++++++++++-------------------
 1 file changed, 11 insertions(+), 19 deletions(-)

diff --git a/db/fixtures/001_badges.rb b/db/fixtures/001_badges.rb
index 8dc3562..b3d55f7 100644
--- a/db/fixtures/001_badges.rb
+++ b/db/fixtures/001_badges.rb
@@ -40,25 +40,17 @@ Badge.seed(:name) do |badge|
   badge.system = false
 end
 
-tech_support_query = <<-EOS
-SELECT id user_id, current_timestamp granted_at
-FROM users
-WHERE id  IN (
-       SELECT p1.user_id
-       FROM post_custom_fields pc
-       JOIN badge_posts p1 ON p1.id = pc.post_id
-       JOIN topics t1 ON p1.topic_id = t1.id
-       WHERE p1.user_id <> t1.user_id AND
-                    name = 'is_accepted_answer' AND
-            p1.user_id IN (
-                   SELECT user_id
-                   FROM posts
-                   WHERE :backfill OR  p1.id IN (:post_ids)
-            )
-        GROUP BY p1.user_id
-        HAVING COUNT(*) > 9
-)
-EOS
+tech_support_query = <<-SQL
+  SELECT p.user_id, MAX(pcf.created_at) AS granted_at
+  FROM post_custom_fields pcf
+       JOIN badge_posts p ON pcf.post_id = p.id
+       JOIN topics t ON p.topic_id = t.id
+  WHERE pcf.name = 'is_accepted_answer'
+    AND p.user_id <> t.user_id -- ignore topics solved by OP
+    AND (:backfill OR p.id IN (:post_ids))
+  GROUP BY p.user_id
+  HAVING COUNT(*) >= 10
+SQL
 
 Badge.seed(:name) do |badge|
   badge.name = I18n.t("badges.tech_support.name")