review: remove old_solution

2024-09-10 14:33:26 +08:00 · 2024-09-10 14:33:26 +08:00 · ca19bb71fa
parent d10c7c3f1f
commit ca19bb71fa
1 changed files with 3 additions and 5 deletions
--- a/plugin.rb
+++ b/plugin.rb
@ -51,14 +51,12 @@ after_initialize do
      topic ||= post.topic

      DistributedMutex.synchronize("discourse_solved_toggle_answer_#{topic.id}") do
-        old_solution = topic.solution
-
-        if old_solution.present?
+        if topic.solution.present?
          UserAction.where(
            action_type: UserAction::SOLVED,
-            target_post_id: old_solution.answer_post_id,
+            target_post_id: topic.solution.answer_post_id,
          ).destroy_all
-          old_solution.destroy!
+          topic.solution.destroy!
        end

        solution = DiscourseSolved::Solution.create(topic:, post:, accepter_user_id: acting_user.id)