From 321f6b8a71f9a4c4859afe4341120b4b5900b581 Mon Sep 17 00:00:00 2001
From: Rimian Perkins <hello@rimian.com.au>
Date: Thu, 10 Oct 2019 12:31:32 +1100
Subject: [PATCH] spec unauthenticated plans request

---
 spec/requests/admin/plans_controller_spec.rb  | 116 ++++++++++++------
 spec/requests/admin_controller_spec.rb        |   4 +-
 .../requests/subscriptions_controller_spec.rb |   4 +-
 3 files changed, 82 insertions(+), 42 deletions(-)

diff --git a/spec/requests/admin/plans_controller_spec.rb b/spec/requests/admin/plans_controller_spec.rb
index 10fbddc..69041e3 100644
--- a/spec/requests/admin/plans_controller_spec.rb
+++ b/spec/requests/admin/plans_controller_spec.rb
@@ -5,53 +5,93 @@ require 'rails_helper'
 module DiscoursePatrons
   module Admin
     RSpec.describe PlansController do
-      let(:admin) { Fabricate(:admin) }
-
-      before { sign_in(admin) }
-
-      xit 'is a subclass of AdminController' do
-        expect(DiscoursePatrons::Admin::PlansController < Admin::AdminController).to eq(true)
+      it 'is a subclass of AdminController' do
+        expect(DiscoursePatrons::Admin::PlansController < ::Admin::AdminController).to eq(true)
       end
 
-      describe "index" do
-        it "is ok" do
-          ::Stripe::Plan.expects(:list)
-          get "/patrons/admin/plans.json"
+      context 'not authenticated' do
+        describe "index" do
+          it "does not get the plans" do
+            ::Stripe::Plan.expects(:list).never
+            get "/patrons/admin/plans.json"
+          end
+
+          it "not ok" do
+            get "/patrons/admin/plans.json"
+            expect(response.status).to eq 403
+          end
+        end
+
+        describe "create" do
+          it "does not create a plan" do
+            ::Stripe::Plan.expects(:create).never
+            post "/patrons/admin/plans.json", params: { name: 'Rick Astley', amount: 1, interval: 'week' }
+          end
+
+          it "is not ok" do
+            post "/patrons/admin/plans.json", params: { name: 'Rick Astley', amount: 1, interval: 'week' }
+            expect(response.status).to eq 403
+          end
+        end
+
+        describe "delete" do
+          it "does not delete a plan" do
+            ::Stripe::Plan.expects(:delete).never
+            delete "/patrons/admin/plans/plan_12345.json"
+          end
+
+          it "is not ok" do
+            delete "/patrons/admin/plans/plan_12345.json"
+            expect(response.status).to eq 403
+          end
         end
       end
 
-      describe "create" do
-        it "creates a plan with a currency" do
-          SiteSetting.stubs(:discourse_patrons_currency).returns('aud')
-          ::Stripe::Plan.expects(:create).with(has_entry(:currency, 'aud'))
-          post "/patrons/admin/plans.json", params: {}
+      context 'authenticated' do
+        let(:admin) { Fabricate(:admin) }
+
+        before { sign_in(admin) }
+
+        describe "index" do
+          it "is ok" do
+            ::Stripe::Plan.expects(:list)
+            get "/patrons/admin/plans.json"
+          end
         end
 
-        it "creates a plan with an interval" do
-          ::Stripe::Plan.expects(:create).with(has_entry(:interval, 'week'))
-          post "/patrons/admin/plans.json", params: { interval: 'week' }
+        describe "create" do
+          it "creates a plan with a currency" do
+            SiteSetting.stubs(:discourse_patrons_currency).returns('aud')
+            ::Stripe::Plan.expects(:create).with(has_entry(:currency, 'aud'))
+            post "/patrons/admin/plans.json", params: {}
+          end
+
+          it "creates a plan with an interval" do
+            ::Stripe::Plan.expects(:create).with(has_entry(:interval, 'week'))
+            post "/patrons/admin/plans.json", params: { interval: 'week' }
+          end
+
+          it "creates a plan with an amount" do
+            ::Stripe::Plan.expects(:create).with(has_entry(:amount, '102'))
+            post "/patrons/admin/plans.json", params: { amount: '102' }
+          end
+
+          it "creates a plan with a title" do
+            ::Stripe::Plan.expects(:create).with(has_entry(:product, name: 'Rick Astley'))
+            post "/patrons/admin/plans.json", params: { name: 'Rick Astley' }
+          end
+
+          it "creates a plan with an id" do
+            ::Stripe::Plan.expects(:create).with(has_entry(id: 'rick-astley'))
+            post "/patrons/admin/plans.json", params: { name: 'Rick Astley' }
+          end
         end
 
-        it "creates a plan with an amount" do
-          ::Stripe::Plan.expects(:create).with(has_entry(:amount, '102'))
-          post "/patrons/admin/plans.json", params: { amount: '102' }
-        end
-
-        it "creates a plan with a title" do
-          ::Stripe::Plan.expects(:create).with(has_entry(:product, name: 'Rick Astley'))
-          post "/patrons/admin/plans.json", params: { name: 'Rick Astley' }
-        end
-
-        it "creates a plan with an id" do
-          ::Stripe::Plan.expects(:create).with(has_entry(id: 'rick-astley'))
-          post "/patrons/admin/plans.json", params: { name: 'Rick Astley' }
-        end
-      end
-
-      describe "delete" do
-        it "deletes a plan" do
-          ::Stripe::Plan.expects(:delete).with('plan_12345')
-          delete "/patrons/admin/plans/plan_12345.json"
+        describe "delete" do
+          it "deletes a plan" do
+            ::Stripe::Plan.expects(:delete).with('plan_12345')
+            delete "/patrons/admin/plans/plan_12345.json"
+          end
         end
       end
     end
diff --git a/spec/requests/admin_controller_spec.rb b/spec/requests/admin_controller_spec.rb
index 5e31e25..28d988a 100644
--- a/spec/requests/admin_controller_spec.rb
+++ b/spec/requests/admin_controller_spec.rb
@@ -9,8 +9,8 @@ module DiscoursePatrons
 
     before { sign_in(admin) }
 
-    xit 'is a subclass of AdminController' do
-      expect(DiscoursePatrons::AdminController < Admin::AdminController).to eq(true)
+    it 'is a subclass of AdminController' do
+      expect(DiscoursePatrons::AdminController < ::Admin::AdminController).to eq(true)
     end
 
     it "is ok" do
diff --git a/spec/requests/subscriptions_controller_spec.rb b/spec/requests/subscriptions_controller_spec.rb
index c24a339..07e4948 100644
--- a/spec/requests/subscriptions_controller_spec.rb
+++ b/spec/requests/subscriptions_controller_spec.rb
@@ -9,8 +9,8 @@ module DiscoursePatrons
 
     before { sign_in(admin) }
 
-    xit 'is a subclass of AdminController' do
-      expect(DiscoursePatrons::SubscriptionsController < Admin::AdminController).to eq(true)
+    it 'is a subclass of AdminController' do
+      expect(DiscoursePatrons::SubscriptionsController < ::Admin::AdminController).to eq(true)
     end
 
     it "gets the empty subscriptions" do