a zillion http stubs to get this spec to pass!

This commit is contained in:
Rimian Perkins 2019-08-27 11:57:51 +10:00
parent d4d62c5458
commit 4b41756cfa
1 changed files with 466 additions and 8 deletions

View File

@ -16,6 +16,7 @@ module DiscourseDonations
RSpec.describe ChargesController, type: :controller do
routes { DiscourseDonations::Engine.routes }
let(:body) { JSON.parse(response.body) }
fab!(:user) { Fabricate(:user, name: 'Lynette') }
before do
SiteSetting.stubs(:disable_discourse_narrative_bot_welcome_post).returns(true)
@ -25,22 +26,479 @@ module DiscourseDonations
end
# Workaround for rails-5 issue. See https://github.com/thoughtbot/shoulda-matchers/issues/1018#issuecomment-315876453
let(:allowed_params) { {create_account: 'true', email: 'email@example.com', password: 'secret', username: 'mr-pink', name: 'kirsten', amount: 100, stripeToken: 'rrurrrurrrrr'} }
let(:allowed_params) { { create_account: 'true', email: 'email@example.com', password: 'secret', username: 'mr-pink', name: 'kirsten', amount: 100, stripeToken: 'rrurrrurrrrr' } }
it 'whitelists the params' do
should permit(:name, :username, :email, :password, :create_account).
for(:create, params: { params: allowed_params })
for(:create, params: { params: allowed_params })
end
it 'responds ok for anonymous users' do
post :create, params: { email: 'foobar@example.com' }
controller.expects(:current_user).at_least(1).returns(user)
customer = {
"id": "cus_FhHJDzf0OxYtb8",
"object": "customer",
"account_balance": 0,
"address": "null",
"balance": 0,
"created": 1566866533,
"currency": "usd",
"default_source": "null",
"delinquent": false,
"description": "null",
"discount": "null",
"email": "null",
"invoice_prefix": "0BBF354",
"invoice_settings": {
"custom_fields": "null",
"default_payment_method": "null",
"footer": "null"
},
"livemode": false,
"metadata": {},
"name": "null",
"phone": "null",
"preferred_locales": [],
"shipping": "null",
"sources": {
"object": "list",
"data": [],
"has_more": false,
"total_count": 0,
"url": "/v1/customers/cus_FhHJDzf0OxYtb8/sources"
},
"subscriptions": {
"object": "list",
"data": [],
"has_more": false,
"total_count": 0,
"url": "/v1/customers/cus_FhHJDzf0OxYtb8/subscriptions"
},
"tax_exempt": "none",
"tax_ids": {
"object": "list",
"data": [],
"has_more": false,
"total_count": 0,
"url": "/v1/customers/cus_FhHJDzf0OxYtb8/tax_ids"
},
"tax_info": "null",
"tax_info_verification": "null"
}
stub_request(:get, "https://api.stripe.com/v1/customers?email=foobar@example.com").
with(
headers: {
'Accept' => '*/*',
'Accept-Encoding' => 'gzip;q=1.0,deflate;q=0.6,identity;q=0.3',
'Authorization' => 'Bearer secret-key-yo',
'Content-Type' => 'application/x-www-form-urlencoded',
'User-Agent' => 'Stripe/v1 RubyBindings/2.8.0',
'X-Stripe-Client-User-Agent' => '{"bindings_version":"2.8.0","lang":"ruby","lang_version":"2.6.2 p47 (2019-03-13)","platform":"x86_64-darwin18","engine":"ruby","publisher":"stripe","uname":"Darwin 192-168-1-102.tpgi.com.au 18.7.0 Darwin Kernel Version 18.7.0: Thu Jun 20 18:42:21 PDT 2019; root:xnu-4903.270.47~4/RELEASE_X86_64 x86_64","hostname":"192-168-1-102.tpgi.com.au"}'
}).
to_return(status: 200, body: customer.to_json, headers: {})
stub_request(:post, "https://api.stripe.com/v1/customers").
with(
body: { "email" => "foobar@example.com" },
headers: {
'Accept' => '*/*',
'Accept-Encoding' => 'gzip;q=1.0,deflate;q=0.6,identity;q=0.3',
'Authorization' => 'Bearer secret-key-yo',
'Content-Type' => 'application/x-www-form-urlencoded',
'User-Agent' => 'Stripe/v1 RubyBindings/2.8.0',
'X-Stripe-Client-User-Agent' => '{"bindings_version":"2.8.0","lang":"ruby","lang_version":"2.6.2 p47 (2019-03-13)","platform":"x86_64-darwin18","engine":"ruby","publisher":"stripe","uname":"Darwin 192-168-1-102.tpgi.com.au 18.7.0 Darwin Kernel Version 18.7.0: Thu Jun 20 18:42:21 PDT 2019; root:xnu-4903.270.47~4/RELEASE_X86_64 x86_64","hostname":"192-168-1-102.tpgi.com.au"}'
}).
to_return(status: 200, body: customer.to_json, headers: {})
plans = {
"object": "list",
"url": "/v1/plans",
"has_more": false,
"data": [
{
"id": "plan_EeE4ns3bvb34ZP",
"object": "plan",
"active": true,
"aggregate_usage": "null",
"amount": 3000,
"amount_decimal": "3000",
"billing_scheme": "per_unit",
"created": 1551862832,
"currency": "usd",
"interval": "month",
"interval_count": 1,
"livemode": false,
"metadata": {},
"nickname": "Pro Plan",
"product": "prod_BT942zL7VcClrn",
"tiers": "null",
"tiers_mode": "null",
"transform_usage": "null",
"trial_period_days": "null",
"usage_type": "licensed"
},
]
}
stub_request(:get, "https://api.stripe.com/v1/plans").
with(
headers: {
'Accept' => '*/*',
'Accept-Encoding' => 'gzip;q=1.0,deflate;q=0.6,identity;q=0.3',
'Authorization' => 'Bearer secret-key-yo',
'Content-Type' => 'application/x-www-form-urlencoded',
'User-Agent' => 'Stripe/v1 RubyBindings/2.8.0',
'X-Stripe-Client-User-Agent' => '{"bindings_version":"2.8.0","lang":"ruby","lang_version":"2.6.2 p47 (2019-03-13)","platform":"x86_64-darwin18","engine":"ruby","publisher":"stripe","uname":"Darwin 192-168-1-102.tpgi.com.au 18.7.0 Darwin Kernel Version 18.7.0: Thu Jun 20 18:42:21 PDT 2019; root:xnu-4903.270.47~4/RELEASE_X86_64 x86_64","hostname":"192-168-1-102.tpgi.com.au"}'
}).
to_return(status: 200, body: plans.to_json, headers: {})
stub_request(:post, "https://api.stripe.com/v1/plans").
with(
body: { "amount" => "0", "currency" => "AUD", "id" => "discourse_donation_recurring__", "nickname" => "Discourse Donation Recurring " },
headers: {
'Accept' => '*/*',
'Accept-Encoding' => 'gzip;q=1.0,deflate;q=0.6,identity;q=0.3',
'Authorization' => 'Bearer secret-key-yo',
'Content-Type' => 'application/x-www-form-urlencoded',
'User-Agent' => 'Stripe/v1 RubyBindings/2.8.0',
'X-Stripe-Client-User-Agent' => '{"bindings_version":"2.8.0","lang":"ruby","lang_version":"2.6.2 p47 (2019-03-13)","platform":"x86_64-darwin18","engine":"ruby","publisher":"stripe","uname":"Darwin 192-168-1-102.tpgi.com.au 18.7.0 Darwin Kernel Version 18.7.0: Thu Jun 20 18:42:21 PDT 2019; root:xnu-4903.270.47~4/RELEASE_X86_64 x86_64","hostname":"192-168-1-102.tpgi.com.au"}'
}).
to_return(status: 200, body: plans.to_json, headers: {})
products = {
"object": "list",
"url": "/v1/products",
"has_more": false,
"data": [
{
"id": "prod_FhGJ7clA2xMxGI",
"object": "product",
"active": true,
"attributes": [],
"caption": "null",
"created": 1566862775,
"deactivate_on": [],
"description": "null",
"images": [],
"livemode": false,
"metadata": {},
"name": "Sapphire Personal",
"package_dimensions": "null",
"shippable": "null",
"statement_descriptor": "null",
"type": "service",
"unit_label": "null",
"updated": 1566862775,
"url": "null"
},
]
}
stub_request(:get, "https://api.stripe.com/v1/products?type=service").
with(
headers: {
'Accept' => '*/*',
'Accept-Encoding' => 'gzip;q=1.0,deflate;q=0.6,identity;q=0.3',
'Authorization' => 'Bearer secret-key-yo',
'Content-Type' => 'application/x-www-form-urlencoded',
'User-Agent' => 'Stripe/v1 RubyBindings/2.8.0',
'X-Stripe-Client-User-Agent' => '{"bindings_version":"2.8.0","lang":"ruby","lang_version":"2.6.2 p47 (2019-03-13)","platform":"x86_64-darwin18","engine":"ruby","publisher":"stripe","uname":"Darwin 192-168-1-102.tpgi.com.au 18.7.0 Darwin Kernel Version 18.7.0: Thu Jun 20 18:42:21 PDT 2019; root:xnu-4903.270.47~4/RELEASE_X86_64 x86_64","hostname":"192-168-1-102.tpgi.com.au"}'
}).
to_return(status: 200, body: products.to_json, headers: {})
stub_request(:post, "https://api.stripe.com/v1/products").
with(
body: { "id" => "Discourse_recurring_donation", "name" => "Discourse Recurring Donation", "type" => "service" },
headers: {
'Accept' => '*/*',
'Accept-Encoding' => 'gzip;q=1.0,deflate;q=0.6,identity;q=0.3',
'Authorization' => 'Bearer secret-key-yo',
'Content-Type' => 'application/x-www-form-urlencoded',
'User-Agent' => 'Stripe/v1 RubyBindings/2.8.0',
'X-Stripe-Client-User-Agent' => '{"bindings_version":"2.8.0","lang":"ruby","lang_version":"2.6.2 p47 (2019-03-13)","platform":"x86_64-darwin18","engine":"ruby","publisher":"stripe","uname":"Darwin 192-168-1-102.tpgi.com.au 18.7.0 Darwin Kernel Version 18.7.0: Thu Jun 20 18:42:21 PDT 2019; root:xnu-4903.270.47~4/RELEASE_X86_64 x86_64","hostname":"192-168-1-102.tpgi.com.au"}'
}).
to_return(status: 200, body: products.to_json, headers: {})
stub_request(:post, "https://api.stripe.com/v1/customers").
with(
body: { "email" => "foobar@example.com", "metadata" => { "discourse_user_id" => "1" } },
headers: {
'Accept' => '*/*',
'Accept-Encoding' => 'gzip;q=1.0,deflate;q=0.6,identity;q=0.3',
'Authorization' => 'Bearer secret-key-yo',
'Content-Type' => 'application/x-www-form-urlencoded',
'User-Agent' => 'Stripe/v1 RubyBindings/2.8.0',
'X-Stripe-Client-User-Agent' => '{"bindings_version":"2.8.0","lang":"ruby","lang_version":"2.6.2 p47 (2019-03-13)","platform":"x86_64-darwin18","engine":"ruby","publisher":"stripe","uname":"Darwin 192-168-1-102.tpgi.com.au 18.7.0 Darwin Kernel Version 18.7.0: Thu Jun 20 18:42:21 PDT 2019; root:xnu-4903.270.47~4/RELEASE_X86_64 x86_64","hostname":"192-168-1-102.tpgi.com.au"}'
}).
to_return(status: 200, body: customer.to_json, headers: {})
subscription = {
"id": "sub_8epEF0PuRhmltU",
"object": "subscription",
"application_fee_percent": "null",
"billing": "charge_automatically",
"billing_cycle_anchor": 1466202990,
"billing_thresholds": "null",
"cancel_at": "null",
"cancel_at_period_end": false,
"canceled_at": 1517528245,
"collection_method": "charge_automatically",
"created": 1466202990,
"current_period_end": 1518906990,
"current_period_start": 1516228590,
"customer": "cus_FhHJDzf0OxYtb8",
"days_until_due": "null",
"default_payment_method": "null",
"default_source": "null",
"default_tax_rates": [],
"discount": "null",
"ended_at": 1517528245,
"items": {
"object": "list",
"data": [
{
"id": "si_18NVZi2eZvKYlo2CUtBNGL9x",
"object": "subscription_item",
"billing_thresholds": "null",
"created": 1466202990,
"metadata": {},
"plan": {
"id": "ivory-freelance-040",
"object": "plan",
"active": true,
"aggregate_usage": "null",
"amount": 999,
"amount_decimal": "999",
"billing_scheme": "per_unit",
"created": 1466202980,
"currency": "usd",
"interval": "month",
"interval_count": 1,
"livemode": false,
"metadata": {},
"nickname": "null",
"product": "prod_BUthVRQ7KdFfa7",
"tiers": "null",
"tiers_mode": "null",
"transform_usage": "null",
"trial_period_days": "null",
"usage_type": "licensed"
},
"quantity": 1,
"subscription": "sub_8epEF0PuRhmltU",
"tax_rates": []
}
],
"has_more": false,
"total_count": 1,
"url": "/v1/subscription_items?subscription=sub_8epEF0PuRhmltU"
},
"latest_invoice": "null",
"livemode": false,
"metadata": {},
"pending_setup_intent": "null",
"plan": {
"id": "ivory-freelance-040",
"object": "plan",
"active": true,
"aggregate_usage": "null",
"amount": 999,
"amount_decimal": "999",
"billing_scheme": "per_unit",
"created": 1466202980,
"currency": "usd",
"interval": "month",
"interval_count": 1,
"livemode": false,
"metadata": {},
"nickname": "null",
"product": "prod_BUthVRQ7KdFfa7",
"tiers": "null",
"tiers_mode": "null",
"transform_usage": "null",
"trial_period_days": "null",
"usage_type": "licensed"
},
"quantity": 1,
"schedule": "null",
"start": 1466202990,
"start_date": 1466202990,
"status": "active",
"tax_percent": "null",
"trial_end": "null",
"trial_start": "null"
}
stub_request(:post, "https://api.stripe.com/v1/subscriptions").
with(
body: { "customer" => "cus_FhHJDzf0OxYtb8", "metadata" => { "discourse_user_id" => "1" } },
headers: {
'Accept' => '*/*',
'Accept-Encoding' => 'gzip;q=1.0,deflate;q=0.6,identity;q=0.3',
'Authorization' => 'Bearer secret-key-yo',
'Content-Type' => 'application/x-www-form-urlencoded',
'User-Agent' => 'Stripe/v1 RubyBindings/2.8.0',
'X-Stripe-Client-User-Agent' => '{"bindings_version":"2.8.0","lang":"ruby","lang_version":"2.6.2 p47 (2019-03-13)","platform":"x86_64-darwin18","engine":"ruby","publisher":"stripe","uname":"Darwin 192-168-1-102.tpgi.com.au 18.7.0 Darwin Kernel Version 18.7.0: Thu Jun 20 18:42:21 PDT 2019; root:xnu-4903.270.47~4/RELEASE_X86_64 x86_64","hostname":"192-168-1-102.tpgi.com.au"}'
}).
to_return(status: 200, body: subscription.to_json, headers: {})
stub_request(:get, "https://api.stripe.com/v1/customers/cus_FhHJDzf0OxYtb8").
with(
headers: {
'Accept' => '*/*',
'Accept-Encoding' => 'gzip;q=1.0,deflate;q=0.6,identity;q=0.3',
'Authorization' => 'Bearer secret-key-yo',
'Content-Type' => 'application/x-www-form-urlencoded',
'User-Agent' => 'Stripe/v1 RubyBindings/2.8.0',
'X-Stripe-Client-User-Agent' => '{"bindings_version":"2.8.0","lang":"ruby","lang_version":"2.6.2 p47 (2019-03-13)","platform":"x86_64-darwin18","engine":"ruby","publisher":"stripe","uname":"Darwin 192-168-1-102.tpgi.com.au 18.7.0 Darwin Kernel Version 18.7.0: Thu Jun 20 18:42:21 PDT 2019; root:xnu-4903.270.47~4/RELEASE_X86_64 x86_64","hostname":"192-168-1-102.tpgi.com.au"}'
}).
to_return(status: 200, body: customer.to_json, headers: {})
invoices = {
"object": "list",
"url": "/v1/invoices",
"has_more": false,
"data": [
{
"id": "in_1Cc9wc2eZvKYlo2ClBzJbDQz",
"object": "invoice",
"account_country": "US",
"account_name": "Stripe.com",
"amount_due": 20,
"amount_paid": 0,
"amount_remaining": 20,
"application_fee_amount": "null",
"attempt_count": 0,
"attempted": false,
"auto_advance": false,
"billing": "send_invoice",
"billing_reason": "subscription_update",
"charge": "null",
"collection_method": "send_invoice",
"created": 1528800106,
"currency": "usd",
"custom_fields": "null",
"customer": "cus_FhHJDzf0OxYtb8",
"customer_address": "null",
"customer_email": "ziad+123@elysian.team",
"customer_name": "null",
"customer_phone": "null",
"customer_shipping": "null",
"customer_tax_exempt": "none",
"customer_tax_ids": [],
"default_payment_method": "null",
"default_source": "null",
"default_tax_rates": [],
"description": "null",
"discount": "null",
"due_date": 1529059306,
"ending_balance": "null",
"footer": "null",
"hosted_invoice_url": "null",
"invoice_pdf": "null",
"lines": {
"data": [
{
"id": "sli_42e8bf79bec714",
"object": "line_item",
"amount": 999,
"currency": "usd",
"description": "1 × Ivory Freelance (at $9.99 / month)",
"discountable": true,
"livemode": false,
"metadata": {},
"period": {
"end": 1521326190,
"start": 1518906990
},
"plan": {
"id": "ivory-freelance-040",
"object": "plan",
"active": true,
"aggregate_usage": "null",
"amount": 999,
"amount_decimal": "999",
"billing_scheme": "per_unit",
"created": 1466202980,
"currency": "usd",
"interval": "month",
"interval_count": 1,
"livemode": false,
"metadata": {},
"nickname": "null",
"product": "prod_BUthVRQ7KdFfa7",
"tiers": "null",
"tiers_mode": "null",
"transform_usage": "null",
"trial_period_days": "null",
"usage_type": "licensed"
},
"proration": false,
"quantity": 1,
"subscription": "sub_8epEF0PuRhmltU",
"subscription_item": "si_18NVZi2eZvKYlo2CUtBNGL9x",
"tax_amounts": [],
"tax_rates": [],
"type": "subscription"
}
],
"has_more": false,
"object": "list",
"url": "/v1/invoices/in_1Cc9wc2eZvKYlo2ClBzJbDQz/lines"
},
"livemode": false,
"metadata": {},
"next_payment_attempt": "null",
"number": "8B36FE9-0005",
"paid": false,
"payment_intent": "null",
"period_end": 1528800106,
"period_start": 1528800106,
"post_payment_credit_notes_amount": 0,
"pre_payment_credit_notes_amount": 0,
"receipt_number": "null",
"starting_balance": 10,
"statement_descriptor": "null",
"status": "draft",
"status_transitions": {
"finalized_at": "null",
"marked_uncollectible_at": "null",
"paid_at": "null",
"voided_at": "null"
},
"subscription": "sub_D2ECXpuEnnXkWU",
"subtotal": 10,
"tax": "null",
"tax_percent": "null",
"total": 10,
"total_tax_amounts": [],
"webhooks_delivered_at": 1528800106
},
]
}
stub_request(:get, "https://api.stripe.com/v1/invoices?customer=cus_FhHJDzf0OxYtb8&subscription=sub_8epEF0PuRhmltU").
with(
headers: {
'Accept' => '*/*',
'Accept-Encoding' => 'gzip;q=1.0,deflate;q=0.6,identity;q=0.3',
'Authorization' => 'Bearer secret-key-yo',
'Content-Type' => 'application/x-www-form-urlencoded',
'User-Agent' => 'Stripe/v1 RubyBindings/2.8.0',
'X-Stripe-Client-User-Agent' => '{"bindings_version":"2.8.0","lang":"ruby","lang_version":"2.6.2 p47 (2019-03-13)","platform":"x86_64-darwin18","engine":"ruby","publisher":"stripe","uname":"Darwin 192-168-1-102.tpgi.com.au 18.7.0 Darwin Kernel Version 18.7.0: Thu Jun 20 18:42:21 PDT 2019; root:xnu-4903.270.47~4/RELEASE_X86_64 x86_64","hostname":"192-168-1-102.tpgi.com.au"}'
}).
to_return(status: 200, body: invoices.to_json, headers: {})
post :create, params: { email: 'foobar@example.com' }, format: :json
expect(body['messages'][0]).to end_with(I18n.t('donations.payment.success'))
expect(response).to have_http_status(200)
end
it 'does not expect a username or email if accounts are not being created' do
current_user = log_in(:coding_horror)
post :create, params: { create_account: 'false' }
post :create, params: { create_account: 'false' }, format: :json
expect(body['messages'][0]).to end_with(I18n.t('donations.payment.success'))
expect(response).to have_http_status(200)
end
@ -55,12 +513,12 @@ module DiscourseDonations
end
it 'does not create user accounts' do
post :create, params: params
post :create, params: params, format: :json
end
it 'does not create user accounts if the user is logged in' do
log_in :coding_horror
post :create, params: params
post :create, params: params, format: :json
end
it 'does not create user accounts when settings are disabled and params are not' do
@ -177,12 +635,12 @@ module DiscourseDonations
it 'awards a group' do
post :create
expect(body['rewards']).to include({'type' => 'group', 'name' => group_name})
expect(body['rewards']).to include({ 'type' => 'group', 'name' => group_name })
end
it 'awards a badge' do
post :create
expect(body['rewards']).to include({'type' => 'badge', 'name' => badge_name})
expect(body['rewards']).to include({ 'type' => 'badge', 'name' => badge_name })
end
end
end