From 57d7f1bf0c26026facc4ce649a6d66ef6c8705f6 Mon Sep 17 00:00:00 2001
From: Keegan George <kgeorge13@gmail.com>
Date: Thu, 21 Jul 2022 14:19:01 -0700
Subject: [PATCH] DEV: Update `<SpreadsheetEditor/>` to Glimmer Component

As of [this commit](https://github.com/discourse/discourse/commit/327dd0beb3e289b613a2d60e299d2ab7189d5ee5), render-modifiers have been introduced, allowing the spreadsheet component to be successfully converted into a Glimmer Component.
---
 .../components/spreadsheet-editor.js          | 101 ++++++++----------
 .../components/spreadsheet-editor.hbs         |   6 +-
 2 files changed, 52 insertions(+), 55 deletions(-)

diff --git a/javascripts/discourse/components/spreadsheet-editor.js b/javascripts/discourse/components/spreadsheet-editor.js
index 0313473..e84a84f 100644
--- a/javascripts/discourse/components/spreadsheet-editor.js
+++ b/javascripts/discourse/components/spreadsheet-editor.js
@@ -1,45 +1,24 @@
 import { action } from "@ember/object";
 import loadScript from "discourse/lib/load-script";
 import { arrayToTable, findTableRegex, tableToObj } from "../lib/utilities";
-import Component from "@ember/component";
+import GlimmerComponent from "discourse/components/glimmer";
 import { ajax } from "discourse/lib/ajax";
 import { popupAjaxError } from "discourse/lib/ajax-error";
 import I18n from "I18n";
 import { schedule } from "@ember/runloop";
-
-export default Component.extend({
-  tagName: "",
-  showEditReason: false,
-  spreadsheet: null,
-
-  // Lifecycle Methods:
-  didInsertElement() {
-    this._super(...arguments);
-
-    schedule("afterRender", () => {
-      this.loadLibraries().then(() => {
-        if (this.isEditingTable) {
-          this.buildPopulatedTable(this.tableHtml);
-        } else {
-          this.buildNewTable();
-        }
-      });
-    });
-  },
-
-  willDestroyElement() {
-    this._super(...arguments);
-    this.spreadsheet?.destroy();
-  },
+import { tracked } from "@glimmer/tracking";
+export default class SpreadsheetEditor extends GlimmerComponent {
+  @tracked showEditReason = false;
+  spreadsheet = null;
 
   // Getters:
   get isEditingTable() {
-    if (this.tableHtml) {
+    if (this.args.tableHtml) {
       return true;
     }
 
     return false;
-  },
+  }
 
   get modalAttributes() {
     if (this.isEditingTable) {
@@ -59,22 +38,37 @@ export default Component.extend({
         },
       };
     }
-  },
+  }
 
   // Actions:
+  @action
+  createSpreadsheet(spreadsheet) {
+    this.spreadsheet = spreadsheet;
+
+    schedule("afterRender", () => {
+      this.loadLibraries().then(() => {
+        if (this.isEditingTable) {
+          this.buildPopulatedTable(this.args.tableHtml);
+        } else {
+          this.buildNewTable();
+        }
+      });
+    });
+  }
+
   @action
   showEditReasonField() {
     if (this.showEditReason) {
-      return this.set("showEditReason", false);
+      this.showEditReason = false;
     } else {
-      return this.set("showEditReason", true);
+      this.showEditReason = true;
     }
-  },
+  }
 
   @action
   cancelTableInsertion() {
-    this.triggerModalClose();
-  },
+    this.args.triggerModalClose();
+  }
 
   @action
   insertTable() {
@@ -83,19 +77,19 @@ export default Component.extend({
     const markdownTable = this.buildTableMarkdown(updatedHeaders, updatedData);
 
     if (!this.isEditingTable) {
-      this.toolbarEvent.addText(markdownTable);
-      return this.triggerModalClose();
+      this.args.toolbarEvent.addText(markdownTable);
+      return this.args.triggerModalClose();
     } else {
       return this.updateTable(markdownTable);
     }
-  },
+  }
 
   // Helper Methods:
   loadLibraries() {
     return loadScript(settings.theme_uploads.jsuites).then(() => {
       return loadScript(settings.theme_uploads.jspreadsheet);
     });
-  },
+  }
 
   buildNewTable() {
     const data = [
@@ -111,7 +105,7 @@ export default Component.extend({
     ];
 
     return this.buildSpreadsheet(data, columns);
-  },
+  }
 
   buildPopulatedTable(table) {
     const tableObject = tableToObj(table);
@@ -136,18 +130,16 @@ export default Component.extend({
     });
 
     return this.buildSpreadsheet(tableData, columns);
-  },
+  }
 
   buildSpreadsheet(data, columns, opts = {}) {
-    const spreadsheetContainer = document.querySelector("#spreadsheet");
-
     // eslint-disable-next-line no-undef
-    this.spreadsheet = jspreadsheet(spreadsheetContainer, {
+    this.spreadsheet = jspreadsheet(this.spreadsheet, {
       data,
       columns,
       ...opts,
     });
-  },
+  }
 
   buildUpdatedPost(tableId, raw, newRaw) {
     const tableToEdit = raw.match(findTableRegex());
@@ -160,20 +152,21 @@ export default Component.extend({
     }
 
     return editedTable;
-  },
+  }
 
   updateTable(markdownTable) {
-    const tableId = this.get("tableId");
-    const postId = this.model.id;
+    const tableId = this.args.tableId;
+    const postId = this.args.model.id;
     const newRaw = markdownTable;
+
     const editReason =
-      this.get("editReason") ||
+      this.editReason ||
       I18n.t(themePrefix("discourse_table_builder.edit.default_edit_reason"));
-    const raw = this.model.raw;
+    const raw = this.args.model.raw;
     const newPostRaw = this.buildUpdatedPost(tableId, raw, newRaw);
 
     return this.sendTableUpdate(postId, newPostRaw, editReason);
-  },
+  }
 
   sendTableUpdate(postId, raw, edit_reason) {
     return ajax(`/posts/${postId}.json`, {
@@ -187,9 +180,9 @@ export default Component.extend({
     })
       .catch(popupAjaxError)
       .finally(() => {
-        this.triggerModalClose();
+        this.args.triggerModalClose();
       });
-  },
+  }
 
   buildTableMarkdown(headers, data) {
     const table = [];
@@ -201,5 +194,5 @@ export default Component.extend({
     });
 
     return arrayToTable(table);
-  },
-});
+  }
+}
diff --git a/javascripts/discourse/templates/components/spreadsheet-editor.hbs b/javascripts/discourse/templates/components/spreadsheet-editor.hbs
index 7404534..b748e0b 100644
--- a/javascripts/discourse/templates/components/spreadsheet-editor.hbs
+++ b/javascripts/discourse/templates/components/spreadsheet-editor.hbs
@@ -20,7 +20,11 @@
     </div>
   {{/if}}
 
-  <div id="spreadsheet" tabindex="1" class="jexcel_container"></div>
+  <div
+    {{did-insert this.createSpreadsheet}}
+    tabindex="1"
+    class="jexcel_container"
+  ></div>
 </DModalBody>
 
 <div class="modal-footer">