DEV: Add system specs (#70)

javascripts/discourse/components/spreadsheet-editor.hbs

@@ -21,11 +21,8 @@
         @icon={{this.modalAttributes.insertTable.icon}}
         @action={{this.insertTable}}
       />
-      <DButton
+
-        @class="btn-flat"
+      <DModalCancel @close={{this.interceptCloseModal}} />
-        @label={{theme-prefix "discourse_table_builder.edit.modal.cancel"}}
-        @action={{this.interceptCloseModal}}
-      />
     </div>
 
     <div class="secondary-actions">

locales/en.yml

@@ -6,7 +6,6 @@ en:
     modal:
       title: "Table Builder"
       create: "Build Table"
-      cancel: "cancel"
       help:
         title: "Using the Spreadsheet Editor"
         enter_key: "Enter"

spec/system/page_objects/modals/insert_table.rb

@@ -0,0 +1,46 @@
+# frozen_string_literal: true
+
+module PageObjects
+  module Modals
+    class InsertTable < PageObjects::Modals::Base
+      MODAL_SELECTOR = ".insert-table-modal"
+      SPREADSHEET_TABLE_SELECTOR = "#{MODAL_SELECTOR} .jexcel"
+
+      def click_insert_table
+        find("#{MODAL_SELECTOR} .btn-insert-table").click
+      end
+
+      def cancel
+        find("#{MODAL_SELECTOR} .d-modal-cancel").click
+      end
+
+      def click_edit_reason
+        find("#{MODAL_SELECTOR} .btn-edit-reason").click
+      end
+
+      def type_edit_reason(text)
+        find("#{MODAL_SELECTOR} .edit-reason input").send_keys(text)
+      end
+
+      def find_cell(row, col)
+        find(
+          "#{SPREADSHEET_TABLE_SELECTOR} tbody tr[data-y='#{row}'] td[data-x='#{col}']"
+        )
+      end
+
+      def select_cell(row, col)
+        find_cell(row, col).double_click
+      end
+
+      def type_in_cell(row, col, text)
+        select_cell(row, col)
+        cell = find_cell(row, col).find("textarea")
+        cell.send_keys(text, :return)
+      end
+
+      def has_content_in_cell?(row, col, content)
+        find_cell(row, col).text == content
+      end
+    end
+  end
+end

spec/system/table_builder_spec.rb

@@ -0,0 +1,157 @@
+# frozen_string_literal: true
+
+require_relative "page_objects/modals/insert_table"
+
+RSpec.describe "Table Builder", system: true do
+  fab!(:user) { Fabricate(:user) }
+
+  let!(:theme_component) { upload_theme_component }
+  let(:composer) { PageObjects::Components::Composer.new }
+  let(:insert_table_modal) { PageObjects::Modals::InsertTable.new }
+  let(:sample_table_md) {}
+  fab!(:topic) { Fabricate(:topic, user: user) }
+  fab!(:post1) { create_post(user: user, topic: topic, raw: <<~RAW) }
+        |Make   | Model   | Year|
+        |-------| ------- | ----|
+        |Toyota | Supra   | 1998|
+        |Nissan | Skyline | 1999|
+        |Honda  | S2000  | 2001|
+        RAW
+
+  let(:topic_page) { PageObjects::Pages::Topic.new }
+
+  before { sign_in(user) }
+
+  def normalize_value(content)
+    content.strip.gsub(/\s+/, " ").gsub(/\r\n/, "\n")
+  end
+
+  context "when creating a new table" do
+    it "should add table items created in spreadsheet to composer input" do
+      visit("/latest")
+      page.find("#create-topic").click
+      page.find(".toolbar-popup-menu-options").click
+      page.find(".select-kit-row[data-name='Insert Table']").click
+      insert_table_modal.type_in_cell(0, 0, "Item 1")
+      insert_table_modal.type_in_cell(0, 1, "Item 2")
+      insert_table_modal.type_in_cell(0, 2, "Item 3")
+      insert_table_modal.type_in_cell(0, 3, "Item 4")
+      insert_table_modal.click_insert_table
+
+      created_table = <<~TABLE
+      |Column 1 | Column 2 | Column 3 | Column 4|
+      |--- | --- | --- | ---|
+      |Item 1 | Item 2 | Item 3 | Item 4|
+      | |  |  | |
+      | |  |  | |
+      | |  |  | |
+      | |  |  | |
+      | |  |  | |
+      TABLE
+
+      expect(normalize_value(composer.composer_input.value)).to eq(
+        normalize_value(created_table)
+      )
+    end
+
+    context "when cancelling table creation" do
+      it "should close the modal if there are no changes made" do
+        visit("/latest")
+        page.find("#create-topic").click
+        page.find(".toolbar-popup-menu-options").click
+        page.find(".select-kit-row[data-name='Insert Table']").click
+        insert_table_modal.cancel
+        expect(page).to have_no_css(".insert-table-modal")
+      end
+
+      it "should show a warning popup if there are unsaved changes" do
+        visit("/latest")
+        page.find("#create-topic").click
+        page.find(".toolbar-popup-menu-options").click
+        page.find(".select-kit-row[data-name='Insert Table']").click
+        insert_table_modal.type_in_cell(0, 0, "Item 1")
+        insert_table_modal.cancel
+        expect(page).to have_css(".dialog-container .dialog-content")
+      end
+    end
+  end
+
+  context "when editing a table" do
+    it "should prefill the spreadsheet with the markdown table items from the post" do
+      topic_page.visit_topic(topic)
+      topic_page.find(".btn-edit-table", visible: :all).click
+      expect(page).to have_selector(".insert-table-modal")
+
+      expected_table_content = [
+        %w[Toyota Supra 1998],
+        %w[Nissan Skyline 1999],
+        %w[Honda S2000 2001]
+      ]
+
+      expected_table_content.each_with_index do |row, row_index|
+        row.each_with_index do |content, col_index|
+          expect(insert_table_modal).to have_content_in_cell(
+            row_index,
+            col_index,
+            content
+          )
+        end
+      end
+    end
+
+    it "should update the post with the new table content" do
+      topic_page.visit_topic(topic)
+      topic_page.find(".btn-edit-table", visible: :all).click
+      expect(page).to have_selector(".insert-table-modal")
+      insert_table_modal.type_in_cell(1, 1, " GTR")
+      insert_table_modal.click_insert_table
+
+      updated_post = <<~RAW
+      |Make | Model | Year|
+      |-------| ------- | ----|
+      |Toyota | Supra | 1998|
+      |Nissan | Skyline | 1999|
+      |Honda | S2000 | 2001|
+      RAW
+
+      expect(normalize_value(post1.reload.raw)).to eq(
+        normalize_value(updated_post)
+      )
+    end
+
+    context "when adding an edit reason" do
+      it "should add the edit reason to the edit history" do
+        edit_reason = "Updated Nissan model"
+
+        topic_page.visit_topic(topic)
+        topic_page.find(".btn-edit-table", visible: :all).click
+        expect(page).to have_selector(".insert-table-modal")
+        insert_table_modal.type_in_cell(1, 1, " GTR")
+        insert_table_modal.click_edit_reason
+        insert_table_modal.type_edit_reason(edit_reason)
+        insert_table_modal.click_insert_table
+        wait_for { post1.reload.edit_reason == edit_reason }
+        expect(post1.reload.edit_reason).to eq(edit_reason)
+      end
+    end
+
+    context "when cancelling table creation" do
+      it "should close the modal if there are no changes made" do
+        topic_page.visit_topic(topic)
+        topic_page.find(".btn-edit-table", visible: :all).click
+        expect(page).to have_selector(".insert-table-modal")
+        insert_table_modal.cancel
+        expect(page).to have_no_css(".insert-table-modal")
+      end
+
+      it "should show a warning popup if there are unsaved changes" do
+        topic_page.visit_topic(topic)
+        topic_page.find(".btn-edit-table", visible: :all).click
+        expect(page).to have_selector(".insert-table-modal")
+        insert_table_modal.type_in_cell(1, 1, " GTR")
+        insert_table_modal.cancel
+        expect(page).to have_css(".dialog-container .dialog-content")
+      end
+    end
+  end
+end