388c4a58e5
DEV: Update `SpreadsheetEditor` to use `@glimmer/component` ( #13 )
...
Now that all of our singletons have been converted to true Ember Services, we can remove our custom `discourse/component/glimmer` superclass and use explicit injection
2022-08-11 11:59:08 -07:00
7b37c6acc1
FIX: Special character alignment issue ( #10 )
...
* DEV: Use alternate fork of `array-to-table`
* DEV: Add unit test for `arrayToTable()` method
* Move `arrayToTable` so it is available for unit tests
* DEV: Add assertion for creating a markdown table with special chars
When a table with special characters (such as `$`) is inserted in a cell to the right of a blank cell. The alignment of the table gets ruined if the table doesn't have surrounding pipes. This check ensures this alignment is correct.
Co-authored-by: Penar Musaraj <pmusaraj@gmail.com>
2022-08-11 11:33:34 -07:00
dacdd1cc4e
FIX: Edit Table button appearing in all `<table>` elements ( #12 )
2022-08-11 11:12:01 -07:00
4289145268
UX: Wrap words instead of dynamic widths and align left ( #11 )
...
* UX: Wrap words instead of dynamic widths and align left
* UX: Improve sticky header on scroll
* DEV: Convert default column text to localizable strings
2022-08-10 13:50:38 -07:00
d25736adad
DEV: Remove Table HTML usage ( #9 )
...
* DEV: Remove Table HTML usage
* DEV: Apply ember linting
2022-08-09 17:14:35 -07:00
98a9081e25
DEV: Populate table content using raw markdown ( #7 )
...
* Very exploratory MD work
* DEV: Populate table content using raw markdown
* DEV: 💄 Linting Fixes
Co-authored-by: Penar Musaraj <pmusaraj@gmail.com>
2022-08-09 16:51:17 -07:00
69bfac2226
UX: Change edit modal primary button to `Save Edit` ( #8 )
...
To add consistency with naming used in other areas of the composer, this PR changes the label of the primary button from Update Table to Save Edit
2022-08-09 16:42:47 -07:00
993a1bbd43
FIX: Use `canEdit` property rather than comparing user ( #6 )
...
* FIX: Use `canEdit` property rather than comparing user
* DEV: Remove unused currentUser variable
2022-08-08 12:21:30 -07:00
695980a250
Merge branch 'main' of https://github.com/keegangeorge/discourse-table-builder
2022-07-28 07:43:23 -07:00
e56f9eacb6
UX: Allow modal to grow dependant on table size
2022-07-28 07:43:10 -07:00
52710496ed
FIX: conflicting class declaration with core ( #4 )
...
* DEV: Remove `fade-in` and use `jsuites.basic.css` instead
* FIX: Linting issues with jspreadsheet-theme
* WIP: Add bash script to handle vendor assets
* FIX: Ember Linting fixes
* DEV: Cleanup comments and commented code
2022-07-28 07:33:25 -07:00
12e09ebad6
Merge pull request #3 from discourse/fix-csp-issues
...
FIX: Use local theme files for external libs
2022-07-26 12:14:36 -07:00
f8a914c8cc
FIX: Use local theme files for external libs
...
This also makes sure we don't need any CSP rules for the loaded JS files.
2022-07-26 13:35:02 -04:00
807b9e0b31
UX: Minor fixes for dark mode
2022-07-21 14:42:55 -07:00
99dc02d896
UX: Hide about in context menu
2022-07-21 14:42:46 -07:00
57d7f1bf0c
DEV: Update `<SpreadsheetEditor/>` to Glimmer Component
...
As of [this commit](327dd0beb3
2022-07-21 14:19:01 -07:00
fbbf78d99b
FIX: Expand button not working on multiple tables in post
2022-07-20 16:28:43 -07:00
20890f7e67
DEV: Improve variable naming for edit icon
2022-07-20 15:15:13 -07:00
8e078d2bc9
DEV: Update tests
2022-07-20 11:18:25 -07:00
9b59f6eeea
DEV: Disable linting for libraries
2022-07-20 11:18:19 -07:00
8b596e3bd2
FIX: New cover image not applying
2022-07-19 16:51:09 -07:00
2c8eca5c28
Merge pull request #2 from keegangeorge/feature-spreadsheet-builder
...
FEATURE: Use spreadsheet editor for building tables
2022-07-19 16:49:10 -07:00
55588620c7
DOCS: Update cover image
2022-07-19 16:42:32 -07:00
3eee3da853
FEATURE: Use spreadsheet editor for building tables
2022-07-19 16:33:10 -07:00
a50cd73dcf
DOCS: Remove To-Do list and update cover image
2022-07-18 11:45:21 -07:00
60d9d65095
Merge pull request #1 from keegangeorge/feature-edit-table
...
FEATURE: Ability to edit markdown tables in posts
2022-07-18 11:32:17 -07:00
f2a77afba5
DEV: Stylesheet fixes
2022-07-18 11:23:38 -07:00
b7a0a22e95
DEV: Cleanup
...
- Linting Fixes (prettier, eslint, ember template lint)
- Reorganize code, moving declarations, consolidating functionality into separate methods
- Add default edit reason locale vs hard-coded string
2022-07-18 11:18:58 -07:00
2ddb6de654
FIX: Only update table portion from raw post
2022-07-18 11:03:57 -07:00
d74b713d0b
FEATURE: Update post contents with edited table (WIP)
...
Known issue: overrides other content on the post and replaces the post with only the table
2022-07-16 11:00:05 -07:00
669be70f18
DEV: Add logic to build markdown table
2022-07-14 17:07:05 -07:00
4bbb3a9647
FEATURE: Column width dynamically set based on heading length
2022-07-14 10:05:27 -07:00
05cd2ada7e
DEV: Remove comments and unused code
2022-07-14 10:05:07 -07:00
bf454250fe
UX: Update cell styles
2022-07-14 10:04:50 -07:00
9b241aaead
DEV: Separate styles into partials
2022-07-14 09:24:38 -07:00
f76ae6dcd8
DEV: Remove unused imports
2022-07-14 09:21:27 -07:00
40f42a92d2
DEV: Move jsuites library to separate file
2022-07-14 09:21:22 -07:00
67a27f0ece
UX: Apply primary button styling for Edit Table button
2022-07-14 08:56:31 -07:00
86af126978
FIX: Spreadsheet only loading for one instance
...
This commit moves spreadsheet logic to a component which resolves the issue where the spreadsheet only loads the first time the edit modal appears.
2022-07-14 08:56:11 -07:00
414e7e6a84
DEV: Remove `ajax` request as raw post is not needed
2022-07-13 16:00:42 -07:00
87b91f5a6f
WIP: Use JSpreadsheet instead of Importabular
2022-07-13 15:42:13 -07:00
29089a6c43
DOCS: Update known issue list
2022-07-13 11:39:18 -07:00
905e553635
FIX: Expand button not working
2022-07-13 11:38:47 -07:00
633109804c
DEV: Add comment for clarity
2022-07-13 11:38:33 -07:00
9bfc23c599
WIP: New approach (see description)
...
- Add edit table button (beside expand table button)
- Parse the table contents
- Display the table as a spreadsheet using the Importabular library
2022-07-12 15:27:03 -07:00
b62f595eeb
DEV: Trigger modal from Edit Table Button
...
Triggers modal after clicking Edit Table from selection. Data from post is then passed to the modal.
2022-07-11 15:05:50 -07:00
83d10bff76
FIX: Linting issues
2022-07-04 18:10:08 -07:00
e733414781
DEV: Move linting/tests to `/workflows` folder
2022-07-04 18:05:47 -07:00
34d1327951
DEV: Add acceptance tests
2022-07-04 18:03:43 -07:00
ccaa7b1d41
FIX: Typo in composer button
...
`Insert Title` => `Insert Table`
2022-07-04 16:35:58 -07:00
Keegan George
Penar Musaraj