discourse/lib/validators/enable_sso_validator.rb

Ignoring revisions in .git-blame-ignore-revs. Click here to bypass and see the normal blame view.

28 lines
629 B
Ruby
Raw Permalink Normal View History

# frozen_string_literal: true
class EnableSsoValidator
def initialize(opts = {})
@opts = opts
end
def valid_value?(val)
return true if val == "f"
return false if SiteSetting.discourse_connect_url.blank? || is_2fa_enforced?
true
end
def error_message
FEATURE: Rename 'Discourse SSO' to DiscourseConnect (#11978) The 'Discourse SSO' protocol is being rebranded to DiscourseConnect. This should help to reduce confusion when 'SSO' is used in the generic sense. This commit aims to: - Rename `sso_` site settings. DiscourseConnect specific ones are prefixed `discourse_connect_`. Generic settings are prefixed `auth_` - Add (server-side-only) backwards compatibility for the old setting names, with deprecation notices - Copy `site_settings` database records to the new names - Rename relevant translation keys - Update relevant translations This commit does **not** aim to: - Rename any Ruby classes or methods. This might be done in a future commit - Change any URLs. This would break existing integrations - Make any changes to the protocol. This would break existing integrations - Change any functionality. Further normalization across DiscourseConnect and other auth methods will be done separately The risks are: - There is no backwards compatibility for site settings on the client-side. Accessing auth-related site settings in Javascript is fairly rare, and an error on the client side would not be security-critical. - If a plugin is monkey-patching parts of the auth process, changes to locale keys could cause broken error messages. This should also be unlikely. The old site setting names remain functional, so security-related overrides will remain working. A follow-up commit will be made with a post-deploy migration to delete the old `site_settings` rows.
2021-02-08 05:04:33 -05:00
if SiteSetting.discourse_connect_url.blank?
return I18n.t("site_settings.errors.discourse_connect_url_is_empty")
end
if is_2fa_enforced?
I18n.t("site_settings.errors.discourse_connect_cannot_be_enabled_if_second_factor_enforced")
end
end
def is_2fa_enforced?
SiteSetting.enforce_second_factor? != "no"
end
end