2019-04-29 20:27:42 -04:00
|
|
|
# frozen_string_literal: true
|
|
|
|
|
FEATURE: Drafts view in user profile
* add drafts.json endpoint, user profile tab with drafts stream
* improve drafts stream display in user profile
* truncate excerpts in drafts list, better handling for resume draft action
* improve draft stream SQL query, add rspec tests
* if composer is open, quietly close it when user opens another draft from drafts stream; load PM draft only when user is in /u/username/messages (instead of /u/username)
* cleanup
* linting fixes
* apply prettier styling to modified files
* add client tests for drafts, includes a fixture for drafts.json
* improvements to code following review
* refresh drafts route when user deletes a draft open in the composer while being in the drafts route; minor prettier scss fix
* added more spec tests, deleted an acceptance test for removing drafts that was too finicky, formatting and code style fixes, added appEvent for draft:destroyed
* prettier, eslint fixes
* use "username_lower" from users table, added error handling for rejected promises
* adds guardian spec for can_see_drafts, adds improvements following code review
* move DraftsController spec to its own file
* fix failing drafts qunit test, use getOwner instead of deprecated this.container
* limit test fixture for draft.json testing to new_topic request only
2018-08-01 02:34:54 -04:00
|
|
|
require 'rails_helper'
|
|
|
|
|
|
|
|
describe DraftsController do
|
|
|
|
it 'requires you to be logged in' do
|
|
|
|
get "/drafts.json"
|
|
|
|
expect(response.status).to eq(403)
|
|
|
|
end
|
|
|
|
|
|
|
|
it 'returns correct stream length after adding a draft' do
|
|
|
|
user = sign_in(Fabricate(:user))
|
|
|
|
Draft.set(user, 'xxx', 0, '{}')
|
|
|
|
get "/drafts.json", params: { username: user.username }
|
|
|
|
expect(response.status).to eq(200)
|
|
|
|
parsed = JSON.parse(response.body)
|
|
|
|
expect(parsed["drafts"].length).to eq(1)
|
|
|
|
end
|
|
|
|
|
|
|
|
it 'has empty stream after deleting last draft' do
|
|
|
|
user = sign_in(Fabricate(:user))
|
|
|
|
Draft.set(user, 'xxx', 0, '{}')
|
|
|
|
Draft.clear(user, 'xxx', 0)
|
|
|
|
get "/drafts.json", params: { username: user.username }
|
|
|
|
expect(response.status).to eq(200)
|
|
|
|
parsed = JSON.parse(response.body)
|
|
|
|
expect(parsed["drafts"].length).to eq(0)
|
|
|
|
end
|
2018-09-12 10:13:20 -04:00
|
|
|
|
2018-09-12 11:09:30 -04:00
|
|
|
it 'does not let a user see drafts stream of another user' do
|
2018-09-12 11:06:30 -04:00
|
|
|
user_b = Fabricate(:user)
|
|
|
|
Draft.set(user_b, 'xxx', 0, '{}')
|
|
|
|
sign_in(Fabricate(:user))
|
|
|
|
get "/drafts.json", params: { username: user_b.username }
|
2018-09-12 13:08:02 -04:00
|
|
|
expect(response.status).to eq(403)
|
2018-09-12 10:13:20 -04:00
|
|
|
end
|
2020-03-23 07:02:24 -04:00
|
|
|
|
|
|
|
it 'does not include topic details when user cannot see topic' do
|
|
|
|
topic = Fabricate(:private_message_topic)
|
|
|
|
topic_user = topic.user
|
|
|
|
other_user = Fabricate(:user)
|
|
|
|
Draft.set(topic_user, "topic_#{topic.id}", 0, '{}')
|
|
|
|
Draft.set(other_user, "topic_#{topic.id}", 0, '{}')
|
|
|
|
|
|
|
|
sign_in(topic_user)
|
|
|
|
get "/drafts.json", params: { username: topic_user.username }
|
|
|
|
expect(response.status).to eq(200)
|
|
|
|
parsed = JSON.parse(response.body)
|
|
|
|
expect(parsed["drafts"].first["title"]).to eq(topic.title)
|
|
|
|
|
|
|
|
sign_in(other_user)
|
|
|
|
get "/drafts.json", params: { username: other_user.username }
|
|
|
|
expect(response.status).to eq(200)
|
|
|
|
parsed = JSON.parse(response.body)
|
|
|
|
expect(parsed["drafts"].first["title"]).to eq(nil)
|
|
|
|
end
|
FEATURE: Drafts view in user profile
* add drafts.json endpoint, user profile tab with drafts stream
* improve drafts stream display in user profile
* truncate excerpts in drafts list, better handling for resume draft action
* improve draft stream SQL query, add rspec tests
* if composer is open, quietly close it when user opens another draft from drafts stream; load PM draft only when user is in /u/username/messages (instead of /u/username)
* cleanup
* linting fixes
* apply prettier styling to modified files
* add client tests for drafts, includes a fixture for drafts.json
* improvements to code following review
* refresh drafts route when user deletes a draft open in the composer while being in the drafts route; minor prettier scss fix
* added more spec tests, deleted an acceptance test for removing drafts that was too finicky, formatting and code style fixes, added appEvent for draft:destroyed
* prettier, eslint fixes
* use "username_lower" from users table, added error handling for rejected promises
* adds guardian spec for can_see_drafts, adds improvements following code review
* move DraftsController spec to its own file
* fix failing drafts qunit test, use getOwner instead of deprecated this.container
* limit test fixture for draft.json testing to new_topic request only
2018-08-01 02:34:54 -04:00
|
|
|
end
|