discourse/db/migrate/20180327062911_add_post_cus...

# frozen_string_literal: true

# This is our current pattern for data migrations needed by plugins, we prefer to keep them in core
# so schema is tightly controlled, especially if we are amending tables owned by core
#
# this index makes looking up posts requiring review much faster (20ms on meta)

class AddPostCustomFieldsAkismetIndex < ActiveRecord::Migration[5.1]
  def change
    add_index :post_custom_fields,
              [:post_id],
              name: "idx_post_custom_fields_akismet",
              where: "name = 'AKISMET_STATE' AND value = 'needs_review'"
  end
end
DEV: enable frozen string literal on all files This reduces chances of errors where consumers of strings mutate inputs and reduces memory usage of the app. Test suite passes now, but there may be some stuff left, so we will run a few sites on a branch prior to merging 2019-05-02 18:17:27 -04:00			`# frozen_string_literal: true`

PERF: add missing index for akismet Note, current practice if for plugins to submit PRs to core for any migrations required for plugins, so we can better control schema. Especially if core tables are being touched. In this case index has close to zero cost unless akismet is installed This reduces the akismet admin query from 20ms on every new page load to 0.5ms 2018-03-27 02:36:13 -04:00			`# This is our current pattern for data migrations needed by plugins, we prefer to keep them in core`
			`# so schema is tightly controlled, especially if we are amending tables owned by core`
			`#`
			`# this index makes looking up posts requiring review much faster (20ms on meta)`

			`class AddPostCustomFieldsAkismetIndex < ActiveRecord::Migration[5.1]`
			`def change`
			`add_index :post_custom_fields,`
			`[:post_id],`
			`name: "idx_post_custom_fields_akismet",`
			`where: "name = 'AKISMET_STATE' AND value = 'needs_review'"`
			`end`
			`end`