discourse/spec/components/cooked_post_processor_spec.rb

require "rails_helper"
require "cooked_post_processor"

describe CookedPostProcessor do
  context "#post_process" do
    let(:upload) do
      Fabricate(:upload,
        url: '/uploads/default/original/1X/1/1234567890123456.jpg'
      )
    end

    let(:post) do
      Fabricate(:post, raw: <<~RAW)
      <img src="#{upload.url}">
      RAW
    end

    let(:cpp) { CookedPostProcessor.new(post, disable_loading_image: true) }
    let(:post_process) { sequence("post_process") }

    it "post process in sequence" do
      cpp.expects(:post_process_oneboxes).in_sequence(post_process)
      cpp.expects(:post_process_images).in_sequence(post_process)
      cpp.expects(:optimize_urls).in_sequence(post_process)
      cpp.expects(:pull_hotlinked_images).in_sequence(post_process)
      cpp.post_process

      expect(PostUpload.exists?(post: post, upload: upload)).to eq(true)
    end

    describe 'when post contains oneboxes and inline oneboxes' do
      let(:url_hostname) { 'meta.discourse.org' }

      let(:url) do
        "https://#{url_hostname}/t/mini-inline-onebox-support-rfc/66400"
      end

      let(:not_oneboxed_url) do
        "https://#{url_hostname}/t/random-url"
      end

      let(:title) { 'some title' }

      let(:post) do
        Fabricate(:post, raw: <<~RAW)
        #{url}
        This is a #{url} with path

        #{not_oneboxed_url}

        This is a https://#{url_hostname}/t/another-random-url test
        This is a #{url} with path

        #{url}
        RAW
      end

      before do
        SiteSetting.enable_inline_onebox_on_all_domains = true

        %i{head get}.each do |method|
          stub_request(method, url).to_return(
            status: 200,
            body: <<~RAW
            <html>
              <head>
                <title>#{title}</title>
                <meta property='og:title' content="#{title}">
                <meta property='og:description' content="some description">
              </head>
            </html>
            RAW
          )
        end
      end

      after do
        InlineOneboxer.purge(url)
        Oneboxer.invalidate(url)
      end

      it 'should respect SiteSetting.max_oneboxes_per_post' do
        SiteSetting.max_oneboxes_per_post = 2
        SiteSetting.add_rel_nofollow_to_user_content = false

        cpp.post_process

        expect(cpp.html).to have_tag('a',
          with: {
            href: url,
            class: described_class::INLINE_ONEBOX_CSS_CLASS
          },
          text: title,
          count: 2
        )

        expect(cpp.html).to have_tag('aside.onebox a', text: title, count: 2)

        expect(cpp.html).to have_tag('aside.onebox a',
          text: url_hostname,
          count: 2
        )

        expect(cpp.html).to have_tag('a',
          without: {
            class: described_class::INLINE_ONEBOX_LOADING_CSS_CLASS
          },
          text: not_oneboxed_url,
          count: 1
        )

        expect(cpp.html).to have_tag('a',
          without: {
            class: 'onebox'
          },
          text: not_oneboxed_url,
          count: 1
        )
      end
    end

    describe 'when post contains inline oneboxes' do
      let(:loading_css_class) do
        described_class::INLINE_ONEBOX_LOADING_CSS_CLASS
      end

      before do
        SiteSetting.enable_inline_onebox_on_all_domains = true
      end

      describe 'internal links' do
        let(:topic) { Fabricate(:topic) }
        let(:url) { topic.url }
        let(:post) { Fabricate(:post, raw: "Hello #{url}") }

        it "includes the topic title" do
          cpp.post_process

          expect(cpp.html).to have_tag('a',
            with: {
              href: UrlHelper.cook_url(url)
            },
            without: {
              class: loading_css_class
            },
            text: topic.title,
            count: 1
          )

          topic.update!(title: "Updated to something else")
          cpp = CookedPostProcessor.new(post, invalidate_oneboxes: true)
          cpp.post_process

          expect(cpp.html).to have_tag('a',
            with: {
              href: UrlHelper.cook_url(url)
            },
            without: {
              class: loading_css_class
            },
            text: topic.title,
            count: 1
          )
        end
      end

      describe 'external links' do
        let(:url_with_path) do
          'https://meta.discourse.org/t/mini-inline-onebox-support-rfc/66400'
        end

        let(:url_with_query_param) do
          'https://meta.discourse.org?a'
        end

        let(:url_no_path) do
          'https://meta.discourse.org/'
        end

        let(:urls) do
          [
            url_with_path,
            url_with_query_param,
            url_no_path
          ]
        end

        let(:title) { '<b>some title</b>' }
        let(:escaped_title) { CGI.escapeHTML(title) }

        let(:post) do
          Fabricate(:post, raw: <<~RAW)
          This is a #{url_with_path} topic
          This should not be inline #{url_no_path} oneboxed

          - #{url_with_path}


             - #{url_with_query_param}
          RAW
        end

        before do
          urls.each do |url|
            stub_request(:get, url).to_return(
              status: 200,
              body: "<html><head><title>#{escaped_title}</title></head></html>"
            )
          end
        end

        after do
          urls.each { |url| InlineOneboxer.purge(url) }
        end

        it 'should convert the right links to inline oneboxes' do
          cpp.post_process
          html = cpp.html

          expect(html).to_not have_tag('a',
            with: {
              href: url_no_path
            },
            without: {
              class: loading_css_class
            },
            text: title
          )

          expect(html).to have_tag('a',
            with: {
              href: url_with_path
            },
            without: {
              class: loading_css_class
            },
            text: title,
            count: 2
          )

          expect(html).to have_tag('a',
            with: {
              href: url_with_query_param
            },
            without: {
              class: loading_css_class
            },
            text: title,
            count: 1
          )
        end
      end
    end
  end

  context "#post_process_images" do

    before do
      SiteSetting.responsive_post_image_sizes = ""
    end

    context "responsive images" do
      before { SiteSetting.responsive_post_image_sizes = "1|1.5|3" }

      it "includes responsive images on demand" do
        upload = Fabricate(:upload, width: 2000, height: 1500, filesize: 10000)
        post = Fabricate(:post, raw: "hello <img src='#{upload.url}'>")

        # fake some optimized images
        OptimizedImage.create!(
          url: 'http://a.b.c/666x500.jpg',
          width: 666,
          height: 500,
          upload_id: upload.id,
          sha1: SecureRandom.hex,
          extension: '.jpg',
          filesize: 500,
          version: OptimizedImage::VERSION
        )

        # fake 3x optimized image, we lose 2 pixels here over original due to rounding on downsize
        OptimizedImage.create!(
          url: 'http://a.b.c/1998x1500.jpg',
          width: 1998,
          height: 1500,
          upload_id: upload.id,
          sha1: SecureRandom.hex,
          extension: '.jpg',
          filesize: 800
        )

        # Fake a loading image
        optimized_image = OptimizedImage.create!(
          url: 'http://a.b.c/10x10.png',
          width: CookedPostProcessor::LOADING_SIZE,
          height: CookedPostProcessor::LOADING_SIZE,
          upload_id: upload.id,
          sha1: SecureRandom.hex,
          extension: '.png',
          filesize: 123
        )

        cpp = CookedPostProcessor.new(post)

        cpp.add_to_size_cache(upload.url, 2000, 1500)
        cpp.post_process_images

        html = cpp.html

        expect(html).to include(%Q|data-small-upload="#{optimized_image.url}"|)
        # 1.5x is skipped cause we have a missing thumb
        expect(html).to include('srcset="http://a.b.c/666x500.jpg, http://a.b.c/1998x1500.jpg 3x"')
      end

      it "doesn't include response images for cropped images" do
        upload = Fabricate(:upload, width: 200, height: 4000, filesize: 12345)
        post = Fabricate(:post, raw: "hello <img src='#{upload.url}'>")

        # fake some optimized images
        OptimizedImage.create!(
          url: 'http://a.b.c/200x500.jpg',
          width: 200,
          height: 500,
          upload_id: upload.id,
          sha1: SecureRandom.hex,
          extension: '.jpg',
          filesize: 500
        )

        cpp = CookedPostProcessor.new(post)
        cpp.add_to_size_cache(upload.url, 200, 4000)
        cpp.post_process_images

        expect(cpp.html).to_not include('srcset="')
      end
    end

    shared_examples "leave dimensions alone" do
      it "doesn't use them" do
        expect(cpp.html).to match(/src="http:\/\/foo.bar\/image.png" width="" height=""/)
        expect(cpp.html).to match(/src="http:\/\/domain.com\/picture.jpg" width="50" height="42"/)
        expect(cpp).to be_dirty
      end
    end

    context "with image_sizes" do
      let(:post) { Fabricate(:post_with_image_urls) }
      let(:cpp) { CookedPostProcessor.new(post, image_sizes: image_sizes) }

      before { cpp.post_process_images }

      context "valid" do
        let(:image_sizes) { { "http://foo.bar/image.png" => { "width" => 111, "height" => 222 } } }

        it "uses them" do
          expect(cpp.html).to match(/src="http:\/\/foo.bar\/image.png" width="111" height="222"/)
          expect(cpp.html).to match(/src="http:\/\/domain.com\/picture.jpg" width="50" height="42"/)
          expect(cpp).to be_dirty
        end
      end

      context "invalid width" do
        let(:image_sizes) { { "http://foo.bar/image.png" => { "width" => 0, "height" => 222 } } }
        include_examples "leave dimensions alone"
      end

      context "invalid height" do
        let(:image_sizes) { { "http://foo.bar/image.png" => { "width" => 111, "height" => 0 } } }
        include_examples "leave dimensions alone"
      end

      context "invalid width & height" do
        let(:image_sizes) { { "http://foo.bar/image.png" => { "width" => 0, "height" => 0 } } }
        include_examples "leave dimensions alone"
      end

    end

    context "with unsized images" do

      let(:post) { Fabricate(:post_with_unsized_images) }
      let(:cpp) { CookedPostProcessor.new(post) }

      it "adds the width and height to images that don't have them" do
        FastImage.expects(:size).returns([123, 456])
        cpp.post_process_images
        expect(cpp.html).to match(/width="123" height="456"/)
        expect(cpp).to be_dirty
      end

    end

    context "with large images" do

      let(:upload) { Fabricate(:upload) }
      let(:post) { Fabricate(:post_with_large_image) }
      let(:cpp) { CookedPostProcessor.new(post, disable_loading_image: true) }

      before do
        SiteSetting.max_image_height = 2000
        SiteSetting.create_thumbnails = true
        FastImage.expects(:size).returns([1750, 2000])
      end

      it "generates overlay information" do
        Upload.expects(:get_from_url).returns(upload)
        OptimizedImage.expects(:resize).returns(true)

        FileStore::BaseStore.any_instance.expects(:get_depth_for).returns(0)

        cpp.post_process_images
        expect(cpp.html).to match_html "<p><div class=\"lightbox-wrapper\"><a class=\"lightbox\" href=\"/uploads/default/original/1X/1234567890123456.jpg\" data-download-href=\"/uploads/default/#{upload.sha1}\" title=\"logo.png\"><img src=\"/uploads/default/optimized/1X/#{upload.sha1}_#{OptimizedImage::VERSION}_690x788.png\" width=\"690\" height=\"788\"><div class=\"meta\">
<span class=\"filename\">logo.png</span><span class=\"informations\">1750×2000 1.21 KB</span><span class=\"expand\"></span>
</div></a></div></p>"
        expect(cpp).to be_dirty
      end

      describe 'when image is inside onebox' do
        let(:url) { 'https://image.com/my-avatar' }
        let(:post) { Fabricate(:post, raw: url) }

        before do
          Oneboxer.stubs(:onebox).with(url, anything).returns("<img class='onebox' src='/uploads/default/original/1X/1234567890123456.jpg' />")
        end

        it 'should not add lightbox' do
          cpp.post_process_oneboxes
          cpp.post_process_images

          expect(cpp.html).to match_html("<p><img class=\"onebox\" src=\"/uploads/default/original/1X/1234567890123456.jpg\" width=\"690\"\ height=\"788\"></p>")
        end
      end

      describe 'when image is an svg' do
        let(:post) do
          Fabricate(:post, raw: '<img src="/uploads/default/original/1X/1234567890123456.svg">')
        end

        it 'should not add lightbox' do
          cpp.post_process_images

          expect(cpp.html).to match_html("<p><img src=\"/uploads/default/original/1X/1234567890123456.svg\" width=\"690\"\ height=\"788\"></p>")
        end

        describe 'when image src is an URL' do
          let(:post) do
            Fabricate(:post, raw: '<img src="http://test.discourse/uploads/default/original/1X/1234567890123456.svg?somepamas">')
          end

          it 'should not add lightbox' do
            SiteSetting.crawl_images = true
            cpp.post_process_images

            expect(cpp.html).to match_html("<p><img src=\"http://test.discourse/uploads/default/original/1X/1234567890123456.svg?somepamas\" width=\"690\"\ height=\"788\"></p>")
          end
        end
      end

    end

    context "with tall images" do

      let(:upload) { Fabricate(:upload) }
      let(:post) { Fabricate(:post_with_large_image) }
      let(:cpp) { CookedPostProcessor.new(post, disable_loading_image: true) }

      before do
        SiteSetting.create_thumbnails = true

        Upload.expects(:get_from_url).returns(upload)
        FastImage.expects(:size).returns([860, 2000])
        OptimizedImage.expects(:resize).never
        OptimizedImage.expects(:crop).returns(true)

        FileStore::BaseStore.any_instance.expects(:get_depth_for).returns(0)
      end

      it "crops the image" do
        cpp.post_process_images
        expect(cpp.html).to match(/width="690" height="500">/)
        expect(cpp).to be_dirty
      end

    end

    context "with iPhone X screenshots" do

      let(:upload) { Fabricate(:upload) }
      let(:post) { Fabricate(:post_with_large_image) }
      let(:cpp) { CookedPostProcessor.new(post, disable_loading_image: true) }

      before do
        SiteSetting.create_thumbnails = true

        Upload.expects(:get_from_url).returns(upload)
        FastImage.expects(:size).returns([1125, 2436])
        OptimizedImage.expects(:resize).returns(true)
        OptimizedImage.expects(:crop).never

        FileStore::BaseStore.any_instance.expects(:get_depth_for).returns(0)
      end

      it "crops the image" do
        cpp.post_process_images
        expect(cpp.html).to match_html "<p><div class=\"lightbox-wrapper\"><a class=\"lightbox\" href=\"/uploads/default/original/1X/1234567890123456.jpg\" data-download-href=\"/uploads/default/#{upload.sha1}\" title=\"logo.png\"><img src=\"/uploads/default/optimized/1X/#{upload.sha1}_#{OptimizedImage::VERSION}_230x500.png\" width=\"230\" height=\"500\"><div class=\"meta\">
<span class=\"filename\">logo.png</span><span class=\"informations\">1125×2436 1.21 KB</span><span class=\"expand\"></span>
</div></a></div></p>"
        expect(cpp).to be_dirty
      end

    end

    context "with large images when using subfolders" do

      let(:upload) { Fabricate(:upload) }
      let(:post) { Fabricate(:post_with_large_image_on_subfolder) }
      let(:cpp) { CookedPostProcessor.new(post, disable_loading_image: true) }
      let(:base_url) { "http://test.localhost/subfolder" }
      let(:base_uri) { "/subfolder" }

      before do
        SiteSetting.max_image_height = 2000
        SiteSetting.create_thumbnails = true
        Discourse.stubs(:base_url).returns(base_url)
        Discourse.stubs(:base_uri).returns(base_uri)

        Upload.expects(:get_from_url).returns(upload)
        FastImage.expects(:size).returns([1750, 2000])
        OptimizedImage.expects(:resize).returns(true)

        FileStore::BaseStore.any_instance.expects(:get_depth_for).returns(0)
      end

      it "generates overlay information" do
        cpp.post_process_images
        expect(cpp.html).to match_html "<p><div class=\"lightbox-wrapper\"><a class=\"lightbox\" href=\"/subfolder/uploads/default/original/1X/1234567890123456.jpg\" data-download-href=\"/subfolder/uploads/default/#{upload.sha1}\" title=\"logo.png\"><img src=\"/subfolder/uploads/default/optimized/1X/#{upload.sha1}_#{OptimizedImage::VERSION}_690x788.png\" width=\"690\" height=\"788\"><div class=\"meta\">
<span class=\"filename\">logo.png</span><span class=\"informations\">1750×2000 1.21 KB</span><span class=\"expand\"></span>
</div></a></div></p>"
        expect(cpp).to be_dirty
      end

      it "should escape the filename" do
        upload.update_attributes!(original_filename: "><img src=x onerror=alert('haha')>.png")
        cpp.post_process_images
        expect(cpp.html).to match_html "<p><div class=\"lightbox-wrapper\"><a class=\"lightbox\" href=\"/subfolder/uploads/default/original/1X/1234567890123456.jpg\" data-download-href=\"/subfolder/uploads/default/#{upload.sha1}\" title=\"&amp;gt;&amp;lt;img src=x onerror=alert(&amp;#39;haha&amp;#39;)&amp;gt;.png\"><img src=\"/subfolder/uploads/default/optimized/1X/#{upload.sha1}_#{OptimizedImage::VERSION}_690x788.png\" width=\"690\" height=\"788\"><div class=\"meta\">
<span class=\"filename\">&amp;gt;&amp;lt;img src=x onerror=alert(&amp;#39;haha&amp;#39;)&amp;gt;.png</span><span class=\"informations\">1750×2000 1.21 KB</span><span class=\"expand\"></span>
</div></a></div></p>"
      end

    end

    context "with title" do

      let(:upload) { Fabricate(:upload) }
      let(:post) { Fabricate(:post_with_large_image_and_title) }
      let(:cpp) { CookedPostProcessor.new(post, disable_loading_image: true) }

      before do
        SiteSetting.max_image_height = 2000
        SiteSetting.create_thumbnails = true

        Upload.expects(:get_from_url).returns(upload)
        FastImage.expects(:size).returns([1750, 2000])
        OptimizedImage.expects(:resize).returns(true)

        FileStore::BaseStore.any_instance.expects(:get_depth_for).returns(0)
      end

      it "generates overlay information" do
        cpp.post_process_images
        expect(cpp.html).to match_html "<p><div class=\"lightbox-wrapper\"><a class=\"lightbox\" href=\"/uploads/default/original/1X/1234567890123456.jpg\" data-download-href=\"/uploads/default/#{upload.sha1}\" title=\"WAT\"><img src=\"/uploads/default/optimized/1X/#{upload.sha1}_#{OptimizedImage::VERSION}_690x788.png\" title=\"WAT\" width=\"690\" height=\"788\"><div class=\"meta\">
       <span class=\"filename\">WAT</span><span class=\"informations\">1750×2000 1.21 KB</span><span class=\"expand\"></span>
       </div></a></div></p>"
        expect(cpp).to be_dirty
      end

    end

    context "topic image" do
      let(:topic) { build(:topic, id: 1) }
      let(:post) { Fabricate(:post_with_uploaded_image, topic: topic) }
      let(:cpp) { CookedPostProcessor.new(post) }

      it "adds a topic image if there's one in the first post" do
        FastImage.stubs(:size)
        expect(post.topic.image_url).to eq(nil)
        cpp.update_post_image
        post.topic.reload
        expect(post.topic.image_url).to be_present
      end
    end

    context "post image" do
      let(:reply) { Fabricate(:post_with_uploaded_image, post_number: 2) }
      let(:cpp) { CookedPostProcessor.new(reply) }

      it "adds a post image if there's one in the post" do
        FastImage.stubs(:size)
        expect(reply.image_url).to eq(nil)
        cpp.update_post_image
        reply.reload
        expect(reply.image_url).to be_present
      end
    end

  end

  context "#extract_images" do

    let(:post) { build(:post_with_plenty_of_images) }
    let(:cpp) { CookedPostProcessor.new(post) }

    it "does not extract emojis or images inside oneboxes or quotes" do
      expect(cpp.extract_images.length).to eq(0)
    end

  end

  context "#get_size_from_attributes" do

    let(:post) { build(:post) }
    let(:cpp) { CookedPostProcessor.new(post) }

    it "returns the size when width and height are specified" do
      img = { 'src' => 'http://foo.bar/image3.png', 'width' => 50, 'height' => 70 }
      expect(cpp.get_size_from_attributes(img)).to eq([50, 70])
    end

    it "returns the size when width and height are floats" do
      img = { 'src' => 'http://foo.bar/image3.png', 'width' => 50.2, 'height' => 70.1 }
      expect(cpp.get_size_from_attributes(img)).to eq([50, 70])
    end

    it "resizes when only width is specified" do
      img = { 'src' => 'http://foo.bar/image3.png', 'width' => 100 }
      SiteSetting.crawl_images = true
      FastImage.expects(:size).returns([200, 400])
      expect(cpp.get_size_from_attributes(img)).to eq([100, 200])
    end

    it "resizes when only height is specified" do
      img = { 'src' => 'http://foo.bar/image3.png', 'height' => 100 }
      SiteSetting.crawl_images = true
      FastImage.expects(:size).returns([100, 300])
      expect(cpp.get_size_from_attributes(img)).to eq([33, 100])
    end

    it "doesn't raise an error with a weird url" do
      img = { 'src' => nil, 'height' => 100 }
      SiteSetting.crawl_images = true
      expect(cpp.get_size_from_attributes(img)).to be_nil
    end

  end

  context "#get_size_from_image_sizes" do

    let(:post) { build(:post) }
    let(:cpp) { CookedPostProcessor.new(post) }

    it "returns the size" do
      image_sizes = { "http://my.discourse.org/image.png" => { "width" => 111, "height" => 222 } }
      expect(cpp.get_size_from_image_sizes("/image.png", image_sizes)).to eq([111, 222])
    end

  end

  context "#get_size" do

    let(:post) { build(:post) }
    let(:cpp) { CookedPostProcessor.new(post) }

    it "ensures urls are absolute" do
      cpp.expects(:is_valid_image_url?).with("http://test.localhost/relative/url/image.png")
      cpp.get_size("/relative/url/image.png")
    end

    it "ensures urls have a default scheme" do
      cpp.expects(:is_valid_image_url?).with("http://schemaless.url/image.jpg")
      cpp.get_size("//schemaless.url/image.jpg")
    end

    it "caches the results" do
      SiteSetting.crawl_images = true
      FastImage.expects(:size).returns([200, 400])
      cpp.get_size("http://foo.bar/image3.png")
      expect(cpp.get_size("http://foo.bar/image3.png")).to eq([200, 400])
    end

    context "when crawl_images is disabled" do

      before do
        SiteSetting.crawl_images = false
      end

      it "doesn't call FastImage" do
        FastImage.expects(:size).never
        expect(cpp.get_size("http://foo.bar/image1.png")).to eq(nil)
      end

      it "is always allowed to crawl our own images" do
        store = stub
        store.expects(:has_been_uploaded?).returns(true)
        Discourse.expects(:store).returns(store)
        FastImage.expects(:size).returns([100, 200])
        expect(cpp.get_size("http://foo.bar/image2.png")).to eq([100, 200])
      end

      it "returns nil if FastImage can't get the original size" do
        Discourse.store.class.any_instance.expects(:has_been_uploaded?).returns(true)
        FastImage.expects(:size).returns(nil)
        expect(cpp.get_size("http://foo.bar/image3.png")).to eq(nil)
      end

    end

  end

  context "#is_valid_image_url?" do

    let(:post) { build(:post) }
    let(:cpp) { CookedPostProcessor.new(post) }

    it "validates HTTP(s) urls" do
      expect(cpp.is_valid_image_url?("http://domain.com")).to eq(true)
      expect(cpp.is_valid_image_url?("https://domain.com")).to eq(true)
    end

    it "doesn't validate other urls" do
      expect(cpp.is_valid_image_url?("ftp://domain.com")).to eq(false)
      expect(cpp.is_valid_image_url?("ftps://domain.com")).to eq(false)
      expect(cpp.is_valid_image_url?("/tmp/image.png")).to eq(false)
      expect(cpp.is_valid_image_url?("//domain.com")).to eq(false)
    end

    it "doesn't throw an exception with a bad URI" do
      expect(cpp.is_valid_image_url?("http://do<main.com")).to eq(nil)
    end

  end

  context "#get_filename" do

    let(:post) { build(:post) }
    let(:cpp) { CookedPostProcessor.new(post) }

    it "returns the filename of the src when there is no upload" do
      expect(cpp.get_filename(nil, "http://domain.com/image.png")).to eq("image.png")
    end

    it "returns the original filename of the upload when there is an upload" do
      upload = build(:upload, original_filename: "upload.jpg")
      expect(cpp.get_filename(upload, "http://domain.com/image.png")).to eq("upload.jpg")
    end

    it "returns a generic name for pasted images" do
      upload = build(:upload, original_filename: "blob.png")
      expect(cpp.get_filename(upload, "http://domain.com/image.png")).to eq(I18n.t('upload.pasted_image_filename'))
    end

  end

  context "#post_process_oneboxes" do
    let(:post) { build(:post_with_youtube, id: 123) }
    let(:cpp) { CookedPostProcessor.new(post, invalidate_oneboxes: true) }

    before do
      Oneboxer.expects(:onebox)
        .with("http://www.youtube.com/watch?v=9bZkp7q19f0", invalidate_oneboxes: true, user_id: nil, category_id: post.topic.category_id)
        .returns("<div>GANGNAM STYLE</div>")

      cpp.post_process_oneboxes
    end

    it "inserts the onebox without wrapping p" do
      expect(cpp).to be_dirty
      expect(cpp.html).to match_html "<div>GANGNAM STYLE</div>"
    end

    it "replaces downloaded onebox image" do
      url = 'https://image.com/my-avatar'
      image_url = 'https://image.com/avatar.png'

      Oneboxer.stubs(:onebox).with(url, anything).returns("<img class='onebox' src='#{image_url}' />")

      post = Fabricate(:post, raw: url)
      upload = Fabricate(:upload, url: "https://test.s3.amazonaws.com/something.png")

      post.custom_fields[Post::DOWNLOADED_IMAGES] = { "//image.com/avatar.png": upload.id }
      post.save_custom_fields

      cpp = CookedPostProcessor.new(post, invalidate_oneboxes: true)
      cpp.post_process_oneboxes

      expect(cpp.doc.to_s).to eq("<p><img class=\"onebox\" src=\"#{upload.url}\" width=\"\" height=\"\"></p>")

      upload.destroy!
      cpp = CookedPostProcessor.new(post, invalidate_oneboxes: true)
      cpp.post_process_oneboxes

      expect(cpp.doc.to_s).to eq("<p><img class=\"onebox\" src=\"#{image_url}\" width=\"\" height=\"\"></p>")
    end

    it "replaces large image placeholder" do
      url = 'https://image.com/my-avatar'
      image_url = 'https://image.com/avatar.png'

      Oneboxer.stubs(:onebox).with(url, anything).returns("<img class='onebox' src='#{image_url}' />")

      post = Fabricate(:post, raw: url)

      post.custom_fields[Post::LARGE_IMAGES] = "[\"//image.com/avatar.png\"]"
      post.save_custom_fields

      cpp = CookedPostProcessor.new(post, invalidate_oneboxes: true)
      cpp.post_process_oneboxes
      cpp.post_process_images

      expect(cpp.doc.to_s).to match(/<div class="large-image-placeholder">/)
    end
  end

  context "#post_process_oneboxes removes nofollow if add_rel_nofollow_to_user_content is disabled" do
    let(:post) { build(:post_with_youtube, id: 123) }
    let(:cpp) { CookedPostProcessor.new(post, invalidate_oneboxes: true) }

    before do
      SiteSetting.add_rel_nofollow_to_user_content = false
      Oneboxer.expects(:onebox)
        .with("http://www.youtube.com/watch?v=9bZkp7q19f0", invalidate_oneboxes: true, user_id: nil, category_id: post.topic.category_id)
        .returns('<aside class="onebox"><a href="https://www.youtube.com/watch?v=9bZkp7q19f0" rel="nofollow noopener">GANGNAM STYLE</a></aside>')
      cpp.post_process_oneboxes
    end

    it "removes nofollow noopener from links" do
      expect(cpp).to be_dirty
      expect(cpp.html).to match_html '<aside class="onebox"><a href="https://www.youtube.com/watch?v=9bZkp7q19f0">GANGNAM STYLE</a></aside>'
    end
  end

  context "#post_process_oneboxes with square image" do

    it "generates a onebox-avatar class" do
      SiteSetting.crawl_images = true

      url = 'https://square-image.com/onebox'

      body = <<~HTML
      <html>
      <head>
      <meta property='og:title' content="Page awesome">
      <meta property='og:image' content="https://image.com/avatar.png">
      <meta property='og:description' content="Page awesome desc">
      </head>
      </html>
      HTML

      stub_request(:head, url)
      stub_request(:get , url).to_return(body: body)
      FinalDestination.stubs(:lookup_ip).returns('1.2.3.4')

      # not an ideal stub but shipping the whole image to fast image can add
      # a lot of cost to this test
      FastImage.stubs(:size).returns([200, 200])

      post = Fabricate.build(:post, raw: url)
      cpp = CookedPostProcessor.new(post, invalidate_oneboxes: true)

      cpp.post_process_oneboxes

      expect(cpp.doc.to_s).not_to include('aspect-image')
      expect(cpp.doc.to_s).to include('onebox-avatar')
    end

  end

  context "#optimize_urls" do

    let(:post) { build(:post_with_uploads_and_links) }
    let(:cpp) { CookedPostProcessor.new(post) }

    it "uses schemaless url for uploads" do
      cpp.optimize_urls
      expect(cpp.html).to match_html <<~HTML
        <p><a href="//test.localhost/uploads/default/original/2X/2345678901234567.jpg">Link</a><br>
        <img src="//test.localhost/uploads/default/original/1X/1234567890123456.jpg"><br>
        <a href="http://www.google.com" rel="nofollow noopener">Google</a><br>
        <img src="http://foo.bar/image.png"><br>
        <a class="attachment" href="//test.localhost/uploads/default/original/1X/af2c2618032c679333bebf745e75f9088748d737.txt">text.txt</a> (20 Bytes)<br>
        <img src="//test.localhost/images/emoji/twitter/smile.png?v=#{Emoji::EMOJI_VERSION}" title=":smile:" class="emoji" alt=":smile:"></p>
      HTML
    end

    context "when CDN is enabled" do

      it "uses schemaless CDN url for http uploads" do
        Rails.configuration.action_controller.stubs(:asset_host).returns("http://my.cdn.com")
        cpp.optimize_urls
        expect(cpp.html).to match_html <<~HTML
          <p><a href="//my.cdn.com/uploads/default/original/2X/2345678901234567.jpg">Link</a><br>
          <img src="//my.cdn.com/uploads/default/original/1X/1234567890123456.jpg"><br>
          <a href="http://www.google.com" rel="nofollow noopener">Google</a><br>
          <img src="http://foo.bar/image.png"><br>
          <a class="attachment" href="//my.cdn.com/uploads/default/original/1X/af2c2618032c679333bebf745e75f9088748d737.txt">text.txt</a> (20 Bytes)<br>
          <img src="//my.cdn.com/images/emoji/twitter/smile.png?v=#{Emoji::EMOJI_VERSION}" title=":smile:" class="emoji" alt=":smile:"></p>
        HTML
      end

      it "doesn't use schemaless CDN url for https uploads" do
        Rails.configuration.action_controller.stubs(:asset_host).returns("https://my.cdn.com")
        cpp.optimize_urls
        expect(cpp.html).to match_html <<~HTML
          <p><a href="https://my.cdn.com/uploads/default/original/2X/2345678901234567.jpg">Link</a><br>
          <img src="https://my.cdn.com/uploads/default/original/1X/1234567890123456.jpg"><br>
          <a href="http://www.google.com" rel="nofollow noopener">Google</a><br>
          <img src="http://foo.bar/image.png"><br>
          <a class="attachment" href="https://my.cdn.com/uploads/default/original/1X/af2c2618032c679333bebf745e75f9088748d737.txt">text.txt</a> (20 Bytes)<br>
          <img src="https://my.cdn.com/images/emoji/twitter/smile.png?v=#{Emoji::EMOJI_VERSION}" title=":smile:" class="emoji" alt=":smile:"></p>
        HTML
      end

      it "doesn't use CDN when login is required" do
        SiteSetting.login_required = true
        Rails.configuration.action_controller.stubs(:asset_host).returns("http://my.cdn.com")
        cpp.optimize_urls
        expect(cpp.html).to match_html <<~HTML
          <p><a href="//my.cdn.com/uploads/default/original/2X/2345678901234567.jpg">Link</a><br>
          <img src="//my.cdn.com/uploads/default/original/1X/1234567890123456.jpg"><br>
          <a href="http://www.google.com" rel="nofollow noopener">Google</a><br>
          <img src="http://foo.bar/image.png"><br>
          <a class="attachment" href="//test.localhost/uploads/default/original/1X/af2c2618032c679333bebf745e75f9088748d737.txt">text.txt</a> (20 Bytes)<br>
          <img src="//my.cdn.com/images/emoji/twitter/smile.png?v=#{Emoji::EMOJI_VERSION}" title=":smile:" class="emoji" alt=":smile:"></p>
        HTML
      end

      it "doesn't use CDN when preventing anons from downloading files" do
        SiteSetting.prevent_anons_from_downloading_files = true
        Rails.configuration.action_controller.stubs(:asset_host).returns("http://my.cdn.com")
        cpp.optimize_urls
        expect(cpp.html).to match_html <<~HTML
          <p><a href="//my.cdn.com/uploads/default/original/2X/2345678901234567.jpg">Link</a><br>
          <img src="//my.cdn.com/uploads/default/original/1X/1234567890123456.jpg"><br>
          <a href="http://www.google.com" rel="nofollow noopener">Google</a><br>
          <img src="http://foo.bar/image.png"><br>
          <a class="attachment" href="//test.localhost/uploads/default/original/1X/af2c2618032c679333bebf745e75f9088748d737.txt">text.txt</a> (20 Bytes)<br>
          <img src="//my.cdn.com/images/emoji/twitter/smile.png?v=#{Emoji::EMOJI_VERSION}" title=":smile:" class="emoji" alt=":smile:"></p>
        HTML
      end

    end

  end

  context "#pull_hotlinked_images" do

    let(:post) { build(:post, created_at: 20.days.ago) }
    let(:cpp) { CookedPostProcessor.new(post) }

    before { cpp.stubs(:available_disk_space).returns(90) }

    it "does not run when download_remote_images_to_local is disabled" do
      SiteSetting.download_remote_images_to_local = false
      Jobs.expects(:cancel_scheduled_job).never
      cpp.pull_hotlinked_images
    end

    context "when download_remote_images_to_local? is enabled" do
      before do
        SiteSetting.download_remote_images_to_local = true
      end

      it "does not run when there is not enough disk space" do
        cpp.expects(:disable_if_low_on_disk_space).returns(true)
        Jobs.expects(:cancel_scheduled_job).never
        cpp.pull_hotlinked_images
      end

      context "and there is enough disk space" do

        before { cpp.expects(:disable_if_low_on_disk_space).returns(false) }

        it "does not run when the system user updated the post" do
          post.last_editor_id = Discourse.system_user.id
          Jobs.expects(:cancel_scheduled_job).never
          cpp.pull_hotlinked_images
        end

        context "and the post has been updated by an actual user" do

          before { post.id = 42 }

          it "ensures only one job is scheduled right after the editing_grace_period" do
            Jobs.expects(:cancel_scheduled_job).with(:pull_hotlinked_images, post_id: post.id).once

            delay = SiteSetting.editing_grace_period + 1
            Jobs.expects(:enqueue_in).with(delay.seconds, :pull_hotlinked_images, post_id: post.id, bypass_bump: false).once

            cpp.pull_hotlinked_images
          end

        end

      end

    end

  end

  context "#disable_if_low_on_disk_space" do

    let(:post) { build(:post, created_at: 20.days.ago) }
    let(:cpp) { CookedPostProcessor.new(post) }

    before { cpp.expects(:available_disk_space).returns(50) }

    it "does nothing when there's enough disk space" do
      SiteSetting.expects(:download_remote_images_threshold).returns(20)
      SiteSetting.expects(:download_remote_images_to_local).never
      expect(cpp.disable_if_low_on_disk_space).to eq(false)
    end

    context "when there's not enough disk space" do

      before { SiteSetting.expects(:download_remote_images_threshold).returns(75) }

      it "disables download_remote_images_threshold and send a notification to the admin" do
        StaffActionLogger.any_instance.expects(:log_site_setting_change).once
        SystemMessage.expects(:create_from_system_user).with(Discourse.site_contact_user, :download_remote_images_disabled).once
        expect(cpp.disable_if_low_on_disk_space).to eq(true)
        expect(SiteSetting.download_remote_images_to_local).to eq(false)
      end

    end

  end

  context "#download_remote_images_max_days_old" do

    let(:post) { build(:post, created_at: 20.days.ago) }
    let(:cpp) { CookedPostProcessor.new(post) }

    before do
      SiteSetting.download_remote_images_to_local = true
      cpp.expects(:disable_if_low_on_disk_space).returns(false)
    end

    it "does not run when download_remote_images_max_days_old is not satisfied" do
      SiteSetting.download_remote_images_max_days_old = 15
      Jobs.expects(:cancel_scheduled_job).never
      cpp.pull_hotlinked_images
    end

    it "runs when download_remote_images_max_days_old is satisfied" do
      SiteSetting.download_remote_images_max_days_old = 30

      Jobs.expects(:cancel_scheduled_job).with(:pull_hotlinked_images, post_id: post.id).once

      delay = SiteSetting.editing_grace_period + 1
      Jobs.expects(:enqueue_in).with(delay.seconds, :pull_hotlinked_images, post_id: post.id, bypass_bump: false).once

      cpp.pull_hotlinked_images
    end
  end

  context "#is_a_hyperlink?" do

    let(:post) { build(:post) }
    let(:cpp) { CookedPostProcessor.new(post) }
    let(:doc) { Nokogiri::HTML::fragment('<body><div><a><img id="linked_image"></a><p><img id="standard_image"></p></div></body>') }

    it "is true when the image is inside a link" do
      img = doc.css("img#linked_image").first
      expect(cpp.is_a_hyperlink?(img)).to eq(true)
    end

    it "is false when the image is not inside a link" do
      img = doc.css("img#standard_image").first
      expect(cpp.is_a_hyperlink?(img)).to eq(false)
    end

  end

  context "grant badges" do
    let(:cpp) { CookedPostProcessor.new(post) }

    context "emoji inside a quote" do
      let(:post) { Fabricate(:post, raw: "time to eat some sweet \n[quote]\n:candy:\n[/quote]\n mmmm") }

      it "doesn't award a badge when the emoji is in a quote" do
        cpp.grant_badges
        expect(post.user.user_badges.where(badge_id: Badge::FirstEmoji).exists?).to eq(false)
      end
    end

    context "emoji in the text" do
      let(:post) { Fabricate(:post, raw: "time to eat some sweet :candy: mmmm") }

      it "awards a badge for using an emoji" do
        cpp.grant_badges
        expect(post.user.user_badges.where(badge_id: Badge::FirstEmoji).exists?).to eq(true)
      end
    end

    context "onebox" do
      let(:post) { Fabricate(:post, raw: "onebox me:\n\nhttps://www.youtube.com/watch?v=Wji-BZ0oCwg\n") }

      before { Oneboxer.stubs(:onebox) }

      it "awards a badge for using an onebox" do
        cpp.post_process_oneboxes
        cpp.grant_badges
        expect(post.user.user_badges.where(badge_id: Badge::FirstOnebox).exists?).to eq(true)
      end

      it "doesn't award the badge when the badge is disabled" do
        Badge.where(id: Badge::FirstOnebox).update_all(enabled: false)
        cpp.post_process_oneboxes
        cpp.grant_badges
        expect(post.user.user_badges.where(badge_id: Badge::FirstOnebox).exists?).to eq(false)
      end
    end

    context "reply_by_email" do
      let(:post) { Fabricate(:post, raw: "This is a **reply** via email ;)", via_email: true, post_number: 2) }

      it "awards a badge for replying via email" do
        cpp.grant_badges
        expect(post.user.user_badges.where(badge_id: Badge::FirstReplyByEmail).exists?).to eq(true)
      end
    end

  end

  context "quote processing" do
    let(:cpp) { CookedPostProcessor.new(cp) }
    let(:pp) { Fabricate(:post, raw: "This post is ripe for quoting!") }

    context "with an unmodified quote" do
      let(:cp) do
        Fabricate(
          :post,
          raw: "[quote=\"#{pp.user.username}, post: #{pp.post_number}, topic:#{pp.topic_id}]\nripe for quoting\n[/quote]\ntest"
        )
      end

      it "should not be marked as modified" do
        cpp.post_process_quotes
        expect(cpp.doc.css('aside.quote.quote-modified')).to be_blank
      end
    end

    context "with a modified quote" do
      let(:cp) do
        Fabricate(
          :post,
          raw: "[quote=\"#{pp.user.username}, post: #{pp.post_number}, topic:#{pp.topic_id}]\nmodified\n[/quote]\ntest"
        )
      end

      it "should be marked as modified" do
        cpp.post_process_quotes
        expect(cpp.doc.css('aside.quote.quote-modified')).to be_present
      end
    end

  end

  context "remove direct reply full quote" do
    let(:topic) { Fabricate(:topic) }
    let!(:post) { Fabricate(:post, topic: topic, raw: "this is the first post") }

    let(:raw) do
      <<~RAW.strip
      [quote="#{post.user.username}, post:#{post.post_number}, topic:#{topic.id}"]
      this is the first post
      [/quote]

      and this is the third reply
      RAW
    end

    let(:raw2) do
      <<~RAW.strip
      and this is the third reply

      [quote="#{post.user.username}, post:#{post.post_number}, topic:#{topic.id}"]
      this is the first post
      [/quote]
      RAW
    end

    before do
      SiteSetting.remove_full_quote = true
    end

    it 'works' do
      hidden = Fabricate(:post, topic: topic, hidden: true, raw: "this is the second post after")
      small_action = Fabricate(:post, topic: topic, post_type: Post.types[:small_action])
      reply = Fabricate(:post, topic: topic, raw: raw)

      freeze_time Time.zone.now do
        topic.bumped_at = 1.day.ago
        CookedPostProcessor.new(reply).removed_direct_reply_full_quotes

        expect(topic.posts).to eq([post, hidden, small_action, reply])
        expect(topic.bumped_at).to eq(1.day.ago)
        expect(reply.raw).to eq("and this is the third reply")
        expect(reply.revisions.count).to eq(1)
        expect(reply.revisions.first.modifications["raw"]).to eq([raw, reply.raw])
        expect(reply.revisions.first.modifications["edit_reason"][1]).to eq(I18n.t(:removed_direct_reply_full_quotes))
      end
    end

    it 'does not delete quote if not first paragraph' do
      reply = Fabricate(:post, topic: topic, raw: raw2)
      CookedPostProcessor.new(reply).removed_direct_reply_full_quotes
      expect(topic.posts).to eq([post, reply])
      expect(reply.raw).to eq(raw2)
    end

    it "does nothing when 'remove_full_quote' is disabled" do
      SiteSetting.remove_full_quote = false

      reply = Fabricate(:post, topic: topic, raw: raw)

      CookedPostProcessor.new(reply).removed_direct_reply_full_quotes
      expect(reply.raw).to eq(raw)
    end

    it "works only on new posts" do
      SiteSetting.queue_jobs = false

      hidden = Fabricate(:post, topic: topic, hidden: true, raw: "this is the second post after")
      small_action = Fabricate(:post, topic: topic, post_type: Post.types[:small_action])

      reply = PostCreator.create!(topic.user, topic_id: topic.id, raw: raw)
      CookedPostProcessor.new(reply).post_process
      expect(reply.raw).to eq(raw)

      PostRevisor.new(reply).revise!(Discourse.system_user, raw: raw, edit_reason: "put back full quote")
      CookedPostProcessor.new(reply).post_process(new_post: true)
      expect(reply.raw).to eq("and this is the third reply")
    end

  end

end
-												Prepare for separation of RSpec helper files

Since rspec-rails 3, the default installation creates two helper files:
* `spec_helper.rb`
* `rails_helper.rb`

`spec_helper.rb` is intended as a way of running specs that do not
require Rails, whereas `rails_helper.rb` loads Rails (as Discourse's
current `spec_helper.rb` does).

For more information:

https://www.relishapp.com/rspec/rspec-rails/docs/upgrade#default-helper-files

In this commit, I've simply replaced all instances of `spec_helper` with
`rails_helper`, and renamed the original `spec_helper.rb`.

This brings the Discourse project closer to the standard usage of RSpec
in a Rails app.

At present, every spec relies on loading Rails, but there are likely
many that don't need to. In a future pull request, I hope to introduce a
separate, minimal `spec_helper.rb` which can be used in tests which
don't rely on Rails.

											
										
										
											2015-10-11 05:41:23 -04:00
+								require "rails_helper"
-												pull hotlinked images

											
										
										
											2013-11-05 13:04:47 -05:00
+								require "cooked_post_processor"
-												Initial release of Discourse

											
										
										
											2013-02-05 14:16:51 -05:00
 								describe CookedPostProcessor do
-												PERF: Move processing of inline onebox out of V8 context. (#6658)


											
										
										
											2018-11-25 20:21:38 -05:00
+								  context "#post_process" do
-												FIX: Link post to uploads in `PostCreator`.

* This ensures that uploads are linked to their post on creation
  instead of a background job which may be delayed if Sidekiq
  is facing difficulties.

											
										
										
											2018-09-05 21:58:01 -04:00
+								    let(:upload) do
 								      Fabricate(:upload,
 								        url: '/uploads/default/original/1X/1/1234567890123456.jpg'
 								      )
 								    end
 								    let(:post) do
 								      Fabricate(:post, raw: <<~RAW)
 								      <img src="#{upload.url}">
 								      RAW
 								    end
-												Initial release of Discourse

											
										
										
											2013-02-05 14:16:51 -05:00
-												FEATURE: Show a blurry preview when lazy loading images

This generates a 10x10 PNG thumbnail for each lightboxed image.
If Image Lazy Loading is enabled (IntersectionObserver API) then
we'll load the low res version when offscreen. As the image scrolls
in we'll swap it for the high res version.

We use a WeakMap to track the old image attributes. It's much less
memory than storing them as `data-*` attributes and swapping them
back and forth all the time.

											
										
										
											2018-12-14 17:44:38 -05:00
+								    let(:cpp) { CookedPostProcessor.new(post, disable_loading_image: true) }
-												refactor CookedPostProcessor & specs

											
										
										
											2013-07-07 19:39:08 -04:00
+								    let(:post_process) { sequence("post_process") }
-												Initial release of Discourse

											
										
										
											2013-02-05 14:16:51 -05:00
-												update back-end specs

											
										
										
											2013-07-10 16:59:07 -04:00
+								    it "post process in sequence" do
-												refactor CookedPostProcessor & specs

											
										
										
											2013-07-07 19:39:08 -04:00
+								      cpp.expects(:post_process_oneboxes).in_sequence(post_process)
-												FIX: properly handle too large & broken images in posts

											
										
										
											2017-11-16 09:45:07 -05:00
+								      cpp.expects(:post_process_images).in_sequence(post_process)
-												pull hotlinked images

											
										
										
											2013-11-05 13:04:47 -05:00
+								      cpp.expects(:optimize_urls).in_sequence(post_process)
 								      cpp.expects(:pull_hotlinked_images).in_sequence(post_process)
-												refactor CookedPostProcessor & specs

											
										
										
											2013-07-07 19:39:08 -04:00
+								      cpp.post_process
-												FIX: Link post to uploads in `PostCreator`.

* This ensures that uploads are linked to their post on creation
  instead of a background job which may be delayed if Sidekiq
  is facing difficulties.

											
										
										
											2018-09-05 21:58:01 -04:00
 								      expect(PostUpload.exists?(post: post, upload: upload)).to eq(true)
-												Initial release of Discourse

											
										
										
											2013-02-05 14:16:51 -05:00
+								    end
-												FEATURE: Reimplement `SiteSetting.max_oneboxes_per_post`. (#6668)

Previously, the site setting was only effective on the client side of
things. Once the site setting was been reached, all oneboxes are not
rendered. This commit changes it such that the site setting is respected
both on the client and server side. The first N oneboxes are rendered and
once the limit has been reached, subsequent oneboxes will not be
rendered.
											
										
										
											2018-11-27 03:00:31 -05:00
+								    describe 'when post contains oneboxes and inline oneboxes' do
 								      let(:url_hostname) { 'meta.discourse.org' }
 								      let(:url) do
 								        "https://#{url_hostname}/t/mini-inline-onebox-support-rfc/66400"
 								      end
-												UX: Strip class when link is not oneboxed due to site setting limits.

											
										
										
											2018-11-29 01:33:01 -05:00
+								      let(:not_oneboxed_url) do
 								        "https://#{url_hostname}/t/random-url"
 								      end
-												FEATURE: Reimplement `SiteSetting.max_oneboxes_per_post`. (#6668)

Previously, the site setting was only effective on the client side of
things. Once the site setting was been reached, all oneboxes are not
rendered. This commit changes it such that the site setting is respected
both on the client and server side. The first N oneboxes are rendered and
once the limit has been reached, subsequent oneboxes will not be
rendered.
											
										
										
											2018-11-27 03:00:31 -05:00
+								      let(:title) { 'some title' }
 								      let(:post) do
 								        Fabricate(:post, raw: <<~RAW)
 								        #{url}
 								        This is a #{url} with path
-												UX: Strip class when link is not oneboxed due to site setting limits.

											
										
										
											2018-11-29 01:33:01 -05:00
+								        #{not_oneboxed_url}
-												FEATURE: Reimplement `SiteSetting.max_oneboxes_per_post`. (#6668)

Previously, the site setting was only effective on the client side of
things. Once the site setting was been reached, all oneboxes are not
rendered. This commit changes it such that the site setting is respected
both on the client and server side. The first N oneboxes are rendered and
once the limit has been reached, subsequent oneboxes will not be
rendered.
											
										
										
											2018-11-27 03:00:31 -05:00
 								        This is a https://#{url_hostname}/t/another-random-url test
 								        This is a #{url} with path
 								        #{url}
 								        RAW
 								      end
 								      before do
 								        SiteSetting.enable_inline_onebox_on_all_domains = true
 								        %i{head get}.each do |method|
 								          stub_request(method, url).to_return(
 								            status: 200,
 								            body: <<~RAW
 								            <html>
 								              <head>
 								                <title>#{title}</title>
 								                <meta property='og:title' content="#{title}">
 								                <meta property='og:description' content="some description">
 								              </head>
 								            </html>
 								            RAW
 								          )
 								        end
 								      end
 								      after do
 								        InlineOneboxer.purge(url)
 								        Oneboxer.invalidate(url)
 								      end
 								      it 'should respect SiteSetting.max_oneboxes_per_post' do
 								        SiteSetting.max_oneboxes_per_post = 2
 								        SiteSetting.add_rel_nofollow_to_user_content = false
 								        cpp.post_process
 								        expect(cpp.html).to have_tag('a',
 								          with: {
 								            href: url,
 								            class: described_class::INLINE_ONEBOX_CSS_CLASS
 								          },
 								          text: title,
 								          count: 2
 								        )
 								        expect(cpp.html).to have_tag('aside.onebox a', text: title, count: 2)
 								        expect(cpp.html).to have_tag('aside.onebox a',
 								          text: url_hostname,
 								          count: 2
 								        )
 								        expect(cpp.html).to have_tag('a',
 								          without: {
 								            class: described_class::INLINE_ONEBOX_LOADING_CSS_CLASS
 								          },
-												UX: Strip class when link is not oneboxed due to site setting limits.

											
										
										
											2018-11-29 01:33:01 -05:00
+								          text: not_oneboxed_url,
-												FEATURE: Reimplement `SiteSetting.max_oneboxes_per_post`. (#6668)

Previously, the site setting was only effective on the client side of
things. Once the site setting was been reached, all oneboxes are not
rendered. This commit changes it such that the site setting is respected
both on the client and server side. The first N oneboxes are rendered and
once the limit has been reached, subsequent oneboxes will not be
rendered.
											
										
										
											2018-11-27 03:00:31 -05:00
+								          count: 1
 								        )
-												UX: Strip class when link is not oneboxed due to site setting limits.

											
										
										
											2018-11-29 01:33:01 -05:00
+								        expect(cpp.html).to have_tag('a',
 								          without: {
 								            class: 'onebox'
 								          },
 								          text: not_oneboxed_url,
 								          count: 1
 								        )
-												FEATURE: Reimplement `SiteSetting.max_oneboxes_per_post`. (#6668)

Previously, the site setting was only effective on the client side of
things. Once the site setting was been reached, all oneboxes are not
rendered. This commit changes it such that the site setting is respected
both on the client and server side. The first N oneboxes are rendered and
once the limit has been reached, subsequent oneboxes will not be
rendered.
											
										
										
											2018-11-27 03:00:31 -05:00
+								      end
 								    end
-												PERF: Move processing of inline onebox out of V8 context. (#6658)


											
										
										
											2018-11-25 20:21:38 -05:00
+								    describe 'when post contains inline oneboxes' do
 								      let(:loading_css_class) do
 								        described_class::INLINE_ONEBOX_LOADING_CSS_CLASS
 								      end
 								      before do
 								        SiteSetting.enable_inline_onebox_on_all_domains = true
 								      end
 								      describe 'internal links' do
 								        let(:topic) { Fabricate(:topic) }
 								        let(:url) { topic.url }
 								        let(:post) { Fabricate(:post, raw: "Hello #{url}") }
 								        it "includes the topic title" do
 								          cpp.post_process
 								          expect(cpp.html).to have_tag('a',
 								            with: {
 								              href: UrlHelper.cook_url(url)
 								            },
 								            without: {
 								              class: loading_css_class
 								            },
 								            text: topic.title,
 								            count: 1
 								          )
 								          topic.update!(title: "Updated to something else")
 								          cpp = CookedPostProcessor.new(post, invalidate_oneboxes: true)
 								          cpp.post_process
 								          expect(cpp.html).to have_tag('a',
 								            with: {
 								              href: UrlHelper.cook_url(url)
 								            },
 								            without: {
 								              class: loading_css_class
 								            },
 								            text: topic.title,
 								            count: 1
 								          )
 								        end
 								      end
 								      describe 'external links' do
 								        let(:url_with_path) do
 								          'https://meta.discourse.org/t/mini-inline-onebox-support-rfc/66400'
 								        end
 								        let(:url_with_query_param) do
 								          'https://meta.discourse.org?a'
 								        end
 								        let(:url_no_path) do
 								          'https://meta.discourse.org/'
 								        end
 								        let(:urls) do
 								          [
 								            url_with_path,
 								            url_with_query_param,
 								            url_no_path
 								          ]
 								        end
-												SECURITY: escape title HTML for inline onebox

											
										
										
											2019-01-09 20:02:05 -05:00
+								        let(:title) { '<b>some title</b>' }
 								        let(:escaped_title) { CGI.escapeHTML(title) }
-												PERF: Move processing of inline onebox out of V8 context. (#6658)


											
										
										
											2018-11-25 20:21:38 -05:00
 								        let(:post) do
 								          Fabricate(:post, raw: <<~RAW)
 								          This is a #{url_with_path} topic
 								          This should not be inline #{url_no_path} oneboxed
 								          - #{url_with_path}
 								             - #{url_with_query_param}
 								          RAW
 								        end
 								        before do
 								          urls.each do |url|
 								            stub_request(:get, url).to_return(
 								              status: 200,
-												SECURITY: escape title HTML for inline onebox

											
										
										
											2019-01-09 20:02:05 -05:00
+								              body: "<html><head><title>#{escaped_title}</title></head></html>"
-												PERF: Move processing of inline onebox out of V8 context. (#6658)


											
										
										
											2018-11-25 20:21:38 -05:00
+								            )
 								          end
 								        end
 								        after do
 								          urls.each { |url| InlineOneboxer.purge(url) }
 								        end
 								        it 'should convert the right links to inline oneboxes' do
 								          cpp.post_process
 								          html = cpp.html
 								          expect(html).to_not have_tag('a',
 								            with: {
 								              href: url_no_path
 								            },
 								            without: {
 								              class: loading_css_class
 								            },
 								            text: title
 								          )
 								          expect(html).to have_tag('a',
 								            with: {
 								              href: url_with_path
 								            },
 								            without: {
 								              class: loading_css_class
 								            },
 								            text: title,
 								            count: 2
 								          )
 								          expect(html).to have_tag('a',
 								            with: {
 								              href: url_with_query_param
 								            },
 								            without: {
 								              class: loading_css_class
 								            },
 								            text: title,
 								            count: 1
 								          )
 								        end
 								      end
 								    end
-												refactor CookedPostProcessor & specs

											
										
										
											2013-07-07 19:39:08 -04:00
+								  end
-												Initial release of Discourse

											
										
										
											2013-02-05 14:16:51 -05:00
-												PERF: Move processing of inline onebox out of V8 context. (#6658)


											
										
										
											2018-11-25 20:21:38 -05:00
+								  context "#post_process_images" do
-												refactor CookedPostProcessor & specs

											
										
										
											2013-07-07 19:39:08 -04:00
-												FEATURE: add support for responsive images in posts

When creating lightboxes we will attempt to create 1.5x and 2x thumbnails
for retina screens, this can be controlled with a new hidden site setting
called responsice_post_image_sizes, if you wish to create 3x images run

SiteSetting.responsive_post_image_sizes = "1|1.5|2|3"


The default should be good for most of the setups as it balances filesize
with quality. 3x thumbs can get big.

											
										
										
											2018-10-02 23:44:53 -04:00
+								    before do
 								      SiteSetting.responsive_post_image_sizes = ""
 								    end
 								    context "responsive images" do
-												FIX: don't use srcset on cropped thumbnails

											
										
										
											2018-10-25 10:08:10 -04:00
+								      before { SiteSetting.responsive_post_image_sizes = "1|1.5|3" }
-												FEATURE: add support for responsive images in posts

When creating lightboxes we will attempt to create 1.5x and 2x thumbnails
for retina screens, this can be controlled with a new hidden site setting
called responsice_post_image_sizes, if you wish to create 3x images run

SiteSetting.responsive_post_image_sizes = "1|1.5|2|3"


The default should be good for most of the setups as it balances filesize
with quality. 3x thumbs can get big.

											
										
										
											2018-10-02 23:44:53 -04:00
-												FIX: don't use srcset on cropped thumbnails

											
										
										
											2018-10-25 10:08:10 -04:00
+								      it "includes responsive images on demand" do
-												FEATURE: add support for responsive images in posts

When creating lightboxes we will attempt to create 1.5x and 2x thumbnails
for retina screens, this can be controlled with a new hidden site setting
called responsice_post_image_sizes, if you wish to create 3x images run

SiteSetting.responsive_post_image_sizes = "1|1.5|2|3"


The default should be good for most of the setups as it balances filesize
with quality. 3x thumbs can get big.

											
										
										
											2018-10-02 23:44:53 -04:00
+								        upload = Fabricate(:upload, width: 2000, height: 1500, filesize: 10000)
 								        post = Fabricate(:post, raw: "hello <img src='#{upload.url}'>")
 								        # fake some optimized images
 								        OptimizedImage.create!(
 								          url: 'http://a.b.c/666x500.jpg',
 								          width: 666,
 								          height: 500,
 								          upload_id: upload.id,
 								          sha1: SecureRandom.hex,
 								          extension: '.jpg',
-												Fix the build.

Ref 570877da3c39707c2101c3510fab1509fb8ba3e2

											
										
										
											2019-01-03 02:34:10 -05:00
+								          filesize: 500,
 								          version: OptimizedImage::VERSION
-												FEATURE: add support for responsive images in posts

When creating lightboxes we will attempt to create 1.5x and 2x thumbnails
for retina screens, this can be controlled with a new hidden site setting
called responsice_post_image_sizes, if you wish to create 3x images run

SiteSetting.responsive_post_image_sizes = "1|1.5|2|3"


The default should be good for most of the setups as it balances filesize
with quality. 3x thumbs can get big.

											
										
										
											2018-10-02 23:44:53 -04:00
+								        )
 								        # fake 3x optimized image, we lose 2 pixels here over original due to rounding on downsize
 								        OptimizedImage.create!(
 								          url: 'http://a.b.c/1998x1500.jpg',
 								          width: 1998,
 								          height: 1500,
 								          upload_id: upload.id,
 								          sha1: SecureRandom.hex,
 								          extension: '.jpg',
 								          filesize: 800
 								        )
-												FEATURE: Show a blurry preview when lazy loading images

This generates a 10x10 PNG thumbnail for each lightboxed image.
If Image Lazy Loading is enabled (IntersectionObserver API) then
we'll load the low res version when offscreen. As the image scrolls
in we'll swap it for the high res version.

We use a WeakMap to track the old image attributes. It's much less
memory than storing them as `data-*` attributes and swapping them
back and forth all the time.

											
										
										
											2018-12-14 17:44:38 -05:00
+								        # Fake a loading image
-												DEV: Improve tests to assert that the right HTML is generated.

											
										
										
											2018-12-19 18:13:36 -05:00
+								        optimized_image = OptimizedImage.create!(
-												FEATURE: Show a blurry preview when lazy loading images

This generates a 10x10 PNG thumbnail for each lightboxed image.
If Image Lazy Loading is enabled (IntersectionObserver API) then
we'll load the low res version when offscreen. As the image scrolls
in we'll swap it for the high res version.

We use a WeakMap to track the old image attributes. It's much less
memory than storing them as `data-*` attributes and swapping them
back and forth all the time.

											
										
										
											2018-12-14 17:44:38 -05:00
+								          url: 'http://a.b.c/10x10.png',
 								          width: CookedPostProcessor::LOADING_SIZE,
 								          height: CookedPostProcessor::LOADING_SIZE,
 								          upload_id: upload.id,
 								          sha1: SecureRandom.hex,
 								          extension: '.png',
 								          filesize: 123
 								        )
-												FEATURE: add support for responsive images in posts

When creating lightboxes we will attempt to create 1.5x and 2x thumbnails
for retina screens, this can be controlled with a new hidden site setting
called responsice_post_image_sizes, if you wish to create 3x images run

SiteSetting.responsive_post_image_sizes = "1|1.5|2|3"


The default should be good for most of the setups as it balances filesize
with quality. 3x thumbs can get big.

											
										
										
											2018-10-02 23:44:53 -04:00
+								        cpp = CookedPostProcessor.new(post)
 								        cpp.add_to_size_cache(upload.url, 2000, 1500)
 								        cpp.post_process_images
-												DEV: Improve tests to assert that the right HTML is generated.

											
										
										
											2018-12-19 18:13:36 -05:00
+								        html = cpp.html
 								        expect(html).to include(%Q|data-small-upload="#{optimized_image.url}"|)
-												FEATURE: add support for responsive images in posts

When creating lightboxes we will attempt to create 1.5x and 2x thumbnails
for retina screens, this can be controlled with a new hidden site setting
called responsice_post_image_sizes, if you wish to create 3x images run

SiteSetting.responsive_post_image_sizes = "1|1.5|2|3"


The default should be good for most of the setups as it balances filesize
with quality. 3x thumbs can get big.

											
										
										
											2018-10-02 23:44:53 -04:00
+								        # 1.5x is skipped cause we have a missing thumb
-												DEV: Improve tests to assert that the right HTML is generated.

											
										
										
											2018-12-19 18:13:36 -05:00
+								        expect(html).to include('srcset="http://a.b.c/666x500.jpg, http://a.b.c/1998x1500.jpg 3x"')
-												FIX: don't use srcset on cropped thumbnails

											
										
										
											2018-10-25 10:08:10 -04:00
+								      end
 								      it "doesn't include response images for cropped images" do
 								        upload = Fabricate(:upload, width: 200, height: 4000, filesize: 12345)
 								        post = Fabricate(:post, raw: "hello <img src='#{upload.url}'>")
 								        # fake some optimized images
 								        OptimizedImage.create!(
 								          url: 'http://a.b.c/200x500.jpg',
 								          width: 200,
 								          height: 500,
 								          upload_id: upload.id,
 								          sha1: SecureRandom.hex,
 								          extension: '.jpg',
 								          filesize: 500
 								        )
 								        cpp = CookedPostProcessor.new(post)
 								        cpp.add_to_size_cache(upload.url, 200, 4000)
 								        cpp.post_process_images
-												FEATURE: add support for responsive images in posts

When creating lightboxes we will attempt to create 1.5x and 2x thumbnails
for retina screens, this can be controlled with a new hidden site setting
called responsice_post_image_sizes, if you wish to create 3x images run

SiteSetting.responsive_post_image_sizes = "1|1.5|2|3"


The default should be good for most of the setups as it balances filesize
with quality. 3x thumbs can get big.

											
										
										
											2018-10-02 23:44:53 -04:00
-												FIX: don't use srcset on cropped thumbnails

											
										
										
											2018-10-25 10:08:10 -04:00
+								        expect(cpp.html).to_not include('srcset="')
-												FEATURE: add support for responsive images in posts

When creating lightboxes we will attempt to create 1.5x and 2x thumbnails
for retina screens, this can be controlled with a new hidden site setting
called responsice_post_image_sizes, if you wish to create 3x images run

SiteSetting.responsive_post_image_sizes = "1|1.5|2|3"


The default should be good for most of the setups as it balances filesize
with quality. 3x thumbs can get big.

											
										
										
											2018-10-02 23:44:53 -04:00
+								      end
 								    end
-												FIX: picture would be hidden when [details] block was closed in the composer

											
										
										
											2015-03-16 13:57:15 -04:00
+								    shared_examples "leave dimensions alone" do
 								      it "doesn't use them" do
 								        expect(cpp.html).to match(/src="http:\/\/foo.bar\/image.png" width="" height=""/)
 								        expect(cpp.html).to match(/src="http:\/\/domain.com\/picture.jpg" width="50" height="42"/)
 								        expect(cpp).to be_dirty
 								      end
 								    end
-												refactor CookedPostProcessor & specs

											
										
										
											2013-07-07 19:39:08 -04:00
-												FIX: picture would be hidden when [details] block was closed in the composer

											
										
										
											2015-03-16 13:57:15 -04:00
+								    context "with image_sizes" do
-												- FEATURE: revamped poll plugin

- add User.staff scope
- inject MessageBus into Ember views (so it can be used by the poll plugin)
- REFACTOR: use more accurate is_first_post? method instead of post_number == 1
- FEATURE: add support for JSON-typed custom fields
- FEATURE: allow plugins to add validation
- FEATURE: add post_custom_fields to PostSerializer
- FEATURE: allow plugins to whitelist post_custom_fields
- FIX: don't bump when post did not save successfully
- FEATURE: polls are supported in any post
- FEATURE: allow for multiple polls in the same post
- FEATURE: multiple choice polls
- FEATURE: rating polls
- FEATURE: new dialect allowing users to preview polls in the composer

											
										
										
											2015-04-23 13:33:29 -04:00
+								      let(:post) { Fabricate(:post_with_image_urls) }
-												FIX: picture would be hidden when [details] block was closed in the composer

											
										
										
											2015-03-16 13:57:15 -04:00
+								      let(:cpp) { CookedPostProcessor.new(post, image_sizes: image_sizes) }
-												refactor CookedPostProcessor & specs

											
										
										
											2013-07-07 19:39:08 -04:00
-												FIX stretched thumbnails

											
										
										
											2013-11-25 12:36:13 -05:00
+								      before { cpp.post_process_images }
-												FIX: picture would be hidden when [details] block was closed in the composer

											
										
										
											2015-03-16 13:57:15 -04:00
+								      context "valid" do
-												Add rubocop to our build. (#5004)


											
										
										
											2017-07-27 21:20:09 -04:00
+								        let(:image_sizes) { { "http://foo.bar/image.png" => { "width" => 111, "height" => 222 } } }
-												FIX: picture would be hidden when [details] block was closed in the composer

											
										
										
											2015-03-16 13:57:15 -04:00
-												REFACTOR: Migrate markdown functionality in ES6

											
										
										
											2016-06-14 14:31:51 -04:00
+								        it "uses them" do
-												FIX: picture would be hidden when [details] block was closed in the composer

											
										
										
											2015-03-16 13:57:15 -04:00
+								          expect(cpp.html).to match(/src="http:\/\/foo.bar\/image.png" width="111" height="222"/)
 								          expect(cpp.html).to match(/src="http:\/\/domain.com\/picture.jpg" width="50" height="42"/)
 								          expect(cpp).to be_dirty
 								        end
 								      end
 								      context "invalid width" do
-												Add rubocop to our build. (#5004)


											
										
										
											2017-07-27 21:20:09 -04:00
+								        let(:image_sizes) { { "http://foo.bar/image.png" => { "width" => 0, "height" => 222 } } }
-												FIX: picture would be hidden when [details] block was closed in the composer

											
										
										
											2015-03-16 13:57:15 -04:00
+								        include_examples "leave dimensions alone"
 								      end
 								      context "invalid height" do
-												Add rubocop to our build. (#5004)


											
										
										
											2017-07-27 21:20:09 -04:00
+								        let(:image_sizes) { { "http://foo.bar/image.png" => { "width" => 111, "height" => 0 } } }
-												FIX: picture would be hidden when [details] block was closed in the composer

											
										
										
											2015-03-16 13:57:15 -04:00
+								        include_examples "leave dimensions alone"
 								      end
 								      context "invalid width & height" do
-												Add rubocop to our build. (#5004)


											
										
										
											2017-07-27 21:20:09 -04:00
+								        let(:image_sizes) { { "http://foo.bar/image.png" => { "width" => 0, "height" => 0 } } }
-												FIX: picture would be hidden when [details] block was closed in the composer

											
										
										
											2015-03-16 13:57:15 -04:00
+								        include_examples "leave dimensions alone"
-												Initial release of Discourse

											
										
										
											2013-02-05 14:16:51 -05:00
+								      end
 								    end
-												refactor CookedPostProcessor & specs

											
										
										
											2013-07-07 19:39:08 -04:00
+								    context "with unsized images" do
-												- FEATURE: revamped poll plugin

- add User.staff scope
- inject MessageBus into Ember views (so it can be used by the poll plugin)
- REFACTOR: use more accurate is_first_post? method instead of post_number == 1
- FEATURE: add support for JSON-typed custom fields
- FEATURE: allow plugins to add validation
- FEATURE: add post_custom_fields to PostSerializer
- FEATURE: allow plugins to whitelist post_custom_fields
- FIX: don't bump when post did not save successfully
- FEATURE: polls are supported in any post
- FEATURE: allow for multiple polls in the same post
- FEATURE: multiple choice polls
- FEATURE: rating polls
- FEATURE: new dialect allowing users to preview polls in the composer

											
										
										
											2015-04-23 13:33:29 -04:00
+								      let(:post) { Fabricate(:post_with_unsized_images) }
-												refactor CookedPostProcessor & specs

											
										
										
											2013-07-07 19:39:08 -04:00
+								      let(:cpp) { CookedPostProcessor.new(post) }
-												keep uploads reverse index up to date

											
										
										
											2013-06-17 16:46:48 -04:00
-												refactor CookedPostProcessor & specs

											
										
										
											2013-07-07 19:39:08 -04:00
+								      it "adds the width and height to images that don't have them" do
 								        FastImage.expects(:size).returns([123, 456])
 								        cpp.post_process_images
-												few components with rspec3 syntax

											
										
										
											2015-01-09 11:34:37 -05:00
+								        expect(cpp.html).to match(/width="123" height="456"/)
 								        expect(cpp).to be_dirty
-												keep uploads reverse index up to date

											
										
										
											2013-06-17 16:46:48 -04:00
+								      end
 								    end
-												refactor CookedPostProcessor & specs

											
										
										
											2013-07-07 19:39:08 -04:00
+								    context "with large images" do
-												Move a bunch of callbacks into PostCreator

											
										
										
											2013-03-18 13:55:34 -04:00
-												FIX: images aren't lightboxed anymore (partially reverts 646c6eb7cd781b47663d104de4f37cdd99b465bf)

											
										
										
											2017-10-18 17:54:36 -04:00
+								      let(:upload) { Fabricate(:upload) }
-												- FEATURE: revamped poll plugin

- add User.staff scope
- inject MessageBus into Ember views (so it can be used by the poll plugin)
- REFACTOR: use more accurate is_first_post? method instead of post_number == 1
- FEATURE: add support for JSON-typed custom fields
- FEATURE: allow plugins to add validation
- FEATURE: add post_custom_fields to PostSerializer
- FEATURE: allow plugins to whitelist post_custom_fields
- FIX: don't bump when post did not save successfully
- FEATURE: polls are supported in any post
- FEATURE: allow for multiple polls in the same post
- FEATURE: multiple choice polls
- FEATURE: rating polls
- FEATURE: new dialect allowing users to preview polls in the composer

											
										
										
											2015-04-23 13:33:29 -04:00
+								      let(:post) { Fabricate(:post_with_large_image) }
-												FEATURE: Show a blurry preview when lazy loading images

This generates a 10x10 PNG thumbnail for each lightboxed image.
If Image Lazy Loading is enabled (IntersectionObserver API) then
we'll load the low res version when offscreen. As the image scrolls
in we'll swap it for the high res version.

We use a WeakMap to track the old image attributes. It's much less
memory than storing them as `data-*` attributes and swapping them
back and forth all the time.

											
										
										
											2018-12-14 17:44:38 -05:00
+								      let(:cpp) { CookedPostProcessor.new(post, disable_loading_image: true) }
-												Initial release of Discourse

											
										
										
											2013-02-05 14:16:51 -05:00
-												refactor CookedPostProcessor & specs

											
										
										
											2013-07-07 19:39:08 -04:00
+								      before do
-												BUGFIX: broken spec

											
										
										
											2014-05-26 07:17:20 -04:00
+								        SiteSetting.max_image_height = 2000
 								        SiteSetting.create_thumbnails = true
-												UX: Don't add light box for SVG images.

											
										
										
											2018-06-18 05:10:23 -04:00
+								        FastImage.expects(:size).returns([1750, 2000])
 								      end
-												BUGFIX: broken spec

											
										
										
											2014-05-26 07:17:20 -04:00
-												UX: Don't add light box for SVG images.

											
										
										
											2018-06-18 05:10:23 -04:00
+								      it "generates overlay information" do
-												refactor CookedPostProcessor & specs

											
										
										
											2013-07-07 19:39:08 -04:00
+								        Upload.expects(:get_from_url).returns(upload)
-												FIX broken spec

											
										
										
											2014-05-26 23:52:39 -04:00
+								        OptimizedImage.expects(:resize).returns(true)
-												FIX: Tests would fail if your test db's optimized image ids were high

											
										
										
											2015-10-16 17:08:16 -04:00
 								        FileStore::BaseStore.any_instance.expects(:get_depth_for).returns(0)
-												Initial release of Discourse

											
										
										
											2013-02-05 14:16:51 -05:00
-												refactor CookedPostProcessor & specs

											
										
										
											2013-07-07 19:39:08 -04:00
+								        cpp.post_process_images
-												Fix the build.

Ref 570877da3c39707c2101c3510fab1509fb8ba3e2

											
										
										
											2019-01-03 02:34:10 -05:00
+								        expect(cpp.html).to match_html "<p><div class=\"lightbox-wrapper\"><a class=\"lightbox\" href=\"/uploads/default/original/1X/1234567890123456.jpg\" data-download-href=\"/uploads/default/#{upload.sha1}\" title=\"logo.png\"><img src=\"/uploads/default/optimized/1X/#{upload.sha1}_#{OptimizedImage::VERSION}_690x788.png\" width=\"690\" height=\"788\"><div class=\"meta\">
-												fix the build

											
										
										
											2018-12-24 23:57:51 -05:00
+								<span class=\"filename\">logo.png</span><span class=\"informations\">1750×2000 1.21 KB</span><span class=\"expand\"></span>
-												FIX: don't crop iPhone X screenshots

											
										
										
											2017-11-14 14:37:27 -05:00
+								</div></a></div></p>"
 								        expect(cpp).to be_dirty
 								      end
-												FIX: Do not add lightbox to onebox images (#6479)


											
										
										
											2018-10-10 17:57:21 -04:00
+								      describe 'when image is inside onebox' do
 								        let(:url) { 'https://image.com/my-avatar' }
 								        let(:post) { Fabricate(:post, raw: url) }
 								        before do
 								          Oneboxer.stubs(:onebox).with(url, anything).returns("<img class='onebox' src='/uploads/default/original/1X/1234567890123456.jpg' />")
 								        end
 								        it 'should not add lightbox' do
 								          cpp.post_process_oneboxes
 								          cpp.post_process_images
 								          expect(cpp.html).to match_html("<p><img class=\"onebox\" src=\"/uploads/default/original/1X/1234567890123456.jpg\" width=\"690\"\ height=\"788\"></p>")
 								        end
 								      end
-												UX: Don't add light box for SVG images.

											
										
										
											2018-06-18 05:10:23 -04:00
+								      describe 'when image is an svg' do
 								        let(:post) do
-												FIX: store the topic links using the cooked upload url

											
										
										
											2018-08-14 06:23:32 -04:00
+								          Fabricate(:post, raw: '<img src="/uploads/default/original/1X/1234567890123456.svg">')
-												UX: Don't add light box for SVG images.

											
										
										
											2018-06-18 05:10:23 -04:00
+								        end
 								        it 'should not add lightbox' do
 								          cpp.post_process_images
-												FIX: store the topic links using the cooked upload url

											
										
										
											2018-08-14 06:23:32 -04:00
+								          expect(cpp.html).to match_html("<p><img src=\"/uploads/default/original/1X/1234567890123456.svg\" width=\"690\"\ height=\"788\"></p>")
-												UX: Don't add light box for SVG images.

											
										
										
											2018-06-18 05:10:23 -04:00
+								        end
-												FIX: URL with params for svg images should not be light boxed.

											
										
										
											2018-06-19 22:47:14 -04:00
 								        describe 'when image src is an URL' do
 								          let(:post) do
-												FIX: store the topic links using the cooked upload url

											
										
										
											2018-08-14 06:23:32 -04:00
+								            Fabricate(:post, raw: '<img src="http://test.discourse/uploads/default/original/1X/1234567890123456.svg?somepamas">')
-												FIX: URL with params for svg images should not be light boxed.

											
										
										
											2018-06-19 22:47:14 -04:00
+								          end
 								          it 'should not add lightbox' do
 								            SiteSetting.crawl_images = true
 								            cpp.post_process_images
-												FIX: store the topic links using the cooked upload url

											
										
										
											2018-08-14 06:23:32 -04:00
+								            expect(cpp.html).to match_html("<p><img src=\"http://test.discourse/uploads/default/original/1X/1234567890123456.svg?somepamas\" width=\"690\"\ height=\"788\"></p>")
-												FIX: URL with params for svg images should not be light boxed.

											
										
										
											2018-06-19 22:47:14 -04:00
+								          end
 								        end
-												UX: Don't add light box for SVG images.

											
										
										
											2018-06-18 05:10:23 -04:00
+								      end
-												FIX: don't crop iPhone X screenshots

											
										
										
											2017-11-14 14:37:27 -05:00
+								    end
 								    context "with tall images" do
 								      let(:upload) { Fabricate(:upload) }
 								      let(:post) { Fabricate(:post_with_large_image) }
-												FEATURE: Show a blurry preview when lazy loading images

This generates a 10x10 PNG thumbnail for each lightboxed image.
If Image Lazy Loading is enabled (IntersectionObserver API) then
we'll load the low res version when offscreen. As the image scrolls
in we'll swap it for the high res version.

We use a WeakMap to track the old image attributes. It's much less
memory than storing them as `data-*` attributes and swapping them
back and forth all the time.

											
										
										
											2018-12-14 17:44:38 -05:00
+								      let(:cpp) { CookedPostProcessor.new(post, disable_loading_image: true) }
-												FIX: don't crop iPhone X screenshots

											
										
										
											2017-11-14 14:37:27 -05:00
 								      before do
 								        SiteSetting.create_thumbnails = true
 								        Upload.expects(:get_from_url).returns(upload)
-												UX: only crops images taller than 18:9 instead of 16:9

											
										
										
											2018-01-31 16:31:16 -05:00
+								        FastImage.expects(:size).returns([860, 2000])
-												FIX: don't crop iPhone X screenshots

											
										
										
											2017-11-14 14:37:27 -05:00
+								        OptimizedImage.expects(:resize).never
 								        OptimizedImage.expects(:crop).returns(true)
 								        FileStore::BaseStore.any_instance.expects(:get_depth_for).returns(0)
 								      end
 								      it "crops the image" do
 								        cpp.post_process_images
-												FEATURE: Show a blurry preview when lazy loading images

This generates a 10x10 PNG thumbnail for each lightboxed image.
If Image Lazy Loading is enabled (IntersectionObserver API) then
we'll load the low res version when offscreen. As the image scrolls
in we'll swap it for the high res version.

We use a WeakMap to track the old image attributes. It's much less
memory than storing them as `data-*` attributes and swapping them
back and forth all the time.

											
										
										
											2018-12-14 17:44:38 -05:00
+								        expect(cpp.html).to match(/width="690" height="500">/)
-												FIX: don't crop iPhone X screenshots

											
										
										
											2017-11-14 14:37:27 -05:00
+								        expect(cpp).to be_dirty
 								      end
 								    end
 								    context "with iPhone X screenshots" do
 								      let(:upload) { Fabricate(:upload) }
 								      let(:post) { Fabricate(:post_with_large_image) }
-												FEATURE: Show a blurry preview when lazy loading images

This generates a 10x10 PNG thumbnail for each lightboxed image.
If Image Lazy Loading is enabled (IntersectionObserver API) then
we'll load the low res version when offscreen. As the image scrolls
in we'll swap it for the high res version.

We use a WeakMap to track the old image attributes. It's much less
memory than storing them as `data-*` attributes and swapping them
back and forth all the time.

											
										
										
											2018-12-14 17:44:38 -05:00
+								      let(:cpp) { CookedPostProcessor.new(post, disable_loading_image: true) }
-												FIX: don't crop iPhone X screenshots

											
										
										
											2017-11-14 14:37:27 -05:00
 								      before do
 								        SiteSetting.create_thumbnails = true
 								        Upload.expects(:get_from_url).returns(upload)
 								        FastImage.expects(:size).returns([1125, 2436])
 								        OptimizedImage.expects(:resize).returns(true)
 								        OptimizedImage.expects(:crop).never
 								        FileStore::BaseStore.any_instance.expects(:get_depth_for).returns(0)
 								      end
 								      it "crops the image" do
 								        cpp.post_process_images
-												Fix the build.

Ref 570877da3c39707c2101c3510fab1509fb8ba3e2

											
										
										
											2019-01-03 02:34:10 -05:00
+								        expect(cpp.html).to match_html "<p><div class=\"lightbox-wrapper\"><a class=\"lightbox\" href=\"/uploads/default/original/1X/1234567890123456.jpg\" data-download-href=\"/uploads/default/#{upload.sha1}\" title=\"logo.png\"><img src=\"/uploads/default/optimized/1X/#{upload.sha1}_#{OptimizedImage::VERSION}_230x500.png\" width=\"230\" height=\"500\"><div class=\"meta\">
-												fix the build

											
										
										
											2018-12-24 23:57:51 -05:00
+								<span class=\"filename\">logo.png</span><span class=\"informations\">1125×2436 1.21 KB</span><span class=\"expand\"></span>
-												PERF: Split queries when cleaning uploads.

This reduces the number of scans that the db has to do in the query
to fetch orphan uploads. Futheremore, we were not batching our
records which bloats memory.

											
										
										
											2016-07-01 03:22:30 -04:00
+								</div></a></div></p>"
-												few components with rspec3 syntax

											
										
										
											2015-01-09 11:34:37 -05:00
+								        expect(cpp).to be_dirty
-												Initial release of Discourse

											
										
										
											2013-02-05 14:16:51 -05:00
+								      end
 								    end
-												Don't append the base url to absolute image urls without protocol.

											
										
										
											2013-05-30 11:17:07 -04:00
-												Adds large image upload on subfolder install spec
											
										
										
											2016-03-09 22:48:50 -05:00
+								    context "with large images when using subfolders" do
-												FIX: images aren't lightboxed anymore (partially reverts 646c6eb7cd781b47663d104de4f37cdd99b465bf)

											
										
										
											2017-10-18 17:54:36 -04:00
+								      let(:upload) { Fabricate(:upload) }
-												Adds large image upload on subfolder install spec
											
										
										
											2016-03-09 22:48:50 -05:00
+								      let(:post) { Fabricate(:post_with_large_image_on_subfolder) }
-												FEATURE: Show a blurry preview when lazy loading images

This generates a 10x10 PNG thumbnail for each lightboxed image.
If Image Lazy Loading is enabled (IntersectionObserver API) then
we'll load the low res version when offscreen. As the image scrolls
in we'll swap it for the high res version.

We use a WeakMap to track the old image attributes. It's much less
memory than storing them as `data-*` attributes and swapping them
back and forth all the time.

											
										
										
											2018-12-14 17:44:38 -05:00
+								      let(:cpp) { CookedPostProcessor.new(post, disable_loading_image: true) }
-												Adds large image upload on subfolder install spec
											
										
										
											2016-03-09 22:48:50 -05:00
+								      let(:base_url) { "http://test.localhost/subfolder" }
 								      let(:base_uri) { "/subfolder" }
 								      before do
 								        SiteSetting.max_image_height = 2000
 								        SiteSetting.create_thumbnails = true
 								        Discourse.stubs(:base_url).returns(base_url)
 								        Discourse.stubs(:base_uri).returns(base_uri)
-												Remove unnecessary post fabricator

											
										
										
											2016-03-20 08:58:33 -04:00
+								        Upload.expects(:get_from_url).returns(upload)
-												FIX: images aren't lightboxed anymore (partially reverts 646c6eb7cd781b47663d104de4f37cdd99b465bf)

											
										
										
											2017-10-18 17:54:36 -04:00
+								        FastImage.expects(:size).returns([1750, 2000])
-												Adds large image upload on subfolder install spec
											
										
										
											2016-03-09 22:48:50 -05:00
+								        OptimizedImage.expects(:resize).returns(true)
 								        FileStore::BaseStore.any_instance.expects(:get_depth_for).returns(0)
 								      end
 								      it "generates overlay information" do
 								        cpp.post_process_images
-												Fix the build.

Ref 570877da3c39707c2101c3510fab1509fb8ba3e2

											
										
										
											2019-01-03 02:34:10 -05:00
+								        expect(cpp.html).to match_html "<p><div class=\"lightbox-wrapper\"><a class=\"lightbox\" href=\"/subfolder/uploads/default/original/1X/1234567890123456.jpg\" data-download-href=\"/subfolder/uploads/default/#{upload.sha1}\" title=\"logo.png\"><img src=\"/subfolder/uploads/default/optimized/1X/#{upload.sha1}_#{OptimizedImage::VERSION}_690x788.png\" width=\"690\" height=\"788\"><div class=\"meta\">
-												fix the build

											
										
										
											2018-12-24 23:57:51 -05:00
+								<span class=\"filename\">logo.png</span><span class=\"informations\">1750×2000 1.21 KB</span><span class=\"expand\"></span>
-												PERF: Split queries when cleaning uploads.

This reduces the number of scans that the db has to do in the query
to fetch orphan uploads. Futheremore, we were not batching our
records which bloats memory.

											
										
										
											2016-07-01 03:22:30 -04:00
+								</div></a></div></p>"
-												few components with rspec3 syntax

											
										
										
											2015-01-09 11:34:37 -05:00
+								        expect(cpp).to be_dirty
-												Initial release of Discourse

											
										
										
											2013-02-05 14:16:51 -05:00
+								      end
-												SECURITY: Escape HTML in filename.

											
										
										
											2016-08-10 23:27:12 -04:00
+								      it "should escape the filename" do
 								        upload.update_attributes!(original_filename: "><img src=x onerror=alert('haha')>.png")
 								        cpp.post_process_images
-												Fix the build.

Ref 570877da3c39707c2101c3510fab1509fb8ba3e2

											
										
										
											2019-01-03 02:34:10 -05:00
+								        expect(cpp.html).to match_html "<p><div class=\"lightbox-wrapper\"><a class=\"lightbox\" href=\"/subfolder/uploads/default/original/1X/1234567890123456.jpg\" data-download-href=\"/subfolder/uploads/default/#{upload.sha1}\" title=\"&amp;gt;&amp;lt;img src=x onerror=alert(&amp;#39;haha&amp;#39;)&amp;gt;.png\"><img src=\"/subfolder/uploads/default/optimized/1X/#{upload.sha1}_#{OptimizedImage::VERSION}_690x788.png\" width=\"690\" height=\"788\"><div class=\"meta\">
-												fix the build

											
										
										
											2018-12-24 23:57:51 -05:00
+								<span class=\"filename\">&amp;gt;&amp;lt;img src=x onerror=alert(&amp;#39;haha&amp;#39;)&amp;gt;.png</span><span class=\"informations\">1750×2000 1.21 KB</span><span class=\"expand\"></span>
-												SECURITY: Escape HTML in filename.

											
										
										
											2016-08-10 23:27:12 -04:00
+								</div></a></div></p>"
 								      end
-												Initial release of Discourse

											
										
										
											2013-02-05 14:16:51 -05:00
+								    end
-												Don't append the base url to absolute image urls without protocol.

											
										
										
											2013-05-30 11:17:07 -04:00
-												FEATURE: use img's title attribute in overlay information when provided

											
										
										
											2014-11-03 16:03:06 -05:00
+								    context "with title" do
-												FIX: images aren't lightboxed anymore (partially reverts 646c6eb7cd781b47663d104de4f37cdd99b465bf)

											
										
										
											2017-10-18 17:54:36 -04:00
+								      let(:upload) { Fabricate(:upload) }
-												- FEATURE: revamped poll plugin

- add User.staff scope
- inject MessageBus into Ember views (so it can be used by the poll plugin)
- REFACTOR: use more accurate is_first_post? method instead of post_number == 1
- FEATURE: add support for JSON-typed custom fields
- FEATURE: allow plugins to add validation
- FEATURE: add post_custom_fields to PostSerializer
- FEATURE: allow plugins to whitelist post_custom_fields
- FIX: don't bump when post did not save successfully
- FEATURE: polls are supported in any post
- FEATURE: allow for multiple polls in the same post
- FEATURE: multiple choice polls
- FEATURE: rating polls
- FEATURE: new dialect allowing users to preview polls in the composer

											
										
										
											2015-04-23 13:33:29 -04:00
+								      let(:post) { Fabricate(:post_with_large_image_and_title) }
-												FEATURE: Show a blurry preview when lazy loading images

This generates a 10x10 PNG thumbnail for each lightboxed image.
If Image Lazy Loading is enabled (IntersectionObserver API) then
we'll load the low res version when offscreen. As the image scrolls
in we'll swap it for the high res version.

We use a WeakMap to track the old image attributes. It's much less
memory than storing them as `data-*` attributes and swapping them
back and forth all the time.

											
										
										
											2018-12-14 17:44:38 -05:00
+								      let(:cpp) { CookedPostProcessor.new(post, disable_loading_image: true) }
-												FEATURE: use img's title attribute in overlay information when provided

											
										
										
											2014-11-03 16:03:06 -05:00
 								      before do
 								        SiteSetting.max_image_height = 2000
 								        SiteSetting.create_thumbnails = true
 								        Upload.expects(:get_from_url).returns(upload)
-												FIX: images aren't lightboxed anymore (partially reverts 646c6eb7cd781b47663d104de4f37cdd99b465bf)

											
										
										
											2017-10-18 17:54:36 -04:00
+								        FastImage.expects(:size).returns([1750, 2000])
-												FEATURE: use img's title attribute in overlay information when provided

											
										
										
											2014-11-03 16:03:06 -05:00
+								        OptimizedImage.expects(:resize).returns(true)
-												FIX: images aren't lightboxed anymore (partially reverts 646c6eb7cd781b47663d104de4f37cdd99b465bf)

											
										
										
											2017-10-18 17:54:36 -04:00
-												FIX: Tests would fail if your test db's optimized image ids were high

											
										
										
											2015-10-16 17:08:16 -04:00
+								        FileStore::BaseStore.any_instance.expects(:get_depth_for).returns(0)
-												FEATURE: use img's title attribute in overlay information when provided

											
										
										
											2014-11-03 16:03:06 -05:00
+								      end
 								      it "generates overlay information" do
 								        cpp.post_process_images
-												Fix the build.

Ref 570877da3c39707c2101c3510fab1509fb8ba3e2

											
										
										
											2019-01-03 02:34:10 -05:00
+								        expect(cpp.html).to match_html "<p><div class=\"lightbox-wrapper\"><a class=\"lightbox\" href=\"/uploads/default/original/1X/1234567890123456.jpg\" data-download-href=\"/uploads/default/#{upload.sha1}\" title=\"WAT\"><img src=\"/uploads/default/optimized/1X/#{upload.sha1}_#{OptimizedImage::VERSION}_690x788.png\" title=\"WAT\" width=\"690\" height=\"788\"><div class=\"meta\">
-												fix the build

											
										
										
											2018-12-24 23:57:51 -05:00
+								       <span class=\"filename\">WAT</span><span class=\"informations\">1750×2000 1.21 KB</span><span class=\"expand\"></span>
-												PERF: Split queries when cleaning uploads.

This reduces the number of scans that the db has to do in the query
to fetch orphan uploads. Futheremore, we were not batching our
records which bloats memory.

											
										
										
											2016-07-01 03:22:30 -04:00
+								       </div></a></div></p>"
-												few components with rspec3 syntax

											
										
										
											2015-01-09 11:34:37 -05:00
+								        expect(cpp).to be_dirty
-												FEATURE: use img's title attribute in overlay information when provided

											
										
										
											2014-11-03 16:03:06 -05:00
+								      end
 								    end
-												refactor CookedPostProcessor & specs

											
										
										
											2013-07-07 19:39:08 -04:00
+								    context "topic image" do
 								      let(:topic) { build(:topic, id: 1) }
-												FIX: thumbnailing wasn't working with CDN enabled

											
										
										
											2013-07-21 18:37:23 -04:00
+								      let(:post) { Fabricate(:post_with_uploaded_image, topic: topic) }
-												refactor CookedPostProcessor & specs

											
										
										
											2013-07-07 19:39:08 -04:00
+								      let(:cpp) { CookedPostProcessor.new(post) }
-												Don't append the base url to absolute image urls without protocol.

											
										
										
											2013-05-30 11:17:07 -04:00
-												FEATURE: include post image in OpenGraph image tag

											
										
										
											2016-10-31 05:41:33 -04:00
+								      it "adds a topic image if there's one in the first post" do
-												pull hotlinked images

											
										
										
											2013-11-05 13:04:47 -05:00
+								        FastImage.stubs(:size)
-												few components with rspec3 syntax

											
										
										
											2015-01-09 11:34:37 -05:00
+								        expect(post.topic.image_url).to eq(nil)
-												Add extraction of image_url for oneboxed images. Fix search by images filter name.

											
										
										
											2017-06-09 07:16:50 -04:00
+								        cpp.update_post_image
-												refactor CookedPostProcessor & specs

											
										
										
											2013-07-07 19:39:08 -04:00
+								        post.topic.reload
-												few components with rspec3 syntax

											
										
										
											2015-01-09 11:34:37 -05:00
+								        expect(post.topic.image_url).to be_present
-												Don't append the base url to absolute image urls without protocol.

											
										
										
											2013-05-30 11:17:07 -04:00
+								      end
-												FEATURE: include post image in OpenGraph image tag

											
										
										
											2016-10-31 05:41:33 -04:00
+								    end
 								    context "post image" do
 								      let(:reply) { Fabricate(:post_with_uploaded_image, post_number: 2) }
 								      let(:cpp) { CookedPostProcessor.new(reply) }
-												refactor CookedPostProcessor & specs

											
										
										
											2013-07-07 19:39:08 -04:00
-												FEATURE: include post image in OpenGraph image tag

											
										
										
											2016-10-31 05:41:33 -04:00
+								      it "adds a post image if there's one in the post" do
 								        FastImage.stubs(:size)
 								        expect(reply.image_url).to eq(nil)
-												Add extraction of image_url for oneboxed images. Fix search by images filter name.

											
										
										
											2017-06-09 07:16:50 -04:00
+								        cpp.update_post_image
-												FEATURE: include post image in OpenGraph image tag

											
										
										
											2016-10-31 05:41:33 -04:00
+								        reply.reload
 								        expect(reply.image_url).to be_present
 								      end
-												Don't append the base url to absolute image urls without protocol.

											
										
										
											2013-05-30 11:17:07 -04:00
+								    end
-												refactor CookedPostProcessor & specs

											
										
										
											2013-07-07 19:39:08 -04:00
+								  end
-												do not lightbox oneboxed images

											
										
										
											2013-06-23 20:10:21 -04:00
-												PERF: Move processing of inline onebox out of V8 context. (#6658)


											
										
										
											2018-11-25 20:21:38 -05:00
+								  context "#extract_images" do
-												do not lightbox oneboxed images

											
										
										
											2013-06-23 20:10:21 -04:00
-												FIX: don't use emojis as topic image

											
										
										
											2015-08-05 06:57:31 -04:00
+								    let(:post) { build(:post_with_plenty_of_images) }
-												pull hotlinked images

											
										
										
											2013-11-05 13:04:47 -05:00
+								    let(:cpp) { CookedPostProcessor.new(post) }
-												refactor CookedPostProcessor & specs

											
										
										
											2013-07-07 19:39:08 -04:00
-												FIX: don't use emojis as topic image

											
										
										
											2015-08-05 06:57:31 -04:00
+								    it "does not extract emojis or images inside oneboxes or quotes" do
-												few components with rspec3 syntax

											
										
										
											2015-01-09 11:34:37 -05:00
+								      expect(cpp.extract_images.length).to eq(0)
-												do not lightbox oneboxed images

											
										
										
											2013-06-23 20:10:21 -04:00
+								    end
-												pull hotlinked images

											
										
										
											2013-11-05 13:04:47 -05:00
+								  end
-												PERF: Move processing of inline onebox out of V8 context. (#6658)


											
										
										
											2018-11-25 20:21:38 -05:00
+								  context "#get_size_from_attributes" do
-												FIX: rescale image during cooked_post_processor when only img height or width is specified

											
										
										
											2015-08-29 17:56:25 -04:00
 								    let(:post) { build(:post) }
 								    let(:cpp) { CookedPostProcessor.new(post) }
 								    it "returns the size when width and height are specified" do
-												Add rubocop to our build. (#5004)


											
										
										
											2017-07-27 21:20:09 -04:00
+								      img = { 'src' => 'http://foo.bar/image3.png', 'width' => 50, 'height' => 70 }
-												FIX: rescale image during cooked_post_processor when only img height or width is specified

											
										
										
											2015-08-29 17:56:25 -04:00
+								      expect(cpp.get_size_from_attributes(img)).to eq([50, 70])
 								    end
 								    it "returns the size when width and height are floats" do
-												Add rubocop to our build. (#5004)


											
										
										
											2017-07-27 21:20:09 -04:00
+								      img = { 'src' => 'http://foo.bar/image3.png', 'width' => 50.2, 'height' => 70.1 }
-												FIX: rescale image during cooked_post_processor when only img height or width is specified

											
										
										
											2015-08-29 17:56:25 -04:00
+								      expect(cpp.get_size_from_attributes(img)).to eq([50, 70])
 								    end
 								    it "resizes when only width is specified" do
-												Add rubocop to our build. (#5004)


											
										
										
											2017-07-27 21:20:09 -04:00
+								      img = { 'src' => 'http://foo.bar/image3.png', 'width' => 100 }
-												Nuke all `SiteSetting.stubs` from our codebase.

											
										
										
											2017-07-07 02:09:14 -04:00
+								      SiteSetting.crawl_images = true
-												FIX: rescale image during cooked_post_processor when only img height or width is specified

											
										
										
											2015-08-29 17:56:25 -04:00
+								      FastImage.expects(:size).returns([200, 400])
 								      expect(cpp.get_size_from_attributes(img)).to eq([100, 200])
 								    end
 								    it "resizes when only height is specified" do
-												Add rubocop to our build. (#5004)


											
										
										
											2017-07-27 21:20:09 -04:00
+								      img = { 'src' => 'http://foo.bar/image3.png', 'height' => 100 }
-												Nuke all `SiteSetting.stubs` from our codebase.

											
										
										
											2017-07-07 02:09:14 -04:00
+								      SiteSetting.crawl_images = true
-												FIX: rescale image during cooked_post_processor when only img height or width is specified

											
										
										
											2015-08-29 17:56:25 -04:00
+								      FastImage.expects(:size).returns([100, 300])
 								      expect(cpp.get_size_from_attributes(img)).to eq([33, 100])
 								    end
-												FIX: Don't raise an error when the img attribute cannot be found

											
										
										
											2017-05-08 15:35:31 -04:00
+								    it "doesn't raise an error with a weird url" do
-												Add rubocop to our build. (#5004)


											
										
										
											2017-07-27 21:20:09 -04:00
+								      img = { 'src' => nil, 'height' => 100 }
-												Nuke all `SiteSetting.stubs` from our codebase.

											
										
										
											2017-07-07 02:09:14 -04:00
+								      SiteSetting.crawl_images = true
-												FIX: Don't raise an error when the img attribute cannot be found

											
										
										
											2017-05-08 15:35:31 -04:00
+								      expect(cpp.get_size_from_attributes(img)).to be_nil
 								    end
-												FIX: rescale image during cooked_post_processor when only img height or width is specified

											
										
										
											2015-08-29 17:56:25 -04:00
+								  end
-												PERF: Move processing of inline onebox out of V8 context. (#6658)


											
										
										
											2018-11-25 20:21:38 -05:00
+								  context "#get_size_from_image_sizes" do
-												pull hotlinked images

											
										
										
											2013-11-05 13:04:47 -05:00
 								    let(:post) { build(:post) }
 								    let(:cpp) { CookedPostProcessor.new(post) }
 								    it "returns the size" do
 								      image_sizes = { "http://my.discourse.org/image.png" => { "width" => 111, "height" => 222 } }
-												few components with rspec3 syntax

											
										
										
											2015-01-09 11:34:37 -05:00
+								      expect(cpp.get_size_from_image_sizes("/image.png", image_sizes)).to eq([111, 222])
-												refactor CookedPostProcessor & specs

											
										
										
											2013-07-07 19:39:08 -04:00
+								    end
-												soften the lightbox overlay

											
										
										
											2013-06-25 20:44:20 -04:00
-												pull hotlinked images

											
										
										
											2013-11-05 13:04:47 -05:00
+								  end
-												PERF: Move processing of inline onebox out of V8 context. (#6658)


											
										
										
											2018-11-25 20:21:38 -05:00
+								  context "#get_size" do
-												pull hotlinked images

											
										
										
											2013-11-05 13:04:47 -05:00
 								    let(:post) { build(:post) }
 								    let(:cpp) { CookedPostProcessor.new(post) }
 								    it "ensures urls are absolute" do
 								      cpp.expects(:is_valid_image_url?).with("http://test.localhost/relative/url/image.png")
 								      cpp.get_size("/relative/url/image.png")
 								    end
 								    it "ensures urls have a default scheme" do
 								      cpp.expects(:is_valid_image_url?).with("http://schemaless.url/image.jpg")
 								      cpp.get_size("//schemaless.url/image.jpg")
 								    end
 								    it "caches the results" do
-												Nuke all `SiteSetting.stubs` from our codebase.

											
										
										
											2017-07-07 02:09:14 -04:00
+								      SiteSetting.crawl_images = true
-												pull hotlinked images

											
										
										
											2013-11-05 13:04:47 -05:00
+								      FastImage.expects(:size).returns([200, 400])
 								      cpp.get_size("http://foo.bar/image3.png")
-												few components with rspec3 syntax

											
										
										
											2015-01-09 11:34:37 -05:00
+								      expect(cpp.get_size("http://foo.bar/image3.png")).to eq([200, 400])
-												pull hotlinked images

											
										
										
											2013-11-05 13:04:47 -05:00
+								    end
 								    context "when crawl_images is disabled" do
-												Nuke all `SiteSetting.stubs` from our codebase.

											
										
										
											2017-07-07 02:09:14 -04:00
+								      before do
 								        SiteSetting.crawl_images = false
 								      end
-												pull hotlinked images

											
										
										
											2013-11-05 13:04:47 -05:00
 								      it "doesn't call FastImage" do
 								        FastImage.expects(:size).never
-												few components with rspec3 syntax

											
										
										
											2015-01-09 11:34:37 -05:00
+								        expect(cpp.get_size("http://foo.bar/image1.png")).to eq(nil)
-												pull hotlinked images

											
										
										
											2013-11-05 13:04:47 -05:00
+								      end
 								      it "is always allowed to crawl our own images" do
 								        store = stub
 								        store.expects(:has_been_uploaded?).returns(true)
 								        Discourse.expects(:store).returns(store)
 								        FastImage.expects(:size).returns([100, 200])
-												few components with rspec3 syntax

											
										
										
											2015-01-09 11:34:37 -05:00
+								        expect(cpp.get_size("http://foo.bar/image2.png")).to eq([100, 200])
-												pull hotlinked images

											
										
										
											2013-11-05 13:04:47 -05:00
+								      end
-												FIX: `FastImage#size` returns `nil` if it can't fetch the image size.

											
										
										
											2016-03-07 22:29:18 -05:00
+								      it "returns nil if FastImage can't get the original size" do
 								        Discourse.store.class.any_instance.expects(:has_been_uploaded?).returns(true)
 								        FastImage.expects(:size).returns(nil)
 								        expect(cpp.get_size("http://foo.bar/image3.png")).to eq(nil)
 								      end
-												refactor CookedPostProcessor & specs

											
										
										
											2013-07-07 19:39:08 -04:00
+								    end
-												soften the lightbox overlay

											
										
										
											2013-06-25 20:44:20 -04:00
-												refactor CookedPostProcessor & specs

											
										
										
											2013-07-07 19:39:08 -04:00
+								  end
-												soften the lightbox overlay

											
										
										
											2013-06-25 20:44:20 -04:00
-												PERF: Move processing of inline onebox out of V8 context. (#6658)


											
										
										
											2018-11-25 20:21:38 -05:00
+								  context "#is_valid_image_url?" do
-												pull hotlinked images

											
										
										
											2013-11-05 13:04:47 -05:00
 								    let(:post) { build(:post) }
 								    let(:cpp) { CookedPostProcessor.new(post) }
 								    it "validates HTTP(s) urls" do
-												few components with rspec3 syntax

											
										
										
											2015-01-09 11:34:37 -05:00
+								      expect(cpp.is_valid_image_url?("http://domain.com")).to eq(true)
 								      expect(cpp.is_valid_image_url?("https://domain.com")).to eq(true)
-												pull hotlinked images

											
										
										
											2013-11-05 13:04:47 -05:00
+								    end
 								    it "doesn't validate other urls" do
-												few components with rspec3 syntax

											
										
										
											2015-01-09 11:34:37 -05:00
+								      expect(cpp.is_valid_image_url?("ftp://domain.com")).to eq(false)
 								      expect(cpp.is_valid_image_url?("ftps://domain.com")).to eq(false)
 								      expect(cpp.is_valid_image_url?("/tmp/image.png")).to eq(false)
 								      expect(cpp.is_valid_image_url?("//domain.com")).to eq(false)
-												pull hotlinked images

											
										
										
											2013-11-05 13:04:47 -05:00
+								    end
 								    it "doesn't throw an exception with a bad URI" do
-												few components with rspec3 syntax

											
										
										
											2015-01-09 11:34:37 -05:00
+								      expect(cpp.is_valid_image_url?("http://do<main.com")).to eq(nil)
-												pull hotlinked images

											
										
										
											2013-11-05 13:04:47 -05:00
+								    end
 								  end
-												PERF: Move processing of inline onebox out of V8 context. (#6658)


											
										
										
											2018-11-25 20:21:38 -05:00
+								  context "#get_filename" do
-												soften the lightbox overlay

											
										
										
											2013-06-25 20:44:20 -04:00
-												refactor CookedPostProcessor & specs

											
										
										
											2013-07-07 19:39:08 -04:00
+								    let(:post) { build(:post) }
 								    let(:cpp) { CookedPostProcessor.new(post) }
 								    it "returns the filename of the src when there is no upload" do
-												few components with rspec3 syntax

											
										
										
											2015-01-09 11:34:37 -05:00
+								      expect(cpp.get_filename(nil, "http://domain.com/image.png")).to eq("image.png")
-												soften the lightbox overlay

											
										
										
											2013-06-25 20:44:20 -04:00
+								    end
-												refactor CookedPostProcessor & specs

											
										
										
											2013-07-07 19:39:08 -04:00
+								    it "returns the original filename of the upload when there is an upload" do
-												Add rubocop to our build. (#5004)


											
										
										
											2017-07-27 21:20:09 -04:00
+								      upload = build(:upload, original_filename: "upload.jpg")
-												few components with rspec3 syntax

											
										
										
											2015-01-09 11:34:37 -05:00
+								      expect(cpp.get_filename(upload, "http://domain.com/image.png")).to eq("upload.jpg")
-												refactor CookedPostProcessor & specs

											
										
										
											2013-07-07 19:39:08 -04:00
+								    end
-												Initial release of Discourse

											
										
										
											2013-02-05 14:16:51 -05:00
-												refactor CookedPostProcessor & specs

											
										
										
											2013-07-07 19:39:08 -04:00
+								    it "returns a generic name for pasted images" do
-												Add rubocop to our build. (#5004)


											
										
										
											2017-07-27 21:20:09 -04:00
+								      upload = build(:upload, original_filename: "blob.png")
-												few components with rspec3 syntax

											
										
										
											2015-01-09 11:34:37 -05:00
+								      expect(cpp.get_filename(upload, "http://domain.com/image.png")).to eq(I18n.t('upload.pasted_image_filename'))
-												basic lightbox support

											
										
										
											2013-02-19 01:57:14 -05:00
+								    end
-												remove trailing whitespaces :heart:

											
										
										
											2013-02-25 11:42:20 -05:00
-												refactor CookedPostProcessor & specs

											
										
										
											2013-07-07 19:39:08 -04:00
+								  end
-												PERF: Move processing of inline onebox out of V8 context. (#6658)


											
										
										
											2018-11-25 20:21:38 -05:00
+								  context "#post_process_oneboxes" do
-												pull hotlinked images

											
										
										
											2013-11-05 13:04:47 -05:00
+								    let(:post) { build(:post_with_youtube, id: 123) }
 								    let(:cpp) { CookedPostProcessor.new(post, invalidate_oneboxes: true) }
-												removed auto_link_images_wider_than setting

											
										
										
											2013-07-06 13:10:53 -04:00
-												pull hotlinked images

											
										
										
											2013-11-05 13:04:47 -05:00
+								    before do
 								      Oneboxer.expects(:onebox)
-												SECURITY: correct local onebox category checks

Also removes ugly "source_topic_id" from cooked posts

Patch was authored by @zogstrip

Signed-off-by: Sam <sam.saffron@gmail.com>

											
										
										
											2018-02-13 18:39:44 -05:00
+								        .with("http://www.youtube.com/watch?v=9bZkp7q19f0", invalidate_oneboxes: true, user_id: nil, category_id: post.topic.category_id)
-												Add rubocop to our build. (#5004)


											
										
										
											2017-07-27 21:20:09 -04:00
+								        .returns("<div>GANGNAM STYLE</div>")
-												PERF: Move processing of inline onebox out of V8 context. (#6658)


											
										
										
											2018-11-25 20:21:38 -05:00
-												pull hotlinked images

											
										
										
											2013-11-05 13:04:47 -05:00
+								      cpp.post_process_oneboxes
-												Initial release of Discourse

											
										
										
											2013-02-05 14:16:51 -05:00
+								    end
-												SECURITY: correct local onebox category checks

Also removes ugly "source_topic_id" from cooked posts

Patch was authored by @zogstrip

Signed-off-by: Sam <sam.saffron@gmail.com>

											
										
										
											2018-02-13 18:39:44 -05:00
-												UX: generic onebox treats all square images as avatars and renders them smaller

											
										
										
											2017-11-12 19:19:06 -05:00
+								    it "inserts the onebox without wrapping p" do
-												few components with rspec3 syntax

											
										
										
											2015-01-09 11:34:37 -05:00
+								      expect(cpp).to be_dirty
-												UX: generic onebox treats all square images as avatars and renders them smaller

											
										
										
											2017-11-12 19:19:06 -05:00
+								      expect(cpp.html).to match_html "<div>GANGNAM STYLE</div>"
-												pull hotlinked images

											
										
										
											2013-11-05 13:04:47 -05:00
+								    end
-												FIX: Onebox images are not downloaded locally without css class

											
										
										
											2018-07-31 17:21:02 -04:00
 								    it "replaces downloaded onebox image" do
 								      url = 'https://image.com/my-avatar'
 								      image_url = 'https://image.com/avatar.png'
 								      Oneboxer.stubs(:onebox).with(url, anything).returns("<img class='onebox' src='#{image_url}' />")
 								      post = Fabricate(:post, raw: url)
 								      upload = Fabricate(:upload, url: "https://test.s3.amazonaws.com/something.png")
 								      post.custom_fields[Post::DOWNLOADED_IMAGES] = { "//image.com/avatar.png": upload.id }
 								      post.save_custom_fields
 								      cpp = CookedPostProcessor.new(post, invalidate_oneboxes: true)
 								      cpp.post_process_oneboxes
 								      expect(cpp.doc.to_s).to eq("<p><img class=\"onebox\" src=\"#{upload.url}\" width=\"\" height=\"\"></p>")
-												FIX: Use find_by_id method to prevent record not found exception

											
										
										
											2018-12-14 16:49:45 -05:00
-												DEV: Use destroy! method to raise error if any (#0d3c1cde)

											
										
										
											2018-12-17 16:35:43 -05:00
+								      upload.destroy!
-												FIX: Use find_by_id method to prevent record not found exception

											
										
										
											2018-12-14 16:49:45 -05:00
+								      cpp = CookedPostProcessor.new(post, invalidate_oneboxes: true)
 								      cpp.post_process_oneboxes
 								      expect(cpp.doc.to_s).to eq("<p><img class=\"onebox\" src=\"#{image_url}\" width=\"\" height=\"\"></p>")
-												FIX: Onebox images are not downloaded locally without css class

											
										
										
											2018-07-31 17:21:02 -04:00
+								    end
-												FIX: Display large/broken image placeholders for image oneboxes

											
										
										
											2018-10-07 08:10:15 -04:00
 								    it "replaces large image placeholder" do
 								      url = 'https://image.com/my-avatar'
 								      image_url = 'https://image.com/avatar.png'
 								      Oneboxer.stubs(:onebox).with(url, anything).returns("<img class='onebox' src='#{image_url}' />")
 								      post = Fabricate(:post, raw: url)
 								      post.custom_fields[Post::LARGE_IMAGES] = "[\"//image.com/avatar.png\"]"
 								      post.save_custom_fields
 								      cpp = CookedPostProcessor.new(post, invalidate_oneboxes: true)
 								      cpp.post_process_oneboxes
 								      cpp.post_process_images
 								      expect(cpp.doc.to_s).to match(/<div class="large-image-placeholder">/)
 								    end
-												UX: generic onebox treats all square images as avatars and renders them smaller

											
										
										
											2017-11-12 19:19:06 -05:00
+								  end
-												Initial release of Discourse

											
										
										
											2013-02-05 14:16:51 -05:00
-												PERF: Move processing of inline onebox out of V8 context. (#6658)


											
										
										
											2018-11-25 20:21:38 -05:00
+								  context "#post_process_oneboxes removes nofollow if add_rel_nofollow_to_user_content is disabled" do
-												FIX: respect nofollow settings for onebox links

											
										
										
											2018-03-26 06:24:39 -04:00
+								    let(:post) { build(:post_with_youtube, id: 123) }
 								    let(:cpp) { CookedPostProcessor.new(post, invalidate_oneboxes: true) }
 								    before do
 								      SiteSetting.add_rel_nofollow_to_user_content = false
 								      Oneboxer.expects(:onebox)
 								        .with("http://www.youtube.com/watch?v=9bZkp7q19f0", invalidate_oneboxes: true, user_id: nil, category_id: post.topic.category_id)
 								        .returns('<aside class="onebox"><a href="https://www.youtube.com/watch?v=9bZkp7q19f0" rel="nofollow noopener">GANGNAM STYLE</a></aside>')
 								      cpp.post_process_oneboxes
 								    end
 								    it "removes nofollow noopener from links" do
 								      expect(cpp).to be_dirty
 								      expect(cpp.html).to match_html '<aside class="onebox"><a href="https://www.youtube.com/watch?v=9bZkp7q19f0">GANGNAM STYLE</a></aside>'
 								    end
 								  end
-												PERF: Move processing of inline onebox out of V8 context. (#6658)


											
										
										
											2018-11-25 20:21:38 -05:00
+								  context "#post_process_oneboxes with square image" do
-												UX: generic onebox treats all square images as avatars and renders them smaller

											
										
										
											2017-11-12 19:19:06 -05:00
 								    it "generates a onebox-avatar class" do
 								      SiteSetting.crawl_images = true
 								      url = 'https://square-image.com/onebox'
 								      body = <<~HTML
 								      <html>
 								      <head>
 								      <meta property='og:title' content="Page awesome">
 								      <meta property='og:image' content="https://image.com/avatar.png">
 								      <meta property='og:description' content="Page awesome desc">
 								      </head>
 								      </html>
 								      HTML
-												FIX: don't double request when downloading a file

											
										
										
											2018-02-24 06:35:57 -05:00
+								      stub_request(:head, url)
 								      stub_request(:get , url).to_return(body: body)
-												UX: generic onebox treats all square images as avatars and renders them smaller

											
										
										
											2017-11-12 19:19:06 -05:00
+								      FinalDestination.stubs(:lookup_ip).returns('1.2.3.4')
 								      # not an ideal stub but shipping the whole image to fast image can add
 								      # a lot of cost to this test
 								      FastImage.stubs(:size).returns([200, 200])
 								      post = Fabricate.build(:post, raw: url)
 								      cpp = CookedPostProcessor.new(post, invalidate_oneboxes: true)
 								      cpp.post_process_oneboxes
 								      expect(cpp.doc.to_s).not_to include('aspect-image')
 								      expect(cpp.doc.to_s).to include('onebox-avatar')
-												pull hotlinked images

											
										
										
											2013-11-05 13:04:47 -05:00
+								    end
-												removed auto_link_images_wider_than setting

											
										
										
											2013-07-06 13:10:53 -04:00
-												pull hotlinked images

											
										
										
											2013-11-05 13:04:47 -05:00
+								  end
-												Initial release of Discourse

											
										
										
											2013-02-05 14:16:51 -05:00
-												PERF: Move processing of inline onebox out of V8 context. (#6658)


											
										
										
											2018-11-25 20:21:38 -05:00
+								  context "#optimize_urls" do
-												refactor CookedPostProcessor & specs

											
										
										
											2013-07-07 19:39:08 -04:00
-												pull hotlinked images

											
										
										
											2013-11-05 13:04:47 -05:00
+								    let(:post) { build(:post_with_uploads_and_links) }
 								    let(:cpp) { CookedPostProcessor.new(post) }
 								    it "uses schemaless url for uploads" do
 								      cpp.optimize_urls
-												FIX: store the topic links using the cooked upload url

											
										
										
											2018-08-14 06:23:32 -04:00
+								      expect(cpp.html).to match_html <<~HTML
 								        <p><a href="//test.localhost/uploads/default/original/2X/2345678901234567.jpg">Link</a><br>
 								        <img src="//test.localhost/uploads/default/original/1X/1234567890123456.jpg"><br>
-												FIX: don't put attachments on the CDN when 'prevent anons from downloading files' is enabled

											
										
										
											2017-02-07 12:06:44 -05:00
+								        <a href="http://www.google.com" rel="nofollow noopener">Google</a><br>
 								        <img src="http://foo.bar/image.png"><br>
 								        <a class="attachment" href="//test.localhost/uploads/default/original/1X/af2c2618032c679333bebf745e75f9088748d737.txt">text.txt</a> (20 Bytes)<br>
-												uses emoji versions for specs (#6276)


											
										
										
											2018-08-16 07:45:30 -04:00
+								        <img src="//test.localhost/images/emoji/twitter/smile.png?v=#{Emoji::EMOJI_VERSION}" title=":smile:" class="emoji" alt=":smile:"></p>
-												FIX: store the topic links using the cooked upload url

											
										
										
											2018-08-14 06:23:32 -04:00
+								      HTML
-												refactor CookedPostProcessor & specs

											
										
										
											2013-07-07 19:39:08 -04:00
+								    end
-												pull hotlinked images

											
										
										
											2013-11-05 13:04:47 -05:00
+								    context "when CDN is enabled" do
-												FIX: don't put attachments on the CDN when 'prevent anons from downloading files' is enabled

											
										
										
											2017-02-07 12:06:44 -05:00
+								      it "uses schemaless CDN url for http uploads" do
-												pull hotlinked images

											
										
										
											2013-11-05 13:04:47 -05:00
+								        Rails.configuration.action_controller.stubs(:asset_host).returns("http://my.cdn.com")
 								        cpp.optimize_urls
-												FIX: store the topic links using the cooked upload url

											
										
										
											2018-08-14 06:23:32 -04:00
+								        expect(cpp.html).to match_html <<~HTML
 								          <p><a href="//my.cdn.com/uploads/default/original/2X/2345678901234567.jpg">Link</a><br>
 								          <img src="//my.cdn.com/uploads/default/original/1X/1234567890123456.jpg"><br>
-												FIX: don't put attachments on the CDN when 'prevent anons from downloading files' is enabled

											
										
										
											2017-02-07 12:06:44 -05:00
+								          <a href="http://www.google.com" rel="nofollow noopener">Google</a><br>
 								          <img src="http://foo.bar/image.png"><br>
 								          <a class="attachment" href="//my.cdn.com/uploads/default/original/1X/af2c2618032c679333bebf745e75f9088748d737.txt">text.txt</a> (20 Bytes)<br>
-												uses emoji versions for specs (#6276)


											
										
										
											2018-08-16 07:45:30 -04:00
+								          <img src="//my.cdn.com/images/emoji/twitter/smile.png?v=#{Emoji::EMOJI_VERSION}" title=":smile:" class="emoji" alt=":smile:"></p>
-												FIX: store the topic links using the cooked upload url

											
										
										
											2018-08-14 06:23:32 -04:00
+								        HTML
-												pull hotlinked images

											
										
										
											2013-11-05 13:04:47 -05:00
+								      end
-												FIX: don't put attachments on the CDN when 'prevent anons from downloading files' is enabled

											
										
										
											2017-02-07 12:06:44 -05:00
+								      it "doesn't use schemaless CDN url for https uploads" do
-												FIX: properly support HTTPS CDN on HTTP site

Previously we changed all CDN links to schemaless.

This is desirable for non HTTPS sites, to ease migration to HTTPS.
It is not desirable for secure sites.

Once site is secure or CDN is secure a rebake should be required
to move it back to non-secure.

											
										
										
											2015-07-24 00:08:32 -04:00
+								        Rails.configuration.action_controller.stubs(:asset_host).returns("https://my.cdn.com")
 								        cpp.optimize_urls
-												FIX: store the topic links using the cooked upload url

											
										
										
											2018-08-14 06:23:32 -04:00
+								        expect(cpp.html).to match_html <<~HTML
 								          <p><a href="https://my.cdn.com/uploads/default/original/2X/2345678901234567.jpg">Link</a><br>
 								          <img src="https://my.cdn.com/uploads/default/original/1X/1234567890123456.jpg"><br>
-												FIX: don't put attachments on the CDN when 'prevent anons from downloading files' is enabled

											
										
										
											2017-02-07 12:06:44 -05:00
+								          <a href="http://www.google.com" rel="nofollow noopener">Google</a><br>
 								          <img src="http://foo.bar/image.png"><br>
 								          <a class="attachment" href="https://my.cdn.com/uploads/default/original/1X/af2c2618032c679333bebf745e75f9088748d737.txt">text.txt</a> (20 Bytes)<br>
-												uses emoji versions for specs (#6276)


											
										
										
											2018-08-16 07:45:30 -04:00
+								          <img src="https://my.cdn.com/images/emoji/twitter/smile.png?v=#{Emoji::EMOJI_VERSION}" title=":smile:" class="emoji" alt=":smile:"></p>
-												FIX: store the topic links using the cooked upload url

											
										
										
											2018-08-14 06:23:32 -04:00
+								        HTML
-												FIX: don't use the CDN for attachments when login is required

											
										
										
											2016-01-06 15:54:01 -05:00
+								      end
-												FIX: don't put attachments on the CDN when 'prevent anons from downloading files' is enabled

											
										
										
											2017-02-07 12:06:44 -05:00
+								      it "doesn't use CDN when login is required" do
-												FIX: don't use the CDN for attachments when login is required

											
										
										
											2016-01-06 15:54:01 -05:00
+								        SiteSetting.login_required = true
 								        Rails.configuration.action_controller.stubs(:asset_host).returns("http://my.cdn.com")
 								        cpp.optimize_urls
-												FIX: store the topic links using the cooked upload url

											
										
										
											2018-08-14 06:23:32 -04:00
+								        expect(cpp.html).to match_html <<~HTML
 								          <p><a href="//my.cdn.com/uploads/default/original/2X/2345678901234567.jpg">Link</a><br>
 								          <img src="//my.cdn.com/uploads/default/original/1X/1234567890123456.jpg"><br>
-												FIX: don't put attachments on the CDN when 'prevent anons from downloading files' is enabled

											
										
										
											2017-02-07 12:06:44 -05:00
+								          <a href="http://www.google.com" rel="nofollow noopener">Google</a><br>
 								          <img src="http://foo.bar/image.png"><br>
 								          <a class="attachment" href="//test.localhost/uploads/default/original/1X/af2c2618032c679333bebf745e75f9088748d737.txt">text.txt</a> (20 Bytes)<br>
-												uses emoji versions for specs (#6276)


											
										
										
											2018-08-16 07:45:30 -04:00
+								          <img src="//my.cdn.com/images/emoji/twitter/smile.png?v=#{Emoji::EMOJI_VERSION}" title=":smile:" class="emoji" alt=":smile:"></p>
-												FIX: store the topic links using the cooked upload url

											
										
										
											2018-08-14 06:23:32 -04:00
+								        HTML
-												FIX: don't put attachments on the CDN when 'prevent anons from downloading files' is enabled

											
										
										
											2017-02-07 12:06:44 -05:00
+								      end
 								      it "doesn't use CDN when preventing anons from downloading files" do
 								        SiteSetting.prevent_anons_from_downloading_files = true
 								        Rails.configuration.action_controller.stubs(:asset_host).returns("http://my.cdn.com")
 								        cpp.optimize_urls
-												FIX: store the topic links using the cooked upload url

											
										
										
											2018-08-14 06:23:32 -04:00
+								        expect(cpp.html).to match_html <<~HTML
 								          <p><a href="//my.cdn.com/uploads/default/original/2X/2345678901234567.jpg">Link</a><br>
 								          <img src="//my.cdn.com/uploads/default/original/1X/1234567890123456.jpg"><br>
-												FIX: don't put attachments on the CDN when 'prevent anons from downloading files' is enabled

											
										
										
											2017-02-07 12:06:44 -05:00
+								          <a href="http://www.google.com" rel="nofollow noopener">Google</a><br>
 								          <img src="http://foo.bar/image.png"><br>
 								          <a class="attachment" href="//test.localhost/uploads/default/original/1X/af2c2618032c679333bebf745e75f9088748d737.txt">text.txt</a> (20 Bytes)<br>
-												uses emoji versions for specs (#6276)


											
										
										
											2018-08-16 07:45:30 -04:00
+								          <img src="//my.cdn.com/images/emoji/twitter/smile.png?v=#{Emoji::EMOJI_VERSION}" title=":smile:" class="emoji" alt=":smile:"></p>
-												FIX: store the topic links using the cooked upload url

											
										
										
											2018-08-14 06:23:32 -04:00
+								        HTML
-												FIX: properly support HTTPS CDN on HTTP site

Previously we changed all CDN links to schemaless.

This is desirable for non HTTPS sites, to ease migration to HTTPS.
It is not desirable for secure sites.

Once site is secure or CDN is secure a rebake should be required
to move it back to non-secure.

											
										
										
											2015-07-24 00:08:32 -04:00
+								      end
-												Initial release of Discourse

											
										
										
											2013-02-05 14:16:51 -05:00
+								    end
-												removed auto_link_images_wider_than setting

											
										
										
											2013-07-06 13:10:53 -04:00
-												Initial release of Discourse

											
										
										
											2013-02-05 14:16:51 -05:00
+								  end
-												PERF: Move processing of inline onebox out of V8 context. (#6658)


											
										
										
											2018-11-25 20:21:38 -05:00
+								  context "#pull_hotlinked_images" do
-												FIX: lightbox wasn't working when using s3 upload

											
										
										
											2013-06-22 07:38:42 -04:00
-												FEATURE: new site setting download_remote_images_max_days_old

											
										
										
											2016-07-06 09:51:48 -04:00
+								    let(:post) { build(:post, created_at: 20.days.ago) }
-												refactor CookedPostProcessor & specs

											
										
										
											2013-07-07 19:39:08 -04:00
+								    let(:cpp) { CookedPostProcessor.new(post) }
-												add disk space usage failsafe

											
										
										
											2013-11-15 10:46:41 -05:00
+								    before { cpp.stubs(:available_disk_space).returns(90) }
-												add download_remote_images_to_local site setting

											
										
										
											2013-11-15 09:22:18 -05:00
+								    it "does not run when download_remote_images_to_local is disabled" do
-												Nuke all `SiteSetting.stubs` from our codebase.

											
										
										
											2017-07-07 02:09:14 -04:00
+								      SiteSetting.download_remote_images_to_local = false
-												pull hotlinked images

											
										
										
											2013-11-05 13:04:47 -05:00
+								      Jobs.expects(:cancel_scheduled_job).never
 								      cpp.pull_hotlinked_images
-												cleaned up CookedPostProcessor and improved specs

											
										
										
											2013-06-15 06:29:20 -04:00
+								    end
-												add download_remote_images_to_local site setting

											
										
										
											2013-11-15 09:22:18 -05:00
+								    context "when download_remote_images_to_local? is enabled" do
-												Nuke all `SiteSetting.stubs` from our codebase.

											
										
										
											2017-07-07 02:09:14 -04:00
+								      before do
 								        SiteSetting.download_remote_images_to_local = true
 								      end
-												pull hotlinked images

											
										
										
											2013-11-05 13:04:47 -05:00
-												FEATURE: warn the admin whenever we disable the download_remote_images_to_local site setting

											
										
										
											2014-04-23 06:43:10 -04:00
+								      it "does not run when there is not enough disk space" do
 								        cpp.expects(:disable_if_low_on_disk_space).returns(true)
-												pull hotlinked images

											
										
										
											2013-11-05 13:04:47 -05:00
+								        Jobs.expects(:cancel_scheduled_job).never
 								        cpp.pull_hotlinked_images
 								      end
-												FEATURE: warn the admin whenever we disable the download_remote_images_to_local site setting

											
										
										
											2014-04-23 06:43:10 -04:00
+								      context "and there is enough disk space" do
-												add disk space usage failsafe

											
										
										
											2013-11-15 10:46:41 -05:00
-												FEATURE: warn the admin whenever we disable the download_remote_images_to_local site setting

											
										
										
											2014-04-23 06:43:10 -04:00
+								        before { cpp.expects(:disable_if_low_on_disk_space).returns(false) }
-												pull hotlinked images

											
										
										
											2013-11-05 13:04:47 -05:00
-												FEATURE: warn the admin whenever we disable the download_remote_images_to_local site setting

											
										
										
											2014-04-23 06:43:10 -04:00
+								        it "does not run when the system user updated the post" do
 								          post.last_editor_id = Discourse.system_user.id
 								          Jobs.expects(:cancel_scheduled_job).never
 								          cpp.pull_hotlinked_images
 								        end
-												pull hotlinked images

											
										
										
											2013-11-05 13:04:47 -05:00
-												FEATURE: warn the admin whenever we disable the download_remote_images_to_local site setting

											
										
										
											2014-04-23 06:43:10 -04:00
+								        context "and the post has been updated by an actual user" do
-												pull hotlinked images

											
										
										
											2013-11-05 13:04:47 -05:00
-												FEATURE: warn the admin whenever we disable the download_remote_images_to_local site setting

											
										
										
											2014-04-23 06:43:10 -04:00
+								          before { post.id = 42 }
-												Rename `ninja_edit_window` to `editing_grace_period` :'(

											
										
										
											2015-11-24 14:28:42 -05:00
+								          it "ensures only one job is scheduled right after the editing_grace_period" do
-												FEATURE: warn the admin whenever we disable the download_remote_images_to_local site setting

											
										
										
											2014-04-23 06:43:10 -04:00
+								            Jobs.expects(:cancel_scheduled_job).with(:pull_hotlinked_images, post_id: post.id).once
-												Rename `ninja_edit_window` to `editing_grace_period` :'(

											
										
										
											2015-11-24 14:28:42 -05:00
+								            delay = SiteSetting.editing_grace_period + 1
-												FEATURE: warn the admin whenever we disable the download_remote_images_to_local site setting

											
										
										
											2014-04-23 06:43:10 -04:00
+								            Jobs.expects(:enqueue_in).with(delay.seconds, :pull_hotlinked_images, post_id: post.id, bypass_bump: false).once
 								            cpp.pull_hotlinked_images
 								          end
-												pull hotlinked images

											
										
										
											2013-11-05 13:04:47 -05:00
 								        end
 								      end
-												forgot to commit the test

											
										
										
											2013-06-24 16:56:03 -04:00
+								    end
-												cleaned up CookedPostProcessor and improved specs

											
										
										
											2013-06-15 06:29:20 -04:00
+								  end
-												PERF: Move processing of inline onebox out of V8 context. (#6658)


											
										
										
											2018-11-25 20:21:38 -05:00
+								  context "#disable_if_low_on_disk_space" do
-												add disk space usage failsafe

											
										
										
											2013-11-15 10:46:41 -05:00
-												FEATURE: new site setting download_remote_images_max_days_old

											
										
										
											2016-07-06 09:51:48 -04:00
+								    let(:post) { build(:post, created_at: 20.days.ago) }
-												add disk space usage failsafe

											
										
										
											2013-11-15 10:46:41 -05:00
+								    let(:cpp) { CookedPostProcessor.new(post) }
 								    before { cpp.expects(:available_disk_space).returns(50) }
 								    it "does nothing when there's enough disk space" do
 								      SiteSetting.expects(:download_remote_images_threshold).returns(20)
 								      SiteSetting.expects(:download_remote_images_to_local).never
-												few components with rspec3 syntax

											
										
										
											2015-01-09 11:34:37 -05:00
+								      expect(cpp.disable_if_low_on_disk_space).to eq(false)
-												add disk space usage failsafe

											
										
										
											2013-11-15 10:46:41 -05:00
+								    end
-												FEATURE: warn the admin whenever we disable the download_remote_images_to_local site setting

											
										
										
											2014-04-23 06:43:10 -04:00
+								    context "when there's not enough disk space" do
 								      before { SiteSetting.expects(:download_remote_images_threshold).returns(75) }
 								      it "disables download_remote_images_threshold and send a notification to the admin" do
-												FIX: log a staff action + send a private message when disabling the 'download_remote_images_to_local' site setting

											
										
										
											2014-09-23 13:11:14 -04:00
+								        StaffActionLogger.any_instance.expects(:log_site_setting_change).once
 								        SystemMessage.expects(:create_from_system_user).with(Discourse.site_contact_user, :download_remote_images_disabled).once
-												few components with rspec3 syntax

											
										
										
											2015-01-09 11:34:37 -05:00
+								        expect(cpp.disable_if_low_on_disk_space).to eq(true)
 								        expect(SiteSetting.download_remote_images_to_local).to eq(false)
-												FEATURE: warn the admin whenever we disable the download_remote_images_to_local site setting

											
										
										
											2014-04-23 06:43:10 -04:00
+								      end
-												add disk space usage failsafe

											
										
										
											2013-11-15 10:46:41 -05:00
+								    end
 								  end
-												PERF: Move processing of inline onebox out of V8 context. (#6658)


											
										
										
											2018-11-25 20:21:38 -05:00
+								  context "#download_remote_images_max_days_old" do
-												FEATURE: new site setting download_remote_images_max_days_old

											
										
										
											2016-07-06 09:51:48 -04:00
 								    let(:post) { build(:post, created_at: 20.days.ago) }
 								    let(:cpp) { CookedPostProcessor.new(post) }
 								    before do
 								      SiteSetting.download_remote_images_to_local = true
 								      cpp.expects(:disable_if_low_on_disk_space).returns(false)
 								    end
 								    it "does not run when download_remote_images_max_days_old is not satisfied" do
 								      SiteSetting.download_remote_images_max_days_old = 15
 								      Jobs.expects(:cancel_scheduled_job).never
 								      cpp.pull_hotlinked_images
 								    end
 								    it "runs when download_remote_images_max_days_old is satisfied" do
 								      SiteSetting.download_remote_images_max_days_old = 30
 								      Jobs.expects(:cancel_scheduled_job).with(:pull_hotlinked_images, post_id: post.id).once
 								      delay = SiteSetting.editing_grace_period + 1
 								      Jobs.expects(:enqueue_in).with(delay.seconds, :pull_hotlinked_images, post_id: post.id, bypass_bump: false).once
 								      cpp.pull_hotlinked_images
 								    end
 								  end
-												PERF: Move processing of inline onebox out of V8 context. (#6658)


											
										
										
											2018-11-25 20:21:38 -05:00
+								  context "#is_a_hyperlink?" do
-												FIX markdown hotlinked images were not properly pulled

											
										
										
											2013-11-20 07:10:08 -05:00
 								    let(:post) { build(:post) }
 								    let(:cpp) { CookedPostProcessor.new(post) }
 								    let(:doc) { Nokogiri::HTML::fragment('<body><div><a><img id="linked_image"></a><p><img id="standard_image"></p></div></body>') }
 								    it "is true when the image is inside a link" do
 								      img = doc.css("img#linked_image").first
-												few components with rspec3 syntax

											
										
										
											2015-01-09 11:34:37 -05:00
+								      expect(cpp.is_a_hyperlink?(img)).to eq(true)
-												FIX markdown hotlinked images were not properly pulled

											
										
										
											2013-11-20 07:10:08 -05:00
+								    end
 								    it "is false when the image is not inside a link" do
 								      img = doc.css("img#standard_image").first
-												few components with rspec3 syntax

											
										
										
											2015-01-09 11:34:37 -05:00
+								      expect(cpp.is_a_hyperlink?(img)).to eq(false)
-												FIX markdown hotlinked images were not properly pulled

											
										
										
											2013-11-20 07:10:08 -05:00
+								    end
 								  end
-												Remove `UserFirst` table and grant Emoji badge directly

											
										
										
											2016-04-07 12:27:26 -04:00
+								  context "grant badges" do
-												FIX: FirstReplyByEmail badge wasn't granted

DEPRECATED: PostProcess badge trigger

											
										
										
											2016-08-10 13:24:01 -04:00
+								    let(:cpp) { CookedPostProcessor.new(post) }
-												FEATURE: New "First Onebox" badge

											
										
										
											2016-04-12 14:09:59 -04:00
-												Remove `UserFirst` table and grant Emoji badge directly

											
										
										
											2016-04-07 12:27:26 -04:00
+								    context "emoji inside a quote" do
-												Feature: Change markdown engine to markdown it

This commit removes the old evilstreak markdownjs engine.

- Adds specs to WhiteLister and changes it to stop using globals
    (Fixes large memory leak)
- Fixes edge cases around bbcode handling
- Removes mdtest which is no longer valid (to be replaced with
    CommonMark)
- Updates MiniRacer to correct minor unmanaged memory leak
- Fixes plugin specs

											
										
										
											2017-07-14 08:27:28 -04:00
+								      let(:post) { Fabricate(:post, raw: "time to eat some sweet \n[quote]\n:candy:\n[/quote]\n mmmm") }
-												Remove `UserFirst` table and grant Emoji badge directly

											
										
										
											2016-04-07 12:27:26 -04:00
 								      it "doesn't award a badge when the emoji is in a quote" do
 								        cpp.grant_badges
 								        expect(post.user.user_badges.where(badge_id: Badge::FirstEmoji).exists?).to eq(false)
 								      end
 								    end
 								    context "emoji in the text" do
 								      let(:post) { Fabricate(:post, raw: "time to eat some sweet :candy: mmmm") }
 								      it "awards a badge for using an emoji" do
 								        cpp.grant_badges
 								        expect(post.user.user_badges.where(badge_id: Badge::FirstEmoji).exists?).to eq(true)
 								      end
 								    end
-												FEATURE: New "First Onebox" badge

											
										
										
											2016-04-12 14:09:59 -04:00
 								    context "onebox" do
-												FIX: FirstReplyByEmail badge wasn't granted

DEPRECATED: PostProcess badge trigger

											
										
										
											2016-08-10 13:24:01 -04:00
+								      let(:post) { Fabricate(:post, raw: "onebox me:\n\nhttps://www.youtube.com/watch?v=Wji-BZ0oCwg\n") }
-												FEATURE: New "First Onebox" badge

											
										
										
											2016-04-12 14:09:59 -04:00
-												FIX: FirstReplyByEmail badge wasn't granted

DEPRECATED: PostProcess badge trigger

											
										
										
											2016-08-10 13:24:01 -04:00
+								      before { Oneboxer.stubs(:onebox) }
-												FEATURE: New "First Onebox" badge

											
										
										
											2016-04-12 14:09:59 -04:00
-												FIX: Don't ever grant badges when they're disabled

											
										
										
											2016-08-19 15:16:37 -04:00
+								      it "awards a badge for using an onebox" do
-												FEATURE: New "First Onebox" badge

											
										
										
											2016-04-12 14:09:59 -04:00
+								        cpp.post_process_oneboxes
 								        cpp.grant_badges
 								        expect(post.user.user_badges.where(badge_id: Badge::FirstOnebox).exists?).to eq(true)
 								      end
-												FIX: Don't ever grant badges when they're disabled

											
										
										
											2016-08-19 15:16:37 -04:00
 								      it "doesn't award the badge when the badge is disabled" do
 								        Badge.where(id: Badge::FirstOnebox).update_all(enabled: false)
 								        cpp.post_process_oneboxes
 								        cpp.grant_badges
 								        expect(post.user.user_badges.where(badge_id: Badge::FirstOnebox).exists?).to eq(false)
 								      end
-												FEATURE: New "First Onebox" badge

											
										
										
											2016-04-12 14:09:59 -04:00
+								    end
-												FIX: FirstReplyByEmail badge wasn't granted

DEPRECATED: PostProcess badge trigger

											
										
										
											2016-08-10 13:24:01 -04:00
+								    context "reply_by_email" do
 								      let(:post) { Fabricate(:post, raw: "This is a **reply** via email ;)", via_email: true, post_number: 2) }
 								      it "awards a badge for replying via email" do
 								        cpp.grant_badges
 								        expect(post.user.user_badges.where(badge_id: Badge::FirstReplyByEmail).exists?).to eq(true)
 								      end
 								    end
-												Remove `UserFirst` table and grant Emoji badge directly

											
										
										
											2016-04-07 12:27:26 -04:00
+								  end
-												FEATURE: Add `quote-modified` class if a quote has been modified

											
										
										
											2018-03-13 13:07:51 -04:00
+								  context "quote processing" do
 								    let(:cpp) { CookedPostProcessor.new(cp) }
 								    let(:pp) { Fabricate(:post, raw: "This post is ripe for quoting!") }
 								    context "with an unmodified quote" do
 								      let(:cp) do
 								        Fabricate(
 								          :post,
 								          raw: "[quote=\"#{pp.user.username}, post: #{pp.post_number}, topic:#{pp.topic_id}]\nripe for quoting\n[/quote]\ntest"
 								        )
 								      end
 								      it "should not be marked as modified" do
 								        cpp.post_process_quotes
 								        expect(cpp.doc.css('aside.quote.quote-modified')).to be_blank
 								      end
 								    end
 								    context "with a modified quote" do
 								      let(:cp) do
 								        Fabricate(
 								          :post,
 								          raw: "[quote=\"#{pp.user.username}, post: #{pp.post_number}, topic:#{pp.topic_id}]\nmodified\n[/quote]\ntest"
 								        )
 								      end
 								      it "should be marked as modified" do
 								        cpp.post_process_quotes
 								        expect(cpp.doc.css('aside.quote.quote-modified')).to be_present
 								      end
 								    end
 								  end
-												FEATURE: Remove full quotes of direct replies. (#6729)


											
										
										
											2018-12-07 07:07:11 -05:00
+								  context "remove direct reply full quote" do
 								    let(:topic) { Fabricate(:topic) }
-												* FEATURE: Adds site setting to let quotes on direct replies.

* DEV: Added test.
* FIX: Do not bump topic when removing full quotes.

											
										
										
											2018-12-12 09:42:53 -05:00
+								    let!(:post) { Fabricate(:post, topic: topic, raw: "this is the first post") }
-												FEATURE: Remove full quote only if first paragraph. (#6793)


											
										
										
											2018-12-18 09:46:20 -05:00
-												* FEATURE: Adds site setting to let quotes on direct replies.

* DEV: Added test.
* FIX: Do not bump topic when removing full quotes.

											
										
										
											2018-12-12 09:42:53 -05:00
+								    let(:raw) do
-												FEATURE: Remove full quotes only from new posts. (#6862)


											
										
										
											2019-01-16 21:24:32 -05:00
+								      <<~RAW.strip
-												* FEATURE: Adds site setting to let quotes on direct replies.

* DEV: Added test.
* FIX: Do not bump topic when removing full quotes.

											
										
										
											2018-12-12 09:42:53 -05:00
+								      [quote="#{post.user.username}, post:#{post.post_number}, topic:#{topic.id}"]
 								      this is the first post
 								      [/quote]
 								      and this is the third reply
 								      RAW
 								    end
-												FEATURE: Remove full quotes of direct replies. (#6729)


											
										
										
											2018-12-07 07:07:11 -05:00
-												FEATURE: Remove full quote only if first paragraph. (#6793)


											
										
										
											2018-12-18 09:46:20 -05:00
+								    let(:raw2) do
-												FEATURE: Remove full quotes only from new posts. (#6862)


											
										
										
											2019-01-16 21:24:32 -05:00
+								      <<~RAW.strip
-												FEATURE: Remove full quote only if first paragraph. (#6793)


											
										
										
											2018-12-18 09:46:20 -05:00
+								      and this is the third reply
 								      [quote="#{post.user.username}, post:#{post.post_number}, topic:#{topic.id}"]
 								      this is the first post
 								      [/quote]
 								      RAW
 								    end
-												FEATURE: Remove full quotes only from new posts. (#6862)


											
										
										
											2019-01-16 21:24:32 -05:00
+								    before do
-												* FEATURE: Adds site setting to let quotes on direct replies.

* DEV: Added test.
* FIX: Do not bump topic when removing full quotes.

											
										
										
											2018-12-12 09:42:53 -05:00
+								      SiteSetting.remove_full_quote = true
-												FEATURE: Remove full quotes only from new posts. (#6862)


											
										
										
											2019-01-16 21:24:32 -05:00
+								    end
-												FEATURE: Remove full quotes of direct replies. (#6729)


											
										
										
											2018-12-07 07:07:11 -05:00
-												FEATURE: Remove full quotes only from new posts. (#6862)


											
										
										
											2019-01-16 21:24:32 -05:00
+								    it 'works' do
-												* FEATURE: Adds site setting to let quotes on direct replies.

* DEV: Added test.
* FIX: Do not bump topic when removing full quotes.

											
										
										
											2018-12-12 09:42:53 -05:00
+								      hidden = Fabricate(:post, topic: topic, hidden: true, raw: "this is the second post after")
 								      small_action = Fabricate(:post, topic: topic, post_type: Post.types[:small_action])
-												FEATURE: Remove full quotes of direct replies. (#6729)


											
										
										
											2018-12-07 07:07:11 -05:00
+								      reply = Fabricate(:post, topic: topic, raw: raw)
-												* FEATURE: Adds site setting to let quotes on direct replies.

* DEV: Added test.
* FIX: Do not bump topic when removing full quotes.

											
										
										
											2018-12-12 09:42:53 -05:00
+								      freeze_time Time.zone.now do
 								        topic.bumped_at = 1.day.ago
 								        CookedPostProcessor.new(reply).removed_direct_reply_full_quotes
 								        expect(topic.posts).to eq([post, hidden, small_action, reply])
 								        expect(topic.bumped_at).to eq(1.day.ago)
 								        expect(reply.raw).to eq("and this is the third reply")
 								        expect(reply.revisions.count).to eq(1)
 								        expect(reply.revisions.first.modifications["raw"]).to eq([raw, reply.raw])
 								        expect(reply.revisions.first.modifications["edit_reason"][1]).to eq(I18n.t(:removed_direct_reply_full_quotes))
 								      end
 								    end
-												FEATURE: Remove full quote only if first paragraph. (#6793)


											
										
										
											2018-12-18 09:46:20 -05:00
+								    it 'does not delete quote if not first paragraph' do
 								      reply = Fabricate(:post, topic: topic, raw: raw2)
 								      CookedPostProcessor.new(reply).removed_direct_reply_full_quotes
 								      expect(topic.posts).to eq([post, reply])
 								      expect(reply.raw).to eq(raw2)
 								    end
-												* FEATURE: Adds site setting to let quotes on direct replies.

* DEV: Added test.
* FIX: Do not bump topic when removing full quotes.

											
										
										
											2018-12-12 09:42:53 -05:00
+								    it "does nothing when 'remove_full_quote' is disabled" do
 								      SiteSetting.remove_full_quote = false
 								      reply = Fabricate(:post, topic: topic, raw: raw)
-												FEATURE: Remove full quotes of direct replies. (#6729)


											
										
										
											2018-12-07 07:07:11 -05:00
-												* FEATURE: Adds site setting to let quotes on direct replies.

* DEV: Added test.
* FIX: Do not bump topic when removing full quotes.

											
										
										
											2018-12-12 09:42:53 -05:00
+								      CookedPostProcessor.new(reply).removed_direct_reply_full_quotes
 								      expect(reply.raw).to eq(raw)
-												FEATURE: Remove full quotes of direct replies. (#6729)


											
										
										
											2018-12-07 07:07:11 -05:00
+								    end
-												FEATURE: Remove full quotes only from new posts. (#6862)


											
										
										
											2019-01-16 21:24:32 -05:00
+								    it "works only on new posts" do
-												DEV: Remove Job stub.

											
										
										
											2019-01-18 10:27:35 -05:00
+								      SiteSetting.queue_jobs = false
-												FEATURE: Remove full quotes only from new posts. (#6862)


											
										
										
											2019-01-16 21:24:32 -05:00
+								      hidden = Fabricate(:post, topic: topic, hidden: true, raw: "this is the second post after")
 								      small_action = Fabricate(:post, topic: topic, post_type: Post.types[:small_action])
 								      reply = PostCreator.create!(topic.user, topic_id: topic.id, raw: raw)
 								      CookedPostProcessor.new(reply).post_process
 								      expect(reply.raw).to eq(raw)
 								      PostRevisor.new(reply).revise!(Discourse.system_user, raw: raw, edit_reason: "put back full quote")
 								      CookedPostProcessor.new(reply).post_process(new_post: true)
 								      expect(reply.raw).to eq("and this is the third reply")
 								    end
-												FEATURE: Remove full quotes of direct replies. (#6729)


											
										
										
											2018-12-07 07:07:11 -05:00
+								  end
-												Initial release of Discourse

											
										
										
											2013-02-05 14:16:51 -05:00
+								end