discourse/app/jobs/onceoff/fix_invalid_gravatar_upload...

# frozen_string_literal: true

module Jobs
  class FixInvalidGravatarUploads < ::Jobs::Onceoff
    def execute_onceoff(args)
      Upload.where(original_filename: "gravatar.png").find_each do |upload|
        # note, this still feels pretty expensive for a once off
        # we may need to re-evaluate this
        extension = FastImage.type(Discourse.store.path_for(upload))
        current_extension = upload.extension

        if extension.to_s.downcase != current_extension.to_s.downcase
          upload&.user&.user_avatar&.update_columns(last_gravatar_download_attempt: nil)
        end
      end
    end
  end
end
DEV: enable frozen string literal on all files This reduces chances of errors where consumers of strings mutate inputs and reduces memory usage of the app. Test suite passes now, but there may be some stuff left, so we will run a few sites on a branch prior to merging 2019-05-02 18:17:27 -04:00			`# frozen_string_literal: true`

FIX: Add onceoff job to fix incorrect extension for gravatar uploads. 2018-07-30 02:43:44 -04:00			`module Jobs`
DEV: Upgrading Discourse to Zeitwerk (#8098) Zeitwerk simplifies working with dependencies in dev and makes it easier reloading class chains. We no longer need to use Rails "require_dependency" anywhere and instead can just use standard Ruby patterns to require files. This is a far reaching change and we expect some followups here. 2019-10-02 00:01:53 -04:00			`class FixInvalidGravatarUploads < ::Jobs::Onceoff`
Fix the build. 2018-07-30 03:07:03 -04:00			`def execute_onceoff(args)`
FIX: Add onceoff job to fix incorrect extension for gravatar uploads. 2018-07-30 02:43:44 -04:00			`Upload.where(original_filename: "gravatar.png").find_each do \|upload\|`
FIX: reduce amount of work onceoff does In the past onceoff was forcing inline download of gravatars, this can be so expensive that it will never finish This fix ensures it only marks avatars stale which will be picked up by regular schedules 2018-10-15 19:29:16 -04:00			`# note, this still feels pretty expensive for a once off`
			`# we may need to re-evaluate this`
FIX: Add onceoff job to fix incorrect extension for gravatar uploads. 2018-07-30 02:43:44 -04:00			`extension = FastImage.type(Discourse.store.path_for(upload))`
			`current_extension = upload.extension`

			`if extension.to_s.downcase != current_extension.to_s.downcase`
FIX: reduce amount of work onceoff does In the past onceoff was forcing inline download of gravatars, this can be so expensive that it will never finish This fix ensures it only marks avatars stale which will be picked up by regular schedules 2018-10-15 19:29:16 -04:00			`upload&.user&.user_avatar&.update_columns(last_gravatar_download_attempt: nil)`
FIX: Add onceoff job to fix incorrect extension for gravatar uploads. 2018-07-30 02:43:44 -04:00			`end`
			`end`
			`end`
			`end`
			`end`