discourse/lib/validators/max_username_length_validat...

# frozen_string_literal: true

class MaxUsernameLengthValidator
  def initialize(opts = {})
    @opts = opts
  end

  def valid_value?(value)
    return false if value < SiteSetting.min_username_length
    @username = User.where('length(username) > ?', value).pluck_first(:username)
    @username.blank?
  end

  def error_message
    if @username.blank?
      I18n.t("site_settings.errors.max_username_length_range")
    else
      I18n.t("site_settings.errors.max_username_length_exists", username: @username)
    end
  end
end
DEV: enable frozen string literal on all files This reduces chances of errors where consumers of strings mutate inputs and reduces memory usage of the app. Test suite passes now, but there may be some stuff left, so we will run a few sites on a branch prior to merging 2019-05-02 18:17:27 -04:00			`# frozen_string_literal: true`

UX: Improve error messages for minimum and maximum username lengths. 2018-08-22 15:49:52 -04:00			`class MaxUsernameLengthValidator`
			`def initialize(opts = {})`
			`@opts = opts`
			`end`

			`def valid_value?(value)`
			`return false if value < SiteSetting.min_username_length`
DEV: pluck_first Doing .pluck(:column).first is a very common pattern in Discourse and in most cases, a limit cause isn't being added. Instead of adding a limit clause to all these callsites, this commit adds two new methods to ActiveRecord::Relation: pluck_first, equivalent to limit(1).pluck(*columns).first and pluck_first! which, like other finder methods, raises an exception when no record is found 2019-10-21 06:32:27 -04:00			`@username = User.where('length(username) > ?', value).pluck_first(:username)`
Remove unecessary code. 2018-10-02 03:20:19 -04:00			`@username.blank?`
UX: Improve error messages for minimum and maximum username lengths. 2018-08-22 15:49:52 -04:00			`end`

			`def error_message`
			`if @username.blank?`
			`I18n.t("site_settings.errors.max_username_length_range")`
			`else`
			`I18n.t("site_settings.errors.max_username_length_exists", username: @username)`
			`end`
			`end`
			`end`