Discource-C
/
discourse
mirror of https://github.com/discourse/discourse.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity
discourse/app/assets/javascripts/select-kit/addon/templates/components/email-group-user-chooser-he...

Ignoring revisions in .git-blame-ignore-revs. Click here to bypass and see the normal blame view.

24 lines
609 B
Handlebars
Raw Normal View History

DEV: {{user-selector}} replacement (#11726) This PR is the first step towards replacing our `{{user-selector}}` and eventually deprecating and removing it from our codebase. Some of `{{user-selector}}` problems are: 1. It's called `{{user-selector}}`, but in reality in can also select groups and emails. 2. It's an Ember component, yet it doesn't have a handlebars template and uses jQuery to render itself and modify the DOM. An example of this problem is when you want to clear the selected users programmatically, see [this](https://github.com/discourse/discourse/blob/6c155dba775441ccef9ac21c770102857978286d/app/assets/javascripts/discourse/app/components/user-selector.js#L179-L185). 3. We now have select kit which does very similar things but a lot better. This PR introduces `{{email-group-user-chooser}}` which is meant to replace `{{user-selector}}`. It extends select kit and has the same features that `{{user-selector}}` has. `{{user-selector}}` is still used in a few places in core, but they'll all be replaced with the new component in a separate commit. Once `{{user-selector}}` is not used anywhere in core, it'll be deprecated and then removed after the 2.7 release.
2021-02-01 05:07:11 -05:00
<div class="choices">
{{#each shownItems as |item|}}
{{component selectKit.options.selectedNameComponent
tabindex=tabindex
item=item
selectKit=selectKit
}}
{{/each}}
{{#if hasHiddenItems}}
<div class="x-more-item" data-hidden-count={{hiddenItemsCount}}>
{{i18n "x_more" count=hiddenItemsCount}}
</div>
{{/if}}
{{#unless hasReachedMaximumSelection}}
<div class="choice input-wrapper">
{{component selectKit.options.filterComponent
selectKit=selectKit
A11Y: makes aria-owns an ID and not a data attribute (#12075)
2021-02-15 06:32:09 -05:00
id=(concat selectKit.uniqueID "-filter")
DEV: {{user-selector}} replacement (#11726) This PR is the first step towards replacing our `{{user-selector}}` and eventually deprecating and removing it from our codebase. Some of `{{user-selector}}` problems are: 1. It's called `{{user-selector}}`, but in reality in can also select groups and emails. 2. It's an Ember component, yet it doesn't have a handlebars template and uses jQuery to render itself and modify the DOM. An example of this problem is when you want to clear the selected users programmatically, see [this](https://github.com/discourse/discourse/blob/6c155dba775441ccef9ac21c770102857978286d/app/assets/javascripts/discourse/app/components/user-selector.js#L179-L185). 3. We now have select kit which does very similar things but a lot better. This PR introduces `{{email-group-user-chooser}}` which is meant to replace `{{user-selector}}`. It extends select kit and has the same features that `{{user-selector}}` has. `{{user-selector}}` is still used in a few places in core, but they'll all be replaced with the new component in a separate commit. Once `{{user-selector}}` is not used anywhere in core, it'll be deprecated and then removed after the 2.7 release.
2021-02-01 05:07:11 -05:00
}}
</div>
{{/unless}}
</div>