discourse/lib/freedom_patches/safe_migrations.rb

# frozen_string_literal: true

require_dependency 'migration/safe_migrate'

# We do not run this in production cause it is intrusive and has
# potential to break stuff, it also breaks under concurrent use
# which rake:multisite_migrate uses
#
# The protection is only needed in Dev and Test
if ENV['RAILS_ENV'] != "production"
  Migration::SafeMigrate.patch_active_record!
end
DEV: enable frozen string literal on all files This reduces chances of errors where consumers of strings mutate inputs and reduces memory usage of the app. Test suite passes now, but there may be some stuff left, so we will run a few sites on a branch prior to merging 2019-05-03 08:17:27 +10:00			`# frozen_string_literal: true`

FEATURE: protect against accidental column or table drops Often we need to amend our schema, it is tempting to use drop_table, rename_column and drop_column to amned schema trouble though is that existing code that is running in production can depend on the existance of previous schema leading to application breaking until new code base is deployed. The commit enforces new rules to ensure we can never drop tables or columns in migrations and instead use Migration::ColumnDropper and Migration::TableDropper to defer drop the db objects 2018-03-20 18:20:50 +11:00			`require_dependency 'migration/safe_migrate'`

DEV: only enable SafeMigrate in development and test SafeMigrate outputs text when we detect attempts to unsafely drop tables and columns It is unfortunately not thread safe This is not needed in production as we would have already caught it by then in our test suite. 2020-04-09 13:41:03 +10:00			`# We do not run this in production cause it is intrusive and has`
			`# potential to break stuff, it also breaks under concurrent use`
			`# which rake:multisite_migrate uses`
			`#`
			`# The protection is only needed in Dev and Test`
			`if ENV['RAILS_ENV'] != "production"`
			`Migration::SafeMigrate.patch_active_record!`
			`end`