discourse/spec/models/topic_embed_spec.rb

require 'rails_helper'
require 'stringio'

describe TopicEmbed do

  it { is_expected.to belong_to :topic }
  it { is_expected.to belong_to :post }
  it { is_expected.to validate_presence_of :embed_url }

  context '.import' do

    let(:user) { Fabricate(:user) }
    let(:title) { "How to turn a fish from good to evil in 30 seconds" }
    let(:url) { 'http://eviltrout.com/123' }
    let(:contents) { "hello world new post <a href='/hello'>hello</a> <img src='/images/wat.jpg'>" }
    let!(:embeddable_host) { Fabricate(:embeddable_host) }

    it "returns nil when the URL is malformed" do
      expect(TopicEmbed.import(user, "invalid url", title, contents)).to eq(nil)
      expect(TopicEmbed.count).to eq(0)
    end

    context 'creation of a post' do
      let!(:post) { TopicEmbed.import(user, url, title, contents) }

      it "works as expected with a new URL" do
        expect(post).to be_present

        # It uses raw_html rendering
        expect(post.cook_method).to eq(Post.cook_methods[:raw_html])
        expect(post.cooked).to eq(post.raw)

        # It converts relative URLs to absolute
        expect(post.cooked).to have_tag('a', with: { href: 'http://eviltrout.com/hello' })
        expect(post.cooked).to have_tag('img', with: { src: 'http://eviltrout.com/images/wat.jpg' })

        expect(post.topic.has_topic_embed?).to eq(true)
        expect(TopicEmbed.where(topic_id: post.topic_id)).to be_present

        expect(post.topic.category).to eq(embeddable_host.category)
      end

      it "Supports updating the post" do
        post = TopicEmbed.import(user, url, title, "muhahaha new contents!")
        expect(post.cooked).to match(/new contents/)
      end

      it "Should leave uppercase Feed Entry URL untouched in content" do
        cased_url = 'http://eviltrout.com/ABCD'
        post = TopicEmbed.import(user, cased_url, title, "some random content")
        expect(post.cooked).to match(/#{cased_url}/)
      end

      it "Should leave lowercase Feed Entry URL untouched in content" do
        cased_url = 'http://eviltrout.com/abcd'
        post = TopicEmbed.import(user, cased_url, title, "some random content")
        expect(post.cooked).to match(/#{cased_url}/)
      end
    end

  end

  describe '.find_remote' do

    context ".title_scrub" do

      let(:url) { 'http://eviltrout.com/123' }
      let(:contents) { "<title>Through the Looking Glass - Classic Books</title><body>some content here</body>" }
      let!(:embeddable_host) { Fabricate(:embeddable_host) }
      let!(:file) { StringIO.new }

      before do
        file.stubs(:read).returns contents
        TopicEmbed.stubs(:open).returns file
      end

      it "doesn't scrub the title by default" do
        response = TopicEmbed.find_remote(url)
        expect(response.title).to eq("Through the Looking Glass - Classic Books")
      end

      it "scrubs the title when the option is enabled" do
        SiteSetting.embed_title_scrubber = " - Classic Books$"
        response = TopicEmbed.find_remote(url)
        expect(response.title).to eq("Through the Looking Glass")
      end

    end

    context 'post with allowed classes "foo" and "emoji"' do
      let(:user) { Fabricate(:user) }
      let(:url) { 'http://eviltrout.com/123' }
      let(:contents) { "my normal size emoji <p class='foo'>Hi</p> <img class='emoji other foo' src='/images/smiley.jpg'>" }
      let!(:embeddable_host) { Fabricate(:embeddable_host) }
      let!(:file) { StringIO.new }

      response = nil

      before do
        SiteSetting.embed_classname_whitelist = 'emoji, foo'
        file.stubs(:read).returns contents
        TopicEmbed.stubs(:open).returns file
        response = TopicEmbed.find_remote(url)
      end

      it "has no author tag" do
        expect(response.author).to be_blank
      end

      it 'img node has emoji class' do
        expect(response.body).to have_tag('img', with: { class: 'emoji' })
      end

      it 'img node has foo class' do
        expect(response.body).to have_tag('img', with: { class: 'foo' })
      end

      it 'p node has foo class' do
        expect(response.body).to have_tag('p', with: { class: 'foo' })
      end

      it 'nodes removes classes other than emoji' do
        expect(response.body).to have_tag('img', without: { class: 'other' })
      end
    end

    context 'post with author metadata' do
      let!(:user) { Fabricate(:user, username: 'eviltrout') }
      let(:url) { 'http://eviltrout.com/321' }
      let(:contents) { '<html><head><meta name="author" content="eviltrout"></head><body>rich and morty</body></html>' }
      let!(:embeddable_host) { Fabricate(:embeddable_host) }
      let!(:file) { StringIO.new }

      response = nil

      before(:each) do
        file.stubs(:read).returns contents
        TopicEmbed.stubs(:open).returns file
        response = TopicEmbed.find_remote(url)
      end

      it "has no author tag" do
        expect(response.author).to eq(user)
      end
    end

    context 'post with no allowed classes' do

      let(:user) { Fabricate(:user) }
      let(:url) { 'http://eviltrout.com/123' }
      let(:contents) { "my normal size emoji <p class='foo'>Hi</p> <img class='emoji other foo' src='/images/smiley.jpg'>" }
      let!(:embeddable_host) { Fabricate(:embeddable_host) }
      let!(:file) { StringIO.new }

      response = nil

      before(:each) do
        SiteSetting.embed_classname_whitelist = ''
        file.stubs(:read).returns contents
        TopicEmbed.stubs(:open).returns file
        response = TopicEmbed.find_remote(url)
      end

      it 'img node doesn\'t have emoji class' do
        expect(response.body).to have_tag('img', without: { class: 'emoji' })
      end

      it 'img node doesn\'t have foo class' do
        expect(response.body).to have_tag('img', without: { class: 'foo' })
      end

      it 'p node doesn\'t foo class' do
        expect(response.body).to have_tag('p', without: { class: 'foo' })
      end

      it 'img node doesn\'t have other class' do
        expect(response.body).to have_tag('img', without: { class: 'other' })
      end
    end

    context "non-ascii URL" do
      let(:url) { 'http://eviltrout.com/test/ماهی' }
      let(:contents) { "<title>سلام</title><body>این یک پاراگراف آزمون است.</body>" }
      let!(:embeddable_host) { Fabricate(:embeddable_host) }
      let!(:file) { StringIO.new }

      before do
        file.stubs(:read).returns contents
        TopicEmbed.stubs(:open)
          .with('http://eviltrout.com/test/%D9%85%D8%A7%D9%87%DB%8C', allow_redirections: :safe).returns file
      end

      it "doesn't throw an error" do
        response = TopicEmbed.find_remote(url)
        expect(response.title).to eq("سلام")
      end
    end

    context "encoded URL" do
      let(:url) { 'http://example.com/hello%20world' }
      let(:contents) { "<title>Hello World!</title><body></body>" }
      let!(:embeddable_host) { Fabricate(:embeddable_host) }
      let!(:file) { StringIO.new }

      before do
        file.stubs(:read).returns contents
        TopicEmbed.stubs(:open)
          .with('http://example.com/hello%20world', allow_redirections: :safe).returns file
      end

      it "doesn't throw an error" do
        response = TopicEmbed.find_remote(url)
        expect(response.title).to eq("Hello World!")
      end
    end

    context "emails" do
      let(:url) { 'http://example.com/foo' }
      let(:contents) { '<p><a href="mailto:foo%40example.com">URL encoded @ symbol</a></p><p><a href="mailto:bar@example.com">normal mailto link</a></p>' }
      let!(:embeddable_host) { Fabricate(:embeddable_host) }
      let!(:file) { StringIO.new }

      before do
        file.stubs(:read).returns contents
        TopicEmbed.stubs(:open).returns file
      end

      it "handles mailto links" do
        response = TopicEmbed.find_remote(url)
        expect(response.body).to have_tag('a', with: { href: 'mailto:foo%40example.com' })
        expect(response.body).to have_tag('a', with: { href: 'mailto:bar@example.com' })
      end
    end
  end

  context ".escape_uri" do
    it "doesn't escape simple URL" do
      url = TopicEmbed.escape_uri('http://example.com/foo/bar')
      expect(url).to eq('http://example.com/foo/bar')
    end

    it "escapes unsafe chars" do
      url = TopicEmbed.escape_uri("http://example.com/?a=\11\15")
      expect(url).to eq('http://example.com/?a=%09%0D')
    end

    it "escapes non-ascii chars" do
      url = TopicEmbed.escape_uri('http://example.com/ماهی')
      expect(url).to eq('http://example.com/%D9%85%D8%A7%D9%87%DB%8C')
    end

    it "doesn't escape already escaped chars" do
      url = TopicEmbed.escape_uri('http://example.com/foo%20bar/foo bar/')
      expect(url).to eq('http://example.com/foo%20bar/foo%20bar/')
    end
  end
end
Prepare for separation of RSpec helper files Since rspec-rails 3, the default installation creates two helper files: * `spec_helper.rb` * `rails_helper.rb` `spec_helper.rb` is intended as a way of running specs that do not require Rails, whereas `rails_helper.rb` loads Rails (as Discourse's current `spec_helper.rb` does). For more information: https://www.relishapp.com/rspec/rspec-rails/docs/upgrade#default-helper-files In this commit, I've simply replaced all instances of `spec_helper` with `rails_helper`, and renamed the original `spec_helper.rb`. This brings the Discourse project closer to the standard usage of RSpec in a Rails app. At present, every spec relies on loading Rails, but there are likely many that don't need to. In a future pull request, I hope to introduce a separate, minimal `spec_helper.rb` which can be used in tests which don't rely on Rails. 2015-10-11 05:41:23 -04:00			`require 'rails_helper'`
FIX: allow emoji class when crawling embedded content, add rspc-html-matchers 2015-09-24 18:20:59 -04:00			`require 'stringio'`
FEATURE: Embeddable Discourse comments, now with simple-rss instead of feedzirra 2013-12-31 14:37:43 -05:00
			`describe TopicEmbed do`

Update rspec syntax to v3 update rspec syntax to v3 change syntax to rspec v3 oops. fix typo mailers classes with rspec3 syntax helpers with rspec3 syntax jobs with rspec3 syntax serializers with rspec3 syntax views with rspec3 syntax support to rspec3 syntax category spec with rspec3 syntax 2014-12-31 09:55:03 -05:00			`it { is_expected.to belong_to :topic }`
			`it { is_expected.to belong_to :post }`
			`it { is_expected.to validate_presence_of :embed_url }`
FEATURE: Embeddable Discourse comments, now with simple-rss instead of feedzirra 2013-12-31 14:37:43 -05:00
			`context '.import' do`

			`let(:user) { Fabricate(:user) }`
			`let(:title) { "How to turn a fish from good to evil in 30 seconds" }`
			`let(:url) { 'http://eviltrout.com/123' }`
			`let(:contents) { "hello world new post <a href='/hello'>hello</a> <img src='/images/wat.jpg'>" }`
FEATURE: Can edit category/host relationships for embedding 2015-08-18 17:15:46 -04:00			`let!(:embeddable_host) { Fabricate(:embeddable_host) }`
FEATURE: Embeddable Discourse comments, now with simple-rss instead of feedzirra 2013-12-31 14:37:43 -05:00
			`it "returns nil when the URL is malformed" do`
Update rspec syntax to v3 update rspec syntax to v3 change syntax to rspec v3 oops. fix typo mailers classes with rspec3 syntax helpers with rspec3 syntax jobs with rspec3 syntax serializers with rspec3 syntax views with rspec3 syntax support to rspec3 syntax category spec with rspec3 syntax 2014-12-31 09:55:03 -05:00			`expect(TopicEmbed.import(user, "invalid url", title, contents)).to eq(nil)`
			`expect(TopicEmbed.count).to eq(0)`
FEATURE: Embeddable Discourse comments, now with simple-rss instead of feedzirra 2013-12-31 14:37:43 -05:00			`end`

			`context 'creation of a post' do`
			`let!(:post) { TopicEmbed.import(user, url, title, contents) }`

			`it "works as expected with a new URL" do`
Update rspec syntax to v3 update rspec syntax to v3 change syntax to rspec v3 oops. fix typo mailers classes with rspec3 syntax helpers with rspec3 syntax jobs with rspec3 syntax serializers with rspec3 syntax views with rspec3 syntax support to rspec3 syntax category spec with rspec3 syntax 2014-12-31 09:55:03 -05:00			`expect(post).to be_present`
FEATURE: Embeddable Discourse comments, now with simple-rss instead of feedzirra 2013-12-31 14:37:43 -05:00
			`# It uses raw_html rendering`
Update rspec syntax to v3 update rspec syntax to v3 change syntax to rspec v3 oops. fix typo mailers classes with rspec3 syntax helpers with rspec3 syntax jobs with rspec3 syntax serializers with rspec3 syntax views with rspec3 syntax support to rspec3 syntax category spec with rspec3 syntax 2014-12-31 09:55:03 -05:00			`expect(post.cook_method).to eq(Post.cook_methods[:raw_html])`
			`expect(post.cooked).to eq(post.raw)`
FEATURE: Embeddable Discourse comments, now with simple-rss instead of feedzirra 2013-12-31 14:37:43 -05:00
			`# It converts relative URLs to absolute`
FIX: allow emoji class when crawling embedded content, add rspc-html-matchers 2015-09-24 18:20:59 -04:00			`expect(post.cooked).to have_tag('a', with: { href: 'http://eviltrout.com/hello' })`
			`expect(post.cooked).to have_tag('img', with: { src: 'http://eviltrout.com/images/wat.jpg' })`
FEATURE: Embeddable Discourse comments, now with simple-rss instead of feedzirra 2013-12-31 14:37:43 -05:00
Update rspec syntax to v3 update rspec syntax to v3 change syntax to rspec v3 oops. fix typo mailers classes with rspec3 syntax helpers with rspec3 syntax jobs with rspec3 syntax serializers with rspec3 syntax views with rspec3 syntax support to rspec3 syntax category spec with rspec3 syntax 2014-12-31 09:55:03 -05:00			`expect(post.topic.has_topic_embed?).to eq(true)`
			`expect(TopicEmbed.where(topic_id: post.topic_id)).to be_present`
FEATURE: Can edit category/host relationships for embedding 2015-08-18 17:15:46 -04:00
			`expect(post.topic.category).to eq(embeddable_host.category)`
FEATURE: Embeddable Discourse comments, now with simple-rss instead of feedzirra 2013-12-31 14:37:43 -05:00			`end`

			`it "Supports updating the post" do`
			`post = TopicEmbed.import(user, url, title, "muhahaha new contents!")`
Update rspec syntax to v3 update rspec syntax to v3 change syntax to rspec v3 oops. fix typo mailers classes with rspec3 syntax helpers with rspec3 syntax jobs with rspec3 syntax serializers with rspec3 syntax views with rspec3 syntax support to rspec3 syntax category spec with rspec3 syntax 2014-12-31 09:55:03 -05:00			`expect(post.cooked).to match(/new contents/)`
FEATURE: Embeddable Discourse comments, now with simple-rss instead of feedzirra 2013-12-31 14:37:43 -05:00			`end`

Normalize URL from Feed Entry after adding link to original in Topic Since a URL might be case sensitive, adding a link to the original Feed Entry with changed case to the Topic could end in 404. 2014-03-26 23:24:57 -04:00			`it "Should leave uppercase Feed Entry URL untouched in content" do`
			`cased_url = 'http://eviltrout.com/ABCD'`
			`post = TopicEmbed.import(user, cased_url, title, "some random content")`
Update rspec syntax to v3 update rspec syntax to v3 change syntax to rspec v3 oops. fix typo mailers classes with rspec3 syntax helpers with rspec3 syntax jobs with rspec3 syntax serializers with rspec3 syntax views with rspec3 syntax support to rspec3 syntax category spec with rspec3 syntax 2014-12-31 09:55:03 -05:00			`expect(post.cooked).to match(/#{cased_url}/)`
Normalize URL from Feed Entry after adding link to original in Topic Since a URL might be case sensitive, adding a link to the original Feed Entry with changed case to the Topic could end in 404. 2014-03-26 23:24:57 -04:00			`end`

			`it "Should leave lowercase Feed Entry URL untouched in content" do`
			`cased_url = 'http://eviltrout.com/abcd'`
			`post = TopicEmbed.import(user, cased_url, title, "some random content")`
Update rspec syntax to v3 update rspec syntax to v3 change syntax to rspec v3 oops. fix typo mailers classes with rspec3 syntax helpers with rspec3 syntax jobs with rspec3 syntax serializers with rspec3 syntax views with rspec3 syntax support to rspec3 syntax category spec with rspec3 syntax 2014-12-31 09:55:03 -05:00			`expect(post.cooked).to match(/#{cased_url}/)`
Normalize URL from Feed Entry after adding link to original in Topic Since a URL might be case sensitive, adding a link to the original Feed Entry with changed case to the Topic could end in 404. 2014-03-26 23:24:57 -04:00			`end`
FEATURE: Embeddable Discourse comments, now with simple-rss instead of feedzirra 2013-12-31 14:37:43 -05:00			`end`

			`end`

FIX: allow emoji class when crawling embedded content, add rspc-html-matchers 2015-09-24 18:20:59 -04:00			`describe '.find_remote' do`

FEATURE: Ability to scrub titles when importing embeddable content 2016-08-22 12:43:02 -04:00			`context ".title_scrub" do`

			`let(:url) { 'http://eviltrout.com/123' }`
			`let(:contents) { "<title>Through the Looking Glass - Classic Books</title><body>some content here</body>" }`
			`let!(:embeddable_host) { Fabricate(:embeddable_host) }`
			`let!(:file) { StringIO.new }`

			`before do`
			`file.stubs(:read).returns contents`
			`TopicEmbed.stubs(:open).returns file`
			`end`

			`it "doesn't scrub the title by default" do`
FEATURE: Support author meta tags for embedding 2016-08-30 12:01:04 -04:00			`response = TopicEmbed.find_remote(url)`
			`expect(response.title).to eq("Through the Looking Glass - Classic Books")`
FEATURE: Ability to scrub titles when importing embeddable content 2016-08-22 12:43:02 -04:00			`end`

			`it "scrubs the title when the option is enabled" do`
			`SiteSetting.embed_title_scrubber = " - Classic Books$"`
FEATURE: Support author meta tags for embedding 2016-08-30 12:01:04 -04:00			`response = TopicEmbed.find_remote(url)`
			`expect(response.title).to eq("Through the Looking Glass")`
FEATURE: Ability to scrub titles when importing embeddable content 2016-08-22 12:43:02 -04:00			`end`

			`end`

FIX: allow emoji class when crawling embedded content, add rspc-html-matchers 2015-09-24 18:20:59 -04:00			`context 'post with allowed classes "foo" and "emoji"' do`
			`let(:user) { Fabricate(:user) }`
			`let(:url) { 'http://eviltrout.com/123' }`
			`let(:contents) { "my normal size emoji <p class='foo'>Hi</p> <img class='emoji other foo' src='/images/smiley.jpg'>" }`
			`let!(:embeddable_host) { Fabricate(:embeddable_host) }`
			`let!(:file) { StringIO.new }`

FEATURE: Support author meta tags for embedding 2016-08-30 12:01:04 -04:00			`response = nil`
FIX: allow emoji class when crawling embedded content, add rspc-html-matchers 2015-09-24 18:20:59 -04:00
Nuke all `SiteSetting.stubs` from our codebase. 2017-07-07 02:09:14 -04:00			`before do`
			`SiteSetting.embed_classname_whitelist = 'emoji, foo'`
FIX: allow emoji class when crawling embedded content, add rspc-html-matchers 2015-09-24 18:20:59 -04:00			`file.stubs(:read).returns contents`
			`TopicEmbed.stubs(:open).returns file`
FEATURE: Support author meta tags for embedding 2016-08-30 12:01:04 -04:00			`response = TopicEmbed.find_remote(url)`
			`end`

			`it "has no author tag" do`
			`expect(response.author).to be_blank`
FIX: allow emoji class when crawling embedded content, add rspc-html-matchers 2015-09-24 18:20:59 -04:00			`end`

			`it 'img node has emoji class' do`
FEATURE: Support author meta tags for embedding 2016-08-30 12:01:04 -04:00			`expect(response.body).to have_tag('img', with: { class: 'emoji' })`
FIX: allow emoji class when crawling embedded content, add rspc-html-matchers 2015-09-24 18:20:59 -04:00			`end`

			`it 'img node has foo class' do`
FEATURE: Support author meta tags for embedding 2016-08-30 12:01:04 -04:00			`expect(response.body).to have_tag('img', with: { class: 'foo' })`
FIX: allow emoji class when crawling embedded content, add rspc-html-matchers 2015-09-24 18:20:59 -04:00			`end`

			`it 'p node has foo class' do`
FEATURE: Support author meta tags for embedding 2016-08-30 12:01:04 -04:00			`expect(response.body).to have_tag('p', with: { class: 'foo' })`
FIX: allow emoji class when crawling embedded content, add rspc-html-matchers 2015-09-24 18:20:59 -04:00			`end`

			`it 'nodes removes classes other than emoji' do`
FEATURE: Support author meta tags for embedding 2016-08-30 12:01:04 -04:00			`expect(response.body).to have_tag('img', without: { class: 'other' })`
			`end`
			`end`

			`context 'post with author metadata' do`
			`let!(:user) { Fabricate(:user, username: 'eviltrout') }`
			`let(:url) { 'http://eviltrout.com/321' }`
			`let(:contents) { '<html><head><meta name="author" content="eviltrout"></head><body>rich and morty</body></html>' }`
			`let!(:embeddable_host) { Fabricate(:embeddable_host) }`
			`let!(:file) { StringIO.new }`

			`response = nil`

			`before(:each) do`
			`file.stubs(:read).returns contents`
			`TopicEmbed.stubs(:open).returns file`
			`response = TopicEmbed.find_remote(url)`
FIX: allow emoji class when crawling embedded content, add rspc-html-matchers 2015-09-24 18:20:59 -04:00			`end`

FEATURE: Support author meta tags for embedding 2016-08-30 12:01:04 -04:00			`it "has no author tag" do`
			`expect(response.author).to eq(user)`
			`end`
FIX: allow emoji class when crawling embedded content, add rspc-html-matchers 2015-09-24 18:20:59 -04:00			`end`

			`context 'post with no allowed classes' do`

			`let(:user) { Fabricate(:user) }`
			`let(:url) { 'http://eviltrout.com/123' }`
			`let(:contents) { "my normal size emoji <p class='foo'>Hi</p> <img class='emoji other foo' src='/images/smiley.jpg'>" }`
			`let!(:embeddable_host) { Fabricate(:embeddable_host) }`
			`let!(:file) { StringIO.new }`

FEATURE: Support author meta tags for embedding 2016-08-30 12:01:04 -04:00			`response = nil`
FIX: allow emoji class when crawling embedded content, add rspc-html-matchers 2015-09-24 18:20:59 -04:00
			`before(:each) do`
Nuke all `SiteSetting.stubs` from our codebase. 2017-07-07 02:09:14 -04:00			`SiteSetting.embed_classname_whitelist = ''`
FIX: allow emoji class when crawling embedded content, add rspc-html-matchers 2015-09-24 18:20:59 -04:00			`file.stubs(:read).returns contents`
			`TopicEmbed.stubs(:open).returns file`
FEATURE: Support author meta tags for embedding 2016-08-30 12:01:04 -04:00			`response = TopicEmbed.find_remote(url)`
FIX: allow emoji class when crawling embedded content, add rspc-html-matchers 2015-09-24 18:20:59 -04:00			`end`

			`it 'img node doesn\'t have emoji class' do`
FEATURE: Support author meta tags for embedding 2016-08-30 12:01:04 -04:00			`expect(response.body).to have_tag('img', without: { class: 'emoji' })`
FIX: allow emoji class when crawling embedded content, add rspc-html-matchers 2015-09-24 18:20:59 -04:00			`end`

			`it 'img node doesn\'t have foo class' do`
FEATURE: Support author meta tags for embedding 2016-08-30 12:01:04 -04:00			`expect(response.body).to have_tag('img', without: { class: 'foo' })`
FIX: allow emoji class when crawling embedded content, add rspc-html-matchers 2015-09-24 18:20:59 -04:00			`end`

			`it 'p node doesn\'t foo class' do`
FEATURE: Support author meta tags for embedding 2016-08-30 12:01:04 -04:00			`expect(response.body).to have_tag('p', without: { class: 'foo' })`
FIX: allow emoji class when crawling embedded content, add rspc-html-matchers 2015-09-24 18:20:59 -04:00			`end`

			`it 'img node doesn\'t have other class' do`
FEATURE: Support author meta tags for embedding 2016-08-30 12:01:04 -04:00			`expect(response.body).to have_tag('img', without: { class: 'other' })`
FIX: allow emoji class when crawling embedded content, add rspc-html-matchers 2015-09-24 18:20:59 -04:00			`end`
FIX: More errors with non-ascii URLs 2017-03-07 11:21:26 -05:00			`end`

			`context "non-ascii URL" do`
			`let(:url) { 'http://eviltrout.com/test/ماهی' }`
			`let(:contents) { "<title>سلام</title><body>این یک پاراگراف آزمون است.</body>" }`
			`let!(:embeddable_host) { Fabricate(:embeddable_host) }`
			`let!(:file) { StringIO.new }`
FIX: allow emoji class when crawling embedded content, add rspc-html-matchers 2015-09-24 18:20:59 -04:00
FIX: More errors with non-ascii URLs 2017-03-07 11:21:26 -05:00			`before do`
			`file.stubs(:read).returns contents`
FIX: do not escape already escaped chars in URL 2017-09-22 11:36:44 -04:00			`TopicEmbed.stubs(:open)`
			`.with('http://eviltrout.com/test/%D9%85%D8%A7%D9%87%DB%8C', allow_redirections: :safe).returns file`
FIX: More errors with non-ascii URLs 2017-03-07 11:21:26 -05:00			`end`

			`it "doesn't throw an error" do`
			`response = TopicEmbed.find_remote(url)`
			`expect(response.title).to eq("سلام")`
			`end`
FIX: allow emoji class when crawling embedded content, add rspc-html-matchers 2015-09-24 18:20:59 -04:00			`end`

FIX: do not escape already escaped chars in URL 2017-09-22 11:36:44 -04:00			`context "encoded URL" do`
			`let(:url) { 'http://example.com/hello%20world' }`
			`let(:contents) { "<title>Hello World!</title><body></body>" }`
			`let!(:embeddable_host) { Fabricate(:embeddable_host) }`
			`let!(:file) { StringIO.new }`

			`before do`
			`file.stubs(:read).returns contents`
			`TopicEmbed.stubs(:open)`
			`.with('http://example.com/hello%20world', allow_redirections: :safe).returns file`
			`end`

			`it "doesn't throw an error" do`
			`response = TopicEmbed.find_remote(url)`
			`expect(response.title).to eq("Hello World!")`
			`end`
			`end`

FIX: handle URL encoded email addresses 2017-09-22 08:26:06 -04:00			`context "emails" do`
			`let(:url) { 'http://example.com/foo' }`
			`let(:contents) { '<p><a href="mailto:foo%40example.com">URL encoded @ symbol</a></p><p><a href="mailto:bar@example.com">normal mailto link</a></p>' }`
			`let!(:embeddable_host) { Fabricate(:embeddable_host) }`
			`let!(:file) { StringIO.new }`

			`before do`
			`file.stubs(:read).returns contents`
			`TopicEmbed.stubs(:open).returns file`
			`end`

			`it "handles mailto links" do`
			`response = TopicEmbed.find_remote(url)`
			`expect(response.body).to have_tag('a', with: { href: 'mailto:foo%40example.com' })`
			`expect(response.body).to have_tag('a', with: { href: 'mailto:bar@example.com' })`
			`end`
			`end`
FIX: allow emoji class when crawling embedded content, add rspc-html-matchers 2015-09-24 18:20:59 -04:00			`end`

FIX: do not escape already escaped chars in URL 2017-09-22 11:36:44 -04:00			`context ".escape_uri" do`
			`it "doesn't escape simple URL" do`
			`url = TopicEmbed.escape_uri('http://example.com/foo/bar')`
			`expect(url).to eq('http://example.com/foo/bar')`
			`end`

			`it "escapes unsafe chars" do`
			`url = TopicEmbed.escape_uri("http://example.com/?a=\11\15")`
			`expect(url).to eq('http://example.com/?a=%09%0D')`
			`end`

			`it "escapes non-ascii chars" do`
			`url = TopicEmbed.escape_uri('http://example.com/ماهی')`
			`expect(url).to eq('http://example.com/%D9%85%D8%A7%D9%87%DB%8C')`
			`end`

			`it "doesn't escape already escaped chars" do`
			`url = TopicEmbed.escape_uri('http://example.com/foo%20bar/foo bar/')`
			`expect(url).to eq('http://example.com/foo%20bar/foo%20bar/')`
			`end`
			`end`
FEATURE: Embeddable Discourse comments, now with simple-rss instead of feedzirra 2013-12-31 14:37:43 -05:00			`end`