discourse/spec/components/concern/has_custom_fields_spec.rb

189 lines
6.3 KiB
Ruby
Raw Normal View History

require "rails_helper"
describe HasCustomFields do
context "custom_fields" do
before do
Topic.exec_sql("create temporary table custom_fields_test_items(id SERIAL primary key)")
Topic.exec_sql("create temporary table custom_fields_test_item_custom_fields(id SERIAL primary key, custom_fields_test_item_id int, name varchar(256) not null, value text)")
class CustomFieldsTestItem < ActiveRecord::Base
include HasCustomFields
end
class CustomFieldsTestItemCustomField < ActiveRecord::Base
belongs_to :custom_fields_test_item
end
end
after do
Topic.exec_sql("drop table custom_fields_test_items")
Topic.exec_sql("drop table custom_fields_test_item_custom_fields")
# import is making my life hard, we need to nuke this out of orbit
des = ActiveSupport::DescendantsTracker.class_variable_get :@@direct_descendants
des[ActiveRecord::Base].delete(CustomFieldsTestItem)
des[ActiveRecord::Base].delete(CustomFieldsTestItemCustomField)
end
it "simple modification of custom fields" do
test_item = CustomFieldsTestItem.new
2015-01-09 11:34:37 -05:00
expect(test_item.custom_fields["a"]).to eq(nil)
test_item.custom_fields["bob"] = "marley"
test_item.custom_fields["jack"] = "black"
2014-04-25 13:15:23 -04:00
test_item.save
test_item = CustomFieldsTestItem.find(test_item.id)
2015-01-09 11:34:37 -05:00
expect(test_item.custom_fields["bob"]).to eq("marley")
expect(test_item.custom_fields["jack"]).to eq("black")
test_item.custom_fields.delete("bob")
test_item.custom_fields["jack"] = "jill"
test_item.save
test_item = CustomFieldsTestItem.find(test_item.id)
2015-01-09 11:34:37 -05:00
expect(test_item.custom_fields).to eq({"jack" => "jill"})
end
2014-04-25 13:15:23 -04:00
it "casts integers to string without error" do
test_item = CustomFieldsTestItem.new
2015-01-09 11:34:37 -05:00
expect(test_item.custom_fields["a"]).to eq(nil)
2014-04-25 13:15:23 -04:00
test_item.custom_fields["a"] = 0
2015-01-09 11:34:37 -05:00
expect(test_item.custom_fields["a"]).to eq(0)
2014-04-25 13:15:23 -04:00
test_item.save
# should be casted right after saving
2015-01-09 11:34:37 -05:00
expect(test_item.custom_fields["a"]).to eq("0")
2014-04-25 13:15:23 -04:00
test_item = CustomFieldsTestItem.find(test_item.id)
2015-01-09 11:34:37 -05:00
expect(test_item.custom_fields["a"]).to eq("0")
2014-04-25 13:15:23 -04:00
end
it "reload loads from database" do
test_item = CustomFieldsTestItem.new
test_item.custom_fields["a"] = 0
2015-01-09 11:34:37 -05:00
expect(test_item.custom_fields["a"]).to eq(0)
test_item.save
# should be casted right after saving
2015-01-09 11:34:37 -05:00
expect(test_item.custom_fields["a"]).to eq("0")
CustomFieldsTestItem.exec_sql("UPDATE custom_fields_test_item_custom_fields SET value='1' WHERE custom_fields_test_item_id=? AND name='a'", test_item.id)
# still the same, did not load
2015-01-09 11:34:37 -05:00
expect(test_item.custom_fields["a"]).to eq("0")
# refresh loads from database
2015-01-09 11:34:37 -05:00
expect(test_item.reload.custom_fields["a"]).to eq("1")
expect(test_item.custom_fields["a"]).to eq("1")
end
it "double save actually saves" do
test_item = CustomFieldsTestItem.new
test_item.custom_fields = {"a" => "b"}
test_item.save
test_item.custom_fields["c"] = "d"
test_item.save
db_item = CustomFieldsTestItem.find(test_item.id)
2015-01-09 11:34:37 -05:00
expect(db_item.custom_fields).to eq({"a" => "b", "c" => "d"})
end
2014-04-25 13:15:23 -04:00
it "handles arrays properly" do
test_item = CustomFieldsTestItem.new
2014-04-25 13:15:23 -04:00
test_item.custom_fields = {"a" => ["b", "c", "d"]}
test_item.save
db_item = CustomFieldsTestItem.find(test_item.id)
2015-01-09 11:34:37 -05:00
expect(db_item.custom_fields).to eq({"a" => ["b", "c", "d"]})
2014-04-25 13:15:23 -04:00
db_item.custom_fields.update('a' => ['c', 'd'])
2014-04-25 13:15:23 -04:00
db_item.save
2015-01-09 11:34:37 -05:00
expect(db_item.custom_fields).to eq({"a" => ["c", "d"]})
2014-04-25 13:15:23 -04:00
# It can be updated to the exact same value
db_item.custom_fields.update('a' => ['c'])
db_item.save
expect(db_item.custom_fields).to eq({"a" => "c"})
db_item.custom_fields.update('a' => ['c'])
db_item.save
expect(db_item.custom_fields).to eq({"a" => "c"})
db_item.custom_fields.delete('a')
2015-01-09 11:34:37 -05:00
expect(db_item.custom_fields).to eq({})
2014-04-25 13:15:23 -04:00
end
it "casts integers in arrays properly without error" do
test_item = CustomFieldsTestItem.new
2014-04-25 13:15:23 -04:00
test_item.custom_fields = {"a" => ["b", 10, "d"]}
test_item.save
2015-01-09 11:34:37 -05:00
expect(test_item.custom_fields).to eq({"a" => ["b", "10", "d"]})
2014-04-25 13:15:23 -04:00
db_item = CustomFieldsTestItem.find(test_item.id)
2015-01-09 11:34:37 -05:00
expect(db_item.custom_fields).to eq({"a" => ["b", "10", "d"]})
2014-04-25 13:15:23 -04:00
end
it "supportes type coersion" do
test_item = CustomFieldsTestItem.new
CustomFieldsTestItem.register_custom_field_type("bool", :boolean)
CustomFieldsTestItem.register_custom_field_type("int", :integer)
CustomFieldsTestItem.register_custom_field_type("json", :json)
test_item.custom_fields = {"bool" => true, "int" => 1, "json" => { "foo" => "bar" }}
test_item.save
test_item.reload
expect(test_item.custom_fields).to eq({"bool" => true, "int" => 1, "json" => { "foo" => "bar" }})
end
it "simple modifications don't interfere" do
test_item = CustomFieldsTestItem.new
2015-01-09 11:34:37 -05:00
expect(test_item.custom_fields["a"]).to eq(nil)
test_item.custom_fields["bob"] = "marley"
test_item.custom_fields["jack"] = "black"
test_item.save
test_item2 = CustomFieldsTestItem.new
2015-01-09 11:34:37 -05:00
expect(test_item2.custom_fields["x"]).to eq(nil)
test_item2.custom_fields["sixto"] = "rodriguez"
test_item2.custom_fields["de"] = "la playa"
test_item2.save
test_item = CustomFieldsTestItem.find(test_item.id)
test_item2 = CustomFieldsTestItem.find(test_item2.id)
2015-01-09 11:34:37 -05:00
expect(test_item.custom_fields).to eq({"jack" => "black", "bob" => "marley"})
expect(test_item2.custom_fields).to eq({"sixto" => "rodriguez", "de" => "la playa"})
end
it "supports bulk retrieval with a list of ids" do
item1 = CustomFieldsTestItem.new
item1.custom_fields = {"a" => ["b", "c", "d"], 'not_whitelisted' => 'secret'}
item1.save
item2 = CustomFieldsTestItem.new
item2.custom_fields = {"e" => 'hallo'}
item2.save
fields = CustomFieldsTestItem.custom_fields_for_ids([item1.id, item2.id], ['a', 'e'])
2015-01-09 11:34:37 -05:00
expect(fields).to be_present
expect(fields[item1.id]['a']).to match_array(['b', 'c', 'd'])
expect(fields[item1.id]['not_whitelisted']).to be_blank
expect(fields[item2.id]['e']).to eq('hallo')
end
end
end