discourse/spec/integration/spam_rules_spec.rb

121 lines
4.7 KiB
Ruby
Raw Normal View History

# encoding: UTF-8
require 'rails_helper'
describe "spam rules for users" do
describe 'auto-silence users based on flagging' do
2016-12-12 20:59:38 -05:00
let!(:admin) { Fabricate(:admin) } # needed to send a system message
let!(:moderator) { Fabricate(:moderator) }
let(:user1) { Fabricate(:user) }
let(:user2) { Fabricate(:user) }
before do
SiteSetting.score_required_to_hide_post = 0
SiteSetting.spam_score_to_silence_new_user = 4.0
2017-11-10 12:18:08 -05:00
SiteSetting.num_users_to_silence_new_user = 2
end
context 'spammer is a new user' do
2016-12-12 20:59:38 -05:00
let(:spammer) { Fabricate(:user, trust_level: TrustLevel[0]) }
context 'spammer post is not flagged enough times' do
2016-12-12 20:59:38 -05:00
let!(:spam_post) { create_post(user: spammer) }
let!(:spam_post2) { create_post(user: spammer) }
before do
PostActionCreator.create(user1, spam_post, :spam)
2016-12-12 20:59:38 -05:00
end
it 'should not hide the post' do
expect(spam_post.reload).to_not be_hidden
end
context 'spam posts are flagged enough times, but not by enough users' do
2016-12-12 20:59:38 -05:00
it 'should not hide the post' do
PostActionCreator.create(user1, spam_post2, :spam)
2016-12-12 20:59:38 -05:00
expect(spam_post.reload).to_not be_hidden
expect(spam_post2.reload).to_not be_hidden
2017-11-10 12:18:08 -05:00
expect(spammer.reload).to_not be_silenced
2016-12-12 20:59:38 -05:00
end
end
context 'one spam post is flagged enough times by enough users' do
let!(:another_topic) { Fabricate(:topic) }
2016-12-12 20:59:38 -05:00
let!(:private_messages_count) { spammer.private_topics_count }
let!(:mod_pm_count) { moderator.private_topics_count }
let!(:reviewable) { PostActionCreator.spam(user2, spam_post).reviewable }
it 'should hide the posts' do
2016-12-12 20:59:38 -05:00
expect(Guardian.new(spammer).can_create_topic?(nil)).to be(false)
2017-07-27 21:20:09 -04:00
expect { PostCreator.create(spammer, title: 'limited time offer for you', raw: 'better buy this stuff ok', archetype_id: 1) }.to raise_error(Discourse::InvalidAccess)
expect(PostCreator.create(spammer, topic_id: another_topic.id, raw: 'my reply is spam in your topic', archetype_id: 1)).to eq(nil)
2017-11-10 12:18:08 -05:00
expect(spammer.reload).to be_silenced
2016-12-12 20:59:38 -05:00
expect(spam_post.reload).to be_hidden
expect(spam_post2.reload).to be_hidden
expect(spammer.reload.private_topics_count).to eq(private_messages_count + 1)
end
context "a post is deleted" do
2017-11-10 12:18:08 -05:00
it 'should silence the spammer' do
2016-12-12 20:59:38 -05:00
spam_post.trash!(moderator); spammer.reload
2017-11-10 12:18:08 -05:00
expect(spammer.reload).to be_silenced
2016-12-12 20:59:38 -05:00
end
end
2014-09-04 16:32:00 -04:00
context "spammer becomes trust level 1" do
2017-11-10 12:18:08 -05:00
it 'should silence the spammer' do
2016-12-12 20:59:38 -05:00
spammer.change_trust_level!(TrustLevel[1]); spammer.reload
2017-11-10 12:18:08 -05:00
expect(spammer.reload).to be_silenced
2016-12-12 20:59:38 -05:00
end
end
end
context 'score_required_to_hide_post takes effect too' do
2017-11-10 12:18:08 -05:00
it 'should silence the spammer' do
SiteSetting.score_required_to_hide_post = 2.0
PostActionCreator.create(user2, spam_post, :spam)
2017-11-10 12:18:08 -05:00
expect(spammer.reload).to be_silenced
2016-12-12 20:59:38 -05:00
expect(Guardian.new(spammer).can_create_topic?(nil)).to be false
end
end
end
end
context "spammer has trust level basic" do
2016-12-12 20:59:38 -05:00
let(:spammer) { Fabricate(:user, trust_level: TrustLevel[1]) }
context 'one spam post is flagged enough times by enough users' do
2016-12-12 20:59:38 -05:00
let!(:spam_post) { Fabricate(:post, user: spammer) }
let!(:private_messages_count) { spammer.private_topics_count }
it 'should not allow spammer to create new posts' do
PostActionCreator.create(user1, spam_post, :spam)
PostActionCreator.create(user2, spam_post, :spam)
2016-12-12 20:59:38 -05:00
expect(spam_post.reload).to_not be_hidden
expect(Guardian.new(spammer).can_create_topic?(nil)).to be(true)
2017-07-27 21:20:09 -04:00
expect { PostCreator.create(spammer, title: 'limited time offer for you', raw: 'better buy this stuff ok', archetype_id: 1) }.to_not raise_error
2016-12-12 20:59:38 -05:00
expect(spammer.reload.private_topics_count).to eq(private_messages_count)
end
end
end
[[:user, trust_level: TrustLevel[2]], [:admin], [:moderator]].each do |spammer_args|
context "spammer is trusted #{spammer_args[0]}" do
2016-12-12 20:59:38 -05:00
let!(:spammer) { Fabricate(*spammer_args) }
let!(:spam_post) { Fabricate(:post, user: spammer) }
let!(:private_messages_count) { spammer.private_topics_count }
it 'should not hide the post' do
PostActionCreator.create(user1, spam_post, :spam)
PostActionCreator.create(user2, spam_post, :spam)
2016-12-12 20:59:38 -05:00
expect(spam_post.reload).to_not be_hidden
end
end
end
end
end