Discource-C
/
discourse
mirror of https://github.com/discourse/discourse.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity
discourse/plugins/chat/spec/system/admin_sidebar_navigation_sp...

Ignoring revisions in .git-blame-ignore-revs. Click here to bypass and see the normal blame view.

26 lines
881 B
Ruby
Raw Normal View History

FIX: Show admin plugin route sub-links in sidebar (#24982) This changes the Plugins link in the admin sidebar to be a section instead, which then shows all enabled plugin admin routes (which are custom routes some plugins e.g. chat define). This is done via adding some special preloaded data for all controllers based on AdminController, and also specifically on Admin::PluginsController, to have the routes loaded without additional requests on page load. We just use a cog for all the route icons for now...we don't have anything better.
2023-12-20 20:37:20 -05:00
# frozen_string_literal: true
describe "Admin Revamp | Sidebar Navigation | Plugin Links", type: :system do
fab!(:admin)
let(:sidebar) { PageObjects::Components::NavigationMenu::Sidebar.new }
before do
chat_system_bootstrap
DEV: Change enable_admin_sidebar_navigation to group setting (#25159) This will make it easier to do more focused testing of this change.
2024-01-08 18:06:27 -05:00
SiteSetting.admin_sidebar_enabled_groups = Group::AUTO_GROUPS[:admins]
FIX: Show admin plugin route sub-links in sidebar (#24982) This changes the Plugins link in the admin sidebar to be a section instead, which then shows all enabled plugin admin routes (which are custom routes some plugins e.g. chat define). This is done via adding some special preloaded data for all controllers based on AdminController, and also specifically on Admin::PluginsController, to have the routes loaded without additional requests on page load. We just use a cog for all the route icons for now...we don't have anything better.
2023-12-20 20:37:20 -05:00
sign_in(admin)
end
it "shows links to enabled plugin admin routes" do
visit("/admin")
expect(sidebar).to have_section_link("Chat", href: "/admin/plugins/chat")
end
FIX: Do not duplicate admin sidebar plugin links (#25780) When hiding/showing the sidebar, as is the case on mobile and using the toggle in the top left on desktop, we delete and recreate the ember component on the page. This causes the `sections` for each sidebar panel to get re-evaluated every time. For the admin sidebar, this means that we were constantly re-adding the plugin links to the sidebar, causing duplication. This can be fixed by just adding @cached to the getter for sections.
2024-02-20 21:58:31 -05:00
it "does not duplicate links to enabled plugin admin routes when showing and hiding sidebar" do
visit("/admin")
expect(sidebar).to have_section_link("Chat", href: "/admin/plugins/chat", count: 1)
find(".header-sidebar-toggle").click
find(".header-sidebar-toggle").click
expect(sidebar).to have_section_link("Chat", href: "/admin/plugins/chat", count: 1)
end
FIX: Show admin plugin route sub-links in sidebar (#24982) This changes the Plugins link in the admin sidebar to be a section instead, which then shows all enabled plugin admin routes (which are custom routes some plugins e.g. chat define). This is done via adding some special preloaded data for all controllers based on AdminController, and also specifically on Admin::PluginsController, to have the routes loaded without additional requests on page load. We just use a cog for all the route icons for now...we don't have anything better.
2023-12-20 20:37:20 -05:00
end