2015-10-11 05:41:23 -04:00
|
|
|
require 'rails_helper'
|
2013-02-05 14:16:51 -05:00
|
|
|
|
|
|
|
describe StaticController do
|
2018-11-14 02:03:02 -05:00
|
|
|
let(:upload) { Fabricate(:upload) }
|
2013-02-05 14:16:51 -05:00
|
|
|
|
2017-11-26 22:50:57 -05:00
|
|
|
context '#favicon' do
|
|
|
|
let(:png) { Base64.decode64("R0lGODlhAQABALMAAAAAAIAAAACAAICAAAAAgIAAgACAgMDAwICAgP8AAAD/AP//AAAA//8A/wD//wBiZCH5BAEAAA8ALAAAAAABAAEAAAQC8EUAOw==") }
|
|
|
|
|
2018-02-24 06:35:57 -05:00
|
|
|
before { FinalDestination.stubs(:lookup_ip).returns("1.2.3.4") }
|
2017-11-26 22:50:57 -05:00
|
|
|
|
2018-11-14 02:03:02 -05:00
|
|
|
after do
|
2019-02-21 02:03:55 -05:00
|
|
|
DistributedMemoizer.flush!
|
2018-11-14 02:03:02 -05:00
|
|
|
end
|
2017-11-26 22:50:57 -05:00
|
|
|
|
2018-11-14 02:03:02 -05:00
|
|
|
it 'returns the default favicon for a missing download' do
|
|
|
|
url = UrlHelper.absolute(upload.url)
|
|
|
|
SiteSetting.favicon = upload
|
2018-02-24 06:35:57 -05:00
|
|
|
stub_request(:get, url).to_return(status: 404)
|
2017-11-26 22:50:57 -05:00
|
|
|
|
|
|
|
get '/favicon/proxied'
|
|
|
|
|
|
|
|
favicon = File.read(Rails.root + "public/images/default-favicon.png")
|
|
|
|
|
|
|
|
expect(response.status).to eq(200)
|
|
|
|
expect(response.content_type).to eq('image/png')
|
|
|
|
expect(response.body.bytesize).to eq(favicon.bytesize)
|
|
|
|
end
|
|
|
|
|
|
|
|
it 'can proxy a favicon correctly' do
|
2018-11-14 02:03:02 -05:00
|
|
|
url = UrlHelper.absolute(upload.url)
|
|
|
|
SiteSetting.favicon = upload
|
2018-02-24 06:35:57 -05:00
|
|
|
stub_request(:get, url).to_return(status: 200, body: png)
|
2017-11-26 22:50:57 -05:00
|
|
|
|
|
|
|
get '/favicon/proxied'
|
|
|
|
|
|
|
|
expect(response.status).to eq(200)
|
|
|
|
expect(response.content_type).to eq('image/png')
|
|
|
|
expect(response.body.bytesize).to eq(png.bytesize)
|
|
|
|
end
|
|
|
|
end
|
|
|
|
|
2017-08-31 00:06:56 -04:00
|
|
|
context '#brotli_asset' do
|
2017-03-20 15:59:06 -04:00
|
|
|
it 'returns a non brotli encoded 404 if asset is missing' do
|
2017-08-31 00:06:56 -04:00
|
|
|
get "/brotli_asset/missing.js"
|
2016-12-15 00:05:20 -05:00
|
|
|
|
2017-08-31 00:06:56 -04:00
|
|
|
expect(response.status).to eq(404)
|
|
|
|
expect(response.headers['Content-Encoding']).not_to eq('br')
|
2017-11-26 22:50:57 -05:00
|
|
|
expect(response.headers['Cache-Control']).to match(/max-age=1/)
|
2017-03-20 15:59:06 -04:00
|
|
|
end
|
|
|
|
|
|
|
|
it 'can handle fallback brotli assets' do
|
|
|
|
begin
|
|
|
|
assets_path = Rails.root.join("tmp/backup_assets")
|
|
|
|
|
|
|
|
GlobalSetting.stubs(:fallback_assets_path).returns(assets_path.to_s)
|
|
|
|
|
|
|
|
FileUtils.mkdir_p(assets_path)
|
|
|
|
|
|
|
|
file_path = assets_path.join("test.js.br")
|
|
|
|
File.write(file_path, 'fake brotli file')
|
|
|
|
|
2017-08-31 00:06:56 -04:00
|
|
|
get "/brotli_asset/test.js"
|
2017-03-20 15:59:06 -04:00
|
|
|
|
|
|
|
expect(response.status).to eq(200)
|
|
|
|
expect(response.headers["Cache-Control"]).to match(/public/)
|
|
|
|
ensure
|
|
|
|
File.delete(file_path)
|
|
|
|
end
|
2016-12-15 00:05:20 -05:00
|
|
|
end
|
|
|
|
|
2016-12-05 00:08:36 -05:00
|
|
|
it 'has correct headers for brotli assets' do
|
2016-12-05 00:37:33 -05:00
|
|
|
begin
|
|
|
|
assets_path = Rails.root.join("public/assets")
|
2016-12-05 00:08:36 -05:00
|
|
|
|
2016-12-05 00:37:33 -05:00
|
|
|
FileUtils.mkdir_p(assets_path)
|
2016-12-05 00:08:36 -05:00
|
|
|
|
2016-12-05 00:37:33 -05:00
|
|
|
file_path = assets_path.join("test.js.br")
|
|
|
|
File.write(file_path, 'fake brotli file')
|
|
|
|
|
2017-08-31 00:06:56 -04:00
|
|
|
get "/brotli_asset/test.js"
|
2016-12-05 00:37:33 -05:00
|
|
|
|
|
|
|
expect(response.status).to eq(200)
|
|
|
|
expect(response.headers["Cache-Control"]).to match(/public/)
|
|
|
|
ensure
|
|
|
|
File.delete(file_path)
|
|
|
|
end
|
2016-12-05 00:08:36 -05:00
|
|
|
end
|
|
|
|
end
|
|
|
|
|
2017-08-31 00:06:56 -04:00
|
|
|
context '#show' do
|
2014-07-24 14:27:34 -04:00
|
|
|
before do
|
|
|
|
post = create_post
|
2017-07-07 02:09:14 -04:00
|
|
|
SiteSetting.tos_topic_id = post.topic.id
|
|
|
|
SiteSetting.guidelines_topic_id = post.topic.id
|
|
|
|
SiteSetting.privacy_topic_id = post.topic.id
|
2014-07-24 14:27:34 -04:00
|
|
|
end
|
|
|
|
|
2013-10-30 16:37:22 -04:00
|
|
|
context "with a static file that's present" do
|
2017-08-31 00:06:56 -04:00
|
|
|
it "should return the right response" do
|
|
|
|
get "/faq"
|
2013-02-05 14:16:51 -05:00
|
|
|
|
2018-06-07 04:11:09 -04:00
|
|
|
expect(response.status).to eq(200)
|
2017-08-31 00:06:56 -04:00
|
|
|
expect(response.body).to include(I18n.t('js.faq'))
|
2018-11-27 21:36:14 -05:00
|
|
|
expect(response.body).to include("<title>FAQ - Discourse</title>")
|
2013-07-23 14:42:52 -04:00
|
|
|
end
|
2013-02-05 14:16:51 -05:00
|
|
|
end
|
|
|
|
|
2017-08-31 00:06:56 -04:00
|
|
|
[
|
|
|
|
['tos', :tos_url, I18n.t('terms_of_service.title')],
|
|
|
|
['privacy', :privacy_policy_url, I18n.t('privacy')]
|
|
|
|
].each do |id, setting_name, text|
|
2013-06-18 10:52:04 -04:00
|
|
|
|
2017-08-31 00:06:56 -04:00
|
|
|
context "#{id}" do
|
2013-10-30 16:37:22 -04:00
|
|
|
context "when #{setting_name} site setting is NOT set" do
|
|
|
|
it "renders the #{id} page" do
|
2017-08-31 00:06:56 -04:00
|
|
|
get "/#{id}"
|
|
|
|
|
2018-06-07 04:11:09 -04:00
|
|
|
expect(response.status).to eq(200)
|
2017-08-31 00:06:56 -04:00
|
|
|
expect(response.body).to include(text)
|
2013-07-23 14:42:52 -04:00
|
|
|
end
|
2013-06-18 10:52:04 -04:00
|
|
|
end
|
|
|
|
|
2013-10-30 16:37:22 -04:00
|
|
|
context "when #{setting_name} site setting is set" do
|
2017-08-31 00:06:56 -04:00
|
|
|
before do
|
|
|
|
SiteSetting.public_send("#{setting_name}=", 'http://example.com/page')
|
|
|
|
end
|
2013-06-18 10:52:04 -04:00
|
|
|
|
2013-10-30 16:37:22 -04:00
|
|
|
it "redirects to the #{setting_name}" do
|
2017-08-31 00:06:56 -04:00
|
|
|
get "/#{id}"
|
|
|
|
|
|
|
|
expect(response).to redirect_to('http://example.com/page')
|
2013-10-30 16:37:22 -04:00
|
|
|
end
|
2013-06-18 10:52:04 -04:00
|
|
|
end
|
|
|
|
end
|
|
|
|
end
|
|
|
|
|
2013-10-30 16:37:22 -04:00
|
|
|
context "with a missing file" do
|
|
|
|
it "should respond 404" do
|
2017-08-31 00:06:56 -04:00
|
|
|
get "/static/does-not-exist"
|
|
|
|
expect(response.status).to eq(404)
|
2013-10-30 16:37:22 -04:00
|
|
|
end
|
|
|
|
end
|
|
|
|
|
|
|
|
it 'should redirect to / when logged in and path is /login' do
|
2017-08-31 00:06:56 -04:00
|
|
|
sign_in(Fabricate(:user))
|
|
|
|
get "/login"
|
|
|
|
expect(response).to redirect_to('/')
|
2013-02-05 14:16:51 -05:00
|
|
|
end
|
|
|
|
|
2014-07-26 17:16:08 -04:00
|
|
|
it "should display the login template when login is required" do
|
2017-07-07 02:09:14 -04:00
|
|
|
SiteSetting.login_required = true
|
2017-08-31 00:06:56 -04:00
|
|
|
|
|
|
|
get "/login"
|
|
|
|
|
2018-06-07 04:11:09 -04:00
|
|
|
expect(response.status).to eq(200)
|
2017-08-31 00:06:56 -04:00
|
|
|
|
|
|
|
expect(response.body).to include(PrettyText.cook(I18n.t(
|
|
|
|
'login_required.welcome_message', title: SiteSetting.title
|
|
|
|
)))
|
2014-07-26 17:16:08 -04:00
|
|
|
end
|
2017-03-08 05:30:49 -05:00
|
|
|
|
|
|
|
context "when login_required is enabled" do
|
|
|
|
before do
|
|
|
|
SiteSetting.login_required = true
|
|
|
|
end
|
|
|
|
|
2018-12-18 16:40:05 -05:00
|
|
|
['faq', 'guidelines', 'rules', 'conduct'].each do |page_name|
|
2018-07-26 15:37:56 -04:00
|
|
|
it "#{page_name} page redirects to login page for anon" do
|
|
|
|
get "/#{page_name}"
|
|
|
|
expect(response).to redirect_to '/login'
|
|
|
|
end
|
2017-08-31 00:06:56 -04:00
|
|
|
|
2018-07-26 15:37:56 -04:00
|
|
|
it "#{page_name} page redirects to login page for anon" do
|
|
|
|
get "/#{page_name}"
|
|
|
|
expect(response).to redirect_to '/login'
|
|
|
|
end
|
2017-03-08 05:30:49 -05:00
|
|
|
|
2018-07-26 15:37:56 -04:00
|
|
|
it "#{page_name} page loads for logged in user" do
|
|
|
|
sign_in(Fabricate(:user))
|
2017-08-31 00:06:56 -04:00
|
|
|
|
2018-07-26 15:37:56 -04:00
|
|
|
get "/#{page_name}"
|
2017-08-31 00:06:56 -04:00
|
|
|
|
2018-07-26 15:37:56 -04:00
|
|
|
expect(response.status).to eq(200)
|
|
|
|
expect(response.body).to include(I18n.t('guidelines'))
|
|
|
|
end
|
2017-03-08 05:30:49 -05:00
|
|
|
end
|
|
|
|
end
|
2018-11-27 21:36:14 -05:00
|
|
|
|
|
|
|
context "crawler view" do
|
|
|
|
it "should include correct title" do
|
|
|
|
get '/faq', headers: { 'HTTP_USER_AGENT' => 'Googlebot' }
|
|
|
|
expect(response.status).to eq(200)
|
|
|
|
expect(response.body).to include("<title>FAQ - Discourse</title>")
|
|
|
|
end
|
|
|
|
end
|
2014-07-26 17:16:08 -04:00
|
|
|
end
|
2013-10-30 16:37:22 -04:00
|
|
|
|
2013-06-04 18:34:54 -04:00
|
|
|
describe '#enter' do
|
|
|
|
context 'without a redirect path' do
|
|
|
|
it 'redirects to the root url' do
|
2017-08-31 00:06:56 -04:00
|
|
|
post "/login.json"
|
|
|
|
expect(response).to redirect_to('/')
|
2013-06-04 18:34:54 -04:00
|
|
|
end
|
|
|
|
end
|
|
|
|
|
|
|
|
context 'with a redirect path' do
|
|
|
|
it 'redirects to the redirect path' do
|
2017-08-31 00:06:56 -04:00
|
|
|
post "/login.json", params: { redirect: '/foo' }
|
|
|
|
expect(response).to redirect_to('/foo')
|
2013-06-04 18:34:54 -04:00
|
|
|
end
|
|
|
|
end
|
|
|
|
|
2014-08-28 17:45:13 -04:00
|
|
|
context 'with a full url' do
|
|
|
|
it 'redirects to the correct path' do
|
2017-08-31 00:06:56 -04:00
|
|
|
post "/login.json", params: { redirect: "#{Discourse.base_url}/foo" }
|
|
|
|
expect(response).to redirect_to('/foo')
|
2014-08-28 17:45:13 -04:00
|
|
|
end
|
|
|
|
end
|
|
|
|
|
2014-10-30 11:31:44 -04:00
|
|
|
context 'with a period to force a new host' do
|
|
|
|
it 'redirects to the root path' do
|
2017-08-31 00:06:56 -04:00
|
|
|
post "/login.json", params: { redirect: ".org/foo" }
|
|
|
|
expect(response).to redirect_to('/')
|
2014-10-30 11:31:44 -04:00
|
|
|
end
|
|
|
|
end
|
|
|
|
|
2014-08-28 17:45:13 -04:00
|
|
|
context 'with a full url to someone else' do
|
|
|
|
it 'redirects to the root path' do
|
2017-08-31 00:06:56 -04:00
|
|
|
post "/login.json", params: { redirect: "http://eviltrout.com/foo" }
|
|
|
|
expect(response).to redirect_to('/')
|
2014-08-28 17:45:13 -04:00
|
|
|
end
|
|
|
|
end
|
|
|
|
|
|
|
|
context 'with an invalid URL' do
|
|
|
|
it "redirects to the root" do
|
2017-08-31 00:06:56 -04:00
|
|
|
post "/login.json", params: { redirect: "javascript:alert('trout')" }
|
|
|
|
expect(response).to redirect_to('/')
|
2014-08-28 17:45:13 -04:00
|
|
|
end
|
|
|
|
end
|
|
|
|
|
2013-06-04 18:34:54 -04:00
|
|
|
context 'when the redirect path is the login page' do
|
|
|
|
it 'redirects to the root url' do
|
2017-08-31 00:06:56 -04:00
|
|
|
post "/login.json", params: { redirect: login_path }
|
|
|
|
expect(response).to redirect_to('/')
|
2013-06-04 18:34:54 -04:00
|
|
|
end
|
|
|
|
end
|
|
|
|
end
|
2013-02-05 14:16:51 -05:00
|
|
|
end
|