2015-10-11 05:41:23 -04:00
|
|
|
require 'rails_helper'
|
2013-02-05 14:16:51 -05:00
|
|
|
|
|
|
|
describe Upload do
|
2013-06-16 04:39:48 -04:00
|
|
|
|
2013-07-13 17:42:19 -04:00
|
|
|
let(:upload) { build(:upload) }
|
|
|
|
let(:thumbnail) { build(:optimized_image, upload: upload) }
|
2013-04-07 11:52:46 -04:00
|
|
|
|
2013-07-13 17:42:19 -04:00
|
|
|
let(:user_id) { 1 }
|
|
|
|
let(:url) { "http://domain.com" }
|
2013-04-07 11:52:46 -04:00
|
|
|
|
2014-07-14 11:34:23 -04:00
|
|
|
let(:image_filename) { "logo.png" }
|
2014-11-03 13:54:10 -05:00
|
|
|
let(:image) { file_from_fixtures(image_filename) }
|
2014-07-14 11:34:23 -04:00
|
|
|
let(:image_filesize) { File.size(image) }
|
2016-09-02 02:50:13 -04:00
|
|
|
let(:image_sha1) { Upload.generate_digest(image) }
|
2013-07-13 17:42:19 -04:00
|
|
|
|
2014-11-03 13:54:10 -05:00
|
|
|
let(:image_svg_filename) { "image.svg" }
|
|
|
|
let(:image_svg) { file_from_fixtures(image_svg_filename) }
|
|
|
|
let(:image_svg_filesize) { File.size(image_svg) }
|
|
|
|
|
2014-04-14 16:55:57 -04:00
|
|
|
let(:attachment_path) { __FILE__ }
|
|
|
|
let(:attachment) { File.new(attachment_path) }
|
|
|
|
let(:attachment_filename) { File.basename(attachment_path) }
|
|
|
|
let(:attachment_filesize) { File.size(attachment_path) }
|
2013-07-23 18:54:18 -04:00
|
|
|
|
2013-07-13 17:42:19 -04:00
|
|
|
context ".create_thumbnail!" do
|
|
|
|
|
|
|
|
it "does not create a thumbnail when disabled" do
|
|
|
|
SiteSetting.stubs(:create_thumbnails?).returns(false)
|
2013-07-31 17:26:34 -04:00
|
|
|
OptimizedImage.expects(:create_for).never
|
2013-09-27 04:55:50 -04:00
|
|
|
upload.create_thumbnail!(100, 100)
|
2013-07-13 17:42:19 -04:00
|
|
|
end
|
|
|
|
|
|
|
|
it "creates a thumbnail" do
|
|
|
|
upload = Fabricate(:upload)
|
|
|
|
thumbnail = Fabricate(:optimized_image, upload: upload)
|
|
|
|
SiteSetting.expects(:create_thumbnails?).returns(true)
|
|
|
|
OptimizedImage.expects(:create_for).returns(thumbnail)
|
2013-09-27 04:55:50 -04:00
|
|
|
upload.create_thumbnail!(100, 100)
|
2013-07-13 17:42:19 -04:00
|
|
|
upload.reload
|
2014-12-31 09:55:03 -05:00
|
|
|
expect(upload.optimized_images.count).to eq(1)
|
2013-07-13 17:42:19 -04:00
|
|
|
end
|
|
|
|
|
|
|
|
end
|
|
|
|
|
2013-11-05 13:04:47 -05:00
|
|
|
context "#create_for" do
|
2013-07-13 17:42:19 -04:00
|
|
|
|
2015-07-15 11:15:43 -04:00
|
|
|
before do
|
|
|
|
Upload.stubs(:fix_image_orientation)
|
|
|
|
ImageOptim.any_instance.stubs(:optimize_image!)
|
|
|
|
end
|
2014-07-09 17:59:57 -04:00
|
|
|
|
2013-07-13 17:42:19 -04:00
|
|
|
it "does not create another upload if it already exists" do
|
2014-05-06 09:41:59 -04:00
|
|
|
Upload.expects(:find_by).with(sha1: image_sha1).returns(upload)
|
2014-04-14 16:55:57 -04:00
|
|
|
Upload.expects(:save).never
|
2014-12-31 09:55:03 -05:00
|
|
|
expect(Upload.create_for(user_id, image, image_filename, image_filesize)).to eq(upload)
|
2013-04-07 11:52:46 -04:00
|
|
|
end
|
|
|
|
|
2014-07-09 17:59:57 -04:00
|
|
|
it "fix image orientation" do
|
|
|
|
Upload.expects(:fix_image_orientation).with(image.path)
|
|
|
|
Upload.create_for(user_id, image, image_filename, image_filesize)
|
|
|
|
end
|
|
|
|
|
2013-07-13 17:42:19 -04:00
|
|
|
it "computes width & height for images" do
|
|
|
|
ImageSizer.expects(:resize)
|
2016-05-03 15:54:07 -04:00
|
|
|
image.expects(:rewind).times(3)
|
2014-04-14 16:55:57 -04:00
|
|
|
Upload.create_for(user_id, image, image_filename, image_filesize)
|
2013-07-13 17:42:19 -04:00
|
|
|
end
|
2013-04-07 11:52:46 -04:00
|
|
|
|
2013-07-13 17:42:19 -04:00
|
|
|
it "does not compute width & height for non-image" do
|
|
|
|
FastImage.any_instance.expects(:size).never
|
2014-04-14 16:55:57 -04:00
|
|
|
upload = Upload.create_for(user_id, attachment, attachment_filename, attachment_filesize)
|
2015-01-28 13:33:11 -05:00
|
|
|
expect(upload.errors.size).to be > 0
|
|
|
|
end
|
|
|
|
|
|
|
|
it "generates an error when the image is too large" do
|
|
|
|
SiteSetting.stubs(:max_image_size_kb).returns(1)
|
|
|
|
upload = Upload.create_for(user_id, image, image_filename, image_filesize)
|
|
|
|
expect(upload.errors.size).to be > 0
|
|
|
|
end
|
|
|
|
|
|
|
|
it "generates an error when the attachment is too large" do
|
|
|
|
SiteSetting.stubs(:max_attachment_size_kb).returns(1)
|
|
|
|
upload = Upload.create_for(user_id, attachment, attachment_filename, attachment_filesize)
|
2014-12-31 09:55:03 -05:00
|
|
|
expect(upload.errors.size).to be > 0
|
2013-05-30 21:13:37 -04:00
|
|
|
end
|
|
|
|
|
2013-07-13 17:42:19 -04:00
|
|
|
it "saves proper information" do
|
2013-07-31 17:26:34 -04:00
|
|
|
store = {}
|
|
|
|
Discourse.expects(:store).returns(store)
|
|
|
|
store.expects(:store_upload).returns(url)
|
2014-04-14 16:55:57 -04:00
|
|
|
|
|
|
|
upload = Upload.create_for(user_id, image, image_filename, image_filesize)
|
|
|
|
|
2014-12-31 09:55:03 -05:00
|
|
|
expect(upload.user_id).to eq(user_id)
|
|
|
|
expect(upload.original_filename).to eq(image_filename)
|
|
|
|
expect(upload.filesize).to eq(image_filesize)
|
|
|
|
expect(upload.width).to eq(244)
|
|
|
|
expect(upload.height).to eq(66)
|
|
|
|
expect(upload.url).to eq(url)
|
2013-07-13 17:42:19 -04:00
|
|
|
end
|
|
|
|
|
2014-11-03 13:54:10 -05:00
|
|
|
context "when svg is authorized" do
|
|
|
|
|
|
|
|
before { SiteSetting.stubs(:authorized_extensions).returns("svg") }
|
|
|
|
|
|
|
|
it "consider SVG as an image" do
|
|
|
|
store = {}
|
|
|
|
Discourse.expects(:store).returns(store)
|
|
|
|
store.expects(:store_upload).returns(url)
|
|
|
|
|
|
|
|
upload = Upload.create_for(user_id, image_svg, image_svg_filename, image_svg_filesize)
|
|
|
|
|
2014-12-31 09:55:03 -05:00
|
|
|
expect(upload.user_id).to eq(user_id)
|
|
|
|
expect(upload.original_filename).to eq(image_svg_filename)
|
|
|
|
expect(upload.filesize).to eq(image_svg_filesize)
|
|
|
|
expect(upload.width).to eq(100)
|
|
|
|
expect(upload.height).to eq(50)
|
|
|
|
expect(upload.url).to eq(url)
|
2014-11-03 13:54:10 -05:00
|
|
|
end
|
|
|
|
|
|
|
|
end
|
|
|
|
|
2013-07-13 17:42:19 -04:00
|
|
|
end
|
2013-05-30 21:13:37 -04:00
|
|
|
|
2013-07-13 17:42:19 -04:00
|
|
|
context ".get_from_url" do
|
|
|
|
|
2013-07-21 18:37:23 -04:00
|
|
|
it "works when the file has been uploaded" do
|
2014-05-06 09:41:59 -04:00
|
|
|
Upload.expects(:find_by).returns(nil).once
|
2013-07-21 18:37:23 -04:00
|
|
|
Upload.get_from_url("/uploads/default/1/10387531.jpg")
|
|
|
|
end
|
|
|
|
|
|
|
|
it "works when using a cdn" do
|
|
|
|
Rails.configuration.action_controller.stubs(:asset_host).returns("http://my.cdn.com")
|
2014-05-06 09:41:59 -04:00
|
|
|
Upload.expects(:find_by).with(url: "/uploads/default/1/02395732905.jpg").returns(nil).once
|
2013-07-21 18:37:23 -04:00
|
|
|
Upload.get_from_url("http://my.cdn.com/uploads/default/1/02395732905.jpg")
|
|
|
|
end
|
|
|
|
|
2013-07-13 17:42:19 -04:00
|
|
|
end
|
|
|
|
|
2016-09-02 02:50:13 -04:00
|
|
|
describe '.generate_digest' do
|
|
|
|
it "should return the right digest" do
|
|
|
|
expect(Upload.generate_digest(image.path)).to eq('bc975735dfc6409c1c2aa5ebf2239949bcbdbd65')
|
|
|
|
end
|
|
|
|
end
|
|
|
|
|
2013-02-05 14:16:51 -05:00
|
|
|
end
|